TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

remove redis reconnect attempts

Browse Source
This commit is contained in:
hsachdeva01 2022-10-06 12:37:06 -07:00
parent de771c979e
commit c8d8f09f56
No known key found for this signature in database
GPG Key ID: CCECDF15FF4C6C47
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
activesupport/lib/active_support/cache/redis_cache_store.rb vendored
View File

@ -36,10 +36,9 @@ class RedisCacheStore < Store
MAX_KEY_BYTESIZE = 1024
DEFAULT_REDIS_OPTIONS = {
connect_timeout: 20,
connect_timeout: 1,
read_timeout: 1,
write_timeout: 1,
reconnect_attempts: 0,
}
DEFAULT_ERROR_HANDLER = -> (method:, returning:, exception:) do

17
activesupport/test/cache/stores/redis_cache_store_test.rb vendored
View File

@ -46,8 +46,7 @@ class LookupTest < ActiveSupport::TestCase
class InitializationTest < ActiveSupport::TestCase
test "omitted URL uses Redis client with default settings" do
assert_called_with Redis, :new, [
connect_timeout: 20, read_timeout: 1, write_timeout: 1,
reconnect_attempts: 0
connect_timeout: 1, read_timeout: 1, write_timeout: 1
] do
build
end
@ -55,8 +54,7 @@ class InitializationTest < ActiveSupport::TestCase
test "no URLs uses Redis client with default settings" do
assert_called_with Redis, :new, [
connect_timeout: 20, read_timeout: 1, write_timeout: 1,
reconnect_attempts: 0
connect_timeout: 1, read_timeout: 1, write_timeout: 1
] do
build url: []
end
@ -65,8 +63,7 @@ class InitializationTest < ActiveSupport::TestCase
test "singular URL uses Redis client" do
assert_called_with Redis, :new, [
url: REDIS_URL,
connect_timeout: 20, read_timeout: 1, write_timeout: 1,
reconnect_attempts: 0
connect_timeout: 1, read_timeout: 1, write_timeout: 1
] do
build url: REDIS_URL
end
@ -75,8 +72,7 @@ class InitializationTest < ActiveSupport::TestCase
test "one URL uses Redis client" do
assert_called_with Redis, :new, [
url: REDIS_URL,
connect_timeout: 20, read_timeout: 1, write_timeout: 1,
reconnect_attempts: 0
connect_timeout: 1, read_timeout: 1, write_timeout: 1
] do
build url: [ REDIS_URL ]
end
@ -84,10 +80,9 @@ class InitializationTest < ActiveSupport::TestCase
test "multiple URLs uses Redis::Distributed client" do
default_args = {
connect_timeout: 20,
connect_timeout: 1,
read_timeout: 1,
write_timeout: 1,
reconnect_attempts: 0,
write_timeout: 1
}
mock = Minitest::Mock.new