Bring this back on the contributing guide.
This commit is contained in:
parent
d1f7656448
commit
ca608b8c9c
@ -252,7 +252,7 @@ Once you're happy that the pull request contains a good change, comment on the G
|
||||
I like the way you've restructured that code in generate_finder_sql, much nicer. The tests look good too.
|
||||
</blockquote>
|
||||
|
||||
If your comment simply says "+1", then odds are that other reviewers aren't going to take it too seriously.
|
||||
If your comment simply says "+1", then odds are that other reviewers aren't going to take it too seriously. Show that you took the time to review the pull request.
|
||||
|
||||
h3. Contributing to the Rails Documentation
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user