TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

remove useless function

Browse Source 
Now that the value is cached on the stack,
`array_of_permitted_scalars_filter` is exactly the same as
`array_of_permitted_scalars?`, so lets just have one
This commit is contained in:
Aaron Patterson 2015-07-17 13:34:01 -07:00
parent 2df8e86caf
commit cb3f25593b
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
actionpack/lib/action_controller/metal/strong_parameters.rb
View File

@ -643,13 +643,7 @@ def permitted_scalar_filter(params, key)
end
def array_of_permitted_scalars?(value)
if value.is_a?(Array)
value.all? {|element| permitted_scalar?(element)}
end
end
def array_of_permitted_scalars_filter(value)
if array_of_permitted_scalars?(value)
if value.is_a?(Array) && value.all? {|element| permitted_scalar?(element)}
yield value
end
end
@ -665,7 +659,7 @@ def hash_filter(params, filter)
if filter[key] == EMPTY_ARRAY
# Declaration { comment_ids: [] }.
array_of_permitted_scalars_filter(self[key]) do |val|
array_of_permitted_scalars?(self[key]) do |val|
params[key] = val
end
else