TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix Browser#preload for older Selenium

Browse Source 
Older versions of selenium had driver_path on
::Selenium::WebDriver::Chrome directly, not on Service. This avoids
errors on those old versions and will preload properly if webdrivers is
installed.
This commit is contained in:
John Hawthorn 2019-07-04 14:47:21 -07:00
parent a59b230579
commit cd4541a1aa
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
actionpack/lib/action_dispatch/system_testing/browser.rb
View File

@ -46,9 +46,19 @@ def capabilities
def preload
case type
when :chrome
::Selenium::WebDriver::Chrome::Service.driver_path.try(:call)
if ::Selenium::WebDriver::Service.respond_to? :driver_path=
::Selenium::WebDriver::Chrome::Service.driver_path.try(:call)
else
# Selenium <= v3.141.0
::Selenium::WebDriver::Chrome.driver_path
end
when :firefox
::Selenium::WebDriver::Firefox::Service.driver_path.try(:call)
if ::Selenium::WebDriver::Service.respond_to? :driver_path=
::Selenium::WebDriver::Firefox::Service.driver_path.try(:call)
else
# Selenium <= v3.141.0
::Selenium::WebDriver::Firefox.driver_path
end
end
end