TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #37103 from giraffate/add_tests_for_no_or_blank_like_arguments_to_query_methods

Browse Source 
Add tests for no or blank like arguments to query methods
This commit is contained in:
Ryuta Kamizono 2019-09-02 10:47:54 +09:00
commit d05f1f036f
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
activerecord/test/cases/relations_test.rb
View File

@ -529,6 +529,14 @@ def test_no_arguments_to_query_methods_raise_errors
assert_raises(ArgumentError) { Topic.preload() }
assert_raises(ArgumentError) { Topic.group() }
assert_raises(ArgumentError) { Topic.reorder() }
assert_raises(ArgumentError) { Topic.order() }
assert_raises(ArgumentError) { Topic.eager_load() }
assert_raises(ArgumentError) { Topic.reselect() }
assert_raises(ArgumentError) { Topic.unscope() }
assert_raises(ArgumentError) { Topic.joins() }
assert_raises(ArgumentError) { Topic.left_joins() }
assert_raises(ArgumentError) { Topic.optimizer_hints() }
assert_raises(ArgumentError) { Topic.annotate() }
end
def test_blank_like_arguments_to_query_methods_dont_raise_errors
@ -537,6 +545,14 @@ def test_blank_like_arguments_to_query_methods_dont_raise_errors
assert_nothing_raised { Topic.preload([]) }
assert_nothing_raised { Topic.group([]) }
assert_nothing_raised { Topic.reorder([]) }
assert_nothing_raised { Topic.order([]) }
assert_nothing_raised { Topic.eager_load([]) }
assert_nothing_raised { Topic.reselect([]) }
assert_nothing_raised { Topic.unscope([]) }
assert_nothing_raised { Topic.joins([]) }
assert_nothing_raised { Topic.left_joins([]) }
assert_nothing_raised { Topic.optimizer_hints([]) }
assert_nothing_raised { Topic.annotate([]) }
end
def test_respond_to_dynamic_finders