TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #6024 from carlosantoniodasilva/amo-dirty-refactor

Browse Source 
Improve AMo::Dirty *_will_change! method
This commit is contained in:
José Valim 2012-04-28 00:15:44 -07:00
commit d0e1c692b4
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
activemodel/lib/active_model/dirty.rb
View File

@ -151,13 +151,15 @@ def attribute_was(attr)
# Handle <tt>*_will_change!</tt> for +method_missing+. # Handle <tt>*_will_change!</tt> for +method_missing+.
def attribute_will_change!(attr) def attribute_will_change!(attr)
return if attribute_changed?(attr)
begin begin
value = __send__(attr) value = __send__(attr)
value = value.duplicable? ? value.clone : value value = value.duplicable? ? value.clone : value
rescue TypeError, NoMethodError rescue TypeError, NoMethodError
end end
changed_attributes[attr] = value unless changed_attributes.include?(attr) changed_attributes[attr] = value
end end
# Handle <tt>reset_*!</tt> for +method_missing+. # Handle <tt>reset_*!</tt> for +method_missing+.