TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Remove redundant passing --skip-active-storage in test cases

Browse Source 
These were added in #30101, after #31084 it became redundant.
This commit is contained in:
bogdanvlviv 2017-11-08 21:39:35 +00:00
parent 89603b41ed
commit d5ad63766e
No known key found for this signature in database
GPG Key ID: E4ACD76A6DB6DFDD
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
railties/test/generators/app_generator_test.rb
View File

@ -423,7 +423,7 @@ def test_config_postgresql_database
end
def test_config_jdbcmysql_database
run_generator([destination_root, "-d", "jdbcmysql", "--skip-active-storage"])
run_generator([destination_root, "-d", "jdbcmysql"])
assert_file "config/database.yml", /mysql/
assert_gem "activerecord-jdbcmysql-adapter"
end
@ -441,7 +441,7 @@ def test_config_jdbcpostgresql_database
end
def test_config_jdbc_database
run_generator([destination_root, "-d", "jdbc", "--skip-active-storage"])
run_generator([destination_root, "-d", "jdbc"])
assert_file "config/database.yml", /jdbc/
assert_file "config/database.yml", /mssql/
assert_gem "activerecord-jdbc-adapter"

2
railties/test/generators/plugin_generator_test.rb
View File

@ -230,7 +230,7 @@ def test_template_from_dir_pwd
end
def test_ensure_that_tests_work
run_generator [destination_root, "--skip-active-storage"]
run_generator
FileUtils.cd destination_root
quietly { system "bundle install" }
assert_match(/1 runs, 1 assertions, 0 failures, 0 errors/, `bin/test 2>&1`)

2
railties/test/generators/plugin_test_runner_test.rb
View File

@ -7,7 +7,7 @@ class PluginTestRunnerTest < ActiveSupport::TestCase
def setup
@destination_root = Dir.mktmpdir("bukkits")
Dir.chdir(@destination_root) { `bundle exec rails plugin new bukkits --skip-bundle --skip-active-storage` }
Dir.chdir(@destination_root) { `bundle exec rails plugin new bukkits --skip-bundle` }
plugin_file "test/dummy/db/schema.rb", ""
end

2
railties/test/generators/shared_generator_tests.rb
View File

@ -63,7 +63,7 @@ def test_name_raises_an_error_if_name_already_used_constant
end
def test_shebang_is_added_to_rails_file
run_generator [destination_root, "--ruby", "foo/bar/baz", "--full", "--skip-active-storage"]
run_generator [destination_root, "--ruby", "foo/bar/baz", "--full"]
assert_file "bin/rails", /#!foo\/bar\/baz/
end

2
railties/test/generators/test_runner_in_engine_test.rb
View File

@ -7,7 +7,7 @@ class TestRunnerInEngineTest < ActiveSupport::TestCase
def setup
@destination_root = Dir.mktmpdir("bukkits")
Dir.chdir(@destination_root) { `bundle exec rails plugin new bukkits --full --skip-bundle --skip-active-storage` }
Dir.chdir(@destination_root) { `bundle exec rails plugin new bukkits --full --skip-bundle` }
plugin_file "test/dummy/db/schema.rb", ""
end