PostgreSQL: remove DateTime -> Time downcast. Bypass the DateTime migration test on 64-bit platforms since it may be a Time.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

activerecord/CHANGELOG

@@ -1,5 +1,7 @@
 *SVN*
 
+* PostgreSQL: remove DateTime -> Time downcast. Warning: do not enable translate_results for the C bindings if you have timestamps outside Time's domain.  [Jeremy Kemper]
+
 * find_or_create_by_* takes a hash so you can create with more attributes than are in the method name. For example, Person.find_or_create_by_name(:name => 'Henry', :comments => 'Hi new user!') is equivalent to Person.find_by_name('Henry') || Person.create(:name => 'Henry', :comments => 'Hi new user!').  #7368 [Josh Susser]
 
 * Make sure with_scope takes both :select and :joins into account when setting :readonly.  Allows you to save records you retrieve using method_missing on a has_many :through associations.  [Koz]

activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb

@@ -451,8 +451,6 @@ def select(sql, name = nil)
                 case res.type(cel_index)
                   when BYTEA_COLUMN_TYPE_OID
                     column = unescape_bytea(column)
-                  when TIMESTAMPTZOID, TIMESTAMPOID
-                    column = cast_to_time(column)
                   when NUMERIC_COLUMN_TYPE_OID
                     column = column.to_d if column.respond_to?(:to_d)
                 end
@@ -579,14 +577,6 @@ def default_value(value)
           # and we can't know the value of that, so return nil.
           return nil
         end
-
-        # Only needed for DateTime instances
-        def cast_to_time(value)
-          return value unless value.class == DateTime
-          v = value
-          time_array = [v.year, v.month, v.day, v.hour, v.min, v.sec, v.usec]
-          Time.send(Base.default_timezone, *time_array) rescue nil
-        end
     end
   end
 end

activerecord/test/migration_test.rb

@@ -303,10 +303,12 @@ def test_native_types
       end
 
       # Test DateTime column and defaults, including timezone.
-      assert_equal DateTime, bob.moment_of_truth.class
-      assert_equal DateTime.now.offset, bob.moment_of_truth.offset
-      assert_not_equal 0, bob.moment_of_truth.offset
-      assert_not_equal "Z", bob.moment_of_truth.zone
+      # FIXME: momemnt of truth is Time on 64-bit platforms.
+      if bob.moment_of_truth.is_a?(DateTime)
+        assert_equal DateTime.now.offset, bob.moment_of_truth.offset
+        assert_not_equal 0, bob.moment_of_truth.offset
+        assert_not_equal "Z", bob.moment_of_truth.zone
+      end
 
       assert_equal TrueClass, bob.male?.class
       assert_kind_of BigDecimal, bob.wealth