TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

only dup the options once, the Callback object does not mutate them

Browse Source
This commit is contained in:
Aaron Patterson 2013-05-14 16:22:29 -07:00
parent 132db318b3
commit dd03f10d52
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
activesupport/lib/active_support/callbacks.rb
View File

@ -585,7 +585,7 @@ def normalize_callback_params(name, filters, block) # :nodoc:
type = CALLBACK_FILTER_TYPES.include?(filters.first) ? filters.shift : :before
options = filters.last.is_a?(Hash) ? filters.pop : {}
filters.unshift(block) if block
[type, filters, options]
[type, filters, options.dup]
end
# This is used internally to append, prepend and skip callbacks to the
@ -636,7 +636,7 @@ def set_callback(name, *filter_list, &block)
type, filters, options = normalize_callback_params(name, filter_list, block)
self_chain = get_callbacks name
mapped = filters.map do |filter|
Callback.build(self_chain, filter, type, options.dup)
Callback.build(self_chain, filter, type, options)
end
__update_callbacks(name) do |target, chain|