TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #45671 from fatkodima/in_batches-subquery-test

Browse Source 
Add missing test ensuring no subqueries for whole table batching
This commit is contained in:
Jean Boussier 2022-07-27 17:13:23 +02:00 committed by GitHub
commit e1a2c9e441
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
activerecord/test/cases/batches_test.rb
View File

@ -473,6 +473,14 @@ def test_in_batches_executes_range_queries_when_constrained_and_opted_in_into_ra
end
end
def test_in_batches_no_subqueries_for_whole_tables_batching
c = Post.connection
quoted_posts_id = Regexp.escape(c.quote_table_name("posts.id"))
assert_sql(/DELETE FROM #{c.quote_table_name("posts")} WHERE #{quoted_posts_id} > .+ AND #{quoted_posts_id} <=/i) do
Post.in_batches(of: 2).delete_all
end
end
def test_in_batches_shouldnt_execute_query_unless_needed
assert_queries(2) do
Post.in_batches(of: @total) { |relation| assert_kind_of ActiveRecord::Relation, relation }