Merge pull request #16210 from sonnym/assert_valid_keys_in_validate

Check for valid options in validate method

activemodel/CHANGELOG.md

@@ -1,3 +1,9 @@
+*   Validate options passed to `ActiveModel::Validations.validate`.
+
+    Preventing, in many cases, the simple mistake of using `validate` instead of `validates`.
+
+    *Sonny Michaud*
+
 *   Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`.
 
     These methods may cause confusion with the `reset_changes` that behaves differently

activemodel/lib/active_model/validations.rb

@@ -141,6 +141,11 @@ def validates_each(*attr_names, &block)
       #   value.
       def validate(*args, &block)
         options = args.extract_options!
+
+        if args.all? { |arg| arg.is_a?(Symbol) }
+          options.assert_valid_keys(%i(on if unless))
+        end
+
         if options.key?(:on)
           options = options.dup
           options[:if] = Array(options[:if])
@@ -148,6 +153,7 @@ def validate(*args, &block)
             Array(options[:on]).include?(o.validation_context)
           }
         end
+
         args << options
         set_callback(:validate, *args, &block)
       end

activemodel/test/cases/validations_test.rb

@@ -167,6 +167,13 @@ def test_invalid_validator
     end
   end
 
+  def test_invalid_options_to_validate
+    assert_raises(ArgumentError) do
+      # A common mistake -- we meant to call 'validates'
+      Topic.validate :title, presence: true
+    end
+  end
+
   def test_errors_conversions
     Topic.validates_presence_of %w(title content)
     t = Topic.new