TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

s/Travis/Buildkite/

Browse Source
This commit is contained in:
Matthew Draper 2019-04-09 11:28:49 +09:30
parent 95fee9438b
commit e485c14a3e
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -97,7 +97,7 @@ Everyone interacting in Rails and its sub-projects' codebases, issue trackers, c
## Code Status ## Code Status
[![Build Status](https://travis-ci.org/rails/rails.svg?branch=master)](https://travis-ci.org/rails/rails) [![Build Status](https://badge.buildkite.com/ab1152b6a1f6a61d3ea4ec5b3eece8d4c2b830998459c75352.svg?branch=master)](https://buildkite.com/rails/rails)
## License ## License

2
RELEASING_RAILS.md
View File

@ -14,7 +14,7 @@ Today is mostly coordination tasks. Here are the things you must do today:
Do not release with a Red CI. You can find the CI status here: Do not release with a Red CI. You can find the CI status here:
``` ```
https://travis-ci.org/rails/rails https://buildkite.com/rails/rails
``` ```
### Is Sam Ruby happy? If not, make him happy. ### Is Sam Ruby happy? If not, make him happy.

6
actioncable/karma.conf.js
View File

@ -52,9 +52,9 @@ if (process.env.CI) {
} }
function buildId() { function buildId() {
const { TRAVIS_BUILD_NUMBER, TRAVIS_BUILD_ID } = process.env const { BUILDKITE_JOB_ID } = process.env
return TRAVIS_BUILD_NUMBER && TRAVIS_BUILD_ID return BUILDKITE_JOB_ID
? `TRAVIS #${TRAVIS_BUILD_NUMBER} (${TRAVIS_BUILD_ID})` ? `Buildkite ${BUILDKITE_JOB_ID}`
: "" : ""
} }
} }

6
guides/source/contributing_to_ruby_on_rails.md
View File

@ -302,7 +302,7 @@ the recommended workflow with the [rails-dev-box](https://github.com/rails/rails
As a compromise, test what your code obviously affects, and if the change is As a compromise, test what your code obviously affects, and if the change is
not in railties, run the whole test suite of the affected component. If all not in railties, run the whole test suite of the affected component. If all
tests are passing, that's enough to propose your contribution. We have tests are passing, that's enough to propose your contribution. We have
[Travis CI](https://travis-ci.org/rails/rails) as a safety net for catching [Buildkite](https://buildkite.com/rails/rails) as a safety net for catching
unexpected breakages elsewhere. unexpected breakages elsewhere.
#### Entire Rails: #### Entire Rails:
@ -418,7 +418,7 @@ To run a single test against all adapters, use:
$ bundle exec rake TEST=test/cases/associations/has_many_associations_test.rb $ bundle exec rake TEST=test/cases/associations/has_many_associations_test.rb
``` ```
You can invoke `test_jdbcmysql`, `test_jdbcsqlite3` or `test_jdbcpostgresql` also. See the file `activerecord/RUNNING_UNIT_TESTS.rdoc` for information on running more targeted database tests, or the file `ci/travis.rb` for the test suite run by the continuous integration server. You can invoke `test_jdbcmysql`, `test_jdbcsqlite3` or `test_jdbcpostgresql` also. See the file `activerecord/RUNNING_UNIT_TESTS.rdoc` for information on running more targeted database tests.
### Warnings ### Warnings
@ -677,7 +677,7 @@ $ git apply ~/my_changes.patch
This works well for simple changes. However, if your changes are complicated or if the code in master has deviated significantly from your target branch, it might require more work on your part. The difficulty of a backport varies greatly from case to case, and sometimes it is simply not worth the effort. This works well for simple changes. However, if your changes are complicated or if the code in master has deviated significantly from your target branch, it might require more work on your part. The difficulty of a backport varies greatly from case to case, and sometimes it is simply not worth the effort.
Once you have resolved all conflicts and made sure all the tests are passing, push your changes and open a separate pull request for your backport. It is also worth noting that older branches might have a different set of build targets than master. When possible, it is best to first test your backport locally against the Ruby versions listed in `.travis.yml` before submitting your pull request. Once you have resolved all conflicts and made sure all the tests are passing, push your changes and open a separate pull request for your backport. It is also worth noting that older branches might have a different set of build targets than master. When possible, it is best to first test your backport locally against the oldest Ruby version permitted by the target branch's `rails.gemspec` before submitting your pull request.
And then... think about your next contribution! And then... think about your next contribution!