TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Ensure mail_to helper does not modify the given html options hash

Browse Source
This commit is contained in:
Carlos Antonio da Silva 2013-04-04 21:25:44 -03:00
parent aa3b6837b2
commit e936cf9c47
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actionpack/lib/action_view/helpers/url_helper.rb
View File

@ -451,7 +451,7 @@ def link_to_if(condition, name, options = {}, html_options = {}, &block)
def mail_to(email_address, name = nil, html_options = {}, &block)
html_options, name = name, nil if block_given?
html_options ||= {}
html_options.stringify_keys!
html_options = html_options.stringify_keys
email_address = ERB::Util.html_escape(email_address)

8
actionpack/test/template/url_helper_test.rb
View File

@ -543,11 +543,17 @@ def test_mail_to_with_block
mail_to('me@example.com') { content_tag(:span, 'Email me') }
end
def test_link_tag_with_block_and_options
def test_mail_to_with_block_and_options
assert_dom_equal %{<a class="special" href="mailto:me@example.com?cc=ccaddress%40example.com"><span>Email me</span></a>},
mail_to('me@example.com', cc: "ccaddress@example.com", class: "special") { content_tag(:span, 'Email me') }
end
def test_mail_to_does_not_modify_html_options_hash
options = { class: 'special' }
mail_to 'me@example.com', 'ME!', options
assert_equal({ class: 'special' }, options)
end
def protect_against_forgery?
self.request_forgery
end