Better error message for String#to_date

I did this because to_date gives a very unhelpful error message if you
do not pass in a correct date. In the process I think this cleans up the
 code nicely and even better it tends to be slightly faster than the
 current implementation.

Benchmark
https://gist.github.com/4440875
This commit is contained in:
Kelly Stannard 2013-01-02 23:50:55 +00:00
parent fba6a6a2d9
commit ebd27d5714
3 changed files with 10 additions and 5 deletions

@ -1,5 +1,13 @@
## Rails 4.0.0 (unreleased) ##
* Change String#to_date to use Date.parse. This gives more consistant error
messages and allows the use of partial dates.
"gibberish".to_date => Argument Error: invalid date
"3rd Feb".to_date => Sun, 03 Feb 2013
*Kelly Stannard*
* It's now possible to compare Date, DateTime, Time and TimeWithZone with Infinity
This allows to create date/time ranges with one infinite bound.
Example:

@ -32,11 +32,7 @@ def to_time(form = :utc)
# "2012-12-13".to_date #=> Thu, 13 Dec 2012
# "12/13/2012".to_date #=> ArgumentError: invalid date
def to_date
unless blank?
date_values = ::Date._parse(self, false).values_at(:year, :mon, :mday)
::Date.new(*date_values)
end
::Date.parse(self, false) unless blank?
end
# Converts a string to a DateTime value.

@ -307,6 +307,7 @@ def test_string_to_datetime
def test_string_to_date
assert_equal Date.new(2005, 2, 27), "2005-02-27".to_date
assert_nil "".to_date
assert_equal Date.new(Date.today.year, 2, 3), "Feb 3rd".to_date
end
end