Better method names in Javascript based on the feedback from @javan
This commit is contained in:
parent
0ce0cf0c04
commit
ee06b33e19
@ -55,14 +55,17 @@ class Cable.Connection
|
||||
{identifier, message, type} = JSON.parse(event.data)
|
||||
|
||||
if type?
|
||||
switch type
|
||||
when Cable.INTERNAL_MESSAGES.SUBSCRIPTION_CONFIRMATION
|
||||
@consumer.subscriptions.notify(identifier, "connected")
|
||||
when Cable.INTERNAL_MESSAGES.SUBSCRIPTION_REJECTION
|
||||
@consumer.subscriptions.rejectSubscription(identifier)
|
||||
@handleTypeMessage(type)
|
||||
else
|
||||
@consumer.subscriptions.notify(identifier, "received", message)
|
||||
|
||||
onTypeMessage: (type) ->
|
||||
switch type
|
||||
when Cable.INTERNAL_MESSAGES.SUBSCRIPTION_CONFIRMATION
|
||||
@consumer.subscriptions.notify(identifier, "connected")
|
||||
when Cable.INTERNAL_MESSAGES.SUBSCRIPTION_REJECTION
|
||||
@consumer.subscriptions.reject(identifier)
|
||||
|
||||
open: ->
|
||||
@disconnected = false
|
||||
@consumer.subscriptions.reload()
|
||||
|
@ -23,29 +23,27 @@ class Cable.Subscriptions
|
||||
@notify(subscription, "initialized")
|
||||
@sendCommand(subscription, "subscribe")
|
||||
|
||||
reload: ->
|
||||
for subscription in @subscriptions
|
||||
@sendCommand(subscription, "subscribe")
|
||||
|
||||
rejectSubscription: (identifier) ->
|
||||
subscriptions = @findAll(identifier)
|
||||
|
||||
for subscription in subscriptions
|
||||
@removeSubscription(subscription)
|
||||
@notify(subscription, "rejected")
|
||||
|
||||
remove: (subscription) ->
|
||||
@removeSubscription(subscription)
|
||||
@forget(subscription)
|
||||
|
||||
unless @findAll(subscription.identifier).length
|
||||
@sendCommand(subscription, "unsubscribe")
|
||||
|
||||
removeSubscription: (subscription) ->
|
||||
reject: (identifier) ->
|
||||
for subscription in @findAll(identifier)
|
||||
@forget(subscription)
|
||||
@notify(subscription, "rejected")
|
||||
|
||||
forget: (subscription) ->
|
||||
@subscriptions = (s for s in @subscriptions when s isnt subscription)
|
||||
|
||||
findAll: (identifier) ->
|
||||
s for s in @subscriptions when s.identifier is identifier
|
||||
|
||||
reload: ->
|
||||
for subscription in @subscriptions
|
||||
@sendCommand(subscription, "subscribe")
|
||||
|
||||
notifyAll: (callbackName, args...) ->
|
||||
for subscription in @subscriptions
|
||||
@notify(subscription, callbackName, args...)
|
||||
|
Loading…
Reference in New Issue
Block a user