TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Log trace of causes for unhandled exceptions

Browse Source
This commit is contained in:
Maxime Lapointe 2023-12-08 11:13:18 -05:00 committed by Rafael Mendonça França
parent 827f4ef15c
commit f47ef36c4d
No known key found for this signature in database
GPG Key ID: FC23B6D0F1EEE948
2 changed files with 52 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
actionpack/lib/action_dispatch/middleware/debug_exceptions.rb
View File

@ -142,17 +142,30 @@ def log_error(request, wrapper)
message = []
message << " "
message << "#{wrapper.exception_class_name} (#{wrapper.message}):"
if wrapper.has_cause?
message << "\nCauses:"
message << "#{wrapper.exception_class_name} (#{wrapper.message})"
wrapper.wrapped_causes.each do |wrapped_cause|
message << "#{wrapped_cause.exception_class_name} (#{wrapped_cause.message})"
message << "Caused by: #{wrapped_cause.exception_class_name} (#{wrapped_cause.message})"
end
message << "\nInformation for: #{wrapper.exception_class_name} (#{wrapper.message}):"
else
message << "#{wrapper.exception_class_name} (#{wrapper.message}):"
end
message.concat(wrapper.annotated_source_code)
message << " "
message.concat(trace)
if wrapper.has_cause?
wrapper.wrapped_causes.each do |wrapped_cause|
message << "\nInformation for cause: #{wrapped_cause.exception_class_name} (#{wrapped_cause.message}):"
message.concat(wrapped_cause.annotated_source_code)
message << " "
message.concat(wrapped_cause.exception_trace)
end
end
log_array(logger, message, request)
end

40
actionpack/test/dispatch/debug_exceptions_test.rb
View File

@ -627,11 +627,43 @@ def self.build_app(app, *args)
get "/nested_exceptions", headers: env
assert_response 500
log = output.rewind && output.read
assert_includes log, <<~MSG
Causes:
RuntimeError (Second error)
RuntimeError (First error)
# Splitting into paragraphs to be easier to see difference/error when there is one
paragraphs = log.split(/\n\s*\n/)
assert_includes(paragraphs[0], <<~MSG.strip)
RuntimeError (Third error)
Caused by: RuntimeError (Second error)
Caused by: RuntimeError (First error)
MSG
assert_includes(paragraphs[1], <<~MSG.strip)
Information for: RuntimeError (Third error):
MSG
assert_match Regexp.new(<<~REGEX.strip), paragraphs[2].lines[0..2].join
\\A.*in `rescue in rescue in raise_nested_exceptions'
.*in `rescue in raise_nested_exceptions'
.*in `raise_nested_exceptions'
REGEX
assert_includes(paragraphs[3], <<~MSG.strip)
Information for cause: RuntimeError (Second error):
MSG
assert_match Regexp.new(<<~REGEX.strip), paragraphs[4].lines[0..1].join
\\A.*in `rescue in raise_nested_exceptions'
.*in `raise_nested_exceptions'
REGEX
assert_includes(paragraphs[5], <<~MSG.strip)
Information for cause: RuntimeError (First error):
MSG
assert_match Regexp.new(<<~REGEX.strip), paragraphs[6].lines[0]
\\A.*in `raise_nested_exceptions'
REGEX
end
test "display backtrace when error type is SyntaxError" do