TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix self is undefined for actioncable within ssr build systems by replacing it globalThis

Browse Source
This commit is contained in:
Zane Wolfgang Pickett 2023-04-13 19:26:40 -03:00 committed by Rafael Mendonça França
parent 4646b0036b
commit f634121c3d
No known key found for this signature in database
GPG Key ID: FC23B6D0F1EEE948
5 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
actioncable/app/assets/javascripts/action_cable.js generated
View File

@ -4,8 +4,8 @@
})(this, (function(exports) {
"use strict";
var adapters = {
logger: self.console,
WebSocket: self.WebSocket
logger: typeof console !== "undefined" ? console : undefined,
WebSocket: typeof WebSocket !== "undefined" ? WebSocket : undefined
};
var logger = {
log(...messages) {

4
actioncable/app/assets/javascripts/actioncable.esm.js generated
View File

@ -1,6 +1,6 @@
var adapters = {
logger: self.console,
WebSocket: self.WebSocket
logger: typeof console !== "undefined" ? console : undefined,
WebSocket: typeof WebSocket !== "undefined" ? WebSocket : undefined
};
var logger = {

4
actioncable/app/assets/javascripts/actioncable.js generated
View File

@ -4,8 +4,8 @@
})(this, (function(exports) {
"use strict";
var adapters = {
logger: self.console,
WebSocket: self.WebSocket
logger: typeof console !== "undefined" ? console : undefined,
WebSocket: typeof WebSocket !== "undefined" ? WebSocket : undefined
};
var logger = {
log(...messages) {

4
actioncable/app/javascript/action_cable/adapters.js
View File

@ -1,4 +1,4 @@
export default {
logger: self.console,
WebSocket: self.WebSocket
logger: typeof console !== "undefined" ? console : undefined,
WebSocket: typeof WebSocket !== "undefined" ? WebSocket : undefined,
}

4
actioncable/test/javascript/src/unit/action_cable_test.js
View File

@ -6,13 +6,13 @@ const {module, test} = QUnit
module("ActionCable", () => {
module("Adapters", () => {
module("WebSocket", () => {
test("default is self.WebSocket", assert => {
test("default is WebSocket", assert => {
assert.equal(ActionCable.adapters.WebSocket, self.WebSocket)
})
})
module("logger", () => {
test("default is self.console", assert => {
test("default is console", assert => {
assert.equal(ActionCable.adapters.logger, self.console)
})
})