TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Make logging_test pass with the new base

Browse Source
This commit is contained in:
Pratik Naik 2009-05-23 01:36:09 +02:00
parent a01d2a2586
commit f766f66946
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actionpack/Rakefile
View File

@ -68,7 +68,7 @@ Rake::TestTask.new(:test_new_base_on_old_tests) do |t|
http_digest_authentication layout mime_responds
record_identifier redirect render render_json render_xml
send_file request_forgery_protection rescue url_rewriter
verification webservice
verification webservice logging
).map { |name| "test/controller/#{name}_test.rb" }
t.verbose = true
end

2
actionpack/lib/action_controller/base/filter_parameter_logging.rb
View File

@ -71,7 +71,7 @@ def process(*)
if logger
parameters = respond_to?(:filter_parameters) ? filter_parameters(params) : params.dup
parameters = parameters.except!(:controller, :action, :format, :_method)
parameters = parameters.except!(:controller, :action, :format, :_method, :only_path)
unless parameters.empty?
# TODO : Move DelayedLog to AS

4
actionpack/test/controller/logging_test.rb
View File

@ -35,7 +35,7 @@ def test_logging_without_parameters
end
def test_logging_with_parameters
get :show, :id => 10
get :show, :id => '10'
assert_equal 3, logs.size
params = logs.detect {|l| l =~ /Parameters/ }
@ -49,6 +49,6 @@ def set_logger
end
def logs
@logs ||= @controller.logger.logged.compact.map {|l| l.strip}
@logs ||= @controller.logger.logged.compact.map {|l| l.to_s.strip}
end
end