TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #5475 from rafaelfranca/fix-build

Browse Source 
Fix ActiveRecord::Relation#blank? tests
This commit is contained in:
Piotr Sarnacki 2012-03-16 13:34:11 -07:00
commit facf1e54f1
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
activerecord/test/cases/relations_test.rb
View File

@ -1238,18 +1238,21 @@ def test_automatically_added_order_references
def test_presence
topics = Topic.scoped
assert_queries(1) do
#checking if there are topics is used before you actually display them,
#thus it shouldn't invoke an extra count query
assert topics.present?
assert !topics.blank?
# the fist query is triggered because there are no topics yet.
assert_queries(1) { assert topics.present? }
#shows count of topics and loops after loading the query should not trigger extra queries either
assert_no_queries { topics.size }
assert_no_queries { topics.count }
assert_no_queries { topics.length }
assert_no_queries { topics.each }
end
# checking if there are topics is used before you actually display them,
# thus it shouldn't invoke an extra count query.
assert_no_queries { assert topics.present? }
assert_no_queries { assert !topics.blank? }
# shows count of topics and loops after loading the query should not trigger extra queries either.
assert_no_queries { topics.size }
assert_no_queries { topics.length }
assert_no_queries { topics.each }
# count always trigger the COUNT query.
assert_queries(1) { topics.count }
assert topics.loaded?
end