TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Skip resetting correct counter caches

Browse Source
This commit is contained in:
fatkodima 2022-05-22 18:33:08 +03:00
parent e20e541ff3
commit fb1da7a3f5
2 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
activerecord/lib/active_record/counter_cache.rb
View File

@ -48,7 +48,9 @@ def reset_counters(id, *counters, touch: nil)
reflection = child_class._reflections.values.find { |e| e.belongs_to? && e.foreign_key.to_s == foreign_key && e.options[:counter_cache].present? }
counter_name = reflection.counter_cache_column
updates[counter_name] = object.send(counter_association).count(:all)
count_was = object.send(counter_name)
count = object.send(counter_association).count(:all)
updates[counter_name] = count if count != count_was
end
if touch
@ -59,7 +61,7 @@ def reset_counters(id, *counters, touch: nil)
updates.merge!(touch_updates)
end
unscoped.where(primary_key => object.id).update_all(updates)
unscoped.where(primary_key => object.id).update_all(updates) if updates.any?
true
end

21
activerecord/test/cases/counter_cache_test.rb
View File

@ -114,6 +114,27 @@ class ::SpecialReply < ::Reply
end
end
test "reset counter skips query for correct counter" do
Topic.reset_counters(@topic.id, :replies_count)
# SELECT "topics".* FROM "topics" WHERE "topics"."id" = ? LIMIT ?
# SELECT COUNT(*) FROM "topics" WHERE "topics"."type" IN (?, ?, ?, ?, ?) AND "topics"."parent_id" = ?
assert_queries(2) do
Topic.reset_counters(@topic.id, :replies_count)
end
end
test "reset counter performs query for correct counter with touch: true" do
Topic.reset_counters(@topic.id, :replies_count)
# SELECT "topics".* FROM "topics" WHERE "topics"."id" = ? LIMIT ?
# SELECT COUNT(*) FROM "topics" WHERE "topics"."type" IN (?, ?, ?, ?, ?) AND "topics"."parent_id" = ?
# UPDATE "topics" SET "updated_at" = ? WHERE "topics"."id" = ?
assert_queries(3) do
Topic.reset_counters(@topic.id, :replies_count, touch: true)
end
end
test "update counter with initial null value" do
category = categories(:general)
assert_equal 2, category.categorizations.count