TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
92,162 Commits 2 Branches 0 Tags 294 MiB
main
Commit Graph

147 Commits

Author SHA1 Message Date
bogdanvlviv
318ccf5b3b
Follow up #33523 [ci skip] 
This commit is the next work after #33523.

Also, this commit removes mention about hidden `utf8` input. Since
form helpers don't generate this input by default since #32125.

Note that I also had created PR #31972 with improvements to
"Action View Form Helpers" guide, but I'll rebase it after merging the
current PR.
 2018-08-27 15:39:49 +03:00
Aaron Patterson
de6a200f82
Merge pull request #33681 from minaslater/replace-white-and-blacklist 
[ci skip] change all instances of blacklist and whitelist to denylist…
 2018-08-23 13:20:22 -07:00
Mina Slater
f1d647aeff [ci skip] corrects more grammar awkwardness, replacing denylist with restricted list and consistently use permitted 2018-08-22 21:52:17 -05:00
Nick Schwaderer
cdee52079c Include form_with in form_helpers rails guide (#33523) 
* Include form_with in form_helpers rails guide

* Include form_tag and form_for footnote

* Id and class attributes are not wrapped anymore

* Include note that all form_with forms are remote:true by default

* Underline most common use case of form_with is with arguments

* Form_with no longer accepts multiple hashes in form helper calls

* Review final sections

* Revert extra documentation

* Remove unnecessary link
 2018-08-22 17:42:28 -07:00
Mina Slater
7bdf43daac [ci skip] fixes awkward grammar 2018-08-22 07:39:26 -05:00
Mina Slater
44da9eb3b9 [ci skip] change all instances of blacklist and whitelist to denylist and allowlist 2018-08-21 21:36:40 -05:00
Paul McMahon
978d486e4d Reference Active Storage instead of third-party libraries in guide 
Paperclip has officially been deprecated, so we shouldn't mention it
anymore.

CarrierWave could still be referenced, as there are use cases where it
currently makes more sense, but for simplicity, I thought removing the
mention of third party libraries made sense. If we want to talk about
them, listing "alternatives" within the Active Storage guide could make
more sense.
 2018-07-26 16:15:34 +09:00
Paul McMahon
7b9c19d94b Rails guides are now served over https 
http links will be redirected to the https version, but still better to
just directly link to the https version.
 2018-07-24 11:29:31 +09:00
Anthony Crumley
258670244d Added a lot of Oxford commas 
[ci skip] A regular expression was used to find a lot of missing Oxford
commas and add them.  The regular expression was as follows.

", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
 2018-05-10 12:46:06 -05:00
Eileen M. Uchitelle
53593a6636
Merge pull request #30474 from yhirano55/make_it_same_title_in_index_and_page 
Make it same title in index and page [ci skip]
 2017-12-13 10:23:14 -05:00
willnet
99f6722e86 [ci skip] Add a missing space before closing curly braces 2017-12-02 16:35:38 +09:00
Yoshiyuki Hirano
c330cc85a7 Update Form Helpers guide to fix example codes [ci skip] 
* It looks that example codes are not based on actual output. So I've fixed it.
* Specifically:
  * There are no lines about utf-8 and authenticity_token.
  * The submit button doesn't have data-disabled-with attribute.
  * Each attribute order of html element is different from actual ones.
 2017-09-17 07:35:36 +09:00
Yoshiyuki Hirano
10dfb153eb Make it same title in index and page [ci skip] 2017-08-31 01:49:50 +09:00
Rafael França
06580a4f97 Merge pull request #28432 from marksiemers/master 
Update 'Building Complex Forms' with `inverse_of`
 2017-04-20 19:58:26 -04:00
yuuji.yaginuma
2b82e96597 Remove datetime fields from helper list [ci skip] 
The `datetime_field` is an alias of the `datetime_local_field`, there is
no helper to generate datetime fields.
Ref: #25469
 2017-04-19 08:06:30 +09:00
marksiemers
dcd6ceb0c9 Update 'Building Complex Forms' with inverse_of 
If the example for complex forms is implemented, ActiveRecord will prevent saving unless `inverse_of: :person` is added to the `has_many :addresses` association.
 2017-03-15 12:38:49 -07:00
Vipul A M
4d5060072b Add link to mentioned API [ci skip] (#28392) 2017-03-12 19:37:48 +05:30
utilum
2dc74387b7 Fixes #27202, [ci skip] 2016-11-30 21:22:30 +01:00
yuuji.yaginuma
ef6699b6ca remove deprecated datetime_field from guide [ci skip] 
`datetime_field` was deprecated in 316811b4d3f4e5a1a7bcd03de97c67218770e333
 2016-04-03 07:57:50 +09:00
Michael Groeneman
43edcc6c8f [ci skip] No hyphen in 'side effects' 2016-02-23 16:29:42 -08:00
Michael Groeneman
3ea7d02ee6 [ci skip] Fix typo in Form Helpers Guide 2016-02-23 16:05:27 -08:00
Genadi Samokovarov
c29fbd3c7a ApplicationRecord documentation pass 
This is a pass over the documentation which fills the missing gaps of
`ApplicationRecord`.

[ci skip]
 2015-12-17 11:56:35 +01:00
Ubuntu
d2a7b9898b Add comma to to make the information clear 2015-11-07 10:37:56 +00:00
Scott González
8be6b47d1f Minor cleanup for form helpers guide [ci skip] 2015-10-08 08:48:56 -04:00
David Verhasselt
b4f4de0500 Remove TIP on parse_query 
[ci skip]
 2015-10-05 19:55:00 +03:00
Anton Chuchkalov
dc4b03fe9a Remove yepnope mention from form helpers guide because it's deprecated [ci skip] 2015-07-30 14:48:55 +02:00
yui-knk
686d6ef587 [ci skip] Upcase when 2015-05-16 16:41:24 +09:00
yui-knk
506360e924 [ci skip] Fix to a singular form (person has one contact_detail) 2015-05-16 16:11:34 +09:00
Vijay Dev
c26ee64b92 Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	guides/source/4_0_release_notes.md
 2015-03-26 16:22:41 +00:00
yui-knk
133317593e [ci skip] Add link for "parameter_names section" 2015-03-23 00:43:04 +09:00
yui-knk
e3efe2bc33 [ci skip] Fix link format 2015-03-15 23:05:17 +09:00
yui-knk
a113c95874 [ci skip] Fix fenced code block lang 2015-03-01 10:44:57 +09:00
Andrey Nering
8c976c3843 Improving 'Customizing Form Builder' section with example [ci skip] 2015-01-16 08:22:50 -02:00
Xavier Noria
7ba24831d7 Merge pull request #18503 from vipulnsward/guides-in-on 
Changed `IN` to `ON` in markdown renderer condition
 2015-01-14 11:35:34 +01:00
Vipul A M
5cfaf5a46e - Changed IN to ON in markdown renderer condition 
- Changed `IN` to `ON` in all note sentences in guides.
 2015-01-14 11:52:13 +05:30
Derek Reeve
b5c1bbbee0 Fix form_for guide binding a form to an object. 
The HTML generated using
    url: { action: :create}
will not generate the form action "/articles/create", it should generate
the form action "/articles" for a new object.
 2015-01-13 10:19:59 -08:00
Xavier Noria
7702974281 warn about reading guides in GitHub 
References #18148.
 2014-12-23 23:32:50 +01:00
Yves Senn
b2351beae5 Merge pull request #17796 from leafac/fix-format 
Fix format "Form Helpers" guide
 2014-11-27 08:39:07 +01:00
Leandro Facchinetti
b4b6c556a7 Fix format "Form Helpers" guide 
The `"_tag"` was interpreted as the start of a italics.
 2014-11-26 23:39:02 -05:00
Juanito Fatas
9614ecd2e7 [ci skip] Add highlight to code (form helper guide). 2014-10-25 21:56:32 +08:00
Thiago Pinto
be83a1726b form_helpers: demonstrating there is also a collection_select method in form builder 2014-09-13 19:32:23 -03:00
Vijay Dev
1fc2e70495 Merge branch 'master' of github.com:rails/docrails 2014-09-03 16:14:10 +00:00
Brian Jordan
2096390463 Adjusted punctuation and grammar for Form Helpers guide [ci skip] 2014-08-26 21:53:59 +00:00
Mikhail Dieterle
52f430f6cc code quotes for classname 2014-08-24 12:27:27 +03:00
Zachary Scott
c0d1823d54 Fix indentation from 1b4b26f [ci skip] 2014-05-28 15:56:38 -07:00
Juanito Fatas
1b4b26f162 [ci skip] Improve form_helpers.md guide. 2014-05-29 06:31:25 +08:00
Vijay Dev
afa3557917 Merge pull request #14872 from jonatack/patch-7 
Grammar and formatting fixes in Form Helpers Guide
 2014-04-27 01:17:17 +05:30
Jon Atack
10c4a3ea10 Fix code & grammar in Form Helpers Guide 
in the "Forms to External Resources" section [skip ci]
 2014-04-25 20:48:06 +02:00
Jon Atack
c354d33990 Grammar and formatting fixes in Form Helpers Guide 
Improved version of #14851 after helpful feedback from @robin850 and @matthewd.

[skip ci]
 2014-04-25 20:26:47 +02:00
Akshay Vishnoi
0c2854fa03 [ci skip] builtin -> built-in 2014-04-20 21:03:09 +05:30
Rashmi Yadav
7ea0a50126 Updating select helper doc [ci skip] 2014-03-08 20:23:15 +01:00
Prathamesh Sonpatki
3cf5d2b75b Fix fields_for documentation with index option [ci skip] 
- fields_for documentation with index option was wrong.
- It does not work with passing model as it is.
- Changed the example by passing id of the address object.
- Fixes #13125.
 2014-01-14 14:38:07 +05:30
Kuldeep Aggarwal
e10f91000b Improved documents [ci skip] 2013-12-14 22:49:00 +05:30
Juanito Fatas
a7713765d9 Some improvements on building nested forms. [ci skip] 2013-12-07 02:04:50 +08:00
Juanito Fatas
b0a3d113a3 Add number and range field to form helpers article 
Also wrap surrounding text to 80 chars.

[ci skip] Closes #13132
 2013-12-02 20:29:32 -02:00
Juanito Fatas
7cd1b3e675 [ci skip] Consistency wording of 9.6 in form_helpers.md 
Chapter 9 is giving a user and set of addresses example.
So 'Add a new address' would be more consistent.
Also change the javascript to JavaScript.
 2013-09-15 23:04:49 +08:00
Vijay Dev
d262773ab7 Merge branch 'master' of github.com:rails/docrails 2013-09-13 00:22:42 +05:30
Sergio
1e667aa5f4 html generated for a search form 
There's a div that is generated in rails for a default search form and is not includen in the example.
 2013-09-09 17:30:09 +02:00
Paul Nikitochkin
2c8bc2cdcd Use Ruby on Rails Coding Conventions for code examples in the guides 
* Indent after private/protected
* Ruby >= 1.9 syntax for hashes
* Prefer method { do_stuff } instead of method{do_stuff} for single-line blocks.

[ci skip]
 2013-09-06 21:42:29 +03:00
Xavier Noria
b77f25cb84 cleans the guides sources from fancy non-ASCII stuff 2013-08-23 17:59:11 +02:00
Brendon Muir
92a03d888e Use binary mode to write uploaded files [ci skip] See: http://stackoverflow.com/a/4988984/129798 for an explanation for why this is required for Ruby 1.9. 2013-08-16 23:33:59 +12:00
Akira Matsuda
19df76f75e params keys are Strings 2013-07-08 17:21:25 +09:00
Akshay Khole
444d3412b9 Fixing Issue #11083 
Removing other occurrences of `the` appearing twice
 2013-06-25 16:47:29 +05:30
Sunny Ripert
53607be559 Remove double spaces in guides 2013-05-28 14:38:02 +02:00
Sunny Ripert
70b302b189 Remove double spaces in code examples 2013-05-28 14:38:02 +02:00
Zoltan Debre
c33c4d1bb6 Here was a 404 error: Active Record Validations 
Active Record Validations and Callbacks's URL and name is changed.
 2013-04-07 18:24:30 +02:00
Andrea
107d199c45 Remove deprecated attr_accessible mention 2013-04-05 19:21:52 +03:00
Vijay Dev
6d8c070821 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
	activerecord/test/cases/adapter_test.rb
	guides/source/testing.md

[ci skip]
 2013-03-30 15:46:14 +05:30
Yves Senn
1a5c3f49f1 mention strong parameters in complex forms section of the guides. 
Closes #9921.
 2013-03-27 15:18:02 +01:00
Vipul A M
926357040b fix introduced : ; fix another typo 2013-03-20 01:50:53 +05:30
Vipul A M
428ff5a896 more typos in guides 2013-03-20 01:23:34 +05:30
Mikhail Dieterle
0ddae9fcf6 fix typo in form helpers guide 2013-03-15 22:48:41 +03:00
Vipul A M
d41c279bf1 do some typo fixing 2013-03-14 10:12:54 +05:30
Vijay Dev
f049016cd3 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	guides/source/getting_started.md
 2013-01-09 01:04:15 +05:30
Amparo Luna + Guillermo Iguaran
03ac174f2d Change guides to use update instead of update_attributes 2013-01-03 12:04:25 -05:00
Franck Verrot
25c12de4ff Link to the right fork of country_select. 2013-01-02 16:12:19 +01:00
Mikhail Dieterle
7f5a1d3359 New hash syntax works only with symbol keys 2013-01-01 21:05:08 +03:00
Mikhail Dieterle
1371b24cce fix wrong hash syntax 2013-01-01 20:40:59 +03:00
Ruafozy
f3dc158a01 Improve English 
* Fix one error
* Improve wording
* Improve punctuation
 2013-01-01 10:22:18 +00:00
Francesco Rodriguez
1e83730067 remove Mass Assignment reference from Form Helpers guide [ci skip] 2012-12-10 19:07:25 -05:00
Steve Klabnik
ed78770b1a Remove references to Rails versions. 
There's no reason for guides to reference old behaviors. They should
be current as of the versions of Rails that they ship with, and including
older information just clutters thing.

I discussed this change with @fxn and he agrees.
 2012-12-07 23:20:35 -08:00
Katie Oldaker
7c05ea23a0 Fixed grammar in a lot of guide prologues. 2012-12-07 12:50:09 -05:00
Steve Klabnik
d16a1b9e8b Normalize on 'After reading this guide, you will know:' 
We have three or four different introduction sentences to the guides.
After this commit, we use the same one everywhere.
 2012-11-29 14:25:02 -08:00
Steve Klabnik
e6b8452e58 Fix title of 'form helpers' guide. 
They're Rails Guides, so obviously we're talking about Rails Form Helpers.

Also, 'helpers' should be capitalized.
 2012-11-29 05:28:52 -08:00
Steve Klabnik
6dcae8ae9c Add periods to the bullet points in guides. 
Talked with @fxn about this. Bullet points should have periods at the ends.
 2012-11-29 05:14:08 -08:00
Agis Anastasopoulos
278e073f46 Switch to 1.9 hash syntax 
I've intentionally left out some spots as they're the expected output, and since Hash#inspect yields `=>` I guess it may be confusing for beginners to see one syntax in the guide and a different one in their system.
 2012-11-16 00:20:37 +02:00
burningTyger
8dabfbebdb use em-dashes instead of two minuses in guides 2012-11-10 23:00:00 +01:00
Carlos Antonio da Silva
f47026e7f9 Add backticks around link_to example in javascript guide [ci skip] 2012-10-28 12:15:35 -02:00
Prem Sichanugrist
5e2866cc34 No more Textile guide generation support 2012-09-17 15:55:17 -04:00
Prem Sichanugrist
41dbb58e2d Fix the usage of * in Markdown 
In Textile `*` would convert to `<strong>`, but in Markdown we have to
use `**` instead.
 2012-09-17 15:54:23 -04:00
Prem Sichanugrist
721afdcc4b Fix remaining formatting problems in the guide 2012-09-17 15:54:23 -04:00
Prem Sichanugrist
9873dd800b Convert all the links into Markdown format 2012-09-17 15:54:23 -04:00
Prem Sichanugrist
31ef4cf656 Convert all inline codes to Markdown syntax 2012-09-17 15:54:23 -04:00
Prem Sichanugrist
c89c163a0e Convert inline code tags to Markdown 2012-09-17 15:54:22 -04:00
Prem Sichanugrist
872b7af337 Convert heading tags and heading section 2012-09-17 15:54:22 -04:00
Prem Sichanugrist
7bc1ca3515 Convert code blocks into GFM style 2012-09-17 15:54:22 -04:00
Prem Sichanugrist
5137d03cc5 Rename the rest of the guides to Markdown 2012-09-17 15:54:22 -04:00