TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,297 Commits 2 Branches 0 Tags 294 MiB
0342393b30
Commit Graph

668 Commits

Author SHA1 Message Date
Jeremy Kemper
0342393b30 Multipart form values may have a content type without being treated as uploaded files if they do not provide a filename. Closes #6401. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-09 18:52:19 +00:00
Jeremy Kemper
57313c54bf assert_response supports symbolic status codes. Closes #6569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-07 21:45:10 +00:00
Jeremy Kemper
5b50504f48 Missed pluralize nil test in [5431]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-06 21:39:16 +00:00
Thomas Fuchs
e52e803a55 Deprecate JavaScriptHelper#update_element_function, which is superseeded by RJS [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-06 09:40:30 +00:00
Jeremy Kemper
080ec9803e Fix invalid test fixture exposed by stricter Ruby 1.8.5 multipart parsing. Closes #6524. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-05 02:40:44 +00:00
Jeremy Kemper
7f6c5a5654 Set ActionView::Base.default_form_builder once rather than passing the :builder option to every form or overriding the form helper methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-03 04:16:58 +00:00
Rick Olson
d4e35666d1 Deprecate start_form_tag and end_form_tag. Use form_tag / '</form>' from now on. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 03:22:48 +00:00
Rick Olson
f7c916ece6 Added block-usage to PrototypeHelper#form_remote_tag, document block-usage of FormTagHelper#form_tag [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 03:06:57 +00:00
David Heinemeier Hansson
e407b44ba1 Made FormTagHelper#form_tag work with blocks, rendering start/end_form_tag deprecated 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-23 23:30:36 +00:00
David Heinemeier Hansson
6c062054cd Added block-usage to TagHelper#content_tag [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-23 22:57:59 +00:00
David Heinemeier Hansson
b34ed9b339 Docfix (closes #6393) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 23:58:41 +00:00
David Heinemeier Hansson
986c1a6240 Deprecated UrlHelper#link_to_image and UrlHelper#link_to :post => true (closes #6409) [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5338 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 23:54:41 +00:00
Rick Olson
cfb7dea783 clean up failing routing tests from missing :only_path option [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5337 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 23:48:52 +00:00
David Heinemeier Hansson
1c71a5d25f Upgraded NumberHelper with number_to_phone support international formats to comply with ITU E.123 by supporting area codes with less than 3 digits, added precision argument to number_to_human_size (defaults to 1) (closes #6421) [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5336 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 23:47:18 +00:00
David Heinemeier Hansson
afd288cf81 Fixed that setting RAILS_ASSET_ID to "" should not add a trailing slash after assets (closes #6454) [BobSilva/chrismear] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5335 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 23:41:11 +00:00
Rick Olson
1d7196b552 Force *_url named routes to show the host in ActionView [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 18:00:20 +00:00
Sam Stephenson
351a224d90 Add support for converting blocks into function arguments in JavaScriptGenerator#call and JavaScriptProxy#call. 
Add JavaScriptGenerator#literal for wrapping a string in an object whose #to_json is the string itself.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-19 22:03:27 +00:00
Rick Olson
dbd0bd5e5c Add <%= escape_once html %> to escape html while leaving any currently escaped entities alone. Fix button_to double-escaping issue. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-18 16:42:19 +00:00
Rick Olson
02358c83b7 Fix double-escaped entities, such as &amp;amp;, &amp;#123;, etc. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-18 15:58:07 +00:00
Jeremy Kemper
a0f74092a8 test deprecated instance variables using to_s instead of inspect which touches other ivars 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-18 00:04:47 +00:00
Nicholas Seckar
03b383853d Fix routing to correctly determine when generation fails. Closes #6300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:52:21 +00:00
Jamis Buck
b5ec0fe313 Fix broken assert_generates when extra keys are being checked. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 14:32:11 +00:00
Jamis Buck
39963b4b9d remove an obsolete #dup call. avoid double negatives, to make the code easier to understand and explain 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 03:11:08 +00:00
Jamis Buck
ef6921628d make sure filters in subclasses with :only or :except conditions are treated like skip_filter calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 01:54:42 +00:00
Michael Koziarski
81ddeadd49 Replace KCODE checks with String#chars for truncate. Closes #6385 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 00:31:30 +00:00
Marcel Molina
065908a4c5 Make page caching respect the format of the resource that is being requested even if the current route is the default route so that, e.g. posts.rss is not transformed by url_for to '/' and subsequently cached as '/index.html' when it should be cached as '/posts.rss'. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 23:29:04 +00:00
Michael Koziarski
41c3623524 Use String#chars in TextHelper::excerpt. Closes #6386 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 21:13:05 +00:00
Jamis Buck
02dc646d55 Fix relative URL root matching problems 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 19:14:11 +00:00
Jeremy Kemper
eaae0399ad r5540@ks: jeremy | 2006-10-08 23:05:30 -0700 
#5949
 r5541@ks:  jeremy | 2006-10-08 23:07:08 -0700
 Fix filter skipping in controller subclasses.
 r5557@ks:  jeremy | 2006-10-08 23:11:24 -0700
 Update changelog.  Closes #5949, references #6297, references #6299.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 06:11:40 +00:00
Jeremy Kemper
a307b8c7dc render_text may optionally append to the response body. render_javascript appends by default. This allows you to chain multiple render :update calls by setting @performed_render = false between them (awaiting a better public API). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:26:35 +00:00
Nicholas Seckar
bc85e6ac4c Rename test assertion to prevent shadowing. Closes #6306. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:20:36 +00:00
Jeremy Kemper
5d1edc55a8 one render per test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:14:38 +00:00
David Heinemeier Hansson
a49e7d5c0c Fixed that NumberHelper#number_to_delimiter should respect precision of higher than two digits (closes #6231) [phallstrom] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:59:19 +00:00
David Heinemeier Hansson
f9650a23f0 Fixed that caches_action breaks with file extensions (closes #6257) [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:56:13 +00:00
David Heinemeier Hansson
211ffd3f79 Fixed that FormHelper#radio_button didn't respect an :id being passed in (closes #6266) [evansj] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:53:59 +00:00
David Heinemeier Hansson
8ff92e2435 Added an html_options hash parameter to javascript_tag() and update_page_tag() helpers #6311 [tzaharia] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:50:11 +00:00
David Heinemeier Hansson
4b3e964a1a Fixed escaping of backslashes in JavaScriptHelper#escape_javascript (closes #6302) [sven@c3d2.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:34:43 +00:00
David Heinemeier Hansson
3c6b7a2191 Fixed that assert_select selects the wrong tag by its contents (closes #6332) [jgarber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:20:31 +00:00
Jeremy Kemper
7ea86773a9 r5515@ks: jeremy | 2006-10-08 13:24:42 -0700 
#6281
 r5516@ks:  jeremy | 2006-10-08 13:29:49 -0700
 respond_to :html doesn't assume .rhtml. Closes #6281.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 20:30:24 +00:00
Jeremy Kemper
d15d15b2c2 Deprecate @response 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5207 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:26:45 +00:00
Jeremy Kemper
d7b5b44a0e Deprecate @headers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:12:16 +00:00
Jeremy Kemper
4f3bf6cb23 Deprecate @cookies 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:04:39 +00:00
Jeremy Kemper
643d17ce9e assert_select_rjs decodes escaped unicode chars since the Javascript generators encode them. Closes #6240. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5202 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:39:31 +00:00
Jeremy Kemper
d7674637f9 Deprecation: @request will be removed after 1.2. Use the request method instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:34:02 +00:00
Jamis Buck
c0eccc9aef modify head so that you can specify a bare status code as the first parameter 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:32:40 +00:00
Jamis Buck
b2ede64a89 Add ActionController::Base#head for rendering empty responses. Add support for symbolic status codes, as well as for having raw integer statuses expand with their default messages. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:13:55 +00:00
Rick Olson
e537de00d8 Fix bug that kept any before_filter except the first one from being able to halt the before_filter chain. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-27 04:55:44 +00:00
Jamis Buck
6a8dcc8a5b Make sure map.resources(:things, :new => { :new => :any }) correctly sets /things/new to be accessible by any method rather than creating another resource at /things/new;new 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 22:45:09 +00:00
Jeremy Kemper
c554a9caba strip_links is case-insensitive. Closes #6285. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 16:26:00 +00:00
Nicholas Seckar
8d809e724a Clear the cache of possible controllers whenever Routes are reloaded. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-23 17:25:06 +00:00