Commit Graph

8124 Commits

Author SHA1 Message Date
kennyj
0360b3eb1f Fix GH #5435. db:structure:dump should be reenable. 2012-03-17 13:57:10 +09:00
José Valim
fbc9d0f44f Simplify helpers handling. Ensure Metal can run AC hooks. 2012-03-15 08:48:38 +01:00
José Valim
e1824c5991 Remove remaining http_only? calls. 2012-03-14 22:58:32 +01:00
José Valim
6db930cb5b Remove --http. 2012-03-14 22:30:01 +01:00
Carlos Antonio da Silva
2963ee6b4b Fix scaffold controller template, ensure rake scaffold test pass by default 2012-03-14 14:47:20 -03:00
José Valim
da07433578 Update railties/guides/source/api_app.textile 2012-03-14 16:53:43 +01:00
Carlos Antonio da Silva
96aea58f22 Do not generate app/views and sprockets entries on http app
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:25 -03:00
Carlos Antonio da Silva
570cc89bad Generate special controller and functional test templates for http apps
The main goal is to not generate the format.html block in scaffold
controller, and to generate a different functional test as we don't rely
on redirects anymore, we should test for http responses.

In addition to that, the :edit action is removed from the http
controller and the edit route is not generated by default, as they
usually do not make sense in this scenario.

[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:25 -03:00
Carlos Antonio da Silva
3e138df977 Rename http-only app generator option to http
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
2c0f6b0d8a Move http only option to AppGenerator
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
7f3847cc14 Add test to ensure setting config.generators.http_only actually disables the generator options
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
ff8e9e07b4 Allow generator configs from http_only! to be overriden by app
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
2b355757d5 Remove duplicated tests from shared generator
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
858a30e571 Refactor http_only, remove reader method
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
219ff43639 Disable template, helper and assets options when using http_only!
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
c825e9a5ea Create generators http_only! setup and hide some common namespaces for now
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:24 -03:00
Carlos Antonio da Silva
124838b508 Generate middleware http_only! config when running http only app generator
[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:23 -03:00
Carlos Antonio da Silva
5c8c7ca2f9 Add http-only option to Rails app generator
Change application controller template accordingly, to inherit from
ActionController::HTTP and not generate protect_from_forgery call.

[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:23 -03:00
Santiago Pastorino
4c16791f35 Add ActionController::HTTP
More info http://edgeguides.rubyonrails.org/api_app.html

[Carlos Antonio da Silva & Santiago Pastorino]
2012-03-14 12:46:23 -03:00
Rafael Mendonça França
1ced5ca67b Remove key_value helper now that master is 1.9 only and we always use
the 1.9 hash syntax in the generators.
2012-03-13 23:10:32 -03:00
José Valim
ec22a2b813 Update API guide with latest decisions. 2012-03-14 00:30:42 +01:00
Piotr Sarnacki
5520e36e48 [engines guide] Add information about running and reverting specified migrations [skip ci] 2012-03-14 00:29:07 +01:00
Carlos Antonio da Silva
dde3058c3a Expand changelog and upgrading rails guide with IdentityMap info 2012-03-13 20:08:55 -03:00
Carlos Antonio da Silva
a8dd21d8b4 Remove IdentityMap 2012-03-13 20:08:54 -03:00
Guillermo Iguaran
e823c8bd6f Add sprockets-rails to generated Gemfile. This should be reverted after sprockets-rails release on rubygems 2012-03-13 18:06:45 -05:00
Guillermo Iguaran
e8296a0288 The sprockets railtie was moved to sprockets/rails/railtie 2012-03-13 18:06:02 -05:00
José Valim
2d3550c4be Merge pull request #5415 from rafaelfranca/refactor
Refactor the test_unit scaffold generator to use the key_value method
2012-03-13 14:20:43 -07:00
José Valim
ae67a63fe9 Merge pull request #572 from sikachu/remove_activeresource
Remove Active Resource source files from the repository.
2012-03-13 14:04:03 -07:00
Piotr Sarnacki
919db1bbbb Check for existence of exactly the called fixture_path= method 2012-03-13 21:28:34 +01:00
Piotr Sarnacki
52bfb48745 Environment in engines tests is required on boot_rails, no need to require explicitly 2012-03-13 21:01:45 +01:00
Piotr Sarnacki
5e754a0a98 Don't need to share engine's tests anymore, plugins are gone 2012-03-13 21:01:44 +01:00
Piotr Sarnacki
24e00e1eb7 Ensure that engine can be mounted at root (#4314)
It's already fixed and the fix was actually in journey library,
but with #4314 it reappeared second time, so probably this
kind of integration test will be good to have to not allow it to
sneak in after changes in journey or rails itself.
2012-03-13 21:01:44 +01:00
Prem Sichanugrist
f1637bf2bb Remove Active Resource source files from the repository
Dear Active Resource,

It's not that I hate you or anything, but you didn't get much attention lately. There're so many alternatives out there, and I think people have made their choice to use them than you. I think it's time for you to have a big rest, peacefully in this Git repository.

I will miss you,

@sikachu.
2012-03-13 14:55:44 -04:00
Vijay Dev
800c70a8f9 Merge branch 'master' of github.com:lifo/docrails 2012-03-13 23:29:30 +05:30
Alexey Vakhov
a9f688648c Fix AM Guide
Use proc as default argument to recaculate recipients array every time
2012-03-13 21:57:42 +04:00
Vijay Dev
6d0cc770ce mark engines guide as wip [ci skip] 2012-03-13 23:24:11 +05:30
Vijay Dev
25cbe00fbc copy-edit contributing guide [ci skip] 2012-03-13 23:21:41 +05:30
Rafael Mendonça França
7c00cde79f Refactor the test_unit scaffold generator to use the key_value method 2012-03-13 14:19:03 -03:00
José Valim
21b69b233b Merge pull request #5397 from rafaelfranca/fix-scaffold
Do not use the attributes hash in the scaffold functional tests
2012-03-13 07:38:23 -07:00
Rafael Mendonça França
08db3d5af3 Use the attributes hash explicitly 2012-03-13 11:21:29 -03:00
David Heinemeier Hansson
e7d55f734a Actually commit the change! 2012-03-13 10:00:15 -04:00
David Heinemeier Hansson
46313151bd Undo unwarranted change to coding conventions. I am not a fan of the aesthetics of private/public at the root but more importantly, we should not be changing coding conventions with almost a decades worth of history at a whim. The conventions are there to have a consistent coding style, that is their primary purpose. When there is so much existing code with the existing style, any change will have to lift an enormous burden of proof as to why its overwhelmingly superior. That is not the case here, so this is being reverted. 2012-03-13 09:57:51 -04:00
Philip Arndt
f0ee9e6889 Fixed problem when fixture_path is not always defined (incidentally, only when ActiveRecord is according to test_help.rb). 2012-03-13 23:28:42 +13:00
Philip Arndt
5088f8ce06 Fixes issue #5193 using the instructions provided in the issue. 2012-03-13 23:27:50 +13:00
Ryan Bigg
30b2dd431e [config guide] Add mass_assignment_sanitizer to Active Record config options 2012-03-12 16:01:57 -07:00
Rafael Mendonça França
7ad4c7c881 Do not use the attributes hash in the scaffold functional tests 2012-03-12 19:45:01 -03:00
Aaron Patterson
10e1ce4fb9 use AS::Logger so we are consistent 2012-03-12 14:27:28 -07:00
Aaron Patterson
51aeae91ac allow people to specify custom formatters, use the default formatter in production so that PID and timestamp are logged. fixes #5388 2012-03-12 14:25:41 -07:00
Filipe Moreira
6c93fbc516 Advise to keep secret token private 2012-03-12 21:19:58 +01:00
Filipe Moreira
0b36ad7066 Advise to keep secret token private 2012-03-12 21:13:17 +01:00