David Heinemeier Hansson
c2054c4289
Superseeded by action_caching_test ( closes #5173 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:39:50 +00:00
David Heinemeier Hansson
40762a4873
Fixed default routing NoMethodError downcase for nil when default controller provided ( closes #5400 ) [kajism@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:09:15 +00:00
David Heinemeier Hansson
df70e28e03
Added locals hash to partials, which makes for convenient access of some times available/some times not variables ( closes #5491 ) [wbruce@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:01:52 +00:00
Jeremy Kemper
da8d7a7011
deprecated render assertions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:51:48 +00:00
Jeremy Kemper
e04a6e8155
deprecated assertions tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:47:51 +00:00
David Heinemeier Hansson
653bfe9600
Dont raise deprecation warning on render :action => "stuff"
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:24:08 +00:00
Jeremy Kemper
ea831469a9
new render deprecations test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:09:18 +00:00
Jeremy Kemper
96c45a8118
Don't use deprecated render API. Cosmetics.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:07:26 +00:00
Jeremy Kemper
7cbb4ac44f
deprecated keep_flash test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:06:10 +00:00
Jeremy Kemper
3158730411
redirect deprecation tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:05:11 +00:00
Jeremy Kemper
d4a3eff89d
no more render_to_string deprecation warnings
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:59:05 +00:00
Jeremy Kemper
7818cf1123
deprecated render tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:05:38 +00:00
Jeremy Kemper
9b424f04ca
test_test deprecation and cosmetics
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:03:57 +00:00
Jeremy Kemper
25ea18aa15
Fix deprecation warnings in verification tests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:17:32 +00:00
Jeremy Kemper
71dbef6d27
Integration tests: thoroughly test ActionController::Integration::Session. Closes #6022 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:34:57 +00:00
Jeremy Kemper
af61b9cdae
action
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:17:13 +00:00
David Heinemeier Hansson
5048aa9831
Deprecated old render parameter calls
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:02:56 +00:00
David Heinemeier Hansson
268c1dee8f
Require action mailer more gracefully
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 22:43:24 +00:00
David Heinemeier Hansson
4bd444c1fe
More deprecation fun
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 22:35:31 +00:00
David Heinemeier Hansson
f12fdc50a6
Better compartmentalizing of assertions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:18:06 +00:00
David Heinemeier Hansson
3142502964
Added assert_select* for CSS selector-based testing (deprecates assert_tag) #5936 [assaf.arkin@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 19:54:21 +00:00
Jeremy Kemper
db9be58719
Cleanup assert_tag :children counting. Closes #2181 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 16:40:01 +00:00
Rick Olson
2b45e2d370
Add routing tests to assert that RoutingError is raised when conditions aren't met. Closes #6016 [Nathan Witmer]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 20:41:40 +00:00
Nicholas Seckar
d34a346d9d
Switch to using FormEncodedPairParser for parsing request parameters.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-30 05:50:02 +00:00
Tobias Lütke
ff063d700d
respond_to .html now always renders #{action_name}.rhtml so that registered custom template handlers do not override it in priority.
...
Custom mime types require a block and throw proper error now.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-30 00:34:36 +00:00
David Heinemeier Hansson
d164d09649
FormEncodedStringParser needs a tad more work before it can handle POST data (like file handling), so were backing out for a bit
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-28 14:05:05 +00:00
Jeremy Kemper
96c6ca369a
Deprecation: test deprecated instance vars in partials.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 05:58:16 +00:00
David Heinemeier Hansson
7b34d0f8c5
Actually, indifferent access mattered in the bowels (hashes hidden in arrays)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 03:09:32 +00:00
David Heinemeier Hansson
a78519071c
Result is made indifferent on the way out
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 02:58:55 +00:00
David Heinemeier Hansson
04fda65306
Changed the POST parameter processing to use the new QueryStringParser and make the result a indifferent hash [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 02:49:09 +00:00
David Heinemeier Hansson
9e054fdf41
More tests for array/hashing in parameters, one failing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 01:57:44 +00:00
Nicholas Seckar
3b1972a896
Add UrlWriter to allow writing urls from Mailers and scripts.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-24 06:15:01 +00:00
Nicholas Seckar
caf546b675
Add test case from ticket #4090
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-22 07:18:24 +00:00
Nicholas Seckar
7678d123a7
Relax Routing's anchor pattern warning; it was preventing use of [^/] inside restrictions.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-15 02:04:11 +00:00
Nicholas Seckar
5baf7462c7
Add controller_paths variable to Routing; Assign Routing.controller_paths from initializer; fix script/about and rails info controller.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-15 01:28:06 +00:00
Rick Olson
8c4b599b7c
Fix assert_redirected_to issue with named routes for module controllers. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-13 18:31:58 +00:00
Nicholas Seckar
84bacf99d6
Invoke method_missing directly for hidden actions. Closes #3030 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-13 04:15:22 +00:00
Jeremy Kemper
c3cdd3b659
Deprecation: check whether instance variables have been monkeyed with before assigning them to deprecation proxies. Raises a RuntimeError if so.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 21:58:31 +00:00
Jeremy Kemper
c40b1a4a67
Deprecate direct usage of @params. Update ActionView::Base for instance var deprecation.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 12:40:14 +00:00
Jeremy Kemper
2399a223c3
Deprecation! @session and @flash will be removed after 1.2. Use the session and flash methods instead. You'll get printed warnings during tests and logged warnings in dev mode when you access either instance variable directly.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4699 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 06:11:56 +00:00
Nicholas Seckar
127ee8c8f8
Make Routing noisy when an anchor regexp is assigned to a segment. Closes #5674
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 22:12:50 +00:00
David Heinemeier Hansson
5130fc84c6
Remove duplicate routes from mapped resources ( closes #5712 ) [eigentone@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 20:46:49 +00:00
Jeremy Kemper
12ab93b72b
Make controller_path available as an instance method. Closes #5724 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 01:56:58 +00:00
David Heinemeier Hansson
2d6ca64c45
Make us pass to ease RESTful children posts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4659 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 00:45:09 +00:00
David Heinemeier Hansson
6e842f216c
Make us pass to ease RESTful children posts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4658 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 00:15:09 +00:00
Marcel Molina
d17bd6a043
Make action caching aware of different formats for the same action so that, e.g. foo.xml is cached separately from foo.html. Implicitly set content type when reading in cached content with mime revealing extensions so the entire onous isn't on the webserver. PDI MORE CACHING TESTS [Marcel Molina Jr.]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4656 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-03 23:59:38 +00:00
Rick Olson
58b996f9b0
Restrict Request Method hacking with ?_method to POST requests. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 03:02:31 +00:00
Jeremy Kemper
c9417dcef3
Nested resource testing.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 01:23:06 +00:00
Jeremy Kemper
a247d72139
Nesting map.resources
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 00:29:02 +00:00
Rick Olson
78e37f45c6
Fix bug when passing multiple options to SimplyRestful, like :new => { :preview => :get, :draft => :get }. [Rick Olson, Josh Susser, Lars Pind]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 21:57:59 +00:00
Rick Olson
d2eafa8b73
Dup the options passed to map.resources so that multiple resources get the same options. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 20:32:48 +00:00
Rick Olson
ed4c295c47
Fixed the new_#{resource}_url route and added named route tests for Simply Restful. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 20:00:18 +00:00
David Heinemeier Hansson
865b175765
Added map.resources from the Simply Restful plugin (backwards incompatible with the plugin!) [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 18:59:58 +00:00
Rick Olson
04d9e94e88
Fixed that you can still access the flash after the flash has been reset in reset_session. Closes #5584 [lmarlow@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-22 02:31:21 +00:00
Jeremy Kemper
71234daef1
r4487@asus: jeremy | 2006-04-29 12:21:39 -0700
...
Check whether @flash is defined? for warnings-safety.
r4488@asus: jeremy | 2006-04-29 12:23:15 -0700
Check whether @flash is defined? for warnings-safety. Obviates nil? check.
r4489@asus: jeremy | 2006-04-29 12:45:18 -0700
Check whether @session is defined? for warnings-safety.
r4490@asus: jeremy | 2006-04-29 12:50:41 -0700
Check whether @rendering_runtime is defined? for warnings-safety.
r4491@asus: jeremy | 2006-04-29 12:55:01 -0700
Check whether @_cycles is defined? for warnings-safety.
r4492@asus: jeremy | 2006-04-29 12:59:19 -0700
Check whether instance variables are defined? for warnings-safety.
r4493@asus: jeremy | 2006-04-29 13:14:09 -0700
Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
r4494@asus: jeremy | 2006-04-29 13:31:34 -0700
Check whether @auto_index defined? for warnings-safety.
r4495@asus: jeremy | 2006-04-29 13:32:24 -0700
Wrap content_columns redefinitions with silence_warnings.
r4496@asus: jeremy | 2006-04-29 13:35:28 -0700
Wrap more redefinitions with silence_warnings.
r4829@asus: jeremy | 2006-07-08 10:59:20 -0700
abstract unit, fix warnings
r4830@asus: jeremy | 2006-07-08 11:06:12 -0700
Use parens to silence warning.
r4831@asus: jeremy | 2006-07-08 11:06:48 -0700
Use parens to silence warning.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 18:14:49 +00:00
David Heinemeier Hansson
11c715a53f
Added exception handling of missing layouts ( closes #5373 ) [chris@ozmm.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 02:38:55 +00:00
Jeremy Kemper
d0526ede40
r4748@asus: jeremy | 2006-06-29 22:40:35 -0700
...
Loosen urlencoded content type check.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-30 05:41:03 +00:00
Nicholas Seckar
e494b0a441
Add route_name_path method to generate only the path for a named routes. For example, map.person will add person_path.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-30 02:36:17 +00:00
Jeremy Kemper
bbc1351344
Determine the correct template_root for deeply nested components. Closes #2841 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-21 00:31:43 +00:00
Rick Olson
2bbcff8cf4
Fix that routes with *path segments in the recall can generate URLs. [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-17 00:25:24 +00:00
David Heinemeier Hansson
36dc94a6a1
Added Hash.create_from_xml(string) which will create a hash from a XML string and even typecast if possible [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-16 10:07:13 +00:00
Rick Olson
2f58a467e3
add passing test to make sure unhandled requests don't load unnecessary classes. Closed #5408 . [nkriege@hotmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-16 03:22:09 +00:00
Jamis Buck
816d67b104
Make sure passed routing options are not mutated by routing code. ( closes #5314 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-07 16:27:14 +00:00
Jamis Buck
ae7029ddd1
Do some path normalization to prevent the possible_controllers list from containing invalid entries
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-07 16:16:37 +00:00
Jamis Buck
4e3543b467
Make sure named routes are never generated relative to some containing module
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-06 19:09:56 +00:00
Jamis Buck
e768dc694d
Improve parameter expiry handling to fix sticky-id issue. Add a more informative Route#to_s method.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-06 17:59:54 +00:00
Jamis Buck
6c04eb2115
Make sure changing the controller from foo/bar to bing/bang does not change relative to foo.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-05 15:48:29 +00:00
Jamis Buck
149f5cad85
Escape the entire path before trying to recognize it ( closes #3671 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-05 15:30:09 +00:00
Jamis Buck
2ffc84d23f
Make sure :id and friends are properly unescaped ( closes #5275 ).
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-05 14:51:27 +00:00
Jamis Buck
332fcfaf6b
Make sure regexp chunks are grouped when the segment has a regexp constraint so that captures are counted correctly ( closes #5267 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-05 14:31:38 +00:00
Jeremy Kemper
8cdf9126d3
Rewind readable CGI params so others may reread them (such as CGI::Session when passing the session id in a multipart form). Closes #210 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-02 06:30:23 +00:00
David Heinemeier Hansson
6dea52c54e
Finish custom handling [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-02 04:38:28 +00:00
David Heinemeier Hansson
5e998d1ea0
Make new mime types first class [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-02 04:29:34 +00:00
David Heinemeier Hansson
984aa7eeb9
Added Mime::Type.register(string, symbol, synonyms = []) for adding new custom mime types [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-02 04:11:56 +00:00
David Heinemeier Hansson
5c30352328
Added support for Mime objects in render :content_type option [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-02 03:39:56 +00:00
Jeremy Kemper
ac66cf1289
Add :status option to send_data and send_file. Defaults to '200 OK'. Closes #5243 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-02 00:51:56 +00:00
David Heinemeier Hansson
9e7e89a561
Dont keep nothing as a lookup [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-01 23:23:24 +00:00
Jamis Buck
b20c575ac0
New routes implementation. Simpler, faster, easier to understand. The published API for config/routes.rb is unchanged, but nearly everything else is different, so expect breakage in plugins and libs that try to fiddle with routes.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-01 15:42:08 +00:00
Jeremy Kemper
ce99c87551
Cope with missing content type and length headers. Parse parameters from multipart and urlencoded request bodies only. Accept multipart PUT parameters. Closes #5235 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-01 00:01:48 +00:00
David Heinemeier Hansson
f9cd92f4ee
Added interrogation of params[:format] to determine Accept type. If :format is specified and matches a declared extension, like "rss" or "xml", that mime type will be put in front of the accept handler. This means you can link to the same action from different extensions and use that fact to determine output [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-31 18:52:24 +00:00
Jeremy Kemper
6ce3bf70a2
follow_redirect doesn't complain about being redirected to the same controller. Closes #5153 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-22 22:59:56 +00:00
Marcel Molina
7252666b74
Add layout attribute to response object with the name of the layout that was rendered, or nil if none rendered. [Kevin Clark kevin.clark@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-17 07:25:36 +00:00
Michael Koziarski
d153525c53
Fix NoMethodError when parsing params like &&. [Adam Greenfield]. Closes #4955
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-16 20:56:41 +00:00
Rick Olson
04ef7f4be6
Small fix in routing to allow dynamic routes (broken after [4242]) [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-30 21:06:49 +00:00
Rick Olson
51cd1aec00
Fix assert_redirected_to tests according to real-world usage.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-25 03:54:46 +00:00
Rick Olson
526c69b49e
Diff compared options with #assert_redirected_to [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 15:08:25 +00:00
Jamis Buck
e75d27f405
restore some commented lines
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-21 20:15:53 +00:00
Jamis Buck
0a0b5bd722
fix to ';' interpretation in route recognition--only follow a route with ';' if the segment in question actually contains a ';'
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-21 17:21:26 +00:00
Jamis Buck
1f80f540a7
Add support in routes for semicolon delimited "subpaths", like /books/:id;:action
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-21 15:17:02 +00:00
Sam Stephenson
23585d721d
Added :add_headers option to verify which merges a hash of name/value pairs into the response's headers hash if the prerequisites cannot be satisfied
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-08 07:04:21 +00:00
David Heinemeier Hansson
47b74e6e16
Added ActionController.filter_parameter_logging that makes it easy to remove passwords, credit card numbers, and other sensitive information from being logged when a request is handled #1897 [jeremye@bsa.ca.gov]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-07 22:26:25 +00:00
David Heinemeier Hansson
42d8548e94
Failed test for Marcel to ponder
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-06 03:51:52 +00:00
Marcel Molina
4859b6c09e
Honor skipping filters conditionally for only certain actions even when the parent class sets that filter to conditionally be executed only for the same actions. Closes #4522 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-05 04:39:59 +00:00
David Heinemeier Hansson
0c07e08d60
ActionView: Allow to register a Template handler with a Symbol (dont kill markaby) ( closes #4328 ) [murphy@cYcnus.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-26 21:50:22 +00:00
Jamis Buck
b0189f3f2f
Fix assert_redirected_to so it works with symbols
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 18:16:48 +00:00
Rick Olson
891a962a19
Added nicer message for assert_redirected_to ( closes #4294 ) [court3nay, Chris McGrath]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 03:50:14 +00:00
David Heinemeier Hansson
c0ad3b6b68
Added test for Accept header for xml_http_request calls in functional tests ( closes #4222 ) [agkr@pobox.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:23:14 +00:00
David Heinemeier Hansson
cc6e8ae57a
Removed XML argument style for respond_to, so type.xml(object.to_xml) no longer works -- it wasnt worth the exception
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:17:14 +00:00
David Heinemeier Hansson
f22f352ee3
Added easy support for testing file uploads with fixture_file_upload ( closes #4105 ) [turnip@turnipspatch.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3939 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:10:52 +00:00
Jamis Buck
79a82e3a97
Make sure xml_simple requests don't blow up if an empty request body is recieved
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 18:56:19 +00:00
Jamis Buck
b2122159b1
fix broken respond_to test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 17:15:22 +00:00
Nicholas Seckar
240213177e
Add ability for relative_url_root to be specified via an environment variable RAILS_RELATIVE_URL_ROOT. Closes #4243 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:45:40 +00:00
David Heinemeier Hansson
9840dc84f1
Allow for respond_to(:html, :js, :xml) ( closes #4277 ) [Caio Chassot]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3919 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:43:37 +00:00
Jamis Buck
7e46571115
Add a test to make sure basic XML entities get unescaped properly
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:21:04 +00:00
Jamis Buck
4e0028fbab
Make Mime::Type.parse consider q values (if any)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3917 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:15:28 +00:00
Jamis Buck
459559a8bc
XML-formatted requests are typecast according to "type" attributes for :xml_simple
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 05:07:27 +00:00
David Heinemeier Hansson
4e15bf787e
Fixed proxy support for lighttpd ( closes #3267 ) [stephen_purcell@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:16:08 +00:00
David Heinemeier Hansson
275ea6de49
Added TestRequest#raw_post that simulate raw_post from CgiRequest ( closes #3042 ) [francois.beausoleil@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:15:12 +00:00
David Heinemeier Hansson
7d06259be9
Dots in template path should not trip up rendering ( closes #4244 ) [lmarlow@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3884 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 02:51:19 +00:00
Jamis Buck
2429074075
Underscore dasherized keys in formatted requests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 21:46:41 +00:00
Jamis Buck
6480d49749
Add MimeResponds::Responder#any for managing multiple types with identical responses
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 18:27:26 +00:00
Sam Stephenson
3589871de8
Added simple alert() notifications for RJS exceptions when config.action_view.debug_rjs = true. Set debug_rjs = true for the default development environment.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3856 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 02:11:59 +00:00
David Heinemeier Hansson
06c2b43f36
Rendering xml shouldnt happen inside any layout. Added class proxying to RJS, so you can call page.field.clear("my_field") to generate Field.clear("my_field");. Added :content_type option to render, so you can change the content type on the fly. Do type/subtype reordering of Accept header preferences for xml types (aka make Firefox work with respond_to). CHANGED DEFAULT: The default content type for .rxml is now application/xml instead of type/xml, see http://www.xml.com/pub/a/2004/07/21/dive.html for reason
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3852 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 01:33:57 +00:00
David Heinemeier Hansson
09cec78248
Default mime type for XML should be application/xml [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 18:50:14 +00:00
David Heinemeier Hansson
de37f7df4f
Mime types are separated by a comma, not semicolon, in the Accept header. Also switch all internal configuration of mime types away from strings and over to Mime::Type [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 16:03:44 +00:00
David Heinemeier Hansson
7af12d04ce
Added synonym and custom type handling to respond_to [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3844 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 06:02:44 +00:00
David Heinemeier Hansson
9e2932f816
Assume that we accept what we give [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3843 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 05:13:55 +00:00
David Heinemeier Hansson
de660957a5
Added defaults to respond_to [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 03:39:58 +00:00
David Heinemeier Hansson
6e3e5cadfb
Added option to render action/template/file of a specific extension (and here by template type). This means you can have multiple templates with the same name but a different extension [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3841 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 01:56:55 +00:00
David Heinemeier Hansson
1c16649b48
Added better support for using the same actions to output for different sources depending on the Accept header [DHH] Added Base#render(:xml => xml) that works just like Base#render(:text => text), but sets the content-type to text/xml and the charset to UTF-8 [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-11 01:23:29 +00:00
Rick Olson
043bee3338
Re-added mixed-in helper methods for the JavascriptGenerator. Moved JavascriptGenerators methods to a module that is mixed in after the helpers are added. Also fixed that variables set in the enumeration methods like #collect are set correctly. Documentation added for the enumeration methods [Rick Olson].
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-08 05:21:27 +00:00
Tobias Lütke
0635f633cc
ActionController::Base.param_parsers now accept symbols. currently supported are :xml_node, :xml_simple and :yaml
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 19:16:55 +00:00
Tobias Lütke
03d37a2d68
Added new infrastructure support for REST webservices.
...
By default application/xml posts are handled by creating a XmlNode object with the same name as the root element of the submitted xml. M$
ActionController::Base.param_parsers['application/atom+xml'] = Proc.new do |data|
node = REXML::Document.new(post)
{ node.root.name => node.root }
end
XmlSimple and Yaml web services were retired, ActionController::Base.param_parsers carries an example which shows how to get this functio$
request.[formatted_post?, xml_post?, yaml_post? and post_format] were all deprecated in favor of request.content_type [Tobias Luetke]
Closes #4081
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 18:59:58 +00:00
David Heinemeier Hansson
5f724b516c
Fixed tests ( closes #4087 ) [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 16:35:27 +00:00
David Heinemeier Hansson
16b9409a9c
allow RJS enum values to be passed to visual_effect() and other scriptaculous helpers #4080 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 06:42:58 +00:00
David Heinemeier Hansson
3d1b51b441
Added .rxml (and any non-rhtml template, really) supportfor CaptureHelper#content_for and CaptureHelper#capture #3287 [Brian Takita]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 19:47:50 +00:00
Nicholas Seckar
26eaf073c4
Remove ::Controllers related cruft; fix AP tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-26 17:49:09 +00:00
David Heinemeier Hansson
e875b0db47
Fixed that the request method would be sticky in tests ( closes #3849 ) [lars@pinds.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-20 23:49:43 +00:00
David Heinemeier Hansson
8896efd41a
Ensure backwards compatibility with symbolized action names for render_action ( closes #3869 ) [anna@wota.jp]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-19 00:46:34 +00:00
David Heinemeier Hansson
1812dbbfde
Make RJS treat symbolic action names nicely #3861 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-17 18:32:21 +00:00
David Heinemeier Hansson
93cba1207a
Modernize flash tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 16:29:21 +00:00
David Heinemeier Hansson
050c3964d8
Stopped the massive bleeding of concerns into ActionController::Base. Base no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 05:51:02 +00:00
Jeremy Kemper
7654082260
Major components cleanup and speedup. Closes #3527 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-09 20:05:11 +00:00
Jeremy Kemper
d0f3e52f02
Move active_record_store_test.rb to test/activerecord/. Closes #3790 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3556 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-09 19:24:22 +00:00
Michael Koziarski
d49a5fcb4c
* Fix pagination problems when using include
...
* Introduce Unit Tests for pagination
* Allow count to work with :include by using count distinct.
[Kevin Clark & Jeremy Hopple]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-09 09:17:40 +00:00
Nicholas Seckar
5450538563
Don't let arbitrary classes match as controllers
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 23:59:37 +00:00
Nicholas Seckar
427d0a8d14
Fix bad require for rake test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 23:14:22 +00:00
Nicholas Seckar
cc768dc900
Fix routing tests to pass when run independently of the entire AP suite
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 23:12:15 +00:00
Nicholas Seckar
b381d8511d
Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 23:09:26 +00:00
David Heinemeier Hansson
2504982945
Added :only and :except controls to skip_before/after_filter just like for when you add filters [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-31 23:55:04 +00:00
Nicholas Seckar
d2adec438e
Ensure assigns are copied to the template when using render :update. Closes #3620 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-30 04:49:17 +00:00
Sam Stephenson
9c52a41241
Add the ability to call JavaScriptGenerator methods from helpers called in update blocks
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 17:09:15 +00:00
Sam Stephenson
4d49f2ca09
Fix render(:update) to not render layouts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 16:29:37 +00:00
David Heinemeier Hansson
010e999092
Fixed that SSL would not correctly be detected when running lighttpd/fcgi behind lighttpd w/mod_proxy ( closes #3548 ) [stephen_purcell@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3467 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 05:32:59 +00:00
David Heinemeier Hansson
ea30f7353b
Raise a RedirectBackError if redirect_to :back is called when theres no HTTP_REFERER defined ( closes #3049 ) [kevin.clark@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 01:52:23 +00:00
Sam Stephenson
06dd1f2ca3
Add render :update for inline RJS
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-20 22:04:07 +00:00
Marcel Molina
4793a2f5cd
Automatically discover layouts when a controller is namespaced. Closes #2199 , #3424 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-15 11:28:55 +00:00
Michael Koziarski
302533b196
Add support for multiple proxy servers in HTTP_X_FORWARDED_HOST. Closes #3397
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 08:31:16 +00:00
Marcel Molina
489ace60fb
Remove Upload Progress. Closes #2871 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 04:27:53 +00:00
Marcel Molina
751b6be464
Allow auto-discovery of third party template library layouts.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-12 07:16:23 +00:00
Marcel Molina
0b55ce7191
Value of full_messages on stubbed out AR instances should be an Array.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-26 19:40:14 +00:00
Marcel Molina
233208b8bb
Don't try to strip out the controller name if default_action_name is nil
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-20 05:32:39 +00:00
Marcel Molina
39766a9b4c
Don't include a layout when rendering an rjs template using render's :template option.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-17 06:38:06 +00:00
Jeremy Kemper
c140e80fc4
More robust relative url root discovery for SCGI compatibility. This solves the 'SCGI routes problem' -- you no longer need to prefix all your routes with the name of the SCGI mountpoint. References #3070 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-08 04:40:24 +00:00
Marcel Molina
c3612a23e6
Silence deprecation warnings for keep_flash when running tests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-02 00:39:25 +00:00
Sam Stephenson
bea737eb5a
Make ActionController's render honor the :locals option when rendering a :file. Closes #1665 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-22 08:37:04 +00:00
Jeremy Kemper
cd8686b456
r3173@asus: jeremy | 2005-11-18 23:34:41 -0800
...
Ticket 2731 - sessions
r3185@asus: jeremy | 2005-11-19 18:02:51 -0800
eliminate const redefinition warning
r3186@asus: jeremy | 2005-11-19 19:25:50 -0800
Use :database option instead of :dbfile
r3187@asus: jeremy | 2005-11-19 19:34:31 -0800
Data writer assigns to instance var. Since nothing is calling write_attribute on the data column except for marshal_data, simplify data reader to lazy-unmarshal the data column (no worrying whether it's already unmarshaled)
r3188@asus: jeremy | 2005-11-19 19:35:40 -0800
Explicitly create the session class so that subsequent requests for the session can find it in the database. This is masking a problem with the controller losing its @session instance var and therefore requesting a new session.
r3189@asus: jeremy | 2005-11-19 19:36:40 -0800
Using create unnecessarily broadens the existing duck-typing so use new + save instead.
r3194@asus: jeremy | 2005-11-19 20:28:17 -0800
Test creation of another instance while first instance is still active. Should return same session_id.
r3195@asus: jeremy | 2005-11-19 20:39:45 -0800
Always create new AR sessions rather than trying too hard to avoid database traffic. References #2731 .
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-20 04:41:59 +00:00
Marcel Molina
62fe5bbfb1
Make rjs templates always implicitly skip out on layouts.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-18 08:32:17 +00:00
Marcel Molina
06e74b6c91
Add support for new rjs templates which wrap an update_page block.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-17 21:28:59 +00:00
Jeremy Kemper
8da9d02e6e
Include QUOTED_TYPE constant in ActionPack AR assertions tests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 09:09:04 +00:00
Jeremy Kemper
745ea39926
MemCache store may be given multiple addresses. Closes #2869 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 08:35:31 +00:00
Jeremy Kemper
08fd13d17c
Handle cookie parsing irregularity for certain Nokia phones. Closes #2530 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-15 07:51:09 +00:00
Jeremy Kemper
0abaf3a2d8
CGI::Session::ActiveRecordStore.data_column_name = 'foobar' to use a different session data column than the 'data' default. References #2731 . Remove error-prone method_missing passthrough to session model. Cleanup.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-09 01:03:24 +00:00
Jeremy Kemper
85baf07be8
Controllers with acronyms in their names (e.g. PDFController) require the correct default helper (PDFHelper in file pdf_helper.rb). Closes #2262 . Do not raise an exception when default helper is missing; log a debug message instead. It's nice to delete empty helpers.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-08 08:23:13 +00:00
David Heinemeier Hansson
a6106e4ec6
Added skip_before_filter/skip_after_filter for easier control of the filter chain in inheritance hierachies [DHH] Added short-hand to assert_tag so assert_tag :tag => "span" can be written as assert_tag "span" [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-04 19:42:22 +00:00
David Heinemeier Hansson
4f754985d0
Added redirect_to :back as a short-hand for redirect_to(request.env["HTTP_REFERER"])
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-02 14:47:03 +00:00
Scott Barron
025949102e
Fix problem where redirecting components can cause an
...
infinite loop [Rick Olson]
Closes #2654
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-30 13:13:02 +00:00
David Heinemeier Hansson
cb0e27cee9
Fix that render :text didn't interpolate instance variables ( Closes #2629 , #2626 ) [skaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-28 07:33:54 +00:00
David Heinemeier Hansson
07c494ae24
Added a reader for flash.now, so it's possible to do stuff like flash.now[:alert] ||= 'New if not set' ( closes #2422 ) [Caio Chassot]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 13:14:10 +00:00
Nicholas Seckar
86a571090c
Reset template variables after using render_to_string. Closes #2559
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-25 02:15:08 +00:00
Jeremy Kemper
22d9bad8a0
Expose the session model backing CGI::Session
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-20 21:59:48 +00:00
Jamis Buck
e515ba9ecd
Fix the html-scanner to count children correctly, playing nicely with :only, fixes #2181 [patrick@lenz.sh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-18 00:50:52 +00:00
Nicholas Seckar
cb8bb70aa7
Make string-keys locals assigns optional
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-17 15:51:07 +00:00
Tobias Lütke
0279949b05
added assert_valid to AP
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-16 02:20:53 +00:00
Nicholas Seckar
e625d27633
Add temporary support for passing locals to render using string keys
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-16 00:04:33 +00:00
Marcel Molina
48fd667bda
Raise an exception if an attempt is made to insert more session data into the ActiveRecordStore data column than the column can hold. Closes #2234 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-15 14:39:29 +00:00
Scott Barron
f8f4eccd9a
If a component redirects when called with render_component_as_string, render the
...
redirected to action.
Fixes #2327
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-15 02:53:21 +00:00
Nicholas Seckar
e0e8f0a302
Fix Request#host_with_port to use the standard port when Rails is behind a proxy.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-15 01:00:25 +00:00
David Heinemeier Hansson
43b6a74fb1
Added :locals support for render :inline #2463 [mdabney@cavoksolutions.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:26:39 +00:00
Jeremy Kemper
9a7ff1433a
r3575@sedna: jeremy | 2005-10-13 11:22:13 -0700
...
Eliminate warning for redefined MemCache constant.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:05:41 +00:00
Sam Stephenson
4b72a4b12f
Unset the X-Requested-With header when using the xhr wrapper in functional tests. Closes #2352 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 18:09:27 +00:00
Sam Stephenson
f49dc37e71
Wrap javascript_tag contents in a CDATA section and add a cdata_section method to TagHelper. Closes #1691 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 22:47:39 +00:00
Sam Stephenson
0886bb391d
Fixed that an instance variable with the same name as a partial should be implicitly passed as the partial :object. Closes #2269 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 20:35:13 +00:00
Marcel Molina
a9de9c48c2
Make assert_tag :children count appropriately. Closes #2181 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-09 01:45:21 +00:00
David Heinemeier Hansson
438db964ad
Testing should also use a default REQUEST_METHOD
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-29 08:43:17 +00:00
Jeremy Kemper
5d19fd7841
Unit tests and fixtures for multipart posts.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2389 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 08:19:26 +00:00
Jeremy Kemper
17d2732b1c
Ticket #2295 - Tolerate consecutive delimiters in query parameters
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 22:23:37 +00:00
Nicholas Seckar
564077373d
Streamline render process, code cleaning. Closes #2294 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 16:45:39 +00:00
Scott Barron
a111e1a271
Keep flash after component is rendered. Closes #2291 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 11:02:11 +00:00
Jeremy Kemper
9852197f83
r3573@asus: jeremy | 2005-09-26 11:38:44 -0700
...
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
r3574@asus: jeremy | 2005-09-26 14:32:11 -0700
Get rid of constant redefine warning.
r3575@asus: jeremy | 2005-09-26 14:33:07 -0700
Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
r3576@asus: jeremy | 2005-09-26 14:33:49 -0700
Unit test overridden original_filename against normal filenames and full Windows paths.
r3577@asus: jeremy | 2005-09-26 14:33:57 -0700
Update change log.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-26 17:59:46 +00:00
Scott Barron
fa7d4a691f
This seems unnecessary to call in teardown and is causing the tests
...
to error because the table has been dropped.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-25 10:41:22 +00:00
Thomas Fuchs
2346f5716f
Fix open/save dialog in IE not opening files send with send_file/send_data, #2279
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-25 06:53:42 +00:00
Jamis Buck
4fa9a2bfe2
Require 'pp' early to prevent the pretty-print methods being mixed in too late and messing up a test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 13:55:27 +00:00
David Heinemeier Hansson
3754822f43
Fixed problem with send_file and WEBrick using stdout #1812
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 10:53:33 +00:00
David Heinemeier Hansson
7f26415d3c
Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 07:54:55 +00:00
David Heinemeier Hansson
47292cdef7
Fixed that Request#domain caused an exception if the domain header wasn't set in the original http request #1795 [Michael Koziarski]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 06:44:53 +00:00
Nicholas Seckar
b9c79f195f
Add routing tests from #1945
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-18 14:37:43 +00:00
Nicholas Seckar
57e0cf8e95
Add a routing test case covering #2101
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-18 14:11:24 +00:00
David Heinemeier Hansson
e9504bb6f7
Cache relative_url_root for all webservers, not just Apache #2193 [skae]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:32:16 +00:00
David Heinemeier Hansson
c1505e3e2b
Included UrlRewriter tests in rake run and made them not depend on Hash order
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:24:29 +00:00
David Heinemeier Hansson
d985260ed7
Made base_tests.rb run as part of rake
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:20:32 +00:00
David Heinemeier Hansson
ebb7bd7835
Added easy assignment of fragment cache store through use of symbols for included stores (old way still works too)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 08:31:32 +00:00
Nicholas Seckar
27962ead03
Add ability to specify Route Regexps for controllers. Closes #1917 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:56:43 +00:00
Nicholas Seckar
9e5d64b3bb
Provide Named Route's hash methods as helper methods. Closes #1744 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 13:45:55 +00:00
David Heinemeier Hansson
3cf7a0a460
Added Kernel#silence_warnings and puts it into use throughout the framework
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 04:58:27 +00:00
David Heinemeier Hansson
e3c02d8c66
Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:27:44 +00:00
Nicholas Seckar
3108764367
Fix overwrite params. Closes #1909
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 22:06:11 +00:00
Jamis Buck
6c44d35268
AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 09:10:31 +00:00
Jamis Buck
e758c2e9db
Yield @content_for_ variables to templates #2058 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:51:27 +00:00
Jamis Buck
01af965a3e
Make rendering an empty partial collection behave like :nothing => true #2080 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:43:38 +00:00
Nicholas Seckar
68c90ab019
Render refactoring; render error reporting fixes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-26 22:37:36 +00:00
Jamis Buck
211617191e
Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-23 09:43:36 +00:00
Jamis Buck
c031a01633
Add an :if option to session management, to allow programmatically enabling or disabling the session
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-17 21:05:31 +00:00
Jamis Buck
50e2474433
Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad
Make sure :layout => false is always used when rendering inside a layout
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d
Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20
Make sure assigns are built for every request when testing #1866
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f
Allow remote_addr to be queried on TestRequest #1668
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
3d2f0001ea
Fixed bug when a partial render was passing a local with the same name as the partial
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 12:24:14 +00:00
David Heinemeier Hansson
d9033bbb28
Demonstrate breakage better
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 12:06:19 +00:00
David Heinemeier Hansson
e95dd53a5d
Added two failing tests for partials with locals from controller
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 09:11:00 +00:00
David Heinemeier Hansson
4f40b2d8fb
Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
1ae0a53d86
Fixed regression for content_for #1820 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
b366dbd952
Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985
Added test for template to layout variable transfer
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 08:43:01 +00:00
Jamis Buck
d76439239d
Add unit test to ensure that session management options are inherited and overridable in subclasses
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:56:53 +00:00
Jamis Buck
06843f8794
Added support for per-action session management #1763
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
bd558ef98e
Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
Nicholas Seckar
741316dc71
Fixed construction of get parameters for arrays
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:12:45 +00:00
Nicholas Seckar
c0771fe7d8
Fix assert_routing with nested controllers. Closes #1582 and #1386 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 15:00:39 +00:00
Nicholas Seckar
bf0b7588ee
Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602
Provide correct defaults for Named Routes which do not specify :action
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 09:09:39 +00:00
David Heinemeier Hansson
16595c93b2
Made pagination faster #1334 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 08:02:01 +00:00
David Heinemeier Hansson
807df4fcf0
Made test_rendering_nothing_on_layout acknowledge the space
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 07:19:26 +00:00
Nicholas Seckar
2bd4ff11f8
Generate URLs for :action => index when :action => nil is supplied.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239
Named routes should not provide nil values to url_for. Includes factoring and extra testcases.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 23:13:15 +00:00
Jamis Buck
847f738cfd
Make Request#subdomains handle "foo.foo.com" correctly
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 16:16:13 +00:00
Jeremy Kemper
c697be5b69
r2992@asus: jeremy | 2005-07-10 02:43:49 -0700
...
Skip ActiveRecordStore tests if neither SQLite 2 nor 3 is available.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:05:06 +00:00
Jamis Buck
8266867881
Improved error message for DoubleRenderError
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 15:31:06 +00:00
Jeremy Kemper
34df31455a
r2948@asus: jeremy | 2005-07-08 16:00:23 -0700
...
Use save instead of save! in ARStore test also.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 18:13:07 +00:00
Nicholas Seckar
c18961f185
Routes now raise an exception if a path component is misconfigured.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62
Fix routes to generate proper URLs when given Fixnum defaults
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:45:51 +00:00
Nicholas Seckar
f4bfacb24f
Enable routes to recognize uppercase controller names. Closes #1635
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42
Properly unescape recognized path components. Fixes #1651 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:43:03 +00:00
Nicholas Seckar
e3af27c51b
Improved testing of functional test setup.
...
Fixed functional test setup so that :controller and :action
are stored into path_parameters using string keys.
Added with_routing test helper which can be used to dynamically
replace the current set of routes inside a unit test.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:23:35 +00:00
David Heinemeier Hansson
75157bbf64
Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:16:05 +00:00
Jeremy Kemper
afbf54bc3d
Add test for dynamic dispatch based on action_name accessor.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 13:45:31 +00:00
David Heinemeier Hansson
212cc3845a
Fixed routing snafu
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
93ec99c246
Partly tuned docs for release (AP)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:27:11 +00:00
Jeremy Kemper
063956b93c
r2879@asus: jeremy | 2005-07-05 16:15:16 -0700
...
Rollback changesets for Ticket #1229 .
r2880@asus: jeremy | 2005-07-05 16:17:08 -0700
Ticket #1229 does not affect Ticket #1614 . Reinstating the changesets.
r2881@asus: jeremy | 2005-07-05 16:24:04 -0700
@test_unchanged in deprecated render test :partials_list action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:31:51 +00:00
Jeremy Kemper
8a2fec8d31
r2874@asus: jeremy | 2005-07-05 16:13:39 -0700
...
Unit test for Ticket #1614 .
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:21:26 +00:00
David Heinemeier Hansson
4fe0248f57
Fixed routing regression on index exception
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:31:51 +00:00
Jamis Buck
3b1d271e02
Routing fix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:06:09 +00:00
Jeremy Kemper
1e6603e6e7
r2850@asus: jeremy | 2005-07-05 13:08:32 -0700
...
Don't be strict about the order in which AR store methods are called. Allow e.g. session close followed by session close.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1710 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 14:50:07 +00:00
Jeremy Kemper
ed12b0cac0
r2836@asus: jeremy | 2005-07-05 00:33:12 -0700
...
Test sessid backward compatibility. DRY up the test classes.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1692 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 02:29:37 +00:00
Jeremy Kemper
ac412ef1c7
r2822@asus: jeremy | 2005-07-04 21:14:30 -0700
...
silence warnings re. class redefinitions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:58 +00:00
Jeremy Kemper
79455b6d45
r2821@asus: jeremy | 2005-07-04 21:14:16 -0700
...
reuse path_to_ar
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1686 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:54 +00:00
Jeremy Kemper
5ab1df9e37
r2820@asus: jeremy | 2005-07-04 21:13:57 -0700
...
Bring in-mem SQLite goodness to active_record_assertions_test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:49 +00:00
Jeremy Kemper
7bcaf2b689
r2817@asus: jeremy | 2005-07-04 20:49:12 -0700
...
active_record_store_test falls back to SQLite2 if 3 is unavailable
r2818@asus: jeremy | 2005-07-04 20:52:25 -0700
update changelog
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 22:48:01 +00:00
Jeremy Kemper
ddb57d8ab8
r2815@asus: jeremy | 2005-07-04 19:49:35 -0700
...
Correct SqlBypass test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:46:01 +00:00
Jeremy Kemper
509bf53889
r2809@asus: jeremy | 2005-07-04 19:29:19 -0700
...
give CGI::Session options as strings, not symbols
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:26:50 +00:00
Jeremy Kemper
50619549ee
r2808@asus: jeremy | 2005-07-04 19:08:48 -0700
...
test at dbman and at CGI::Session level. need to merge the test classes since they're the same tests for different backends..
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1680 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:26:45 +00:00
David Heinemeier Hansson
128e352614
Fixed that hashes was not working properly when passed by GET to lighttpd #849 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 19:21:48 +00:00
Jeremy Kemper
452442dde8
r2790@asus: jeremy | 2005-07-04 16:30:58 -0700
...
smart active record session class. session class is pluggable; a basic SqlBypass class is provided. set CGI::Session::ActiveRecordStore.session_class = SqlBypass and set SqlBypass.connection = SomeARConnection. Further tests pending.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 18:30:27 +00:00
Jeremy Kemper
5900d4ff75
r2788@asus: jeremy | 2005-07-04 16:16:20 -0700
...
Don't unnecessarily pollute $:. Use SQLite3 instead of SQLite by default.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 18:30:17 +00:00
Jamis Buck
6e7e552b03
Fix broken capture test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:36:22 +00:00
Jamis Buck
fcdcd9b9fa
Hashes sent via multipart post should be converted to strings #1032 [me@julik.nl]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:31:37 +00:00
Jamis Buck
cf9c991d4c
Fix test broken by [1648]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:20:25 +00:00
David Heinemeier Hansson
5524dedc06
Fixed routing bug #1592
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 12:01:06 +00:00
David Heinemeier Hansson
208291391c
Added JavascriptHelper#update_element_function, which returns a Javascript function (or expression) that'll update a DOM element according to the options passed #933 [mortonda@dgrmm.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 11:01:43 +00:00
David Heinemeier Hansson
177ed3e681
Added more tests on assert_redirected_to #1581 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:16:38 +00:00
David Heinemeier Hansson
524d1b5e04
Uncommented request.recycle! as it breaks more than it fixes, left test case in, xal?
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-30 14:49:36 +00:00
David Heinemeier Hansson
94cae0d0a2
Got back to functional testing harmony
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 09:44:55 +00:00
Jeremy Kemper
31e48939b1
r1475@iwill: jeremy | 2005-06-28 23:19:51 -0700
...
Ticket 1543 - Fix test_process
r1476@iwill: jeremy | 2005-06-29 00:20:53 -0700
Correct expected, actual order for assert_equal. Use new render method in TestController.
r1477@iwill: jeremy | 2005-06-29 00:23:45 -0700
Generate route and assign parameters without modifying the user's params.
r1480@iwill: jeremy | 2005-06-29 00:28:52 -0700
Update changelog.
r1481@iwill: jeremy | 2005-06-29 00:34:02 -0700
Directly generate paths with a leading slash instead of tacking it on later.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1557 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 02:41:00 +00:00
Jamis Buck
453ed15395
Routes fail with leading slash #1540 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 21:18:04 +00:00
David Heinemeier Hansson
beffb77e05
Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:44:16 +00:00
David Heinemeier Hansson
b8689c77a4
Don't ignore :controller for urls made inside a controller module #1526 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 15:17:59 +00:00
David Heinemeier Hansson
a7116b6534
Make named routes work without hashes #1523 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 14:32:19 +00:00
David Heinemeier Hansson
2269c23699
Fixed assert_redirected_to to handle absolute controller paths properly #1472 [Rick Olson/Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 05:36:03 +00:00
David Heinemeier Hansson
930b59eb39
Fixed that Functional tests do not set request.path_parameters properly #1512 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 14:36:13 +00:00
David Heinemeier Hansson
6f6c6b8bcb
Updated assert_generates/routing to the new Routes code #1498 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 10:58:44 +00:00
Jamis Buck
17928b7347
Eliminate a "string literal in condition" warning from some routes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 09:20:38 +00:00
Jamis Buck
af33a6a6b1
Fix problem with symbol/string mismatch on some routes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 22:15:45 +00:00
David Heinemeier Hansson
8e56f5ea3e
Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 16:40:01 +00:00
David Heinemeier Hansson
964a477340
Include Routing tests in rake run #1287
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:39:28 +00:00
David Heinemeier Hansson
1e0d9a642f
Added :xhr => true/false option to verify so you can ensure that a request is coming from an Ajax call or not #1464 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:02:30 +00:00
David Heinemeier Hansson
92473b8f96
Fixed relative urls support for lighttpd #1048 [Nicholas Seckar/maznawak@nerim.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-18 05:17:18 +00:00
David Heinemeier Hansson
a895be0259
Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:42:49 +00:00
Jeremy Kemper
7bb486055e
r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700
...
Ticket 1394 - Helper isolation
r1319@iwill: jeremy | 2005-06-15 01:10:00 -0700
Formulate a test case for helper isolation.
r1331@iwill: jeremy | 2005-06-15 15:21:07 -0700
Update changelog
r1332@iwill: jeremy | 2005-06-15 15:21:30 -0700
Remove superfluous, broken layout_test
r1333@iwill: jeremy | 2005-06-15 15:24:10 -0700
Use an anonymous Module to store helpers per-class instead of tossing them all in template_class. Create a new helper module for subclasses which includes its superclass' helper module. Remove unnecessary ActionView::Base.controller_delegate. Update helper tests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 17:17:58 +00:00
Jamis Buck
14c378cc7f
render(:template) applies a layout by default. render("foo/bar") works with a layout again.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 13:20:17 +00:00
David Heinemeier Hansson
cb79118111
Fixed double-singularization on scaffolded pagination call (Address would be turned into Addres) #1216 , #1404 [nilsga]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 04:17:45 +00:00
Jamis Buck
75fb0a32a8
Support :render option to :verify #1440 [TobiasLuetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 13:23:55 +00:00
Jamis Buck
b2b757be39
Fix broken test case caused by change of testing address from 127.0.0.1 to 0.0.0.0
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 10:31:31 +00:00
Jamis Buck
f6ec9e3d66
Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-10 12:21:25 +00:00
Jamis Buck
e4c047e489
render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-01 13:39:58 +00:00
Jamis Buck
6ce58318f5
render(:inline) defaults to :layout => false
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3
Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1
render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b
verify with :redirect_to won't redirect if a redirect or render has already been performed #1350
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa
render(:partial => "...") uses an empty hash for the local assigns #1365 . render(:partial => true) is identical to the older render_partial()
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:20:37 +00:00
David Heinemeier Hansson
79d9794f09
Updated unit test style
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 17:12:29 +00:00
David Heinemeier Hansson
c41f0cc720
Test for no layout on nothing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 16:59:55 +00:00
David Heinemeier Hansson
da0c4c5c96
Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6
Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
d3704f888b
Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
dd8c92ea5b
Fixed Request#remote_ip in testing #1251 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
aa20834222
Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
e6f3e5d900
Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
b4fe4daa84
Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
3b9bf64130
Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
806cf6d76a
Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
dca7efa67e
Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
e5b3d08a0a
Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
68dfe3e046
Clean up load paths to avoid unit test interaction #1113 [alles@atomicobject.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:16:00 +00:00
David Heinemeier Hansson
7f558cbd05
Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
4ab40059b7
Added simulation of @request.request_uri in functional tests #1038 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:22:19 +00:00
David Heinemeier Hansson
7c8d2f28e1
Removed broken attempt to DRY module ClassMethod #970
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:29:43 +00:00
David Heinemeier Hansson
ce96c5b30b
Added assert_no_cookie and fixed assert_cookie_equal to deal with non-existing cookies #979 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:54:25 +00:00
David Heinemeier Hansson
00121b2ca2
Added :method option to verify for ensuring that either GET, POST, etc is allowed #984 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:33:30 +00:00
David Heinemeier Hansson
9fb6a54a16
Added fourth option to process in test cases to specify the content of the flash #949 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 21:43:25 +00:00
David Heinemeier Hansson
f569a14318
Added Verifications that allows you to specify preconditions to actions in form of statements like <tt>verify :only => :update_post, :params => "admin_privileges", :redirect_to => { :action => "settings" }</tt>, which ensure that the update_post action is only called if admin_privileges is available as a parameter -- otherwise the user is redirected to settings. #897 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 21:41:10 +00:00
David Heinemeier Hansson
a5b55c6b9f
Removed old UrlWriter methods that are no longer in use after Routes #942
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:31:01 +00:00
David Heinemeier Hansson
b88fa4d1df
Routes: *path items should use arrays #883
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-21 00:40:51 +00:00
David Heinemeier Hansson
0919dbf6b6
Routes: Convert results of #to_param to strings #879
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 22:44:12 +00:00
David Heinemeier Hansson
a61360688c
Changed .htaccess to allow dispatch.* to be called from a sub-directory as part of the push with Action Pack to make Rails work on non-vhost setups #826 [Nicholas Seckar/Tobias Luetke] Fixed routing and helpers to make Rails work on non-vhost setups #826 [Nicholas Seckar/Tobias Luetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 22:02:22 +00:00
David Heinemeier Hansson
a35cf348bf
Added a much improved Flash module that allows for finer-grained control on expiration and allows you to flash the current action #839 [Caio Chassot]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 19:12:53 +00:00
David Heinemeier Hansson
37a46151ec
Added path collection syntax for Routes that will gobble up the rest of the url and pass it on to the controller #830 [rayners]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-20 14:04:33 +00:00
David Heinemeier Hansson
193edfbfdb
Removed the reliance on PATH_INFO as it was causing problems for caching and inhibited the new non-vhost support #822 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-14 00:25:24 +00:00
David Heinemeier Hansson
688f0f6712
Fixed that map.connect should convert arguments to strings #780 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 14:16:25 +00:00
David Heinemeier Hansson
28a11969ce
Fix request.path_info and clear up LoadingModule behavior #754 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-01 02:04:54 +00:00
David Heinemeier Hansson
630638b00e
Fixed that Routes would raise NameErrors if a controller component contains characters that are not valid constant names #733 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:12:35 +00:00
David Heinemeier Hansson
8cddbf0d37
Added PATH_INFO access from the request that allows urls like the following to be interpreted by rails: http://www.example.com/dispatcher.cgi/controller/action -- that makes it possible to use rails as a CGI under lighttpd and would also allow (for example) Rublog to be ported to rails without breaking existing links to Rublog-powered blogs. #728 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:11:05 +00:00
David Heinemeier Hansson
02df588cf7
Fixed tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 11:50:59 +00:00
David Heinemeier Hansson
b7889524bf
Fix empty url_for with nested modules #707
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 01:38:10 +00:00
David Heinemeier Hansson
11a2bb91f5
Added some unit tests #706
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 23:53:55 +00:00
David Heinemeier Hansson
41ea6963a3
Added Base#render_to_string to parse a template and get the result back as a string #479
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 14:57:08 +00:00
David Heinemeier Hansson
cd689cf22b
Fixed some tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:52:38 +00:00
David Heinemeier Hansson
f153f42469
Never end generated paths with a '/' #683
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 20:54:40 +00:00
David Heinemeier Hansson
acb3d2cf75
Fixed internal calling
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 00:02:02 +00:00
David Heinemeier Hansson
cf6d77600a
Tests and tweaks for components
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:51:59 +00:00
David Heinemeier Hansson
0011116592
Unit tests for rendering components
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:49:12 +00:00
David Heinemeier Hansson
cae0f46eda
Fixed a few tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@703 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:21:08 +00:00
David Heinemeier Hansson
9a5d6d6388
Added ActionView::Base.register_template_handler for easy integration of an alternative template language to ERb and Builder. See test/controller/custom_handler_test.rb for a usage example #656 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 17:22:37 +00:00
David Heinemeier Hansson
5760a6cb3e
Clear route defaults using :name => nil #663
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:53:18 +00:00
David Heinemeier Hansson
519fe7ccbc
Added URL escaping for routing #664
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:52:28 +00:00
David Heinemeier Hansson
37249f6a86
Fixed that assert_template_xpath_matches did not indicate when a path was not found #658 [Eric Hodel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 17:13:57 +00:00
David Heinemeier Hansson
bc574a86ac
Skip Active Record tests in Action Pack if the SQLite database cant be brought up
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:28:13 +00:00
David Heinemeier Hansson
02e382a765
More tests for Routing related stuff
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@647 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:00:21 +00:00
David Heinemeier Hansson
6a48e89ae7
Fix that routes werent being loaded in production environment
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 02:04:37 +00:00
David Heinemeier Hansson
29066036f2
Make Routes drop the default for action when the controller changes #651
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 01:46:29 +00:00
David Heinemeier Hansson
b1999be5a7
A hopefully more successful attempt at the Routing branch merge
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:45:35 +00:00
David Heinemeier Hansson
88a3343ed5
Backed out of routing merge.. investigating missing patches
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:24:55 +00:00
David Heinemeier Hansson
c844755e5a
Merged back the Routing branch
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 00:51:02 +00:00
David Heinemeier Hansson
65f834ad45
Stringify the parameters on follow_redirect
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 21:54:34 +00:00
David Heinemeier Hansson
61a6a440cb
Added follow_redirect method for functional tests that'll get-request the redirect that was made.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 19:35:30 +00:00
David Heinemeier Hansson
098fa94356
Fixed documentation snafus #575 , #576 , #577 , #585
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-07 14:15:53 +00:00
David Heinemeier Hansson
80b656637a
Added :application_prefix to url_for and friends that makes it easier to setup Rails in non-vhost environments #516 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 13:50:58 +00:00
David Heinemeier Hansson
dfed3d309e
A few missing files
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:55:13 +00:00
David Heinemeier Hansson
2ee84cc6f9
Fixed that all redirect and render calls now return true, so you can use the pattern of "do and return". Added that renders and redirects called in before_filters will have the same effect as returning false: stopping the chain. Added that only one render or redirect can happen per action. The first call wins and subsequent calls are ignored.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:13:34 +00:00
David Heinemeier Hansson
9c09f81bc6
Added arrays as a value option for params in url_for and friends #467 [Eric Anderson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 14:06:33 +00:00
David Heinemeier Hansson
96e54780b3
Fixed that send_file would "remember" all the files sent by adding to the headers again and again #458 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 13:29:49 +00:00
David Heinemeier Hansson
d3a8d5f93c
Fixed url rewriter confusion when the controller or action name was a substring of the controller_prefix or action_prefix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 16:23:18 +00:00
David Heinemeier Hansson
cb8a020ec9
Fixed url rewriter confusion when the controller name was a substring of the controller_prefix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 15:21:09 +00:00
David Heinemeier Hansson
11f766d3eb
Removed authentication framework as xal made me realize that with noradios conditional filters, it was actually more code to use the framework than doing it by hand. Killing a darling! Props to noradio for the patch and xal for the nerve to stand up and question the captain before the plane crashed. Oh, and a pad on my own back for walking away from a couple of hours of work without getting pissy
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:21:29 +00:00
David Heinemeier Hansson
677d92299b
Added conditional filters #431 [Marcel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:14:47 +00:00
David Heinemeier Hansson
cbd367b7fa
Added :before option to authentication
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 16:43:21 +00:00
David Heinemeier Hansson
75fca04590
Added authentication framework to protect actions behind a condition and redirect on failure. See ActionController::Authentication for more.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 15:20:00 +00:00
David Heinemeier Hansson
0b6fe2244e
Taken out as noradio took over
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-08 23:41:42 +00:00
David Heinemeier Hansson
efe0348486
Added the possibility of passing nil to UrlHelper#link_to to use the link itself as the name
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@338 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-05 00:38:09 +00:00
David Heinemeier Hansson
3e7a4ecc57
Fixed redirects when the controller and action is named the same. Still haven't fixed same controller, module, and action, though #201 [Josh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-02 20:10:11 +00:00
David Heinemeier Hansson
00deaf6d56
Added :host and :protocol options to url_for and friends to redirect to another host and protocol than the current.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-23 18:59:24 +00:00
David Heinemeier Hansson
a04b1f3d8a
Added more informative exception when using helper :some_helper and the helper requires another file that fails, you'll get an error message tells you what file actually failed to load, rather than falling back on assuming it was the helper file itself #346 [dblack]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:44:16 +00:00
David Heinemeier Hansson
61960e7b37
Added Request#port_string to get something like ":8080" back on 8080 and "" on 80 (or 443 with https).
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-18 18:01:28 +00:00
David Heinemeier Hansson
a7532f9d5f
Added Request#domain (returns string) and Request#subdomains (returns array).
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-18 17:19:15 +00:00
David Heinemeier Hansson
922f817a5a
Added the option of passing false to :module or :controller_prefix in order to "break out" of a module or prefix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-13 11:35:48 +00:00
David Heinemeier Hansson
c8d68dfed3
Killed the out of place alias and made sure you can use the different HTTP methods within the same testaction
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@80 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-08 10:43:24 +00:00
David Heinemeier Hansson
465e0c0c26
Added the possibility of having validate be protected for assert_(in)valid_column #263 [Tobias Luetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@67 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 12:18:33 +00:00
David Heinemeier Hansson
a544d7aa37
Added all the HTTP methods as alternatives to the generic "process" for functional testing #276 [Tobias Luetke]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@58 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 11:10:46 +00:00
David Heinemeier Hansson
50f333b203
Added graceful handling of non-alphanumeric names and misplaced brackets in input parameters [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@39 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-01 12:57:16 +00:00
David Heinemeier Hansson
177cae5483
Allow symbols to be used as names for setting cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@22 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:11:42 +00:00
David Heinemeier Hansson
defda16b83
Allow symbols to be used as keys for setting cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@21 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:09:38 +00:00
David Heinemeier Hansson
d0c90331f1
Added a new container for cookies that makes them more intuative to use. The old methods of cookie and @cookies have been deprecated.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@20 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:04:35 +00:00
David Heinemeier Hansson
db045dbbf6
Initial
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-24 01:04:44 +00:00