TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
39,154 Commits 2 Branches 0 Tags 294 MiB
06344b9416
Commit Graph

39154 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
655953cd48 assert that constants have been set rather than the names 2013-08-01 11:02:15 -07:00
Aaron Patterson
92ab4d6a8a remove dead code 2013-08-01 11:02:15 -07:00
Aaron Patterson
5dd38ad021 pushing out more callback definitions 2013-08-01 11:02:15 -07:00
Aaron Patterson
9da52a5e55 push more mutations out of the builder 
`configure_dependency` actually defined callbacks, so rename the method
and move it to the appropriate method.
 2013-08-01 11:02:15 -07:00
Aaron Patterson
537fe2bf83 remove dependency on @model when defining callbacks 2013-08-01 11:02:15 -07:00
Aaron Patterson
49d50b9d80 extract more mutations to the caller 2013-08-01 11:02:15 -07:00
Aaron Patterson
35f94acf55 separate some mutations from reflection construction 2013-08-01 11:02:15 -07:00
Rafael Mendonça França
69339e54d3 Fix current_page? when the URL contains escaped characters 
In some cases webservers like nginx send the escaped characters
lowercased to the Rails application. The current_page? helper was
comparing the escaped strings that are different since Ruby escapes the
URL using uppercased characters.
 2013-08-01 10:46:35 -03:00
Carlos Antonio da Silva
4e00ac3ca4 Merge pull request #11699 from satococoa/fix-render-status-symbols-document 
Fix status codes in document
 2013-08-01 04:38:37 -07:00
José Valim
872723f24e Merge pull request #11701 from morgoth/link-fix-in-guides 
Added missing closing bracket for markdown url in guides [ci skip]
 2013-08-01 03:35:07 -07:00
Wojciech Wnętrzak
ce757c4c7e Added missing closing bracket for markdown url in guides [ci skip] 2013-08-01 12:21:21 +02:00
Satoshi Ebisawa
c883fedc47 Fix status code in documents [ci skip] 
RFC 6585 Additional HTTP Status Codes
http://www.ietf.org/rfc/rfc6585.txt
 2013-08-01 17:17:45 +09:00
Eugene Gilburg
1e583f81d2 Minor optimization and code cleanup in query_methods. 
- Use symbols rather than strings where possible to avoid extra object construction
- Use destructive methods where possible to avoid extra object construction
- Use array union rather than concat followed by uniq
- Use shorthand block syntax where possible
- Use consistent multiline block styles, method names, method parenteses style, and spacing
 2013-07-31 22:20:19 -07:00
Carlos Antonio da Silva
5704e3c41d Merge pull request #11689 from arunagw/readme-updated-av 
Moved README into action_view [ci skip]
 2013-07-31 18:46:05 -07:00
Aaron Patterson
bd3059a633 oops! 💣 2013-07-31 18:19:55 -07:00
Aaron Patterson
f25251b573 do is_a? tests on assignment so runtime is faster 2013-07-31 18:19:36 -07:00
Aaron Patterson
afa510ed69 Revert "all scope_chain methods allocate new arrays, no need to dup" 
This reverts commit 1468a4b89aa4bca99160bfa03572b2c0ab348db5.
 2013-07-31 18:08:58 -07:00
Aaron Patterson
6da63410cb callback should always have a value 2013-07-31 18:08:56 -07:00
Aaron Patterson
946ac5eb43 no need to to_sym 2013-07-31 18:07:06 -07:00
Aaron Patterson
c856d895bd pass the mixin in to the code generation methods 2013-07-31 17:35:43 -07:00
Aaron Patterson
bc06ee374b we should not allow invalid objects to be constructed 2013-07-31 17:31:30 -07:00
Aaron Patterson
a9087ab25a push some validation up to the factory method 2013-07-31 17:28:08 -07:00
Andrew White
a6f568acc6 Merge pull request #11686 from gzohari/pr-refactor-time-datetime 
Refactor Date, Time, DateTime timezone methods
 2013-07-31 15:49:08 -07:00
Aaron Patterson
5e9f49aad9 use bind values for model types 2013-07-31 15:31:21 -07:00
Gilad Zohari
3102a9aa4c Refactor Date, Time, DateTime timezone methods 
Similar implementations of #in_time_zone exists for Date, Time and DateTime so
method is extracted into its own module. Also some logic is extracted into
private method.
 2013-08-01 00:27:25 +03:00
Justin George
16bf1ba476 remove language about configuring digest method [ci skip] 2013-07-31 14:17:39 -07:00
Arun Agrawal
622d2a4b0d Moved README into action_view [ci skip] 2013-07-31 15:44:17 -04:00
Andrew White
742d1f2eda Merge pull request #11681 from gzohari/pr-refactor-date-time 
Remove duplication from date_time calculations
 2013-07-31 06:23:46 -07:00
Rafael Mendonça França
4ae5d4d34e Merge pull request #11678 from vipulnsward/helper_destructive 
Change from `map` => `map!` and `collect!` to save creation of extra array
 2013-07-31 05:38:51 -07:00
Gilad Zohari
89060b8ef9 Remove duplication from date_time calculations 
Methods: :past? and :future? are already defined identically
in date_and_time/calculations.rb which is included in Date.
Because DateTime is a subclass of Date, it can call them.
 2013-07-31 13:57:25 +03:00
Vipul A M
4ce11c0150 Change from map => map! and collect! to save creation of extra array. 2013-07-31 10:07:04 +05:30
Rafael Mendonça França
ffb680e121 Merge pull request #11601 from TylerRick/dont_permanently_silence_all_warnings 
Remove $VERBOSE = nil from tasks.rb
 2013-07-30 19:00:04 -07:00
Rafael Mendonça França
47f6d37c26 Merge pull request #11606 from vipulnsward/refactor_array_parser 
Refactor `ArrayParser`
 2013-07-30 18:55:18 -07:00
Rafael Mendonça França
0cdac3e029 Merge pull request #11668 from neerajdotname/make_test_order_independent_2 
Make test order independent
 2013-07-30 18:29:10 -07:00
Aaron Patterson
1468a4b89a all scope_chain methods allocate new arrays, no need to dup 2013-07-30 16:21:40 -07:00
Rafael Mendonça França
fa41836190 Merge pull request #11673 from jetthoughts/11671_describe_access_to_helpers_from_controller 
Improve documentation for controller how to get included helpers
 2013-07-30 13:56:19 -07:00
Paul Nikitochkin
63ba124fa4 Improve documentation for controller how to get included helpers [ci skip] 
Closes #11671
 2013-07-30 22:52:48 +03:00
Justin George
72e53910a0 update guide to reflect default HMAC SHA1 in MessageVerifier used in SignedCookieStore [ci skip] 2013-07-30 12:38:44 -07:00
Rafael Mendonça França
e14039eacb Merge pull request #11672 from henrikhodne/patch-1 
Add retry to `gem install bundler` for Travis
 2013-07-30 11:29:47 -07:00
Henrik Hodne
7c4811fb34 Add retry to gem install bundler for Travis 
This adds the retry behaviour used for other commands to the bundler installation.
 2013-07-30 11:19:26 -07:00
Max Shytikov
af1e3b7c48 fix tests 2013-07-30 20:03:57 +03:00
Max Shytikov
e2180e84a9 Rails.logger should have level specified by config.log_level. 
Fix bug when log level of Rails.logger (which was set via config.logger) does not match the    config.log_level.
 2013-07-30 18:25:00 +03:00
Neeraj Singh
389e9fe9cf assert_no_queries should ignore certain sqls 
postgresql test if randomly executed then executes "SHOW max_identifier_length". Hence
the need to ignore certain predefined sqls that deal with system calls.
 2013-07-30 20:51:44 +05:30
Rafael Mendonça França
77cf5cfc74 Merge pull request #11664 from thedarkone/digestor-thread-safety 
AV::Digestor thread safety fixes
 2013-07-30 06:39:17 -07:00
thedarkone
650810fc6c AV::Digestor thread safety fixes. 
This fixes potential thread safety issues introduced in 09f6fe1. The problem
with the original code was that the "recursion-stopping" `nil` values could
be seen by other threads.
 2013-07-30 15:21:32 +02:00
Andrew White
2d53ee0f42 Don't mutate the original inflections instance in the tests 2013-07-30 12:01:56 +01:00
Andrew White
0423d9c6c5 Add CHANGELOG entry for inflection removal 2013-07-30 12:00:40 +01:00
Neeraj Singh
9c9a5a67bc assert_no_queries should allow to ignore some queries 2013-07-30 13:31:00 +05:30
Andrew White
c300dca996 Don't have a cow, man! 
Remove cow => kine from default inflections but leave the test case
in place to prevent regression of the [old Trac ticket 4929][1].

[1]: http://web.archive.org/web/20090314050915/http://dev.rubyonrails.org/ticket/4929
 2013-07-30 08:13:03 +01:00
Rafael Mendonça França
42f01e94e2 Merge branch 'revert-order-prepending' 
Conflicts:
	activerecord/CHANGELOG.md
 2013-07-30 00:05:47 -03:00