Commit Graph

1174 Commits

Author SHA1 Message Date
Michael Koziarski
e3898491f2 make error_messages_for return "" for nil objects
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-19 08:47:18 +00:00
Marcel Molina
363b79f942 Refactor human_size to exclude decimal place if it is zero.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-19 05:31:48 +00:00
Sam Stephenson
f0650c51cc Get the version right: 1.5.0_pre0, not rc0
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-18 23:19:47 +00:00
Sam Stephenson
75784f6bcc Update to Prototype 1.5.0_rc0
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-18 23:14:47 +00:00
David Heinemeier Hansson
e87c4f064f Dont repeat the button_to method
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-16 05:04:19 +00:00
Marcel Molina
4793a2f5cd Automatically discover layouts when a controller is namespaced. Closes #2199, #3424.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-15 11:28:55 +00:00
Michael Koziarski
f9e0ba2913 Correct the case of the CSS declarations. [Blair Zajac] Closes #3171
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 21:28:51 +00:00
Michael Koziarski
302533b196 Add support for multiple proxy servers in HTTP_X_FORWARDED_HOST. Closes #3397
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 08:31:16 +00:00
Michael Koziarski
12e0cb7971 Fix broken autocompleter test.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 07:26:21 +00:00
Michael Koziarski
8edbdfc9f4 Fix for failing auto complete unit test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 07:21:08 +00:00
Michael Koziarski
543f789240 Fix failing test due to hard coded year
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 07:08:55 +00:00
Marcel Molina
0a7af125ca Documentation typo fix. Closes #2367.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 04:43:33 +00:00
Marcel Molina
489ace60fb Remove Upload Progress. Closes #2871.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 04:27:53 +00:00
Marcel Molina
f4f7e750dc Add test for min_chars auto_complete_field fix. Closes #2929.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 04:00:11 +00:00
Marcel Molina
2b7f1cdbe9 Fix typo in function name mapping in auto_complete_field. Closes #3446.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 01:37:30 +00:00
Marcel Molina
751b6be464 Allow auto-discovery of third party template library layouts.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-12 07:16:23 +00:00
Marcel Molina
b30ccefe6f Have the form builder output radio button, not check box, when calling the radio button helper. Closes #3331.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-06 17:49:14 +00:00
David Heinemeier Hansson
10cf9ecafc Added assignment of the Autocompleter object created by JavaScriptMacroHelper#auto_complete_field to a local javascript variables [DHH] Added :on option for PrototypeHelper#observe_field that allows you to specify a different callback hook to have the observer trigger on [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-03 04:11:51 +00:00
David Heinemeier Hansson
987d9dbf31 Added JavaScriptHelper#button_to_function that works just like JavaScriptHelper#link_to_function but uses a button instead of a href [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-31 04:31:10 +00:00
David Heinemeier Hansson
d7487fffe5 Made Field.focus in prototype friendly to effects by adding optional delay parameter [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-31 04:14:07 +00:00
David Heinemeier Hansson
89d8afa2c4 Added that JavaScriptHelper#link_to_function will honor existing :onclick definitions when adding the function call [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3365 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-31 03:51:43 +00:00
David Heinemeier Hansson
341d34cd50 Added that JavaScriptHelper#link_to_function will honor existing :onclick definitions when adding the function call [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3364 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-31 03:50:08 +00:00
David Heinemeier Hansson
00541f263b Added :disable_with option to FormTagHelper#submit_tag to allow for easily disabled submit buttons with different text [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-30 19:41:25 +00:00
Scott Barron
63c822afb2 Make auto_link handle nil by returning quickly if blank?
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3359 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-30 18:45:04 +00:00
Marcel Molina
0b55ce7191 Value of full_messages on stubbed out AR instances should be an Array.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-26 19:40:14 +00:00
Marcel Molina
839f03b7d0 Make auto_link match urls with a port number specified.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-26 19:31:40 +00:00
Thomas Fuchs
eb53467bdf Added support for toggling visual effects to ScriptaculousHelper::visual_effect, #3323.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-25 18:53:22 +00:00
Thomas Fuchs
1455697ee8 Update to script.aculo.us to 1.5.0 rev. 3343
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-25 18:23:25 +00:00
David Heinemeier Hansson
cfb0babec3 Added :select option for JavaScriptMacroHelper#auto_complete_field that makes it easier to only use part of the auto-complete suggestion as the value for insertion [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-24 22:58:33 +00:00
David Heinemeier Hansson
ac963f0623 Added :select option for JavaScriptMacroHelper#auto_complete_field that makes it easier to only use part of the auto-complete suggestion as the value for insertion [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-24 01:04:08 +00:00
David Heinemeier Hansson
96536bebae Added :select option for JavaScriptMacroHelper#auto_complete_field that makes it easier to only use part of the auto-complete suggestion as the value for insertion [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-24 00:52:14 +00:00
Tobias Lütke
af60120d30 cosmetic change to assert_valid
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3341 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-23 19:47:10 +00:00
Tobias Lütke
373bc86d2d only log session_id if @session object responds to .session_id.
In functional test cases you often pass in a hash as session object which doesn't have this method. 


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-22 21:16:11 +00:00
David Heinemeier Hansson
4e76ae3904 Added delayed execution of Javascript from within RJS (closes #3264) [devslashnull@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3335 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-22 18:05:50 +00:00
David Heinemeier Hansson
778d6704d4 Add session ID to default logging, but remove the verbose description of every step [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-22 04:04:56 +00:00
David Heinemeier Hansson
43f6643b8b Fix form_for use of datetime_select and date_select as well as a few stylistic upgrades to AR
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3330 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-21 06:16:42 +00:00
David Heinemeier Hansson
71dcc6982e Added toggle to compliment show and hide for RJS
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-20 23:25:05 +00:00
Marcel Molina
233208b8bb Don't try to strip out the controller name if default_action_name is nil
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-20 05:32:39 +00:00
Sam Stephenson
c61d27d0c7 Add additional RJS functionality: alert, redirect_to, call, assign, and <<
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-20 00:20:33 +00:00
Nicholas Seckar
6b38b9739a Documentation fixes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-19 01:52:05 +00:00
Marcel Molina
39766a9b4c Don't include a layout when rendering an rjs template using render's :template option.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-17 06:38:06 +00:00
Thomas Fuchs
fc4ffbdc69 Update trunk to scriptaculous 1.5 final
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-13 18:41:58 +00:00
Jeremy Kemper
eecbd106a7 Don't used defined? on a scoped constant since it results in a const_missing call.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-13 18:05:31 +00:00
Sam Stephenson
a5a54ae9e3 Update to Prototype 1.4.0 final
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3297 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-13 17:51:17 +00:00
David Heinemeier Hansson
e5d9ad3e29 Added option inheritance for find calls on has_and_belongs_to_many and has_many assosociations [DHH] Added option to specify :group, :limit, :offset, and :select options from find on has_and_belongs_to_many and has_many assosociations [DHH]
Added form_remote_for (form_for meets form_remote_tag) [DHH]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-13 00:39:51 +00:00
Thomas Fuchs
f7e39c4ec7 Update to script.aculo.us 1.5.0_rc6
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3285 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-12 17:14:05 +00:00
David Heinemeier Hansson
6b7e51df51 Added form_remote_for [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-10 00:41:32 +00:00
David Heinemeier Hansson
32b27f997b Remove insignificant classes from docs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-08 05:43:54 +00:00
Jeremy Kemper
c140e80fc4 More robust relative url root discovery for SCGI compatibility. This solves the 'SCGI routes problem' -- you no longer need to prefix all your routes with the name of the SCGI mountpoint. References #3070.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-08 04:40:24 +00:00
David Heinemeier Hansson
c7bdd00b86 Fixed RDoc warnings [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-08 03:23:31 +00:00
Marcel Molina
96c29ab890 Fix docs for text_area_tag. Closes #3083.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3207 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-02 04:37:53 +00:00
Marcel Molina
c3612a23e6 Silence deprecation warnings for keep_flash when running tests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-02 00:39:25 +00:00
Marcel Molina
139e2c4aad Change form_for and fields_for method signatures to take object name and object as separate arguments rather than as a Hash.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-12-02 00:37:33 +00:00
Jeremy Kemper
d933627044 Introduce :selected option to the select helper. Allows you to specify a selection other than the current value of object.method. Specify :selected => nil to leave all options unselected. Closes #2991.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-23 21:59:20 +00:00
Jeremy Kemper
202e4208c4 Correct spelling of persistent [Stefan Kaes]. Document and eliminate warnings in clear_persistent_model_associations.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-23 00:35:37 +00:00
Thomas Fuchs
d958f22ecc Make javascript_include_tag :default behave correctly with application.js, fixes #2986
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-22 23:18:53 +00:00
Nicholas Seckar
bd5ace88b2 Initialize @optional in routing code to avoid warnings
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-22 22:24:25 +00:00
Sam Stephenson
bea737eb5a Make ActionController's render honor the :locals option when rendering a :file. Closes #1665.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-22 08:37:04 +00:00
Jeremy Kemper
130c493a4f FormHelper correctly passes its object through select, collection_select, country_select, and time_zone_select.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-22 01:32:40 +00:00
Jamis Buck
f783d50cf8 Allow assert_tag(:conditions) to match the empty string when a tag has no children. Closes #2959. [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 21:02:10 +00:00
Jamis Buck
f9b199040c Update html-scanner to handle CDATA sections better. Closes #2970. [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 20:43:35 +00:00
Jeremy Kemper
6580662254 Don't put flash in session if sessions are disabled.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 18:09:28 +00:00
David Heinemeier Hansson
d345b7a4f0 Back out of 3109 for now as it seems to interfere with the flash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 16:59:25 +00:00
Sam Stephenson
ede2a222ee Strip out trailing &_= for raw post bodies #2868
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 08:04:28 +00:00
Jeremy Kemper
e9b26c52a2 Fix grammar error in [3115]. References #2966.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 02:14:31 +00:00
Sam Stephenson
f212c88315 Pass multiple arguments to Element.show and Element.hide in JavaScriptGenerator instead of using iterators
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 01:54:36 +00:00
Jeremy Kemper
a0293c80f0 Improve expire_fragment documentation. Closes #2966.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 01:08:30 +00:00
Marcel Molina
55a3979a09 Correct docs for automatic layout assignment. Closes #2610.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-20 18:50:09 +00:00
Jeremy Kemper
da9f713d2c r3209@asus: jeremy | 2005-11-20 01:04:22 -0800
If sessions are disabled, return a hash that raises an error when it's accessed.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-20 09:06:43 +00:00
Jeremy Kemper
63b792162b Make data writer private. Marshal/unmarshal handle nil.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-20 08:15:51 +00:00
Jeremy Kemper
c7bc10b2e4 Log ActiveRecordStore debugging.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-20 08:07:33 +00:00
Jeremy Kemper
991189b58d Document request.env and request.host. Strip trailing whitespace.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-20 05:31:33 +00:00
Jeremy Kemper
cd8686b456 r3173@asus: jeremy | 2005-11-18 23:34:41 -0800
Ticket 2731 - sessions
 r3185@asus:  jeremy | 2005-11-19 18:02:51 -0800
 eliminate const redefinition warning
 r3186@asus:  jeremy | 2005-11-19 19:25:50 -0800
 Use :database option instead of :dbfile
 r3187@asus:  jeremy | 2005-11-19 19:34:31 -0800
 Data writer assigns to instance var.  Since nothing is calling write_attribute on the data column except for marshal_data, simplify data reader to lazy-unmarshal the data column (no worrying whether it's already unmarshaled)
 r3188@asus:  jeremy | 2005-11-19 19:35:40 -0800
 Explicitly create the session class so that subsequent requests for the session can find it in the database.  This is masking a problem with the controller losing its @session instance var and therefore requesting a new session.
 r3189@asus:  jeremy | 2005-11-19 19:36:40 -0800
 Using create unnecessarily  broadens the existing duck-typing so use new + save instead.
 r3194@asus:  jeremy | 2005-11-19 20:28:17 -0800
 Test creation of another instance while first instance is still active.  Should return same session_id.
 r3195@asus:  jeremy | 2005-11-19 20:39:45 -0800
 Always create new AR sessions rather than trying too hard to avoid database traffic.  References #2731.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-20 04:41:59 +00:00
Sam Stephenson
d777e506f2 Update to Prototype 1.4.0_rc4. Closes #2943 (old Array.prototype.reverse behavior can be obtained by passing false as an argument)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-19 06:59:07 +00:00
Sam Stephenson
b3c65bc849 Use Element.update('id', 'html') instead of uid=501(sam) gid=501(sam) groups=501(sam), 81(appserveradm), 79(appserverusr), 80(admin).innerHTML = 'html' in JavaScriptGenerator#replace_html so that script tags are evaluated
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-18 18:03:45 +00:00
Marcel Molina
62fe5bbfb1 Make rjs templates always implicitly skip out on layouts.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-18 08:32:17 +00:00
Jeremy Kemper
fb3fc46cdd Correct length for the truncate text helper. Closes #2913.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-18 01:25:39 +00:00
Sam Stephenson
173544f56c Update to Prototype 1.4.0_rc3. Closes #1893, #2505, #2550, #2748, #2783.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-18 00:53:11 +00:00
Marcel Molina
06e74b6c91 Add support for new rjs templates which wrap an update_page block.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-17 21:28:59 +00:00
Jeremy Kemper
e9a4e4d88b Inline a method used by render_partial. Closes #2881.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-17 19:08:53 +00:00
Marcel Molina
5cb2aa722d Rename Version constant to VERSION. Closes #2802.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-17 00:32:16 +00:00
Jeremy Kemper
98898ed798 Correct time_zone_options_for_select docs. Closes #2892.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 21:57:30 +00:00
Jeremy Kemper
9de738aadc Remove the unused, slow response_dump and session_dump variables from error pages. References #1222.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 21:34:24 +00:00
Jeremy Kemper
8da9d02e6e Include QUOTED_TYPE constant in ActionPack AR assertions tests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 09:09:04 +00:00
Jeremy Kemper
ba942dfc45 fewer objects, no loop in convert_content_type. Closes #2883.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 09:05:04 +00:00
Jeremy Kemper
c63f3bdc7a Inline commonly-called template presence checks. Closes #2882.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 09:03:00 +00:00
Jeremy Kemper
ede505592c Avoid logging code if logger is nil. Closes #2881.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 09:00:23 +00:00
Jeremy Kemper
eb1dd6a206 Use Set instead of Array to speed up prototype helper include? calls. Closes #2880.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 08:53:26 +00:00
Jeremy Kemper
745ea39926 MemCache store may be given multiple addresses. Closes #2869.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-16 08:35:31 +00:00
Jeremy Kemper
05d580dffa Remove invalid links in ActionView::Helpers::UrlHelper documentation. Closes #1961.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3041 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-15 09:42:32 +00:00
Jeremy Kemper
08fd13d17c Handle cookie parsing irregularity for certain Nokia phones. Closes #2530.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-15 07:51:09 +00:00
Sam Stephenson
d99ed9bd6a Refactored JavaScriptHelper into PrototypeHelper and ScriptaculousHelper. Added PrototypeHelper::JavaScriptGenerator and PrototypeHelper#update_page for easily modifying multiple elements in an Ajax response.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-14 22:28:47 +00:00
Thomas Fuchs
415d27490f Update trunk to latests script.aculo.us
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-14 20:49:10 +00:00
Tobias Lütke
037f61c8e9 * Updated docs for in_place_editor, fixes a couple bugs and offers extended support for external controls [Justin Palmer] closes #2870
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-14 20:46:32 +00:00
Jeremy Kemper
5cd2f32697 Update documentation for render :file. References #2858.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-14 00:12:46 +00:00
Jeremy Kemper
da2d4d6d57 Note that the ruby-memcache bindings are required to use the memcache store.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-14 00:08:24 +00:00
Jeremy Kemper
44ca6f4b62 Only include builtin filters whose filenames match /^[a-z][a-z_]*_helper.rb$/ to avoid including operating system metadata such as ._foo_helper.rb. References #2855.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-13 22:21:19 +00:00
David Heinemeier Hansson
b0c23e589f hidden_field can also be in fields_for
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-13 12:54:00 +00:00
David Heinemeier Hansson
c6435b77de Make form_for work with additional options
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-13 12:53:03 +00:00
David Heinemeier Hansson
0306127bb5 Show with local vars
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-13 11:14:12 +00:00
David Heinemeier Hansson
947cec29d5 Added FormHelper#form_for and FormHelper#fields_for that makes it easier to work with forms for single objects also if they don't reside in instance variables [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-13 11:13:11 +00:00
Jeremy Kemper
b81c46e6bd options_for_select allows any objects which respond_to? :first and :last rather than restricting to Array and Range. Closes #2824. References [2126].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-10 22:08:20 +00:00
Scott Barron
339fff7950 This does not need to be thread local (thanks skaes).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-10 12:59:22 +00:00
Jeremy Kemper
adba181060 The auto_link text helper accepts an optional block to format the link text for each url and email address. References #2628.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-10 06:04:50 +00:00
Jeremy Kemper
3661eacfbd Include all of session creation in stale_session_check
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-09 20:34:44 +00:00
Jamis Buck
b7ce9c5a87 assert_tag uses exact matches for string conditions, instead of partial matches. Use regex to do partial matches. #2799
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-09 13:42:05 +00:00
Jeremy Kemper
bb4c32e2b5 Delete existing sessions with the same session id before creating a new session. Prevents duplication and hijacking.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-09 06:00:46 +00:00
Jeremy Kemper
0abaf3a2d8 CGI::Session::ActiveRecordStore.data_column_name = 'foobar' to use a different session data column than the 'data' default. References #2731. Remove error-prone method_missing passthrough to session model. Cleanup.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-09 01:03:24 +00:00
Jeremy Kemper
85baf07be8 Controllers with acronyms in their names (e.g. PDFController) require the correct default helper (PDFHelper in file pdf_helper.rb). Closes #2262. Do not raise an exception when default helper is missing; log a debug message instead. It's nice to delete empty helpers.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-08 08:23:13 +00:00
David Heinemeier Hansson
cd2b9a9498 Made ready for 0.14.3 (RC4)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-07 19:40:27 +00:00
David Heinemeier Hansson
3c31062c3d Added request as instance method to views, so you can do <%= request.env["HTTP_REFERER"] %>, just like you can already access response, session, and the likes [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-07 13:51:56 +00:00
David Heinemeier Hansson
6ab9f2bb40 Fix READMEs (closes #2680) [coffee2code]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-07 09:51:47 +00:00
David Heinemeier Hansson
01cfd2b00a Fix docs (closes #2725)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-07 09:36:43 +00:00
David Heinemeier Hansson
8dda7c5449 Fix conflict with assert_tag and Glue gem (closes #2255) [david.felstead@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-07 09:31:49 +00:00
Jamis Buck
0073a759f1 Add documentation to assert_tag indicating that it only works with well-formed XHTML
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-06 13:59:07 +00:00
Sam Stephenson
8a8b472fc2 Update changelog
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-05 03:04:41 +00:00
Sam Stephenson
313468a732 Added action_pack.rb stub so that ActionPack::Version loads properly
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-05 03:03:31 +00:00
Jeremy Kemper
ad4e611488 Update paginator docs. Closes #2744.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-05 02:10:29 +00:00
David Heinemeier Hansson
9d17e7cce4 Fix assert_no_tag
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-04 21:37:34 +00:00
David Heinemeier Hansson
a6106e4ec6 Added skip_before_filter/skip_after_filter for easier control of the filter chain in inheritance hierachies [DHH] Added short-hand to assert_tag so assert_tag :tag => "span" can be written as assert_tag "span" [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-04 19:42:22 +00:00
David Heinemeier Hansson
4f754985d0 Added redirect_to :back as a short-hand for redirect_to(request.env["HTTP_REFERER"])
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-02 14:47:03 +00:00
Jeremy Kemper
ddf6910941 ensure close_session in AC::Base#process
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-02 01:23:34 +00:00
Thomas Fuchs
d47f3bcbad Change javascript_include_tag :defaults to not use script.aculo.us loader, which facilitates the use of plugins for future script.aculo.us and third party javascript extensions, and provide register_javascript_include_default for plugins to specify additional JavaScript files to load. Removed scriptaculous.js, slider.js and builder.js
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-01 06:34:40 +00:00
Scott Barron
025949102e Fix problem where redirecting components can cause an
infinite loop [Rick Olson]

Closes #2654


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-30 13:13:02 +00:00
Jeremy Kemper
54a4e50662 Removed erroneous arg-size check in AC::Base.fragment_cache_store=. Closes #2650.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-29 23:12:13 +00:00
Thomas Fuchs
56ae4ab547 Added support for the queue option on visual_effect
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-29 15:01:39 +00:00
Thomas Fuchs
d8f0a3f93c Update script.aculo.us to V1.5_rc4
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-29 11:48:53 +00:00
David Heinemeier Hansson
cb0e27cee9 Fix that render :text didn't interpolate instance variables (Closes #2629, #2626) [skaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-28 07:33:54 +00:00
Nicholas Seckar
f2c920ec24 Fix line number detection and escape RAILS_ROOT in backtrace Regexp
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-27 21:58:39 +00:00
David Heinemeier Hansson
706a8a8f96 rake should run functional tests even if the unit tests have failures [Jim Weirich]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-27 18:44:28 +00:00
Nicholas Seckar
a7aa26906c Recognize ./#{RAILS_ROOT} as RAILS_ROOT in error traces
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-27 17:09:00 +00:00
Nicholas Seckar
435f0c254e Add name to changelogs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-27 16:57:25 +00:00
Sam Stephenson
f15819e8f0 Bump to Prototype 1.4.0_rc2
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 22:07:27 +00:00
Nicholas Seckar
d6461bf9f5 Remove fingerprinting from AR session store; fix bug in store. Closes #2612
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2754 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 20:15:43 +00:00
David Heinemeier Hansson
17816a11ee Proper CSS color definition (closes #2334)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 13:26:51 +00:00
David Heinemeier Hansson
4e9bc0f02d Added TextHelper#strip_tags for removing HTML tags from a string (using HTMLTokenizer) (closes #2229) [marcin@junkheap.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 13:26:04 +00:00
David Heinemeier Hansson
82f1e19e4c Fixed docs (closes #2468)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 13:20:46 +00:00
David Heinemeier Hansson
07c494ae24 Added a reader for flash.now, so it's possible to do stuff like flash.now[:alert] ||= 'New if not set' (closes #2422) [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-26 13:14:10 +00:00
David Heinemeier Hansson
c7a6b9862d Prepared for release of 0.14.2 (RC3)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2737 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-25 22:11:48 +00:00
Nicholas Seckar
86a571090c Reset template variables after using render_to_string. Closes #2559
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-25 02:15:08 +00:00
Scott Barron
3a2943c54d Take a different approach to keeping flash around when using components.
One that, you know, doesn't involve consuming every byte of free memory
on the system.

Closes #2589.

References #2291.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-25 00:38:51 +00:00
Jeremy Kemper
b57c86ae74 r3689@sedna: jeremy | 2005-10-16 10:24:36 -0700
Ticket 2404 - delete fixtures after using them
 r3744@sedna:  jeremy | 2005-10-23 12:28:28 -0700
 track dirty and loaded fixtures more carefully
 r3745@sedna:  jeremy | 2005-10-23 12:29:39 -0700
 fix broken tests
 r3756@sedna:  jeremy | 2005-10-23 15:51:00 -0700
 Global Logger.silencer switch for Logger#silence.
 r3757@sedna:  jeremy | 2005-10-23 15:51:35 -0700
 Correct changelogs


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-23 20:00:05 +00:00
Jeremy Kemper
22d9bad8a0 Expose the session model backing CGI::Session
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-20 21:59:48 +00:00
Jamis Buck
4da2d6c1ed Abbreviate RAILS_ROOT in traces
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-19 15:56:21 +00:00
David Heinemeier Hansson
2555b885ed Really ready for release
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-19 14:28:55 +00:00
David Heinemeier Hansson
83dc37b910 Made ready to push RC2
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-19 06:24:12 +00:00
Nicholas Seckar
7d8ecad127 Update error trace templates
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-18 14:08:05 +00:00
Sam Stephenson
d82c51bb16 Upgrade to Prototype 1.4.0_rc1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2672 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-18 02:48:33 +00:00
Jamis Buck
e515ba9ecd Fix the html-scanner to count children correctly, playing nicely with :only, fixes #2181 [patrick@lenz.sh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-18 00:50:52 +00:00
David Heinemeier Hansson
11cb22f0e6 Updated the gem specs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-17 21:55:13 +00:00