TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
45,442 Commits 2 Branches 0 Tags 294 MiB
0950d409b0
Commit Graph

1477 Commits

Author SHA1 Message Date
Robin Dupret
b894b7b90a Fix few typos in the documentation [ci skip] 2013-12-21 18:59:55 +01:00
Vijay Dev
a3b1105ada Merge branch 'master' of github.com:lifo/docrails 2013-12-20 00:10:30 +05:30
Akira Matsuda
a3ebe7f3a7 Unused classes in AMo tests 2013-12-19 18:31:11 +09:00
David Heinemeier Hansson
c0a2d474c5 Get ready to release 4.1.0.beta1 2013-12-17 16:05:28 -08:00
Tejas Dinkar
da2b05bb6b Allows you to check if an attribute has changed to a particular value 
model.name_changed?(from: "Pete", to: "Ringo")
 2013-12-15 12:13:31 +05:30
Rafael Mendonça França
12affbe491 Fix typo [ci skip] 2013-12-13 18:33:30 -02:00
Rafael Mendonça França
b34352e425 Merge pull request #13255 from strzalek/bump-builder 
Bump up builder
 2013-12-12 12:22:21 -08:00
Godfrey Chan
f650981483 Added :nodoc: for attribute_changed? and attribute_was [ci skip] 
These methods were made "public" in 47617ecd so that `method_missing`
can invoke them without going through `send`, but they aren't meant
for consumption from outside of Rails.
 2013-12-12 12:04:07 -08:00
Łukasz Strzałkowski
9f506c494b More liberal builder dependency 
Allowing us to get 3.2.x versions if needed.
 2013-12-12 20:03:02 +01:00
Akshay Vishnoi
5fccd77b6c Spelling and Grammar checks 2013-12-12 18:28:34 +05:30
Yves Senn
6f3c3ba784 Merge pull request #13287 from aayushkhandelwal11/typo_rectified 
typos rectified lifecycle => life cycle
 2013-12-11 23:32:04 -08:00
Aayush khandelwal
10fffd7ae6 typos rectified lifecycle => life cycle 2013-12-12 12:55:35 +05:30
Rafael Mendonça França
5853c64a4b Revert "Merge pull request #13276 from aayushkhandelwal11/change_to_key" 
This will call primary_key two times

This reverts commit d0588a2e897d33c6c12e9fc5f8680328d37a26ca, reversing
changes made to 87e1e86640fb8b5a260ff7c0044aaae58fff2bc4.
 2013-12-11 13:43:28 -02:00
Rafael Mendonça França
d0588a2e89 Merge pull request #13276 from aayushkhandelwal11/change_to_key 
removing multiple check conditions to single check condition
 2013-12-11 06:22:42 -08:00
Aayush khandelwal
1889dcbc9f removing multiple check conditions to single check condition 2013-12-11 19:36:25 +05:30
Guillermo Iguaran
87e1e86640 Merge pull request #13273 from robertomiranda/test-remove-require 
Remove require 'models/administrator', Administrator is not used in secure password test
 2013-12-11 05:39:14 -08:00
robertomiranda
df7e5b69de Remove require 'models/administrator', Administrator is not used in secure password test 2013-12-11 08:34:28 -05:00
aditya-kapoor
0c55335074 Merge branch 'master' of github.com:lifo/docrails 2013-12-10 11:44:07 +05:30
Carlos Antonio da Silva
05a685eeb7 Merge pull request #13145 from acapilleri/fix_email_example 
fix email regex example code [ci skip]
 2013-12-03 07:47:25 -08:00
Angelo capilleri
f590cdb656 fix email regex example code [ci skip] 
different from the regex in EmailValidator
 2013-12-03 16:44:39 +01:00
Lauro Caetano
b1b9a0aeca Typos. return -> returns. [ci skip] 2013-12-03 13:31:36 -02:00
Genadi Samokovarov
6329d9fa8b Remove deprecated cattr_* requires 2013-12-03 00:28:15 +02:00
Akshay Vishnoi
ef0f633c66 Typo and grammatical fixes [ci skip] 2013-12-02 19:35:02 +05:30
Yves Senn
7c6d99e81e first pass through CHANGELOGS to extract 4_1_release_notes. [ci skip] 
Extract **notable changes**, **deprecations** and **removals** from
each CHANGELOG.

I tried to reference the commits and pull requests for new features
and deprecations.

In the process I also made some minor changes to the CHANGELOGS.

The 4_1_release_notes guide is declared WIP.
 2013-11-28 17:24:15 +01:00
Xavier Noria
17c29a0df0 Merge remote-tracking branch 'docrails/master' 
Conflicts:
	activesupport/lib/active_support/core_ext/hash/deep_merge.rb
	activesupport/lib/active_support/core_ext/hash/keys.rb
 2013-11-24 20:00:24 +01:00
Carlos Antonio da Silva
aa7fdfb859 Remove short circuit return in favor of simple conditional 2013-11-15 01:11:57 -02:00
Carlos Antonio da Silva
374d465f28 Invert conditional to avoid double checking for Regexp 2013-11-15 01:04:57 -02:00
Carlos Antonio da Silva
9014a79436 Only check that the option exists once instead of doing on each conditional 2013-11-15 01:01:59 -02:00
Carlos Antonio da Silva
61fef76106 Remove argument that is accessible as attribute 2013-11-15 01:00:53 -02:00
Carlos Antonio da Silva
b8c6c08452 Cache regexp source on format validation to avoid allocating new objects 
Example:

    >> r = /some-regexp/
    => /some-regexp/
    >> r.source.object_id == r.source.object_id
    => false
 2013-11-15 00:38:55 -02:00
Carlos Antonio da Silva
70161ae3b8 Make code simpler to read by using a case statement 2013-11-15 00:24:54 -02:00
Carlos Antonio da Silva
12815e0d44 Avoid a new hash allocation 2013-11-15 00:24:54 -02:00
Carlos Antonio da Silva
4c7e3a3087 Use a simple conditional rather than short circuit with next 2013-11-15 00:19:03 -02:00
Carlos Antonio da Silva
d2992818e0 Simplify number parsing logic in numericality validation 2013-11-15 00:07:22 -02:00
Carlos Antonio da Silva
f70e30ec6d Avoid creation of extra hash with merge just to set a value 2013-11-15 00:07:22 -02:00
Prem Sichanugrist
efff6c1fd4 Change syntax format for example returned values 
According to our guideline, we leave 1 space between `#` and `=>`, so we
want `# =>` instead of `#=>`.

Thanks to @fxn for the suggestion.

[ci skip]
 2013-11-11 13:53:54 -05:00
Carlos Antonio da Silva
deaf285824 Merge pull request #12686 from kryzhovnik/master 
Minor doc fix of ActiveModel::Naming. [ci skip]

Conflicts:
	activemodel/lib/active_model/naming.rb
 2013-11-02 14:46:56 -02:00
Andrey Samsonov
fb6f02c521 Minor doc fix of ActiveModel::Naming. 
- qoute example line's result when it kind of String
- right ("singular_route_key") method in example
 2013-10-29 15:23:03 +04:00
Guillermo Iguaran
c31b900221 Merge pull request #12635 from mperham/4-0-stable 
Allow any version of BCrypt
 2013-10-24 19:31:13 -02:00
Akira Matsuda
68db6bc431 Let validates_inclusion_of accept Time and DateTime ranges 
fixes 4.0.0 regression introduced in 0317b93c17a46d7663a8c36edc26ad0ba3d75f85
 2013-10-23 22:10:15 +09:00
T.J. Schuck
5d7b413d84 Use bcrypt's public cost attr, not internal constant 
See:

- https://github.com/codahale/bcrypt-ruby/pull/63
- https://github.com/codahale/bcrypt-ruby/pull/64
- https://github.com/codahale/bcrypt-ruby/pull/65
 2013-10-10 11:46:59 -04:00
Arun Agrawal
31488dba85 observers are not part of ActiveModel [ci skip] 2013-10-09 14:25:16 +02:00
Vijay Ubuntu
27576df810 adding load_path to include active_model in the load path of example 
similar to activerecord/examples/simple.rb
 2013-10-09 01:52:55 +05:30
Rafael Mendonça França
c48c111bb2 Merge pull request #8791 from griffinmyers/master 
Updated DirtyModel's @changed_attributes hash to be symbol/string agnostic

Conflicts:
	activemodel/CHANGELOG.md
 2013-10-03 11:37:10 -03:00
T.J. Schuck
4a99e10199 bcrypt-ruby v3.1.2 supports Ruby 2.0 on Windows 2013-09-23 14:28:26 -04:00
Rafael Mendonça França
ed0b080cb3 Fix the documentation method. 
It is reload! in the class definition.

[ci skip]
 2013-09-23 11:25:43 -03:00
Rafael Mendonça França
7ef29140eb No need to abbreviate ActiveModel 
[ci skip]
 2013-09-23 11:01:43 -03:00
Rafael Mendonça França
089e1b6426 Document reset_changes since it is part of public API 
[ci skip]
 2013-09-23 11:00:56 -03:00
Rafael Mendonça França
9aa1a3d853 Merge pull request #10816 from bogdan/less-dirty-dirty 
Make AM::Dirty less dirty to plugin into AR or other library
 2013-09-23 10:59:05 -03:00
Rajarshi Das
782d794c20 use assert_empty in activemodel conditional validation test cases 2013-09-10 17:26:39 +05:30
Rajarshi Das
e21a18bed0 fix actionview and activemodel test cases typos 2013-09-05 14:21:57 +05:30
aditya-kapoor
6b9b0767bf Merge branch 'master' of github.com:lifo/docrails 2013-09-01 18:05:04 +05:30
Gaurish Sharma
65f1766a08 Add :nodoc: to ActiveModel::SecurePassword.min_cost 
[ci skip]
 2013-08-29 01:27:18 +05:30
Rajarshi Das
9f478deaab remove unused instance variable 2013-08-23 16:04:08 +05:30
aditya-kapoor
b27c40637a fixed a typo 2013-08-20 14:21:36 +05:30
Guillermo Iguaran
99e33c03b7 Dont' check for any order in hash since we aren't sorting it and this is determinated only by the used interpreter 2013-08-18 16:40:21 -05:00
Guillermo Iguaran
c40111c346 Refactor serialization test for hash order 2013-08-18 09:04:09 -05:00
Gaurish Sharma
90c450f6cd Avoid Skip in test, have a unified test for order 2013-08-09 15:27:21 +05:30
Gaurish Sharma
9f8116fb77 Add tests for ActiveModel::Serializers::JSON#as_json ordering 2013-08-09 04:32:00 +05:30
Ryoji Yoshioka
23ef1dfd70 Fix: documentation for ActiveModel::Errors 2013-08-05 18:58:22 +09:00
Max Shytikov
af1e3b7c48 fix tests 2013-07-30 20:03:57 +03:00
Arun Agrawal
f52832de2a grab executable from rubygems 
As done here d7fc97d3f90c0e30865d32ce202658f03248cacc
 2013-07-26 11:07:25 +02:00
Vladimir Kiselev
3be0cdfa55 Fix secure_password password_confirmation validations 2013-07-24 03:14:15 +04:00
Burkhard Vogel-Kreykenbohm
ad62cf68f8 bcrypt-ruby stable is 3.1 2013-07-17 16:39:07 +02:00
John Gesimondo
0e945f8909 it's xml, not json 
change docs for xml serializer to talk about xml
 2013-07-13 16:25:04 -07:00
Ankit Gupta-FIR
6a71d09ad2 Replaced older rocket sign to new : 2013-07-04 17:25:50 +01:00
Aaron Patterson
09b31f08d4 eagerly initialize the attributes module to avoid check-then-set race conditions 2013-07-02 14:34:40 -07:00
Aaron Patterson
4c88f4ce16 remove wrong documentation from a :nodoc:'d method 2013-07-02 14:04:40 -07:00
Aaron Patterson
d094aaad19 the data structure used to store attribute aliases should not be exposed 2013-07-01 16:23:08 -07:00
Vipul A M
404a61e19c Remove redundant escapes from xml serialization test 2013-07-01 10:17:33 +05:30
Steven Yang
6e583cdac3 fix typo in ActiveModel::Error docs [ci skip] 2013-06-30 18:38:29 -03:00
Steven Yang
5fe43ffcfb remove evals from AM::Validations::Callbacks 
follow the same refactor at a63a964a5d1ed02cf0df1b1a33a96ed2a9fa987b
 2013-06-30 18:47:55 +08:00
Steven Yang
e8fe6660d2 provide a more sementicthe local variables name for ActiveModel::Validations::Clusivity#include? method 
the original name `exclusion` is a bit confusing when using with the method `inclusion_method`
rename it to a more logic neutral name.
 2013-06-29 18:36:40 +08:00
Paul Nikitochkin
e63ba910ae Remove deprecation warning from AttributeMethodsMatcher 2013-06-28 00:16:42 +03:00
Łukasz Strzałkowski
468939297d Remove deprecated attr_protected/accessible 
Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters.
 2013-06-27 20:38:30 +02:00
Carlos Antonio da Silva
48ab2c06e0 Merge pull request #11054 from senny/11048_make_default_value_explicit 
make default value for `:message` on `AM::Errors` explicit.
 2013-06-27 05:16:38 -07:00
Carlos Antonio da Silva
61346d1b42 Merge pull request #10774 from chuckbergeron/validates-inclusion-of-accuracy-for-non-numeric-ranges 
Greater accuracy for validates_inclusion_of on non-numeric ranges

Closes #10774, fixes #10593
 2013-06-25 21:48:41 -03:00
Akshay Khole
444d3412b9 Fixing Issue #11083 
Removing other occurrences of `the` appearing twice
 2013-06-25 16:47:29 +05:30
Rajarshi Das
cbd4a2e317 replace all older rocket sign to new ":" from examples of active record and active models 2013-06-24 11:19:51 +05:30
José Valim
e1f4f64434 Revert "Merge pull request #11053 from yangchenyun/mine" 
Those two files are required by active_support/rails.rb
loaded in active_model.rb

It is common to require common dependencies on the root
files to avoid boilerplate in each file.

This reverts commit 763635e30f17800ebc0a8ae98d780edc8ebfb4e5, reversing
changes made to 4f46ef36aaef217834f3f96d3689d32f6a6761ea.
 2013-06-22 18:36:26 +02:00
Yves Senn
ca99ab2481 make default value for :message on AM::Errors explicit. 2013-06-22 13:48:42 +02:00
Yves Senn
763635e30f Merge pull request #11053 from yangchenyun/mine 
Add explicit dependencies of ActiveSupport to enable independent usage of ActiveModel::Name
 2013-06-22 03:32:15 -07:00
Steven Yang
c20b5ca037 add explicit AS dependencies for ActiveModel::Naming 
There are two missing ActiveSupport dependencies to use ActiveModel::Name class or ActiveModel::Naming module independently.

Missing dependencies for Module#delegate defined in `active_support/core_ext/module/delegation`, used at [L148](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L148)

Missing dependencies for Object#blank? defined in `active_support/core_ext/object/blank`, used at [L131](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L131)
 2013-06-22 18:24:29 +08:00
Arun Agrawal
67f668845e Saying gemcutter => rubygems [ci skip] 2013-06-21 11:04:52 +02:00
Fred Wu
85750d43fa ActiveModel::Model inclusion chain backward compatibility 2013-06-20 12:16:17 +10:00
Fred Wu
0b502cb879 Fixes AciveModel::Model with no ancestors, fixes #11004 
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
 2013-06-19 17:16:04 +02:00
Fred Wu
e3dc10f133 Fixed ActiveModel::Model's inclusion chain 2013-06-19 11:25:10 +10:00
Aaron Patterson
47617ecdf7 expose a few attribute changed methods 2013-06-11 13:39:46 -07:00
Aaron Patterson
a63a964a5d remove some evals from callback conditionals 2013-06-11 10:20:29 -07:00
Daichi Arai
d61241b060 fix ActiveModel::Validations.validators_on doc 2013-06-10 18:34:34 +09:00
Carlos Antonio da Silva
94725b81f5 Merge pull request #10860 from ka8725/activemodel_log 
Ignore activemodel/log/ folder
 2013-06-07 05:27:29 -07:00
Richard Livsey
9906eb1355 Docfix: Use public interface instead of setting instance variables 
Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor.
 2013-06-07 12:41:05 +02:00
Andrey Koleshko
120f6e07f6 Stub logger for tests 2013-06-06 19:47:57 +03:00
Arun Agrawal
a84a08ecea No need to load 'rake/packagetask' as it's already 
in 'rubygems/package_task'
 2013-06-02 20:41:21 +02:00
Phil Calvin
5d93ef8f45 Fix regression in has_secure_password. 
If the confirmation was blank, but the password wasn't, it would still save.
 2013-05-30 11:18:43 -07:00
Charles Bergeron
0317b93c17 Use Range#cover? for Numeric ranges (tests via endpoints) and use Range#include? for non-numeric ranges 
added changelog message
 2013-05-27 23:54:25 -07:00
William Myers
0e655873d4 DirtyModel uses a hash to keep track of any changes made to attributes 
of an instance. When using the attribute_will_change! method, you must
supply a string and not a symbol or the *_changed? method will break
(because it is looking for the attribute name as a string in the keys
of the underlying hash). To remedy this, I simply made the underlying
hash a HashWithIndifferentAccess so it won't matter if you supply
the attribute name as a symbol or string to attribute_will_change!.
 2013-05-27 23:41:26 -04:00
Nick Sutterer
7d84c3a2f7 deprecate Validator#setup (to get rid of a respond_to call). validators do their setup in their constructor now. 2013-05-23 10:00:44 -03:00
Aaron Patterson
9fef7c8dc9 Merge pull request #10527 from zenspider/squishy_minitest5 
Squishy minitest5
 2013-05-16 13:41:54 -07:00
Aaron Patterson
ba55276434 deprecating string based terminators 2013-05-14 16:03:09 -07:00
Aaron Patterson
d53b5f0739 Merge branch 'master' into normalizecb 
* master: (61 commits)
  add tests for reset_calbacks
  Fixing build broken by this change
  Extract variable out of loop
  Updated comment to Rails 4
  Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext
  better error message when app name is not passed in `rails new`
  Code cleanup for ActionDispatch::Flash#call
  Fix typo: require -> requires
  Add CHANGELOG entry for #10576
  Merge pull request #10556 from Empact/deprecate-schema-statements-distinct
  Some editorial changes on the documentation.
  respond_to -> respond to in a message from AM::Lint
  specify that dom_(id|class) are deprecated in controllers, views are fine
  copy edits [ci skip]
  Fix class and method name typos
  Replace multi_json with json
  ruby -> Ruby
  Adding documentation to the automatic inverse_of finder.
  Improve CHANGELOG entry [ci kip]
  Call assume_migrated_upto_version on connection
  ...

Conflicts:
	activesupport/lib/active_support/callbacks.rb
 2013-05-13 11:51:10 -07:00
Xavier Noria
19c6c8f5d7 respond_to -> respond to in a message from AM::Lint 
The error message uses English to say that the object should respond
to a certain method. You check that with respond_to, but that's not
English.

This makes this error message also consistent with the rest.
 2013-05-12 13:59:51 +02:00
Aaron Patterson
23122ab2d4 callbacks are wrapped with lambdas 2013-05-10 10:13:21 -07:00
wangjohn
eb93d16e49 Using define method instead of class eval when defining model callbacks. 
Based on my benchmark results, this change improves performance
substantially when defining callbacks.

This benchmark (https://gist.github.com/wangjohn/5542610) was run using
the current master and also using my experimental branch which replaced
class_eval with define_single_method.

Using class_eval (current master):

                    user     system      total        real
10 trials       0.000000   0.000000   0.000000 (  0.001568)
50 trials       0.020000   0.000000   0.020000 (  0.021715)
500 trials      0.110000   0.000000   0.110000 (  0.115357)
1000 trials     0.250000   0.000000   0.250000 (  0.260025)
10000 trials    2.560000   0.000000   2.560000 (  2.568408)
50000 trials   12.800000   0.010000  12.810000 ( 12.886871)

Using define_single_method (experimental branch):

                    user     system      total        real
10 trials       0.000000   0.000000   0.000000 (  0.000790)
50 trials       0.000000   0.000000   0.000000 (  0.002960)
500 trials      0.050000   0.010000   0.060000 (  0.055690)
1000 trials     0.100000   0.000000   0.100000 (  0.094073)
10000 trials    0.890000   0.000000   0.890000 (  0.900364)
50000 trials    4.650000   0.000000   4.650000 (  4.686127)
 2013-05-08 13:47:56 -04:00
Ryan Davis
3073c53198 Updates to make rails 4 happy with minitest 5: 
+ Namespace changes, overhaul of runners.
+ Internal ivar name changes
- Removed a logger globally applied to tests that spew everywhere?!?
+ Override Minitest#__run to sort tests by name.
+ Reworked testing isolation to work with the new cleaner architecture.
- Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago.
- Minor report output differences.
 2013-05-06 17:38:45 -07:00
Patrick Robertson
eebb9ddf9b Convert ActiveModel to 1.9 hash syntax. 
I also attempted to fix other styleguide violations such as
{ a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
 2013-05-01 18:01:46 -07:00
Rafael Mendonça França
feb44b9213 rails/master is now 4.1.0.beta 2013-04-29 13:15:24 -03:00
David Heinemeier Hansson
1ec64297f9 Bump version to rc1 2013-04-29 08:29:18 -07:00
Xavier Noria
31aab3ee57 pass over the code comments 
* Highlights the requirement of an attributes method.
* Removes some details that depend on the implementation of the class including the module.
* Applies guidelines here and there.
 2013-04-28 12:03:59 +02:00
Carlos Antonio da Silva
3e47e193c6 Merge pull request #10286 from neerajdotname/fix-wrong-test-name-and-failure-message 
fix wrong test description and failure message
 2013-04-21 09:22:51 -07:00
Neeraj Singh
2242317fdd fix wrong test description and failure message 2013-04-21 12:00:38 -04:00
Neeraj Singh
cf69d527fe Added tests for if condition in Active Model callbacks 2013-04-21 11:34:12 -04:00
Yves Senn
068289f239 align the result of expressions vertically [ci skip]. 2013-04-12 17:22:39 +02:00
Yves Senn
c245437de7 use unified and clean formatting in CHANGELOGS. [ci skip] 2013-04-12 15:52:43 +02:00
Anupam Choudhury
e000aa92dd Removed unused setup 2013-04-09 20:57:55 +05:30
Sam Ruby
04cda1848c Prefer find_by over dynamic finders in rdoc 2013-04-02 15:09:15 -04:00
Carlos Antonio da Silva
09c55dcc5d Review some tests from AMo::Errors to remove "should" usage 
Also remove duplicated tests for Errors#as_json and minor improvements
in some tests.
 2013-03-30 15:04:09 -03:00
Carlos Antonio da Silva
3d0c0c6c95 Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip] 
Add a working example of how to use this new method.
 2013-03-30 14:38:13 -03:00
Vijay Dev
6d8c070821 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
	activerecord/test/cases/adapter_test.rb
	guides/source/testing.md

[ci skip]
 2013-03-30 15:46:14 +05:30
Rafael Mendonça França
b8b3df0e63 Merge pull request #8527 from shockone/patch-1 
Add a method full_messages_for to the Errors class
 2013-03-25 09:04:25 -07:00
Rafael Mendonça França
ba012fa04d Merge pull request #9864 from vipulnsward/fix_test_AR_v2 
Introduce test on Error#full_message for attribute with underscores; Fix...
 2013-03-25 08:56:29 -07:00
shock_one
ec1b715b0e Add a method full_messages_for to the Errors class 2013-03-24 09:38:28 +02:00
Rafael Mendonça França
e600384515 Merge pull request #8501 from charliesome/version-to-s 
Add #to_s method to VERSION modules
 2013-03-23 18:51:16 -07:00
Prathamesh Sonpatki
5f59317ec6 Fixed typo in activemodel/CHANGELOG 2013-03-24 02:27:43 +05:30
Prathamesh Sonpatki
33d1e37408 Reverted change in activemodel/CHANGELOG.md introduced by d45145acdc576e46a1f1719d69bec96b5bf07b0a 2013-03-24 02:14:21 +05:30
Prathamesh Sonpatki
d45145acdc Changed 'args' to 'arguments' when used in places other than code with fixing few more typos 2013-03-24 00:34:06 +05:30
Carlos Antonio da Silva
a03ab8cef8 Remove exception variable from rescue block 
Just raising from the rescue block will re-raise the exception, so the
variable is not necessary.
 2013-03-22 14:00:06 -03:00
Vipul A M
24fee97581 Add Error#full_message test; Fix typos 
Introduce test on Error#full_message for attribute with underscores; Fix
some typos
 2013-03-22 14:53:32 +05:30
robertomiranda
7e07b7bb5d Change Standard error when is required bcrypt-ruby and fails 2013-03-21 22:52:42 -05:00
Charlie Somerville
c07e1515f7 Add version method to top level modules 2013-03-21 19:56:07 +11:00
Intrepidd
9c025ab6e9 Tidying up some require : removing useless sort and homogenizing with the rest of the code the wat the includes are done 2013-03-20 18:24:48 +00:00
wangjohn
3ee30ca44a The repair_validations helper was not working correctly before because 
it only cleared the validations that created :validate callbacks. This
didn't include the validates created by validates_with, so I've added a
method to clear all validations.
 2013-03-19 12:23:20 -04:00
Xavier Noria
ddd2c75b26 Revert "instruct RDoc to only parse Ruby files under lib [Fixes #9779]" 
This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57.
 2013-03-18 21:19:47 +01:00
Xavier Noria
c24528fbc9 instruct RDoc to only parse Ruby files under lib [Fixes #9779] 2013-03-18 20:36:32 +01:00
Vipul A M
233737706c fix some typos found in activemodel 2013-03-18 17:20:05 +05:30
Vipul A M
29dcf096b0 Small typos here and there. 2013-03-15 11:55:03 +05:30
Waynn Lue
008fd54e74 clarify verbiage 2013-03-12 18:44:10 -07:00
Carlos Antonio da Silva
b3a31e9363 Fix AMo code example indent, add missing author to entry [ci skip] 2013-03-09 14:57:31 -03:00
Rafael Mendonça França
cf09ac380e Merge pull request #9545 from senny/9535_secure_password_blank 
`has_secure_password` is not invalid when assigning empty Strings
 2013-03-07 08:05:05 -08:00
Vijay Dev
6ea48ebfa6 Merge branch 'master' of github.com:lifo/docrails 2013-03-05 22:51:48 +05:30
Yves Senn
8c1687bbf8 has_secure_password is not invalid when assigning empty Strings. 
Closes #9535.

With 692b3b6 the `password=` setter does no longer set blank passwords.
This triggered validation errors when assigning empty Strings to `password`
and `password_confirmation`.

This patch only sets the confirmation if it is not `blank?`.
 2013-03-04 18:56:05 +01:00
Yves Senn
b501ee47fa validates_confirmation_of does not override writer methods. 2013-03-04 18:51:34 +01:00
Lebin Sebastian F
50b3b968d4 Small Typo 2013-03-04 13:23:23 +05:30
Rafael Mendonça França
0f75e2c51f Update CHANGELOGS 2013-02-26 13:45:57 -03:00
David Heinemeier Hansson
c0bc9ce38c Preparing for 4.0.0.beta1 release 2013-02-25 08:31:50 -06:00
Xavier Noria
05857ec30e did a pass over the AM changelog [ci skip] 2013-02-24 20:37:15 +01:00
Angelo capilleri
40c1ee8b7d added more accurate test for add_on_empty 
with the current tests, if delete the assignment of is_empty in add_on_empty method
the tests not fail. With this test, if we delete is_empty, the test fails
 2013-02-19 18:48:37 +01:00
Vijay Dev
0c145448c4 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	guides/source/upgrading_ruby_on_rails.md
 2013-02-15 22:06:17 +05:30
Henrik Nyh
53c22e097a Clarify ActiveModel::Validator initialization in docs. 
As discussed with @josevalim on Ruby Rogues Parley.
 2013-02-09 15:54:14 +01:00
Rafael Mendonça França
e16110c4b8 Take care of whitespaces and changing the hash syntax 2013-02-04 09:59:22 -02:00