Commit Graph

10365 Commits

Author SHA1 Message Date
Godfrey Chan
b663e26544 Actually rename to rake initializers 2015-03-21 12:45:15 -07:00
Arthur Nogueira Neves
3064533076 Merge pull request #19441 from y-yagi/use_exist
use `Dir.exist?` instead of deprecated `Dir.exists?`
2015-03-21 12:24:39 -04:00
Arthur Nogueira Neves
bfd73559ec Merge pull request #19445 from prathamesh-sonpatki/rm-ostruct
Removed requiring ostruct because its unused
2015-03-21 12:16:51 -04:00
Prathamesh Sonpatki
5b7b4e8403 Removed requiring ostruct because its unused 2015-03-21 18:49:56 +05:30
Prathamesh Sonpatki
64eb76ed16 Fix typos in test runner's help output 2015-03-21 18:25:58 +05:30
yuuji.yaginuma
a8bf335793 use Dir.exist? instead of deprecated Dir.exists? 2015-03-21 16:27:43 +09:00
eileencodes
34640210ec Revert "Use def setup instead of setup do"
This reverts commit 044f9ab7a4d6646ddce4560bb83b58cdc0baa751.
2015-03-20 19:32:42 -04:00
Godfrey Chan
9e80c29cd5 rake initializer -> rake initializers
Also edited the copy to be more consistent with `rake routes`.

See #19323.
2015-03-20 15:51:01 -07:00
Jeremy Kemper
5154089c18 Revert "Merge pull request #19404 from dmathieu/remove_rack_env"
Preserving RACK_ENV behavior.

This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing
changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
2015-03-20 08:14:11 -07:00
Jeremy Kemper
a4e7a6f9d6 Revert "Merge pull request #19411 from dmathieu/rack_env_changelog"
Preserving RACK_ENV behavior.

This reverts commit b19990c82c6a9beff0cd058dc2ff67894a2f9ea7, reversing
changes made to ac291b76ea770b5795c767f2f74a8d0b33744809.
2015-03-20 08:13:48 -07:00
eileencodes
c757e9b60a Remove #build_original_fullpath method
Removing `#build_original_fullpath` because it is no longer
used by the Rails' source code or called in the `#call` method becasue
the previous commit now uses `fullpath` from Rack.

The method was nodoc'ed so it's safe to remove.

NOTE: I did this as a separate commit so if this does cause a problem
with engines etc reverting is easy.
2015-03-20 08:48:04 -04:00
eileencodes
0755d30017 Use fullpath from Rack request rather than building it
In Rack, `#fullpath` checks if there is a query string and builds the
query correctly:

```
def path
  script_name + path_info
end

def fullpath
  query_string.empty? ? path : "#{path}?#{query_string}"
end
```

We can utilize this instead of manually building the fullpath because
they are the same result. This also reduces allocations in `#call`
because we don't need `build_original_fullpath` to create the paths and
query strings. We don't need to build `fullpath` twice.
2015-03-20 08:48:00 -04:00
amitkumarsuroliya
44e94a38f4 Updated MySQL documentation link to MySQL latest version 5.6 everywhere [ci skip] 2015-03-19 22:11:18 +05:30
Damien Mathieu
cbadeeb969 add changelog entry for removing the fallback to rack_env
[ci skip]
2015-03-19 16:04:49 +01:00
Aaron Patterson
7bdc7635b8 Merge pull request #19404 from dmathieu/remove_rack_env
Don't fallback to RACK_ENV when RAILS_ENV is not present
2015-03-19 07:46:57 -07:00
Arthur Neves
a9eb12393f Use absolute path on find_method location for the runner 2015-03-19 10:15:03 -04:00
Arthur Neves
4bb9268474 Fix test rake when passing multiple arguments
bundle exec db:migrate rake was not working, with the new runner, before this commit
2015-03-19 10:15:03 -04:00
Arthur Neves
9afd9d232c method_source needs to be a hard dependency on railties 2015-03-19 10:15:03 -04:00
Yves Senn
9959e9525b Merge pull request #19216 from senny/bin_test_runner
`bin/rails test` runner (rerun snippets, run tests by line, option documentation)
2015-03-19 14:27:01 +01:00
Damien Mathieu
d578cbfb5c don't fallback to RACK_ENV when RAILS_ENV is not present 2015-03-19 10:06:28 +01:00
Arthur Neves
2f23f97b2e Add a new-line to the end of route method generated code.
Fix regression on route method that was added by
bac812a7ef2660a2fe2ab00822e5e66228379822. The regression was that when
calling the `route` method, we were not appending a \n anymore.

[fixes #19316]
2015-03-18 10:33:59 -04:00
Yves Senn
d9bbafb2e7 run test_test.rb using the bin/rails test. 2015-03-18 09:52:19 +01:00
Arthur Neves
8017e6af31 Use Rails::TestRunner on rake test 2015-03-18 09:52:19 +01:00
Arthur Neves
f10c7e1849 Fix reporter test and verbose mode 2015-03-18 09:52:19 +01:00
Yves Senn
6ccbeb458a move ENV["BACKTRACE"] support into the TestRunner. 2015-03-18 09:52:19 +01:00
Yves Senn
ac5ead59ae -p, --pattern to run tests using a pattern. 2015-03-18 09:52:19 +01:00
Yves Senn
f78708c180 use bin/rails t runner in test_runner_test.rb. 2015-03-18 09:52:18 +01:00
Arthur Neves
de94929d70 Fix relative dir call on test runner 2015-03-18 09:52:18 +01:00
Arthur Neves
3cc783b6bf Add tests for runner#test_files method 2015-03-18 09:52:18 +01:00
Arthur Neves
b58c0914f4 Run multiple files on runner 2015-03-18 09:52:18 +01:00
Yves Senn
090c83672f -e / --environment for the test runner. 2015-03-18 09:52:18 +01:00
Yves Senn
f4ea8dda1b move argument parsing into the Runner. 2015-03-18 09:52:18 +01:00
Yves Senn
613bdd9d4c get rid of NAMED_PATTERNS in favor of running a whole directory 2015-03-18 09:52:18 +01:00
Yves Senn
fb2dc2adca document running a test by line number. 2015-03-18 09:52:17 +01:00
Yves Senn
7e9775bdb0 pluralize rerun snippet heading. 2015-03-18 09:52:17 +01:00
Yves Senn
ff79441d49 add tests for our minitest reporter. 2015-03-18 09:52:17 +01:00
Arthur Neves
ccee7eea8e Show the right file when test raises 2015-03-18 09:52:17 +01:00
Arthur Neves
a71bcdb4f3 Move minitest plugin
Minitest Rails plugin should be loaded on test_help, so we report errors
even when not running from the runner.

Also fix the backtrace
2015-03-18 09:52:17 +01:00
Arthur Neves
739cfd5d90 Move some logic to runner 2015-03-18 09:52:17 +01:00
Arthur Neves
5ae2c7060f Dont display Failed test if suite passed 2015-03-18 09:52:17 +01:00
Arthur Neves
d1a5460e3e Better file:line parsing and filter method by file too 2015-03-18 09:52:17 +01:00
Arthur Neves
cf7ba1fbbd no need to escape the method in a regex wrap, minitest does that for us 2015-03-18 09:52:16 +01:00
Arthur Neves
5d934caabb If a nem given, use that name to filter the test 2015-03-18 09:52:16 +01:00
Arthur Neves
ff0a7611cf Add test run by line, and report error by line 2015-03-18 09:52:16 +01:00
Yves Senn
c5532e06d9 spike of a OptionParser backed test runner. 2015-03-18 09:52:16 +01:00
Semyon Pupkov
82a1680fb1 Fix deprecation warning in rails_info_controller tests
Use keyword arguments in request methods
2015-03-17 11:45:14 +05:00
yuuji.yaginuma
5f6fc9e389 add mailer suffix to comments for email previews 2015-03-15 08:57:06 +09:00
Rafael Mendonça França
814d4da48e Merge pull request #19323 from naoty/rake_initializer
Add `rake initializer`
2015-03-13 14:55:53 -03:00
Naoto Kaneko
baa9ffb822 Add rake initializer
This task prints out initializers for an application. It is useful to
develop a rubygem which involves the initialization process.
2015-03-14 01:41:21 +09:00
Joshua Peek
9655cb1ce7 Update sprockets links to point to rails org 2015-03-13 10:55:50 -03:00