TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
2,709 Commits 2 Branches 0 Tags 294 MiB
0b55ce7191
Commit Graph

2709 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
d933627044 Introduce :selected option to the select helper. Allows you to specify a selection other than the current value of object.method. Specify :selected => nil to leave all options unselected. Closes #2991. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-23 21:59:20 +00:00
Jeremy Kemper
26f2fbf35f Credit ticket author. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-23 21:40:23 +00:00
Jeremy Kemper
b94d6c0654 Enable warnings on first load only. File which are loaded but raise an exception are not added to loaded set. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-23 21:31:51 +00:00
Florian Weber
c66ac2102b Fixed bug where using update_attribute after pushing a record to a habtm association of the object caused duplicate rows in the join table. #2888 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-23 21:03:25 +00:00
Jeremy Kemper
202e4208c4 Correct spelling of persistent [Stefan Kaes]. Document and eliminate warnings in clear_persistent_model_associations. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-23 00:35:37 +00:00
Jeremy Kemper
e8f664dde0 MySQL, PostgreSQL: reconnect! also reconfigures the connection. Otherwise, the connection 'loses' its settings if it times out and is reconnected. Closes #2978. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 23:55:04 +00:00
Thomas Fuchs
d958f22ecc Make javascript_include_tag :default behave correctly with application.js, fixes #2986 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 23:18:53 +00:00
Nicholas Seckar
bd5ace88b2 Initialize @optional in routing code to avoid warnings 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 22:24:25 +00:00
Jeremy Kemper
3e51cd8b8e Model generator: correct relative path to test_helper in unit test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 21:33:56 +00:00
Sam Stephenson
1b3c9a0a56 Remove superfluous check for pluralize_table_names (use table_name which does this check when it's set). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 08:59:52 +00:00
Sam Stephenson
bea737eb5a Make ActionController's render honor the :locals option when rendering a :file. Closes #1665. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 08:37:04 +00:00
Jeremy Kemper
130c493a4f FormHelper correctly passes its object through select, collection_select, country_select, and time_zone_select. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-22 01:32:40 +00:00
Jeremy Kemper
d21ba5aec9 has_and_belongs_to_many: use JOIN instead of LEFT JOIN. References #2937. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 22:27:19 +00:00
Jamis Buck
f783d50cf8 Allow assert_tag(:conditions) to match the empty string when a tag has no children. Closes #2959. [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 21:02:10 +00:00
Jamis Buck
f9b199040c Update html-scanner to handle CDATA sections better. Closes #2970. [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 20:43:35 +00:00
Jeremy Kemper
f1a184fe88 MySQL: introduce :encoding option to specify the character set for client, connection, and results. Only available for MySQL 4.1 and later with the mysql-ruby driver. Do SHOW CHARACTER SET in mysql client to see available encodings. Closes #2975. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 18:51:27 +00:00
Jeremy Kemper
6580662254 Don't put flash in session if sessions are disabled. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 18:09:28 +00:00
David Heinemeier Hansson
d345b7a4f0 Back out of 3109 for now as it seems to interfere with the flash 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 16:59:25 +00:00
Jeremy Kemper
baad1c4cdc Simpler Mysql load test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 12:47:28 +00:00
Marcel Molina
119155bebb Revert [3130]. Behavior of introducing Kernel.binding causes breakage. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 09:34:10 +00:00
Jeremy Kemper
5177333e70 Use Kernel.binding rather than binding to allow columns of that name. References #2973. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 08:34:50 +00:00
Sam Stephenson
ede2a222ee Strip out trailing &_= for raw post bodies #2868 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 08:04:28 +00:00
Marcel Molina
7355d9f1bd Make the db_schema_dump task honor the SCHEMA environment variable if present the way db_schema_import does. Closes #2931. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 08:01:41 +00:00
Jeremy Kemper
60091c1e2a r3241@asus: jeremy | 2005-11-20 23:26:28 -0800 
Active Support is warnings-safe.  References #1792.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:51 +00:00
Jeremy Kemper
9a77e2f2be r3240@asus: jeremy | 2005-11-20 23:22:34 -0800 
Introduce enable_warnings counterpart to silence_warnings.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:44 +00:00
Jeremy Kemper
d792427301 r3239@asus: jeremy | 2005-11-20 23:21:37 -0800 
Test for absence of instance vars rather than nil so we don't get a warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3133 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:39 +00:00
Jeremy Kemper
5129de7bbd r3220@asus: jeremy | 2005-11-20 03:19:22 -0800 
Enable Action Mailer warnings in unit tests.  adv_attr_accessor hecks for presence of instance variable before getting it.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3132 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:33 +00:00
Jeremy Kemper
d1ac316fa4 r3219@asus: jeremy | 2005-11-20 03:07:19 -0800 
silence necessary warnings in logger test.  guard against multiple requires in kernel test.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:27 +00:00
Jeremy Kemper
7ed37c82a9 r3218@asus: jeremy | 2005-11-20 03:06:32 -0800 
alias old format_message before overriding it


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:22 +00:00
Jeremy Kemper
ddc863c134 r3217@asus: jeremy | 2005-11-20 03:06:01 -0800 
warnings-safe inherited alias for class_inheritable_attributes


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:17 +00:00
Jeremy Kemper
3148216cbb r3216@asus: jeremy | 2005-11-20 03:05:20 -0800 
simplify cattr_ and mattr_accessor


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:12 +00:00
Jeremy Kemper
a821c3dd93 r3215@asus: jeremy | 2005-11-20 02:05:56 -0800 
Eliminate double-requires due to Ruby seeing different paths to the same file.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:04 +00:00
Jeremy Kemper
1a44b9cf1a r3214@asus: jeremy | 2005-11-20 02:03:05 -0800 
Parenthesize args in Inflections


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:28:59 +00:00
Jeremy Kemper
27f96c7d11 r3213@asus: jeremy | 2005-11-20 02:01:28 -0800 
Turn on warnings for tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:28:54 +00:00
Jeremy Kemper
edc7c521b8 Turn warnings on when loading a file if Dependencies.mechanism == :load. Common mistakes such as redefined methods will print warnings to stderr. References #752. References #1792. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:06:33 +00:00
Sam Stephenson
2b6e2bfed7 Have the lighttpd server script report the actual ip to which the server is bound. Closes #2903. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3123 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 06:19:25 +00:00
Marcel Molina
9a37fd44cb Add plugin library directories to the load path after the lib directory so that libraries in the lib directory get precedence. Closes #2910. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3122 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 05:55:35 +00:00
Marcel Molina
f14625bb46 Make help for the console command more explicit about how to specify the desired environment in which to run the console. Closes #2911. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 05:33:13 +00:00
Marcel Molina
dd198e259f Pull out Array#to_strings in favor of more general Symbol#to_proc. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 02:17:10 +00:00
Marcel Molina
69bf71f5e9 Add Symbol#to_proc, which allows for, e.g. [:foo, :bar].map(&:to_s). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3118 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 02:15:32 +00:00
Jeremy Kemper
e9b26c52a2 Fix grammar error in [3115]. References #2966. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 02:14:31 +00:00
Sam Stephenson
f212c88315 Pass multiple arguments to Element.show and Element.hide in JavaScriptGenerator instead of using iterators 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 01:54:36 +00:00
Jeremy Kemper
a0293c80f0 Improve expire_fragment documentation. Closes #2966. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 01:08:30 +00:00
Marcel Molina
5d785dbc11 Add Array#to_strings which to_s's all elements in an array. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 22:36:02 +00:00
Marcel Molina
baa2ab5ac3 Add extended_by, extend_with_included_modules_from and copy_instance_variables_from to Object. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 22:32:40 +00:00
Marcel Molina
55a3979a09 Correct docs for automatic layout assignment. Closes #2610. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 18:50:09 +00:00
Jeremy Kemper
dfa8aa0e1e PostgreSQL: the purge_test_database Rake task shouldn't explicitly specify the template0 template when creating a fresh test database. Closes #2964. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 12:00:46 +00:00
Jeremy Kemper
da9f713d2c r3209@asus: jeremy | 2005-11-20 01:04:22 -0800 
If sessions are disabled, return a hash that raises an error when it's accessed.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 09:06:43 +00:00
Jeremy Kemper
63b792162b Make data writer private. Marshal/unmarshal handle nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:15:51 +00:00
Jeremy Kemper
c7bc10b2e4 Log ActiveRecordStore debugging. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:07:33 +00:00