Commit Graph

91 Commits

Author SHA1 Message Date
Ryunosuke Sato
40f226ae94 Fix link to rails-ujs
https://github.com/rails/rails-ujs is merged into actionview in favor of https://github.com/rails/rails/pull/28098.
[skip ci]
2017-03-30 01:10:20 +09:00
Jon Moss
9cc2f50f9c Update some jquery-ujs references to rails-ujs
[ci skip]
2017-03-18 22:41:15 -04:00
Scott González
175e7efbc1 Action Mailer Basics clean up [ci skip] 2017-01-25 16:17:12 -05:00
Scott González
d09be0b005 Clean up wording in Action Mailer Basics [ci skip] 2017-01-21 10:54:36 -05:00
yuuji.yaginuma
d71f289fb2 stop using removed render :text
Follow up to 79a5ea9eadb4d43b62afacedc0706cbe88c54496
2016-12-03 15:28:59 +09:00
yuuji.yaginuma
2a45296114 remove -t option from default sendmail arguments [ci skip]
Follow up to #24436
2016-07-06 18:57:53 +09:00
Jonne Haß
5e3fb2f7b0
Do not suggest nonsensical OpenSSL verify modes [ci skip]
SSL_set_verify(3) explains:

SSL_VERIFY_FAIL_IF_NO_PEER_CERT
  Server mode: if the client did not return a certificate, the TLS/SSL
handshake is immediately terminated with a "handshake failure" alert.
This flag must
  be used together with SSL_VERIFY_PEER.

  Client mode: ignored

SSL_VERIFY_CLIENT_ONCE
  Server mode: only request a client certificate on the initial TLS/SSL
handshake. Do not ask for a client certificate again in case of a
renegotiation.
  This flag must be used together with SSL_VERIFY_PEER.

  Client mode: ignored

The SMTP connection here uses a OpenSSL socket in client mode,
suggesting invalid/ignored flags is rather misleading.
2016-06-07 15:50:46 +02:00
yuuji.yaginuma
fb1163949a update Active Job default adapter [ci skip]
Follow up to 625baa69d14881ac49ba2e5c7d9cac4b222d7022
2016-03-22 07:45:10 +09:00
Stan Lo
f7ce370e60 Add caching guide in ActionMailer basics 2016-02-25 00:36:41 +08:00
Jon Moss
f800e00f9a Merge pull request #23660 from meinac/change_x_gzip_to_gzip
Change x-gzip to gzip in docs [ci skip]
2016-02-13 10:28:21 -05:00
Mehmet Emin İNAÇ
2b63f2ee75 Change x-gzip to gzip in docs [ci skip]
For more information about GNU zip mime type please check IETF's web site [RFC6713](http://tools.ietf.org/html/rfc6713) or [IANA](http://www.iana.org/assignments/media-types/media-types.xhtml#application)
2016-02-13 17:11:05 +02:00
Ryuta Kamizono
1335959135 Fix grammar a to an [ci skip] 2016-02-13 20:44:44 +09:00
David Heinemeier Hansson
ea4f0e2bab Refer to rails command instead of rake in a bunch of places
Still more to do. Please assist!
2015-12-18 13:01:10 +01:00
amitkumarsuroliya
c7000d93e7 correcting word smpt -> smtp in ActionMailer guide [ci skip]
`smpt.gmail.com` should be `smtp.gmail.com`
2015-09-20 16:32:03 +05:30
melissawahnish
1896be9741 [ci skip] Adding a note to Action Mailer Basics documentation that Google increased its
security measures so using the example for Gmail will return a “Password Incorrect” error,
and you will receive an email from Google that they blocked a sign-in attempt.  You can change
your Gmail settings or use another ESP.

I discovered this when I was testing a simple mailer example app and was just going to
use my personal Gmail account for the test.  I think it would be best to note this change
since now Gmail may not be the best option for a quick test.  I hope this saves time for other Rails
developers.  The Gmail example does show a good example of how to configure the smpt settings.
2015-08-08 14:02:33 -04:00
Alexey Markov
35aa47d524 Small fix 2015-08-06 22:35:05 +03:00
Mauro George
9cc438f559 Create Adding images in Action Mailer Views on guides
[ci skip]
2015-07-03 07:38:56 -03:00
Yves Senn
40bdf0dd4c Merge pull request #20117 from jfine/action-mailer-smtp-settings-update
Add openssl_verify_mode and sync other smtp_settings with API docs [ci skip]
2015-06-19 12:04:58 +02:00
Guilherme Goettems Schneider
ac6180ec1b Fix email with name format in Guides. [ci skip] 2015-05-26 13:49:41 -03:00
Jared Fine
cbf0ea8a30 Add openssl_verify_mode and sync other smtp_settings with API docs 2015-05-11 17:27:10 -04:00
Vijay Dev
9c290fbe7f Merge branch 'master' of github.com:rails/docrails 2015-05-08 16:20:27 +00:00
Yves Senn
f58c1e17fa Merge pull request #19931 from prathamesh-sonpatki/note-about-non-get-links
Added note about non-GET links getting converted to GET links in mailer  Added note about non-GET links getting converted to GET links in mailer templates [ci skip]
2015-04-28 13:43:39 +02:00
Prathamesh Sonpatki
3d92a9e087 Added note about non-GET links getting converted to GET links in mailer templates [ci skip] 2015-04-28 17:05:44 +05:30
Prathamesh Sonpatki
33f83401ad Updated titles of headers in Action Mailer guide 2015-04-28 15:46:35 +05:30
Yuki Nishijima
8657fb7775 Add guide for Action Mailer Previews
[ci skip]
2015-02-08 15:41:32 -08:00
Vipul A M
5cfaf5a46e - Changed IN to ON in markdown renderer condition
- Changed `IN` to `ON` in all note sentences in guides.
2015-01-14 11:52:13 +05:30
Josh Cheek
2d1f4033ab Un-inline if statement
The single line was long enough that it rendered on two lines,
causing the example to look like syntactically invalid code.
2014-12-29 12:59:05 -07:00
Dan Bernier
65158a6701 Fix bug in ActionMailer guide.
When setting a mailer's default from address, you have to pass a hash
with a `:from` key; you can't pass just an email address.
2014-12-24 16:12:47 +00:00
Xavier Noria
7702974281 warn about reading guides in GitHub
References #18148.
2014-12-23 23:32:50 +01:00
yuuji.yaginuma
c15d3fb0da [ci skip] fix description of url_for 2014-11-30 10:18:07 +09:00
Guo Xiang Tan
ec49324bd7 Update docs to reflect changes to MailerGenerator. 2014-11-25 09:56:49 +08:00
Juanito Fatas
49f8356f33 [ci skip] Fix code snippet display in Action Mailer Basics guide. 2014-09-16 15:32:38 +08:00
Logan Hasson
3941b8da9f [ci skip] Clarify Action Mailer/Active Job usage note 2014-08-21 10:55:50 -04:00
Cristian Bica
9e7f4a94ca Updated rdoc / guides / release notes related to ActiveJob / ActionMailer 2014-08-20 17:48:34 +03:00
@schneems and @sgrif
2bbcca004c Deprecate *_path methods in mailers
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.

Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.

Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.

The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.

Paired @sgrif & @schneems
2014-07-30 12:01:45 -05:00
Sam DeCesare
fd984e8500 fix bug in email with name example code
The display name in the email "to" field needs to be quoted otherwise
your email-sending service will fail when trying to deliver mail to
user's with commas in their name (i.e. John Smith, M.D.).
2014-06-11 17:41:06 -07:00
Juanito Fatas
2e1903822a [ci skip] Refine Action Mailer guide.
* Wrap 80 words if possible.
* Make attachment hash options more readable. (L239-L243)

  Before:

  ![screenshot 2014-06-11 02 59 54](https://cloud.githubusercontent.com/assets/1000669/3235432/a91d0464-f0d2-11e3-9e4a-6af2b2a83f1a.png)

   After:

  ![screenshot 2014-06-11 02 59 36](https://cloud.githubusercontent.com/assets/1000669/3235428/a47b28dc-f0d2-11e3-806c-cfaedd3f15df.png)

* L619 Wrap "location" in code: `"location"`.
* L628 Use actual section name.
* L697 Remove unnecessary `./` when refer to other guide.
2014-06-11 03:13:10 +08:00
Josef Šimánek
981dda53db Use generated binstubs in guides examples.
[ci skip]
2014-05-20 13:29:18 +02:00
Yves Senn
75cd7bc3c2 Merge pull request #13728 from semenyukdmitriy/master
Added missing `file` delivery method to the Configuration Guide
2014-01-22 01:53:30 -08:00
Semenyuk Dmitriy
9e63ead4ae [ci skip] Added missing file delivery method 2014-01-22 15:50:01 +06:00
Yves Senn
080fc9cad3 docs should say email not Email. [ci skip] 2014-01-20 15:04:36 +01:00
Yves Senn
dfac4ced1d docs, hyperlink the Mail gem in Action Mailer guide. [ci skip] 2014-01-20 14:47:40 +01:00
AvnerCohen
f381759430 Minor align BR tags with HTML void - with reference to the generators code change - f038d4cc5f 2013-10-09 14:42:33 +02:00
Paul Nikitochkin
2c8bc2cdcd Use Ruby on Rails Coding Conventions for code examples in the guides
* Indent after private/protected
* Ruby >= 1.9 syntax for hashes
* Prefer method { do_stuff } instead of method{do_stuff} for single-line blocks.

[ci skip]
2013-09-06 21:42:29 +03:00
Peter Jaros
2e0a9941a8 AM Guide: Should be "different formats". 2013-07-24 15:23:48 -04:00
Cristian Planas
93fd780a88 Using preferred find_by syntax in guides 2013-07-01 01:38:46 +02:00
Robin Dupret
59efb76306 Remove a duplicated section [ci skip]
Attachments were previously covered so remove the useless part. Just
move a note about multipart headers set when the mail method is
triggered to the kept section.
2013-06-29 19:14:09 +02:00
Kyle Fritz
6f30110cb4 correct no-replay@example.com to no-reply@example.com 2013-05-29 14:46:07 -03:00
Sunny Ripert
53607be559 Remove double spaces in guides 2013-05-28 14:38:02 +02:00
Sunny Ripert
606c09b8db Consistent use of one space only after punctuation 2013-05-28 14:38:02 +02:00