TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
53,682 Commits 2 Branches 0 Tags 294 MiB
0d4aa374a2
Commit Graph

92 Commits

Author SHA1 Message Date
Eileen M. Uchitelle
3c52b2000c Merge pull request #21738 from cllns/remove-to_s-from-example 
[Engines Guide] Remove to_s example, since it's outside the scope
 2015-09-25 12:24:51 -04:00
Sean Collins
30769669e3 Remove to_s example 
It's outside the scope of the Engines guide

[skip ci]
 2015-09-24 10:15:52 -06:00
Sean Collins
11f00fd3e3 Change the paths for both Gemfile lines to be 'engines/blorgh' 
They're now consistent.

Also changes the quotes to be single, so we only have one type of quote per line

[skip ci]
 2015-09-23 12:29:17 -06:00
Sean Collins
1b9e2bc5aa Remove leading slash from path 
The leading slash denotes an absolute path,
rather than a relative one (which is more popular)

[ci skip]
 2015-09-22 22:05:06 -06:00
Matthew Draper
90d0b852a5 Revert "Grammar correction" 
This reverts commit 67e467b9a5c113177aff925f07136e9b7f2a1eda.
 2015-06-11 21:53:33 +09:30
hemali jain
67e467b9a5 Grammar correction 2015-06-11 15:13:30 +05:30
Kuldeep Aggarwal
02b8087464 [ci skip]fix docs for Engines 2015-05-30 21:27:25 +05:30
kuldeepaggarwal
f4fd4d617f [CI SKIP] correct error text message 2015-05-09 21:51:06 +05:30
Vijay Dev
8ac458ad2e Merge branch 'master' of github.com:rails/docrails 2015-04-14 02:07:26 +00:00
Zachary Scott
da5fe3be1f Apply comments from @rafaelfranca: we shouldn't recommend you use scaffold css 
Closes #19492 and fixes #19453
 2015-04-12 18:11:14 -07:00
Mikhail Dieterle
8ec88a1b9e [ci skip] add missing file extension 2015-04-10 23:07:04 +03:00
Mikhail Dieterle
81b291915c [ci skip] format rake output 2015-04-10 22:55:19 +03:00
Mikhail Dieterle
746695d6c8 [ci skip] fix helper name 2015-04-10 22:35:46 +03:00
Kasper Timm Hansen
56e788edb3 [ci skip] Use explicit module namespace in guide 
The Engines guide used an inline namespace, `Blorgh::ApplicationController`, which caused problems for users using an
explicit module namespace because the `ApplicationController` inherited from wasn't fully qualified.
The controller qualification was fixed in 661479324d573d419d8e15a1ea257e01856084af.

This ditches the inline namespace and makes the example more consistent with others in the guide.
 2015-02-21 13:34:22 +01:00
Yves Senn
661479324d guides, fully qualify ApplicationController. Closes #19024. 2015-02-21 11:24:56 +01:00
Vipul A M
5cfaf5a46e - Changed IN to ON in markdown renderer condition 
- Changed `IN` to `ON` in all note sentences in guides.
 2015-01-14 11:52:13 +05:30
Xavier Noria
7702974281 warn about reading guides in GitHub 
References #18148.
 2014-12-23 23:32:50 +01:00
Godfrey Chan
40c3880d8b We shouldn't be linking to edgeapi [ci skip] 2014-11-25 04:34:43 -08:00
Godfrey Chan
b7b9e92093 Correct example in the engines testing guide [ci skip] 
Reference #17453
 2014-11-23 00:15:47 -08:00
David Elliott
21ba9b11f9 technical correction in guides under 'Generating an engine' 
`bin/rails` would not exist outside of a rails project
 2014-09-28 09:20:32 -07:00
yuuji.yaginuma
38e8bb8301 [ci skip] Fix sample code in engines guide 2014-08-10 22:10:15 +09:00
David Heinemeier Hansson
206347fd3e Update docs to reflect that helper stubs are no longer generated 2014-08-03 15:12:05 -07:00
Michael Mitchell
266e8db6fa [ci skip] Changes some wording to better foreshadow what is coming up later. 
This should prevent some anxiety readers may experience when the doc goes into something different than what it just explained. Also clarifies a statement about priority in engines and application environments

[ci skip] fixes double `the`

[ci skip] more clarifications

[ci skip] changes from tics to quotes
 2014-07-02 09:54:42 -07:00
Robin Dupret
11ac0cad08 Follow-up to #15215 [ci skip] 2014-06-27 16:52:04 +02:00
Rafael Mendonça França
ce54f67e4e Merge pull request #14113 from murb/patch-1 
Moved explanation of `--mountable` option up
 2014-06-23 14:43:58 -03:00
Ben Hicks
43bdd728a0 Remove extra list item element 
Cleaning up the list items that detail what an engines `--full` option
generates. Joining a multiline multi list item into a multiline single
list item.

[ci skip]
 2014-06-19 17:58:29 -05:00
Zachary Scott
6daa46621b Generated engines don't include bin/rake, fixes #15409 [ci skip] 2014-05-29 13:49:29 -07:00
John Kelly Ferguson
d02c810e29 Rename Posts to Articles in Guides, continuation of 2d446e77 / #13774 [ci skip] 2014-05-21 23:01:45 -04:00
Josef Šimánek
981dda53db Use generated binstubs in guides examples. 
[ci skip]
 2014-05-20 13:29:18 +02:00
Arthur Nogueira Neves
fa83601996 Merge pull request #11836 from mcfiredrill/engines-testing-doc 
additional note about routes in functional tests for engines [ci skip]
 2014-04-16 10:49:26 -04:00
Maarten Brouwers
b3c3e596cc Moved explanation of --mountable option up 
The example code uses `--mountable`. In previous version this was followed by an explanation of the `--full` option, which doesn't make sense. Later on in the text this is better explained. I moved this explanation up without repeating too much.
 2014-02-19 16:37:31 +01:00
Ilja Krijger
1196bec8e0 Typo fix [ci skip] 2013-12-28 11:24:01 +01:00
Ben Lewis
f95d78e402 Word wrapping engines guide [ci skip] 2013-12-14 13:28:08 -07:00
Ben Lewis
39eb10c3b5 Clarification, grammar fixes, punctuation, and capitalization [ci skip] 2013-12-14 13:27:45 -07:00
Martin Harrigan
08c72946c5 Helper should be a module in Rails guides [ci skip] 2013-11-23 11:26:17 +00:00
Damien Mathieu
a0fe2f1fc8 fix typo introduced when searching in markdown document with vim 2013-10-24 13:33:13 +02:00
Damien Mathieu
b8a538625a rephrase the overriding views part about the view path 
See rails/rails#12608
 2013-10-24 13:30:04 +02:00
Juanito Fatas
53d1779b67 [ci skip] Add missing migrate step in generating comment resource section. 2013-09-22 19:00:38 +08:00
Juanito Fatas
448aa840cb [ci skip] Fix a typo in Engines.md. 2013-09-22 02:26:07 +08:00
Paul Nikitochkin
2c8bc2cdcd Use Ruby on Rails Coding Conventions for code examples in the guides 
* Indent after private/protected
* Ruby >= 1.9 syntax for hashes
* Prefer method { do_stuff } instead of method{do_stuff} for single-line blocks.

[ci skip]
 2013-09-06 21:42:29 +03:00
Xavier Noria
b77f25cb84 cleans the guides sources from fancy non-ASCII stuff 2013-08-23 17:59:11 +02:00
Carlos Antonio da Silva
6846d9146b Fix typo [ci skip] 2013-08-19 00:34:19 -03:00
scaryguy
7c9f9dcc21 blorgh_engine to blorgh [ci-skip] 2013-08-18 20:50:23 +03:00
Tony Miller
82acd0eaaf additional note about routes in functional tests for engines [ci skip] 2013-08-10 20:58:47 -07:00
Sergey Kuznetsov
9d39577bd9 Add author_name field to post_params to the engines docs 2013-08-10 14:58:24 +04:00
Vijay Dev
3613235cc3 Merge branch 'master' of github.com:rails/docrails 2013-07-21 18:08:43 +05:30
Mikhail Dieterle
760662de86 use strong_params in example 2013-07-19 10:54:24 +03:00
blahedo
726530689e Cleaned up wording and tags. 
Replaced <br /> with <br> for consistency; Added note about
singular/plural distinction (which was previously confusing to a Rails
noob); Rephrased explanation of how form is routed to controller, again
to reduce confusion; and added explanation to replace incorrect link.
[ci skip]
 2013-07-06 18:36:23 -04:00
Steve Klabnik
ab28bafc9f Add note about decorator loading in Engines guide. 
Because decorators aren't referenced by the application, they won't get
autoloaded. And because we recommend the pattern, it would be irresponsible
to not show how to load them properly.

Fixes #10647.
 2013-05-24 11:24:00 -05:00
Adam Dalton
8cb4f127d9 User is not part of the Blorgh domain, so user_class doesn't make sense. This commit changes it to author_class. 2013-04-08 09:56:20 -04:00