TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
18,630 Commits 2 Branches 0 Tags 294 MiB
10dec0e65e
Commit Graph

3553 Commits

Author SHA1 Message Date
Aaron Patterson
f22b40a8f2 make sure we use the engine assigned to the table when quoting 2010-09-27 14:29:07 -07:00
Neeraj Singh
7f743233c4 Fix for nested_attributes with has_many association fails when a single record is being updated. 
[#5705 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-27 23:11:24 +02:00
José Valim
fe0251e408 Merge remote branch 'miloops/warnings' 
Conflicts:
	actionpack/lib/action_controller/metal/url_for.rb
 2010-09-27 21:00:54 +02:00
Neeraj Singh
fbd1d306b9 Three performance improvements: 
* for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation.

* Instead of performing String#blank? do Array#empty?

* no need to create variable relation
 2010-09-27 10:49:49 -07:00
Emilio Tagua
eff68d86ad Prevent shadowing outer local variable. 2010-09-27 11:19:19 -03:00
Aaron Patterson
7918a5c966 third parameter is not used 2010-09-26 18:25:13 -07:00
Nic Benders
f8c7f4cc53 db:structure:dump should list current Rails.env adapter in errors, not always the test adapter 
[#5710 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-26 20:45:30 -03:00
Tim Connor
d6f7b7d353 Fix remove_index issue when provided :name is a symbol 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-26 20:40:14 -03:00
Marcelo Giorgi
72543b2e63 Delegate ActiveRecord::Base.offset to scoped methods (analogous to limit) [#5688 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-24 20:24:54 -03:00
Brian Candler
a348ffcb2d Fix warning message when db/schema.rb doesn't exist [#5625 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-24 17:40:03 -03:00
tnp
55b6fa9370 restore behavior of touch for models without :updated_xx [#5439 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-24 20:42:38 +02:00
Neeraj Singh
097240f602 reject_id option should be respected while using nested_attributes 
[#5579 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-24 12:46:24 +02:00
Aaron Patterson
a4dd0b3433 switch present in favor of empty 2010-09-22 16:14:46 -07:00
Emilio Tagua
f6de806537 Refactor association_collection uniq method. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:02 -03:00
Emilio Tagua
2da809da37 No need to use inject here. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:02 -03:00
Emilio Tagua
ea35ccfe20 Perf: refactor method. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:02 -03:00
Emilio Tagua
0580f5a6ac No need to use inject here, use map instead. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:02 -03:00
Emilio Tagua
4513cc142c Goodbye inject, hello map. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:02 -03:00
Emilio Tagua
569be76ed6 Use map instead inject. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 18:08:02 -03:00
Santiago Pastorino
090c9ae3a3 Missing the mysql2 gem here 2010-09-22 14:33:44 -03:00
Neeraj Singh
48a108d55b Error message should advice to use 'mysql2' gem. 
If I create a new app using command
rails new demo -d mysql
then Gemfile contains 'mysql2' gem by default.

However if mysql gem is missing then error message says
raise "!!! Missing the mysql gem. Add it to your Gemfile: gem 'mysql', '2.8.1'"

[#5569 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-22 14:20:56 -03:00
Aaron Patterson
0cf45c850c avoid a proc object 2010-09-22 09:01:11 -07:00
Aaron Patterson
fe8a307088 avoid creating a range object 2010-09-22 09:01:11 -07:00
Aaron Patterson
aa85a7a7e7 drying up construct_association 2010-09-21 21:01:48 -07:00
Aaron Patterson
8186c5736b dry up some conditionals 2010-09-21 20:44:21 -07:00
Aaron Patterson
723adecab9 fixing case / when indentation 2010-09-21 20:38:36 -07:00
Aaron Patterson
9b1a4fda6f fix case / when indentation 2010-09-21 20:32:11 -07:00
Aaron Patterson
27be777888 avoid a hash lookup 2010-09-21 20:32:00 -07:00
Aaron Patterson
e66bf6f5e3 remove more codes 2010-09-21 19:56:53 -07:00
Aaron Patterson
9b81ae6969 deleting more code 2010-09-21 19:41:15 -07:00
Aaron Patterson
8d6a6b250e use each properly to avoid splatting a variable 2010-09-21 19:37:07 -07:00
Aaron Patterson
19ff42d909 deleting repeated codes 2010-09-21 19:27:23 -07:00
Aaron Patterson
79ef26c8c9 do not pass nil values to arel 2010-09-21 19:22:37 -07:00
Aaron Patterson
31eb765640 refacoring duplicate code. <3 <3 <3 2010-09-21 16:50:22 -07:00
Aaron Patterson
50041e563a this reject can be replaced with compact 2010-09-21 15:25:09 -07:00
Aaron Patterson
fdd537e7f9 removing unused code 2010-09-21 15:25:09 -07:00
Aaron Patterson
d7877ffc30 remove some repeated code 2010-09-21 15:25:09 -07:00
Aaron Patterson
67a9ae6a66 break up giant method 2010-09-21 15:25:08 -07:00
Aaron Patterson
88b1d51f82 removing lolinject 2010-09-21 14:42:42 -07:00
Hemant Kumar
953d129bb2 remove join table rows before removing owner row for habtm associations, fixes#5674 2010-09-21 13:58:09 -07:00
Aaron Patterson
96bd936b64 providing arel with column information when possible [#5392 state:resolved] 2010-09-21 13:53:47 -07:00
Xavier Noria
f4abe66d35 un-nodocs AR::Batches 2010-09-21 20:44:45 +02:00
Stevie Graham
83ecd03e7d use instance_eval, reduce method calls. 
execution time in seconds for `rake test_sqlite3`:

ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-darwin10.4.0]
  - before: 52.771426, 52.159505, 52.937056
  - after: 51.452584, 51.897017, 51.584431

rubinius 1.0.1 (1.8.7 release 2010-06-03 JI) [x86_64-apple-darwin10.4.0]
  - before: 284.334076
  - after: 285.753028

ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]
  - before: 75.811548, 75.533153, 75.353122
  - after: 75.244243, 75.19226, 75.256925
 2010-09-21 01:44:29 +08:00
Piotr Sarnacki
d475de7e25 Add helper for loading seed data for engine and application 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-20 10:41:05 +02:00
Thiago Pradi
3c9bf6e1dc Exception handling more readable 
[#5601 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-19 12:18:51 -07:00
Xavier Noria
2b6c2e947b adds to the API guidelines the proper spelling of Arel 2010-09-19 00:05:05 +02:00
Tim Connor
37de59eacf Fix issue with remove_index and add unit test [#5645 state:resolved] 2010-09-18 20:49:31 +02:00
Tim Connor
55d0d57bfc Raise errors when index creation fails 2010-09-18 20:49:28 +02:00
Aaron Patterson
55736ef125 @join_values is passed in, so we should use the parameter 2010-09-15 14:18:15 -07:00
Aaron Patterson
ac9c715947 passing the quoted id to arel if the object has a quoted id 2010-09-10 15:28:57 -07:00