TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
6,087 Commits 2 Branches 0 Tags 294 MiB
11dde5ca2f
Commit Graph

6087 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
8ed83b9b1e validates_inclusion_of and validates_exclusion_of allow formatted :message strings. Closes #8132 [devrieda, Mike Naberezny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8172 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 22:01:04 +00:00
Jeremy Kemper
609a03fd2a Fix typo in generator usage blurb. Closes #10217 [Mike Naberezny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8171 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 22:00:32 +00:00
Michael Koziarski
c95f066bf5 Add 'foxy' support for fixtures of polymorphic associations. Closes #10183 [jbarnette, David Lowenfels] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 21:53:22 +00:00
Michael Koziarski
0c12d6c6dc Ensure that the routing optimisation code isn't used when additional arguments are passed to the named route. Closes #10209 [bscofield, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 21:25:25 +00:00
Michael Koziarski
e1a2f3c898 Remove unnecessary route reload in integration tests, obsoleted by [7676]. Closes #10094. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8168 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-19 23:11:26 +00:00
Rick Olson
24e6cbc724 Don't cache net/http object so that ActiveResource is more thread-safe. Closes #10142 [kou] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-19 00:06:23 +00:00
David Heinemeier Hansson
a76490d917 Fixed that partial rendering should look at the type of the first render to determine its own type if no other clues are available (like when using text.plain.erb as the extension in AM) (closes #10130) [java] Fixed that partials would be broken when using text.plain.erb as the extension #10130 [java] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-18 22:01:33 +00:00
David Heinemeier Hansson
713ca5196d Docfix (closes #10155) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-18 21:51:09 +00:00
Michael Koziarski
6d0e5eaf06 memoize host with port and refactor the tests which depend on it changing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 05:41:47 +00:00
Michael Koziarski
c07eae4d40 Remove unneeded code to disable optimisations. the defined?(request) stuff takes care of this now. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 03:57:42 +00:00
Michael Koziarski
d7ff645e31 Use debug, not info as log_info will discard the information if info is used. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 03:57:19 +00:00
Jeremy Kemper
129b3bdcea Clarify Array#in_groups_of implementation, don't dup unless needed, only require enumerator once. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 02:48:08 +00:00
Jeremy Kemper
bff217272d RAILS_GEM_VERSION may be set to any valid gem version specifier. Closes #10057. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 01:39:19 +00:00
Jeremy Kemper
4249ffe249 Load config/preinitializer.rb, if present, before loading the environment. Closes #9943. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 01:38:58 +00:00
Jeremy Kemper
24c9250968 Table names aren't nested: replace / with _ to match the likely table name. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 23:01:24 +00:00
Jeremy Kemper
ace7518fcb Resource and scaffold generators pass on the full name to the dependent model, so nested resources give a corresponding nested model. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 22:56:40 +00:00
Jeremy Kemper
473202df83 attr_readonly behaves well with optimistic locking. Closes #10188. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:31:24 +00:00
Jeremy Kemper
32602acdb7 Remove components mention from railties README. Closes #10182 [sjgman9] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:31:01 +00:00
Jeremy Kemper
9f43627d2f Use the new TestCase subclasses in the scaffold and resource generators also. Closes #10174 [bscofield] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:30:28 +00:00
Jeremy Kemper
65a29b3433 MacOS X -> Mac OS X. Closes #10171 [henrik@nyh.se] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-16 20:29:45 +00:00
Jeremy Kemper
aa9e5a4339 Use Leopard's native mysql_config. Closes #10167 [Robert Evans] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8146 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-15 00:25:19 +00:00
Jeremy Kemper
1225b2f76e Remove warning about fixture loading order from test_helper since we disable foreign key checks now. [Mike Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 22:50:56 +00:00
Jeremy Kemper
5e772321a3 Correct MySQL install instructions for Leopard. Closes #10167 [mnaberez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 20:59:37 +00:00
Jeremy Kemper
cb1f569231 Remove stale warning from application generator usage message. Closes #10165 [bronson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 19:30:38 +00:00
Jeremy Kemper
990a3f3a83 Use rexml for some tests rather than string include? checks to account for unordered attributes. Closes #10164 [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 18:59:05 +00:00
Jeremy Kemper
40cc41931e Add MySQL install instructions for Leopard in particular. Closes #10167 [Robert Evans] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 18:24:52 +00:00
Jeremy Kemper
ea256eaa7f Base#to_xml supports the nil="true" attribute like Hash#to_xml. Closes #8268. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 10:33:25 +00:00
Jeremy Kemper
a75cafbda2 Speedup String#blank? and remove some overspecified tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 10:02:26 +00:00
Michael Koziarski
696d140b6c Only Benchmark and log if we're going to output the information. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 09:39:27 +00:00
Michael Koziarski
5ce6d74531 Fix Tests broken in [8134] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 09:36:35 +00:00
Michael Koziarski
7106dca977 Actually cache the template names. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 09:30:25 +00:00
Jeremy Kemper
78fb61a1fa FastCGI handler ignores unsupported signals like USR2 on Windows [Grzegorz Derebecki] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8132 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-13 00:54:57 +00:00
Marcel Molina
578c7a18e4 Change plings to the more conventional quotes in the documentation. Closes #10104 [danger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-12 18:36:42 +00:00
David Heinemeier Hansson
55b6697493 Fixed that has_many :through associations should render as collections too (closes #9051) [mathie/danger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-12 15:02:12 +00:00
Michael Koziarski
a406643b95 Improve documentation for IrreversibleMigrations. Closes #9636 [toolmantim] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-11 21:31:59 +00:00
Rick Olson
3104291322 Fix HasManyThrough Association so it uses :conditions on the HasMany Association. Closes #9729 [danger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-11 01:03:43 +00:00
Rick Olson
49cb41270a Only load ActionMailer::TestCase if ActionMailer is loaded. Closes #10137 [defunkt] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-11 01:01:11 +00:00
Michael Koziarski
79823e0b2f Ensure that column names are quoted. Closes #10134 [wesley.moxam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-10 21:33:13 +00:00
David Heinemeier Hansson
0f2c6302a1 Set the record straight on the purpose and utility of db/schema.rb 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 22:08:52 +00:00
David Heinemeier Hansson
2e12afaefe Fixed that db:reset would use migrations instead of loading db/schema.rb [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8123 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 21:58:24 +00:00
David Heinemeier Hansson
9d56d12360 Remove things that trip up RDoc 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8122 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 20:06:36 +00:00
David Heinemeier Hansson
5c8beba9dc Prepare versions for RC1 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8121 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 20:02:29 +00:00
David Heinemeier Hansson
b318134c99 Kill the whiny_protected_attributes setting and kill the exception raised. Instead, just log the mass-assignment misalignment as a debug warning (closes #9966) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 19:57:24 +00:00
David Heinemeier Hansson
21350d226e Removed unused code (closes #9906) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 19:14:28 +00:00
Rick Olson
5dc3f91832 initial experimental commit of active_model 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8118 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-09 14:59:15 +00:00
Rick Olson
fcfcc707d4 Ensure the plugin loader only loads plugins once. Closes #10102 [haruki_zaemon] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-08 15:41:46 +00:00
Rick Olson
f1b1af88b5 Refactor Plugin Loader. Add plugin lib paths early, and add lots of tests. Closes #9795 [lazyatom] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-08 05:29:44 +00:00
Marcel Molina
c443a6199a Update README to use new smtp settings configuration API. Closes #10060 [psq] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-08 03:39:15 +00:00
Marcel Molina
7143d80147 Smattering of grammatical fixes to documentation. Closes #10083 [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-08 03:37:16 +00:00
Jeremy Kemper
709dc33c92 Rearrange vendor bundles so gem overrides work correctly. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-07 19:29:21 +00:00