TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
48,590 Commits 2 Branches 0 Tags 294 MiB
122f55ced1
Commit Graph

48590 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sean Griffin
c9a953a17e Merge pull request #18119 from joker1007/add_require_core_ext_hash_to_activejob 
Add 'require' for Hash#with_indifferent_access to active_job/arguments.rb
 2014-12-21 10:46:22 -07:00
Sammy Larbi
f5489f9ab4 Clarify ActiveRecord testing guidelines [ci skip] 
1. Specify that you need to create the test databases, and that no special
   Rails command needs to be run to do that.
2. Although the underscore style of `rake test_mysql` works, make the
   documentation of running the tests in RUNNING_UNIT_TESTS.rdoc
   consistent with the "Contributing..." guide.
3. Promote "Testing Active Record" to not be a subsection of
   "Running a Single Test," since it doesn't make sense as a subsection
   of that.
 2014-12-21 10:18:46 -06:00
Abdelkader Boudih
ef529c6371 Merge pull request #18124 from jonatack/patch-8 
Testing guide grammar fix
 2014-12-21 15:10:08 +00:00
Jon Atack
2f1cf8101f Testing guide grammar fix 
[skip ci]
 2014-12-21 16:06:46 +01:00
joker1007
7b76f05cd1 Add 'require' for Hash#with_indifferent_access 
ActiveJob::Arguments uses Hash#with_indifferent_access.
But, activejob gem does not require Hash extension library.
When we use activejob as standalone,
we need extra require statement. This is unhandy.

This commit fixes it.
 2014-12-21 21:03:16 +09:00
Vipul A M
732bba8d4c - Fixed unused variable 
- Changed test to verify complete message instead of verifying if message contains text.
 2014-12-21 13:28:20 +05:30
Zachary Scott
651bba1bfe We will be using the application already created in the Getting Started guide. 
[ci skip]
 2014-12-20 19:02:47 -08:00
Zachary Scott
a504cbee78 Merge pull request #18114 from jonatack/patch-8 
Follow-up to d971021 [skip ci]
 2014-12-20 16:26:08 -08:00
Mark Dodwell
fecbed6fb1 Add support for Reply-To field in mail_to helper 2014-12-20 15:50:09 -08:00
Jon Atack
74ddf0051f Follow-up to d9710212 [skip ci] 2014-12-21 00:36:01 +01:00
Zachary Scott
4ad9d68581 Fixture data is accessible by a local method, and not a variable [ci skip] 2014-12-20 15:30:55 -08:00
Zachary Scott
72752643bb Shorten the explaination of this to fit on one line [ci skip] 2014-12-20 15:26:17 -08:00
Zachary Scott
7514b6ab18 s/folder/directory [ci skip] 2014-12-20 15:26:00 -08:00
Zachary Scott
9ea0e37f72 "In PostgreSQL, just superusers.." => "In PostgreSQL, only superusers.." 
[ci skip]
 2014-12-20 15:13:12 -08:00
Zachary Scott
bc24f19686 Make sure this section is rendered as a NOTE and remove redundant sentence. 
[ci skip]
 2014-12-20 15:10:28 -08:00
Zachary Scott
356e95c009 Add note about the association between the two fixture files and how they're connection. 
[ci skip]
 2014-12-20 15:07:11 -08:00
Zachary Scott
6925c14689 Remove YAML implementation detail, as we're not trying to document all of 
YAML's behavior in this guide. [ci skip]
 2014-12-20 15:03:32 -08:00
Zachary Scott
c709edaceb Remove use of "very" [ci skip] 2014-12-20 14:57:40 -08:00
Zachary Scott
06e1881fd3 Fix syntax error with RDoc directive, 
this should be `:nodoc:` in order to be parsed.
 2014-12-20 14:52:26 -08:00
Zachary Scott
d1c30f9576 Merge pull request #18113 from eileencodes/fix-grammar-in-assets-configuring-guide 
Improve grammar in configuring serve_static_files guide [ci skip]
 2014-12-20 14:51:06 -08:00
Zachary Scott
d9710212c2 Describe the mailer and helpers directories which are generated by rails new. 
[ci skip]
 2014-12-20 14:42:52 -08:00
eileencodes
90077a4779 [ci skip] Improve grammar in configuring serve_static_files guide 2014-12-20 17:39:45 -05:00
Zachary Scott
32626dec3f Update comment regarding test environment with help from @matthewd [ci skip] 2014-12-20 11:05:36 -08:00
Zachary Scott
e8e4e72639 Fixed syntax error in RDoc directive 2014-12-20 10:28:08 -08:00
Arthur Nogueira Neves
155a21fe01 Merge pull request #18092 from nippysaurus/clarity_batch_starting_point 
Update description for `start` parameter.
 2014-12-20 13:16:56 -05:00
Andrey Nering
f7d81c924f Add note about Ajax and CSRF-Token [ci skip] 2014-12-20 14:33:55 -02:00
Vijay Dev
34cd7e2b1a Renaming the autoloading guide [ci skip] 
The term 'constant autoloading' can be mistakenly
construed as 'constantly autoloading'.
 2014-12-20 15:46:15 +00:00
Vijay Dev
194b965036 pass over the autoloading guide [ci skip] 2014-12-20 15:34:51 +00:00
Vijay Dev
15590c1a2a Merge branch 'master' of github.com:rails/docrails 2014-12-20 14:26:21 +00:00
Yves Senn
a8015865d2 Merge pull request #18110 from claudiob/point-guide-to-master 
Replace guides.ror.org/v4.2.0 with guides.ror.org
 2014-12-20 14:44:20 +01:00
claudiob
902da271f5 Replace guides.ror.org/v4.2.0 with guides.ror.org 
No need to point links to http://guides.rubyonrails.org/v4.2.0/... now
that the Ruby on Rails guides point to 4.2.0.
 2014-12-20 05:37:09 -08:00
Abdelkader Boudih
79b71da793 Merge pull request #18108 from kryzhovnik/fix_autoloading_guide 
Fix link in autoloading guide
 2014-12-20 09:24:38 +00:00
Andrey Samsonov
604df2c57e Fix link in autoloading guide 
[ci skip]
 2014-12-20 13:05:58 +04:00
Godfrey Chan
d507f332a9 activejob needs to be built before actionmailer 2014-12-19 16:12:32 -08:00
Xavier Noria
461fa6390d Merge pull request #18104 from andreynering/guides-dsl 
Add link for Domain-Specific Language [ci skip]
 2014-12-20 00:54:06 +01:00
Xavier Noria
83bbc2352c prefer single quotes, by the beard of the prophet! 2014-12-20 00:51:30 +01:00
Xavier Noria
0cd5ddbbe1 Merge pull request #18103 from tpope/portable-setup 
Make bin/setup portable
 2014-12-20 00:46:45 +01:00
Tim Pope
1ae88b84a6 Make bin/setup portable 2014-12-19 18:36:53 -05:00
Arthur Nogueira Neves
e4f015e4e8
Merge pull request #18102 from arthurnn/nodoc_constant 
Add nodoc to some constants [skip ci]
 2014-12-19 18:22:46 -05:00
Andrey Nering
f57e1a2245 Add link for Domain-Specific Language [ci skip] 2014-12-19 21:16:58 -02:00
Godfrey Chan
2d04bdd86f Merge pull request #18100 from chancancode/serve_static_files 
Allow static asset serving from env variable (enhanced!)
Conflicts:
	railties/CHANGELOG.md
 2014-12-19 14:55:34 -08:00
Xavier Noria
352680c1d3 last pass to the autoloading guide before release [ci skip] 2014-12-19 19:50:24 +01:00
Rafael Mendonça França
86637391db Remove rack and i18n master from bug report tempaltes [ci skip] 2014-12-19 15:12:31 -02:00
Carlos Antonio da Silva
4073413d3c Use released I18n 0.7.0 2014-12-19 15:09:06 -02:00
Yves Senn
10e989b76d Merge pull request #18082 from rails/17945_purge_in_test_only 
`db:schema:load` and `db:structure:load` do not purge the database
 2014-12-19 12:15:27 +01:00
Yves Senn
be1e0241f0 force: :cascade to recreate tables referenced by foreign-keys. 2014-12-19 11:27:04 +01:00
Godfrey Chan
111f2f4422 Use released rack 
`rack.version` was bumped in 28e77c710a
 2014-12-19 01:26:19 -08:00
Godfrey Chan
5923ee6fe0 Revert "Merge pull request #18003 from sikachu/permit_all_parameters-thread-safety" 
This reverts commit da5cc10e945552da54234f858470238a3fc36767.

Fixes #18091

See also https://github.com/rails/rails/pull/18003#commitcomment-9030909
 2014-12-19 01:14:26 -08:00
Michael Dawson
d557f1bac0 Clarity start parameter 
I find that `Specifies the starting point for the batch processing.`
does not give enough information for me to understand what this
parameter actually does.
 2014-12-19 15:42:40 +10:00
Zachary Scott
65faa8f0da Output extension is no longer generated [ci skip] 
/cc @senny Is this change documented somewhere?
 2014-12-18 16:54:48 -08:00