Commit Graph

3004 Commits

Author SHA1 Message Date
Carl Lerche
13004d4f84 Make the query built by has_many ...., :dependent => :____ lazy since all the information is not really available yet. 2010-04-02 22:33:57 -07:00
Carl Lerche
386b7bfd9d Remove an unused argument 2010-04-02 20:13:09 -07:00
Pratik Naik
c6372d6049 Improve scope docs 2010-04-03 01:49:01 +01:00
Pratik Naik
41a2ba652a Improve named scope lambda 2010-04-03 01:35:43 +01:00
Pratik Naik
684e4d39d6 Remove unnecessary argument for creating scopes 2010-04-03 01:35:43 +01:00
Pratik Naik
13eb2c87e6 Make Relation#inspect less noisy 2010-04-02 18:57:46 +01:00
Pratik Naik
cfa283201e Goodbye ActiveRecord::NamedScope::Scope 2010-04-02 18:57:46 +01:00
Pratik Naik
62fe16932c Make Relation#first and Relation#last behave like named scope's 2010-04-02 18:57:46 +01:00
Pratik Naik
ee07950c03 Scope#method_missing can safely rely on Relation#method_missing 2010-04-02 18:57:45 +01:00
Pratik Naik
0be31f8563 Scope#current_scoped_methods_when_defined is no longer needed 2010-04-02 18:57:45 +01:00
Pratik Naik
83ebe6224f Oops :extends is not a MULTI_VALUE_METHOD 2010-04-02 17:39:47 +01:00
Pratik Naik
b77dd218ce Add Relation extensions 2010-04-02 17:38:02 +01:00
Pratik Naik
bc7da9b77d Consistency when using Relation constants 2010-04-02 17:38:02 +01:00
David Heinemeier Hansson
d868cb4f8a Prep for beta2, depend on latest Bundler 2010-04-01 13:36:45 -07:00
Doug Richardson
e8292abbcd Read postgresql encoding using string key instead of symbol [#4304 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-04-01 08:36:57 -07:00
Ernie Miller
ccf8311123 Fix mapping of bigint/smallint/uuid columns in postgresql adapter.
Signed-off-by: Emilio Tagua <miloops@gmail.com>
2010-03-31 19:22:44 -03:00
Pratik Naik
5562abb4e9 Dont try to load the record from the db if preloading didn't find anything 2010-03-31 12:56:09 +01:00
Emilio Tagua
8d99ec9a4d Named scopes shouldn't test equality using to_a if it's not an Array, this was causing records to be loaded before they were needed.
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-30 15:36:18 +02:00
wycats
4aded43b73 Replace the placeholder base_hook API with on_load. To specify some code that
should run during framework load do:

ActiveSupport.on_load(:action_controller) do
  # Code run in the context of AC::Base
end
2010-03-29 17:08:50 -07:00
José Valim
56bed512f9 Fix dom_id for ActiveRecord [#4296 state:resolved] 2010-03-30 01:32:26 +02:00
Ernie Miller
63026541b2 Fix honoring :primary_key option when joining or eager loading a belongs_to association
[#765 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-03-29 15:24:27 -07:00
Emilio Tagua
7006aa1a85 Arel now handles ranges with excluded end. 2010-03-29 12:30:13 -03:00
Emilio Tagua
53ddbfc460 Warn scoped order and limit are ignored. [#4123 state:resolved] 2010-03-29 11:30:06 -03:00
wycats
5f7bc47303 Rename modularized_table_name_prefix to full_table_name_prefix [#4032 state:resolved] 2010-03-28 23:45:38 -07:00
Andrew White
67d1cec4c8 Add the ability to specify table_name_prefix on individual modules
Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 23:43:28 -07:00
Aaron Patterson
98d2d8ce2c use the database to lower case strings rather than ruby. [#4293 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 22:16:34 -07:00
David Heinemeier Hansson
a4eab8f1f3 Update example of default_scope to use the new arel finder syntax 2010-03-28 19:11:06 -07:00
Eugene Pimenov
fc6746fc3f PostgreSQL adapter: escape_bytea, quote_string and unescape_bytea aren't thread-safe in Ruby 1.8 [#3237 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 18:04:46 -07:00
Matthew Rudy Jacobs
b0967cc5cf defining a named_scope which overwrites an existing method is now allowed we just log a warning.
This was motivated by the fact that :open is defined on all classes
as such the named_scope "open" can never be used, without hacking
ActiveRecord with an "undef_method" [#4083 state:resolved]

Signed-off-by: wycats <wycats@gmail.com>
2010-03-28 13:53:20 -07:00
Rizwan Reza
f1e5a9ff98 Add :dependent = to has_one and has_many [#3075 state:resolved] 2010-03-28 18:47:46 +04:30
Xavier Noria
76f024ac8d adds missing requires for Object#blank? and Object#present? 2010-03-28 14:15:02 +02:00
Xavier Noria
105f9b8154 adds missing requires for Object#duplicable? 2010-03-28 13:26:13 +02:00
Rizwan Reza
66d57d7ba8 Oops, a docfix. 2010-03-28 11:10:35 +04:30
Rizwan Reza
6c2a0675f1 When creating database with rake, create schemas in schema_search_path if it doesn't exist. 2010-03-28 11:01:15 +04:30
José Valim
ff522cf4bc Revert "primary_key now supports :limit for MySQL". Break Sam Ruby app.
To reproduce, start a new application, create a scaffold and run test suite. [#876 state:open]

This reverts commit faeca694b3d4afebf6b623b493e86731e773c462.
2010-03-27 14:39:43 +01:00
Rizwan Reza
faeca694b3 primary_key now supports :limit for MySQL
Signed-off-by: wycats <wycats@gmail.com>
2010-03-27 03:49:53 -07:00
José Valim
0cb3311d06 Revert "primary_key now supports :limit. [#876 state:resolved]" since it broke AR test suite.
This reverts commit 41e5c7ed44fedb95636ef9b7a792c46ea03309bd.
2010-03-27 11:05:37 +01:00
Aaron Patterson
3172db12e4 avoiding a few closure references by evaling. [#4223 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-27 01:41:44 -07:00
Rizwan Reza
41e5c7ed44 primary_key now supports :limit. [#876 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-27 01:33:42 -07:00
Pratik Naik
68ade93cde Revert "Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved]"
This reverts commit 3a875e618487a06a56f6cf912cf5440f294921cc.
2010-03-27 08:22:32 +00:00
Nathaniel Bibler
3a875e6184 Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-27 00:35:39 -07:00
Kris Selden
afb786ad8a In PostgreSQLAdapter, switch tables query to use current_schemas function [#918 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-26 17:18:33 -07:00
wycats
197904341f Merge branch 'master' into docrails 2010-03-26 15:10:24 -07:00
José Valim
395d6648ce Move application configuration to the application configuration object, remove railtie_name and engine_name and allow to set the configuration object. 2010-03-26 18:47:55 +01:00
Rizwan Reza
5176b28852 Better MySQL Error message. [#3775 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-26 13:25:53 +01:00
chrisfinne
76d2c455c0 Add debugging documentation for _callback_chain to ActiveRecord::Callback
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
2010-03-26 14:01:21 +04:30
Jeremy Roman
ffb22bd2be fix habtm documentation to correct typo
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
2010-03-26 13:35:56 +04:30
Emilio Tagua
d06a754fdd Remove unused attributes_with_quotes method. 2010-03-25 15:47:16 -03:00
Emilio Tagua
fc2e25734a Move methods from association to relation finder methods. 2010-03-25 15:47:06 -03:00
Emilio Tagua
90a4709601 Refactor relation merging to create just one relation and then assign values, instead of creating multiple relation objects. 2010-03-25 13:03:30 -03:00