Commit Graph

5825 Commits

Author SHA1 Message Date
David Heinemeier Hansson
630638b00e Fixed that Routes would raise NameErrors if a controller component contains characters that are not valid constant names #733 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:12:35 +00:00
David Heinemeier Hansson
8cddbf0d37 Added PATH_INFO access from the request that allows urls like the following to be interpreted by rails: http://www.example.com/dispatcher.cgi/controller/action -- that makes it possible to use rails as a CGI under lighttpd and would also allow (for example) Rublog to be ported to rails without breaking existing links to Rublog-powered blogs. #728 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:11:05 +00:00
David Heinemeier Hansson
02df588cf7 Fixed tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 11:50:59 +00:00
David Heinemeier Hansson
b7889524bf Fix empty url_for with nested modules #707
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 01:38:10 +00:00
David Heinemeier Hansson
11a2bb91f5 Added some unit tests #706
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 23:53:55 +00:00
David Heinemeier Hansson
fd6abf0a59 Fixed tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 15:05:04 +00:00
David Heinemeier Hansson
41ea6963a3 Added Base#render_to_string to parse a template and get the result back as a string #479
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 14:57:08 +00:00
David Heinemeier Hansson
2bf29b3485 Added FormOptionsHelper#time_zone_select and FormOptionsHelper#time_zone_options_for_select to work with the new value object TimeZone in Active Record #688 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:54:58 +00:00
David Heinemeier Hansson
cd689cf22b Fixed some tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:52:38 +00:00
David Heinemeier Hansson
f153f42469 Never end generated paths with a '/' #683
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 20:54:40 +00:00
David Heinemeier Hansson
acb3d2cf75 Fixed internal calling
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 00:02:02 +00:00
David Heinemeier Hansson
cf6d77600a Tests and tweaks for components
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:51:59 +00:00
David Heinemeier Hansson
0011116592 Unit tests for rendering components
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:49:12 +00:00
David Heinemeier Hansson
cae0f46eda Fixed a few tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@703 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:21:08 +00:00
David Heinemeier Hansson
9a5d6d6388 Added ActionView::Base.register_template_handler for easy integration of an alternative template language to ERb and Builder. See test/controller/custom_handler_test.rb for a usage example #656 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 17:22:37 +00:00
David Heinemeier Hansson
2a5fc27cea Added AssetTagHelper that provides methods for linking a HTML page together with other assets, such as javascripts, stylesheets, and feeds.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 16:04:50 +00:00
David Heinemeier Hansson
ad1fe7dd27 Completed FormTagHelper by adding radio_button_tag and select_tag
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 13:09:09 +00:00
David Heinemeier Hansson
967339e4d3 Added FormTagHelper that provides a number of methods for creating form tags that doesn't rely on conventions with an object assigned to the template like FormHelper does. With the FormTagHelper, you provide the names and values yourself.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 12:49:14 +00:00
David Heinemeier Hansson
5eac7ad1d9 Updated tests for TextHelper#auto_link
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 12:19:20 +00:00
David Heinemeier Hansson
5760a6cb3e Clear route defaults using :name => nil #663
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:53:18 +00:00
David Heinemeier Hansson
519fe7ccbc Added URL escaping for routing #664
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:52:28 +00:00
David Heinemeier Hansson
37249f6a86 Fixed that assert_template_xpath_matches did not indicate when a path was not found #658 [Eric Hodel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 17:13:57 +00:00
David Heinemeier Hansson
b305756d9f Added TextHelper#auto_link, TextHelper#auto_link_urls, and TextHelper#auto_link_email_addresses to turn those elements into ahrefs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 14:06:36 +00:00
David Heinemeier Hansson
bc574a86ac Skip Active Record tests in Action Pack if the SQLite database cant be brought up
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:28:13 +00:00
David Heinemeier Hansson
02e382a765 More tests for Routing related stuff
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@647 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:00:21 +00:00
David Heinemeier Hansson
6a48e89ae7 Fix that routes werent being loaded in production environment
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 02:04:37 +00:00
David Heinemeier Hansson
29066036f2 Make Routes drop the default for action when the controller changes #651
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 01:46:29 +00:00
David Heinemeier Hansson
b1999be5a7 A hopefully more successful attempt at the Routing branch merge
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:45:35 +00:00
David Heinemeier Hansson
88a3343ed5 Backed out of routing merge.. investigating missing patches
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:24:55 +00:00
David Heinemeier Hansson
c844755e5a Merged back the Routing branch
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 00:51:02 +00:00
David Heinemeier Hansson
65f834ad45 Stringify the parameters on follow_redirect
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 21:54:34 +00:00
David Heinemeier Hansson
61a6a440cb Added follow_redirect method for functional tests that'll get-request the redirect that was made.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 19:35:30 +00:00
David Heinemeier Hansson
098fa94356 Fixed documentation snafus #575, #576, #577, #585
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-07 14:15:53 +00:00
David Heinemeier Hansson
b69d337527 Applied the dblack patch
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 15:35:30 +00:00
David Heinemeier Hansson
80b656637a Added :application_prefix to url_for and friends that makes it easier to setup Rails in non-vhost environments #516 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 13:50:58 +00:00
David Heinemeier Hansson
45db66de56 Added :encode option to mail_to that'll allow you to masquarede the email address behind javascript or hex encoding #494 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 13:48:24 +00:00
David Heinemeier Hansson
dfed3d309e A few missing files
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:55:13 +00:00
David Heinemeier Hansson
2ee84cc6f9 Fixed that all redirect and render calls now return true, so you can use the pattern of "do and return". Added that renders and redirects called in before_filters will have the same effect as returning false: stopping the chain. Added that only one render or redirect can happen per action. The first call wins and subsequent calls are ignored.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:13:34 +00:00
David Heinemeier Hansson
9c09f81bc6 Added arrays as a value option for params in url_for and friends #467 [Eric Anderson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 14:06:33 +00:00
David Heinemeier Hansson
96e54780b3 Fixed that send_file would "remember" all the files sent by adding to the headers again and again #458 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 13:29:49 +00:00
David Heinemeier Hansson
d3a8d5f93c Fixed url rewriter confusion when the controller or action name was a substring of the controller_prefix or action_prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 16:23:18 +00:00
David Heinemeier Hansson
cb8a020ec9 Fixed url rewriter confusion when the controller name was a substring of the controller_prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 15:21:09 +00:00
David Heinemeier Hansson
11f766d3eb Removed authentication framework as xal made me realize that with noradios conditional filters, it was actually more code to use the framework than doing it by hand. Killing a darling! Props to noradio for the patch and xal for the nerve to stand up and question the captain before the plane crashed. Oh, and a pad on my own back for walking away from a couple of hours of work without getting pissy
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:21:29 +00:00
David Heinemeier Hansson
677d92299b Added conditional filters #431 [Marcel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:14:47 +00:00
David Heinemeier Hansson
cbd367b7fa Added :before option to authentication
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 16:43:21 +00:00
David Heinemeier Hansson
75fca04590 Added authentication framework to protect actions behind a condition and redirect on failure. See ActionController::Authentication for more.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 15:20:00 +00:00
David Heinemeier Hansson
0b6fe2244e Taken out as noradio took over
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-08 23:41:42 +00:00
David Heinemeier Hansson
efe0348486 Added the possibility of passing nil to UrlHelper#link_to to use the link itself as the name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@338 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-05 00:38:09 +00:00
David Heinemeier Hansson
3e7a4ecc57 Fixed redirects when the controller and action is named the same. Still haven't fixed same controller, module, and action, though #201 [Josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-02 20:10:11 +00:00
David Heinemeier Hansson
ce58e5cd06 Added DateHelper#select_time and DateHelper#select_second #373 [Scott Baron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-02 15:32:01 +00:00
David Heinemeier Hansson
3b05d412de Fixed some test cases
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-01 16:41:14 +00:00
David Heinemeier Hansson
00deaf6d56 Added :host and :protocol options to url_for and friends to redirect to another host and protocol than the current.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-23 18:59:24 +00:00
David Heinemeier Hansson
d91405a415 Fixed UrlHelper#link_to_unless so it doesn't care if the id is a string or fixnum [zenspider]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 22:50:44 +00:00
David Heinemeier Hansson
a04b1f3d8a Added more informative exception when using helper :some_helper and the helper requires another file that fails, you'll get an error message tells you what file actually failed to load, rather than falling back on assuming it was the helper file itself #346 [dblack]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-22 13:44:16 +00:00
David Heinemeier Hansson
7b5ed66122 Added respondence to *_before_type_cast for all attributes to return their string-state before they were type casted by the column type. Added use of *_before_type_cast for all input and text fields.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-19 11:25:55 +00:00
David Heinemeier Hansson
61960e7b37 Added Request#port_string to get something like ":8080" back on 8080 and "" on 80 (or 443 with https).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-18 18:01:28 +00:00
David Heinemeier Hansson
a7532f9d5f Added Request#domain (returns string) and Request#subdomains (returns array).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-18 17:19:15 +00:00
David Heinemeier Hansson
db6179d12f Fixed DateHelper#date_select so that you can pass include_blank as an option even if you don't use start_year and end_year #59 [what-a-day]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-15 12:47:50 +00:00
David Heinemeier Hansson
c80f974fa3 Added FormHelper#radio_button to work with radio buttons like its already possible with check boxes [Michael Koziarski]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-14 13:48:27 +00:00
David Heinemeier Hansson
922f817a5a Added the option of passing false to :module or :controller_prefix in order to "break out" of a module or prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-13 11:35:48 +00:00
David Heinemeier Hansson
0cce17f811 Updated unit tests to reflect lowercase post as method in form tags
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-13 11:08:21 +00:00
David Heinemeier Hansson
0990c1309d Fixed all helpers so that they use XHTML compliant double quotes for values instead of single quotes [htonl/bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-12 11:31:54 +00:00
David Heinemeier Hansson
85a5deacdc Use lower-case post instead of POST as form method for XHTML compliance #290 [Scott Baron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-12 11:17:25 +00:00
David Heinemeier Hansson
1188d3005a Fixed problem with cookies not being set to path=/ by default and a test buggerboo
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-10 17:16:11 +00:00
David Heinemeier Hansson
e1917cab32 Added link_to_image(src, options = {}, html_options = {}, *parameters_for_method_reference)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-09 23:18:25 +00:00
David Heinemeier Hansson
c8d68dfed3 Killed the out of place alias and made sure you can use the different HTTP methods within the same testaction
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@80 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-08 10:43:24 +00:00
David Heinemeier Hansson
465e0c0c26 Added the possibility of having validate be protected for assert_(in)valid_column #263 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@67 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 12:18:33 +00:00
David Heinemeier Hansson
1e4a936bd0 Trick tests on url_for
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@66 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 12:17:17 +00:00
David Heinemeier Hansson
a544d7aa37 Added all the HTTP methods as alternatives to the generic "process" for functional testing #276 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@58 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-07 11:10:46 +00:00
David Heinemeier Hansson
005371e16c Added options to tailor header tag, div id, and div class on ActiveRecordHelper#error_messages_for [josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@41 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-01 13:59:16 +00:00
David Heinemeier Hansson
50f333b203 Added graceful handling of non-alphanumeric names and misplaced brackets in input parameters [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@39 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-01 12:57:16 +00:00
David Heinemeier Hansson
177cae5483 Allow symbols to be used as names for setting cookies
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@22 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:11:42 +00:00
David Heinemeier Hansson
defda16b83 Allow symbols to be used as keys for setting cookies
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@21 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:09:38 +00:00
David Heinemeier Hansson
d0c90331f1 Added a new container for cookies that makes them more intuative to use. The old methods of cookie and @cookies have been deprecated.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@20 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:04:35 +00:00
David Heinemeier Hansson
db045dbbf6 Initial
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-24 01:04:44 +00:00