TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
43,039 Commits 2 Branches 0 Tags 294 MiB
1497529d05
Commit Graph

2326 Commits

Author SHA1 Message Date
Rafael Mendonça França
7252b43c6e Only some dynamic finders are deprecated. 
find_by_* and find_by_*! are not deprecated for example, so lets add a
note only where it is needed

[ci skip]
 2014-01-16 22:12:37 -02:00
Rex Feng
beeb8969e0 clean up security guide: his => their [ci skip] 2014-01-16 18:57:21 -05:00
Zachary Scott
3d5c4a1647 Remove duplicate configuration option for ActiveSupport [ci skip] 
Fixes rails/rails#13732
 2014-01-16 11:06:10 -08:00
Chulki Lee
1ab6c656d6 Use single quotes in generated files 2014-01-14 11:13:42 -08:00
Carlos Antonio da Silva
028029c1b6 Merge pull request #13705 from mess110/controller_generator_route_quotes 
Single quotes for controller generated routes. This is more consistent with all other Rails generated code.
 2014-01-14 02:13:28 -08:00
Yves Senn
c2a6fc42d2 Merge pull request #13706 from prathamesh-sonpatki/issue-13125 
Fix fields_for documentation with index option [ci skip]
 2014-01-14 01:16:34 -08:00
Prathamesh Sonpatki
3cf5d2b75b Fix fields_for documentation with index option [ci skip] 
- fields_for documentation with index option was wrong.
- It does not work with passing model as it is.
- Changed the example by passing id of the address object.
- Fixes #13125.
 2014-01-14 14:38:07 +05:30
Cristian Mircea Messel
9cdc7c0614 single quotes for controller generated routes 
Write routes in route.rb with single quotes

    get 'welcome/index'

instead of

    get "welcome/index"
 2014-01-14 09:31:51 +02:00
Uday Kadaboina
ad04c2e0b5 [ci skip] Added alias to CSRF 2014-01-14 01:31:23 -05:00
Xavier Noria
e992cd4d91 updates screenshot data [ci skip] 2014-01-13 23:32:04 +01:00
Xavier Noria
7524a9166c revises a few things in the getting started guide [ci skip] 
More to come.
 2014-01-13 23:11:44 +01:00
Rystraum Gamonez
25a9623422 Updated Changelog to reflect removal of :dependent => :restrict 
Based on https://github.com/rails/rails/issues/2502, the option has
been removed.
 2014-01-14 01:29:26 +08:00
Xavier Noria
6049249c6c upgrade SDoc 
Kudos to @zzak for taking over SDoc and make it work with RDoc 4.
 2014-01-12 22:18:44 +01:00
leriksen
951bb848be [ci skip] - error_messages_for has been deprecated since 2.3.8 - lets reduce any confusion for users 2014-01-10 12:08:17 +11:00
Rafael Mendonça França
8a5b480ebb Merge pull request #13582 from schneems/schneems/preserve-connection-behavior 
Ensure Active Record connection consistency
 2014-01-09 14:37:51 -08:00
schneems
6cc03675d3 Ensure Active Record connection consistency 
Currently Active Record can be configured via the environment variable `DATABASE_URL` or by manually injecting a hash of values which is what Rails does, reading in `database.yml` and setting Active Record appropriately. Active Record expects to be able to use `DATABASE_URL` without the use of Rails, and we cannot rip out this functionality without deprecating. This presents a problem though when both config is set, and a `DATABASE_URL` is present. Currently the `DATABASE_URL` should "win" and none of the values in `database.yml` are used. This is somewhat unexpected to me if I were to set values such as `pool` in the `production:` group of `database.yml` they are ignored.

There are many ways that active record initiates a connection today:

- Stand Alone (without rails)
  - `rake db:<tasks>`
  - ActiveRecord.establish_connection
 
- With Rails
  - `rake db:<tasks>`
  - `rails <server> | <console>`
  - `rails dbconsole`


We should make all of these behave exactly the same way. The best way to do this is to put all of this logic in one place so it is guaranteed to be used.

Here is my prosed matrix of how this behavior should work:

```
No database.yml
No DATABASE_URL
=> Error
```

```
database.yml present
No DATABASE_URL
=> Use database.yml configuration
```

```
No database.yml
DATABASE_URL present
=> use DATABASE_URL configuration
```

```
database.yml present
DATABASE_URL present
=> Merged into `url` sub key. If both specify `url` sub key, the `database.yml` `url`
   sub key "wins". If other paramaters `adapter` or `database` are specified in YAML,
   they are discarded as the `url` sub key "wins".
```

### Implementation

Current implementation uses `ActiveRecord::Base.configurations` to resolve and merge all connection information before returning. This is achieved through a utility class: `ActiveRecord::ConnectionHandling::MergeAndResolveDefaultUrlConfig`.

To understand the exact behavior of this class, it is best to review the behavior in activerecord/test/cases/connection_adapters/connection_handler_test.rb though it should match the above proposal.
 2014-01-09 16:35:37 -06:00
Rafael Mendonça França
a67f25d50b Merge pull request #13632 from tinogomes/master 
Adding Hash#compact and Hash#compact! methods
 2014-01-09 10:14:25 -08:00
tinogomes
5121593787 Adding Hash#compact and Hash#compact! methods 
* Adding Hash#compact and Hash#compact! methods
  * Using Ruby 1.9 syntax on documentation
  * Updating guides for `Hash#compact` and `Hash#compact!` methods
  * Updating CHANGELOG for ActiveSupport
  * Removing unecessary protected method and lambda for `Hash#compact` implementations
  * Performing `Hash#compact` implementation - https://gist.github.com/tinogomes/8332883
  * fixing order position
  * Fixing typo
 2014-01-09 16:02:55 -02:00
Jake Worth
de535226e8 Fix typo [ci skip] 2014-01-08 13:47:20 -06:00
Damien Mathieu
a334425caf create/drop test and development databases only if RAILS_ENV is nil 
Closes #13625
 2014-01-08 14:37:07 +01:00
seapy
6c252b5cb9 Fixed typo [ci skip] 
singular is more suited to
 2014-01-08 21:57:25 +09:00
Yves Senn
2229c523aa update 4.1 release notes with deprecation commit link. [ci skip] 2014-01-06 10:00:40 +01:00
Soon Van
44473e49a8 Ruby is a proper noun here, not part of code fragment [ci skip] 
Last line of note also relates heavily to first part
and parenthesis broke reading flow.
 2014-01-05 18:42:14 -05:00
Andrew White
3a48b83e5e Allow an absolute controller path inside a module scope 
Fixes #12777
 2014-01-05 19:58:04 +00:00
T.J. Schuck
72bb3fc297 Change all "can not"s to the correct "cannot". 2014-01-03 17:02:31 -05:00
Yves Senn
97e7ca48c1 Deprecate unused symbolized_base_class and symbolized_sti_name. 
These methods were only used for the `IdentityMap` which was removed.
They are no longer used internally and should be removed without replacement.

As they were not `:nodoc:`'ed it's better to deprecate them before removal.
 2014-01-03 16:31:20 +01:00
Jon Leighton
ff7ab3bc78 Automatically maintain test database schema 
* Move check from generated helper to test_help.rb, so that all
  applications can benefit
* Rather than just raising when the test schema has pending migrations,
  try to load in the schema and only raise if there are pending
  migrations afterwards
* Opt out of the check by setting
  config.active_record.maintain_test_schema = false
* Deprecate db:test:* tasks. The test helper is now fully responsible
  for maintaining the test schema, so we don't need rake tasks for this.
  This is also a speed improvement since we're no longer reloading the
  test database on every call to "rake test".
 2014-01-02 13:49:00 +00:00
Mo Omer
6fc59d38d8 Removed elipsis indicating that the reader should have more code than what is pasted. 
[ci skip]
 2014-01-01 19:00:57 -02:00
Rafael Mendonça França
0b4905d0d5 Make explicit that the view file need to be created [ci skip] 
Closes #13566
 2014-01-01 18:57:18 -02:00
Rafael Mendonça França
a7094f5c88 Do not highlight rake routes output as ruby code [ci skip] 
Closes #13565
 2014-01-01 18:54:55 -02:00
Rafael Mendonça França
e015f4e2e3 Merge pull request #13556 from yahonda/update_mysql_grant 
Update grant statement to address #13549
 2014-01-01 07:38:15 -08:00
Juanito Fatas
aa22ab8ce1 [ci skip] Add missing flash message in block filter example. 
Also make all three examples consistent.
 2014-01-01 21:49:40 +08:00
Yasuo Honda
eb9ced882d Update grant statement to address #13549 2014-01-01 09:25:47 +09:00
Vijay Dev
c4fb191a4c Merge branch 'master' of github.com:lifo/docrails 2013-12-31 22:44:34 +05:30
Steven Nunez
ff47b0518b Update explanation to match example 2013-12-30 09:51:19 -05:00
Ilja Krijger
1196bec8e0 Typo fix [ci skip] 2013-12-28 11:24:01 +01:00
Robin Dupret
a9444916ee Ensure backward compatibility between Minitest 5 and 4 
Define Minitest::Test in case we are running the gist under Minitest 4
and avoid relying on MiniTest::Unit::TestCase to avoid displaying
warning on version five.

[ci skip]
 2013-12-27 11:30:53 +01:00
Yves Senn
aabfba7aa0 doc fix. Use sess.path within open_session. Closes #13490. [ci skip] 2013-12-27 09:35:14 +01:00
Arun Agrawal
fd1c515d4d Minitest::Unit::TestCase is Minitest::Test [ci skip] 2013-12-26 23:55:59 +01:00
Semenyk Dmitriy
46096a082f Fixed typo [CI skip] 2013-12-27 00:28:47 +05:00
Juanito Fatas
b58c8d36b7 [ci skip] Update getting started Ruby version. 2013-12-24 20:33:23 +08:00
Juanito Fatas
7c09ac7104 [ci skip] a destroy action in controller, not delete [getting_stated.md]. 2013-12-24 01:45:15 +08:00
Pavel Pravosud
e1aaa2ff73 Bump Jbuilder version to 2.0.0 2013-12-20 10:35:32 -05:00
schneems
6f1d0b517d [ci skip] trailing documentation whitespace 2013-12-19 20:41:48 -05:00
Guillermo Iguaran
d6ac7d72c5 Merge pull request #13326 from schneems/schneems/add-asset-flag 
Flag `config.assets.raise_runtime_errors` in dev
 2013-12-19 17:39:53 -08:00
schneems
2ff2f1ba52 Flag config.assets.raise_runtime_errors in dev 
By default `config.assets.raise_runtime_errors` should be set to `true` in development for new apps.

Source: https://github.com/rails/sprockets-rails/pull/100
 2013-12-19 20:37:18 -05:00
Lauro Caetano
6de454fb05 Merge pull request #13357 from taryneast/master 
Describe precision + scale in migrations guide
 2013-12-19 14:51:39 -08:00
Taryn East
e2c17cfb2b [ci skip] Describe precision + scale in migrations 
Telling somebody that "precision sets the precision" is not very helpful.
Newbies want to know what precision is *for*, likewise with scale.

So I've added a very brief description for each.
 2013-12-20 08:55:13 +11:00
Rafael Mendonça França
bfdae1775a Make possible to use symbol as the verifier name 2013-12-19 17:06:40 -02:00
Xavier Noria
87fc20a4aa revises the release notes about message verifiers (second take) [ci skip] 2013-12-19 20:01:24 +01:00
Xavier Noria
d0829f46db Revert "revises the release notes about message verifiers [ci skip]" 
This reverts commit 293a1a68992ba3e3e80f9f0f685e866ff79bf11a.
 2013-12-19 19:59:48 +01:00
Xavier Noria
293a1a6899 revises the release notes about message verifiers [ci skip] 
Example code does not run yet with beta1.
 2013-12-19 19:58:40 +01:00
Rafael Mendonça França
33566770ee Merge pull request #13408 from JuanitoFatas/remove-tt 
Remove <tt> tag in 4_1_release notes. [ci skip].
 2013-12-19 10:51:20 -08:00
Juanito Fatas
729f45a209 Remove <tt> tag in 4_1_release notes. [ci skip]. 2013-12-20 02:43:58 +08:00
Vijay Dev
a3b1105ada Merge branch 'master' of github.com:lifo/docrails 2013-12-20 00:10:30 +05:30
Xavier Noria
3968870d31 couple of tweaks to the release notes [ci skip] 2013-12-19 18:24:46 +01:00
Vijay Dev
4dd8b0b548 Revert "Update contributing_to_ruby_on_rails.md" 
This reverts commit 41ba51f4850a8cd2fe69789011ac33366366d32f.

[ci skip]
 2013-12-19 22:51:17 +05:30
Vijay Dev
3351c2d466 Revert "Update security.md" 
This reverts commit f4804fafecdc057988575b4516afe9ca1d5f42fc.

[ci skip]
 2013-12-19 22:51:01 +05:30
Vijay Dev
1406630b21 Revert "Fix on-site markdown rendering [ci skip]" 
This reverts commit 427db6b9d2b35a72f3c017eb19a2e1e800b0a7a3.

[ci skip]
 2013-12-19 22:50:25 +05:30
Vijay Dev
f858691744 Revert "Underscore in markdown should be escaped with backslash [ci skip]" 
This reverts commit b58f3a641795e1777aa3e12a853c34ff512acfb9.

Reason: Discussion in b58f3a6417

[ci skip]
 2013-12-19 22:50:17 +05:30
Xavier Noria
320ac8ef5a pass over half of the release notes [ci skip] 2013-12-19 18:09:28 +01:00
Juanito Fatas
f4e744d38d [ci skip] Remove <tt> tag in 4_1_release notes. 2013-12-19 23:53:16 +08:00
Jared Beck
813ab76788 Update configuring guide with I18n options regarding available locales 
Add information about 'available_locales' and 'enforce_available_locales'
to the configuring guide.

Closes #13202. [ci skip]
 2013-12-19 08:14:51 -02:00
Godfrey Chan
e63748cd37 Merge pull request #13366 from vipulnsward/minitest-namespace-change 
Change all `MiniTest` to `Minitest`
 2013-12-18 19:22:30 -08:00
Sıtkı Bağdat
0add074d37 Fix typo [ci skip] 2013-12-18 12:34:45 +02:00
Godfrey Chan
8a6d40ffc3 Added a link to the Module#concerning docs from the 4.1 release notes [ci skip] 2013-12-18 01:57:36 -08:00
Vipul A M
7bae2921ec Change all MiniTest to Minitest since, MiniTest namespace has been renamed to Minitest 
Ref: https://github.com/seattlerb/minitest/blob/master/History.txt
 2013-12-18 14:39:50 +05:30
Corprew Reed
55f7c8d971 typo: should be 'DateTime.civil_from_format' and not 'DateTime.civil_from_fromat' 2013-12-17 23:18:14 -08:00
Juanito Fatas
24195d17b6 [ci skip] Prettify the removals from Action Controller in 4.1 release notes. 2013-12-18 09:15:40 +08:00
Jeremy Kemper
d3fcaba626 Mention new CSRF protection gotcha in upgrade guide 2013-12-17 15:40:11 -07:00
Jeremy Kemper
626ced225c Discuss Action Pack's new CSRF protection from remote script tags and what it means for your app. In short, update your tests if they don't already use the 'xhr :post' style. 2013-12-17 15:20:28 -07:00
Jeremy Kemper
39ca25f5c4 Merge pull request #13345 from jeremy/get-csrf 
CSRF protection from cross-origin <script> tags
 2013-12-17 12:29:57 -08:00
Jeremy Kemper
1650bb3d56 CSRF protection from cross-origin <script> tags 
Thanks to @homakov for sounding the alarm about JSONP-style data leaking
 2013-12-17 13:14:17 -07:00
Jeremy Kemper
2b096c7170 Merge pull request #13314 from laurocaetano/blacklist_array_methods 
Create a blacklist to disallow mutator methods to be delegated to Array

Conflicts:
	guides/source/upgrading_ruby_on_rails.md
 2013-12-17 11:29:23 -07:00
Yves Senn
bb0bc7a26f Merge pull request #13346 from chancancode/release_notes_etc 
Release notes fixes [ci skip]
 2013-12-17 08:56:27 -08:00
Godfrey Chan
2003d0409e Some assorted fixes for the 4.1 release notes: 
* Added release notes for secrets.yml and mentioned it in the highlights
* Added release notes for Mailer previews and mentioned it in the highlights
* Added release notes for Module#concerning
* Removed mention for AV extraction from the highlights
* Rearranged the major features to put highlighted features first
* Various improvements and typo fixes

[ci skip]
 2013-12-17 08:39:07 -08:00
Carlos Antonio da Silva
ae196e85ee Merge pull request #13341 from carlosantoniodasilva/ca-i18n 
Default I18n.enforce_available_locales to true

We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option.

Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting.
 2013-12-17 08:22:26 -08:00
Lauro Caetano
d4ee09cda1 Create a blacklist to disallow mutator methods to be delegated to Array. 
This change was necessary because the whitelist wouldn't work.
It would be painful for users trying to update their applications.

This blacklist intent to prevent odd bugs and confusion in code that call mutator
methods directely on the `Relation`.
 2013-12-17 13:43:10 -02:00
Yves Senn
998550396f release notes link to fixed versions of the API. [ci skip] 
As discussed with @fxn the release notes are a snapshot document.
The links going out to the API should represent that exact snapshot.
This means we always link to the full final release. For example
the 3.2 release notes link to http://api.rubyonrails.org/v3.2.0.
 2013-12-17 12:19:56 +01:00
Carlos Antonio da Silva
8e21ae37ad Add changelog and upgrading notice related to I18n enforce_available_locales handling 2013-12-17 09:06:56 -02:00
Yves Senn
798da61825 minor doc reword. Upgrade Rails itself not to Rails. [ci skip] 
/cc @chancancode
 2013-12-17 11:21:11 +01:00
Yves Senn
eeda62eac4 use bin/spring in release notes. [ci skip] 
Follow up to: 828a8f2145 (commitcomment-4879462)

This will be available after c6e25804b3
is released.
 2013-12-17 09:43:19 +01:00
Rafael Mendonça França
0dea33f770 Remove the link for code.whytheluckystiff.net 
This is not a valid URL.

[ci skip]
 2013-12-16 16:57:35 -02:00
Jacob Evan Shreve
80dbcf629c Fix url leak in application templates guide 
Encapsulate url that was including the trailing quote and colon.
 2013-12-16 13:43:50 -05:00
Ivan
e838fa068f Added absence parameter to pluralization table 
Added `absence` parameter to table in section `5.1.2 Error Message Interpolation`.
 2013-12-16 10:13:35 +03:00
Rafael Mendonça França
108171a44e Merge pull request #13307 from akshay-vishnoi/typo 
Spelling and Grammar check [ci skip]
 2013-12-15 11:19:44 -08:00
Akshay Vishnoi
c758093eca Spelling and Grammar check [ci skip] 2013-12-16 00:44:37 +05:30
Robin Dupret
fc83efae51 Merge pull request #13181 from fluxusfrequency/patch-4 
Clarification, grammar fixes, punctuation, and capitalization [ci skip]
 2013-12-14 13:33:17 -08:00
schneems
8d005eb867 [ci skip] add assets.raise_runtime_errors flag 
The flag will be used in multiple places to check for errors during runtime if enabled.

Source:  https://github.com/rails/sprockets-rails/pull/100
 2013-12-14 12:44:54 -08:00
Ben Lewis
f95d78e402 Word wrapping engines guide [ci skip] 2013-12-14 13:28:08 -07:00
Ben Lewis
39eb10c3b5 Clarification, grammar fixes, punctuation, and capitalization [ci skip] 2013-12-14 13:27:45 -07:00
Kuldeep Aggarwal
e10f91000b Improved documents [ci skip] 2013-12-14 22:49:00 +05:30
Juanito Fatas
02caba2b86 Improve document: working with javascript in rails [ci skip]. 
* Add form_tag generated output.
* improve some text.
* data-remote='true' should use double quotes.
 2013-12-14 19:22:04 +08:00
Yves Senn
7ce846c177 Merge pull request #13305 from psahni/form_tag_with_parameters 
form_tag with parameters fixed [ci skip]
 2013-12-13 00:59:46 -08:00
Prashant Sahni
330883196b form_tag with parameters fixed [ ci skip ] 2013-12-13 14:03:44 +05:30
Afshin Mokhtari
6353ea4746 fix grammatical error 2013-12-12 17:52:18 -05:00
Xavier Noria
a176bd095c docs guidelines: recommends wording in a way that avoids "you"s and "your"s 2013-12-12 21:48:33 +01:00
Xavier Noria
6814c78b67 copy-edits 68abbac [ci skip] 
* Rewording to avoid "you"s.

* Suggest as first natural alternative to refactor the block
  to evaluate to the returned value.

* Removes the quotes around "filters", since that is a common
  work in our jargon.
 2013-12-12 21:22:37 +01:00
Carlos Antonio da Silva
07fd25c759 Merge pull request #13293 from akshay-vishnoi/typo 
Spelling and Grammar checks [ci skip]
 2013-12-12 08:12:13 -08:00
Rafael Mendonça França
a9b3c8f2b0 Merge pull request #13271 from chancancode/warn_about_using_return_in_as_callbacks 
Warn about using `return` inside inline callback blocks [ci skip]
 2013-12-12 08:10:57 -08:00
Rafael Mendonça França
1454f2c20a Merge pull request #13290 from strzalek/inline-syntax-docs 
Variants inline syntax documentation
 2013-12-12 07:59:17 -08:00
Akshay Vishnoi
5fccd77b6c Spelling and Grammar checks 2013-12-12 18:28:34 +05:30
Łukasz Strzałkowski
3ce9563d42 Variants inline syntax documentation [ci skip] 
* Extend method documentation
  * Mention it in actionpack/CHANGELOG
  * Update release notes
 2013-12-12 13:20:45 +01:00
Yves Senn
5c5d5080b7 Merge pull request #13032 from kuldeepaggarwal/after_touch_documentation 
[ci skip] added after_touch callback documentation [ci skip]
 2013-12-12 03:18:24 -08:00
Kuldeep Aggarwal
bdbb5e3a42 [ci skip] added after_touch callback documentation 
[ci skip] added more explanation for `after_touch` callback
 2013-12-12 16:44:03 +05:30
Aayush khandelwal
10fffd7ae6 typos rectified lifecycle => life cycle 2013-12-12 12:55:35 +05:30
Godfrey Chan
68abbac2fc Warn about using return inside inline callback blocks [ci skip] 
Closes #12981
 2013-12-11 15:58:12 -08:00
Juanito Fatas
a7713765d9 Some improvements on building nested forms. [ci skip] 2013-12-07 02:04:50 +08:00
Prashant Sahni
71a7b1f1d4 capitalize words starting after numbered list to maintain consistency [ci skip] 2013-12-06 11:47:22 +05:30
Arun Agrawal
53fc2f89f6 Using 2.3.11 URL for 2.3.x guides [ci skip] 2013-12-05 17:53:34 +01:00
Yves Senn
d71c1fc6a7 add missing CHANGELOG entry for d8c6f52. [ci skip] 
Discoverd by #13175.
 2013-12-05 11:41:12 +01:00
Yves Senn
64c784f553 end sentences with a .. [ci skip] 2013-12-05 11:33:12 +01:00
Jashank Jeremy
f83dae831f Rails on Rack: Replace an unpleasant grammatical construct. 
[ci skip]
 2013-12-05 15:16:00 +12:00
Rafael Mendonça França
f56e51d4e4 Hightlight message verifier in the release notes [ci skip] 2013-12-04 23:17:18 -02:00
Rafael Mendonça França
05a011bd6b Update the releases notes 2013-12-04 22:56:48 -02:00
Robin Dupret
fe077b50c9 Remove an extra period 
As a side not, the period after etc is not always
needed http://en.wiktionary.org/wiki/etc
 2013-12-04 20:19:10 +01:00
Arun Agrawal
3eab07416a Update guides welcome page to point to version 3.2.16 [ci skip] 2013-12-04 19:54:30 +01:00
Kuldeep Aggarwal
673a8a8dfe update guides to new version of rails 3.2.x[ci skip] 2013-12-05 00:08:02 +05:30
Yves Senn
2e7756aa2f mention Active Record enums as major feature for 4.1. [ci skip] 2013-12-04 17:45:42 +01:00
Ben Lewis
ded25a3353 Formatting, capitalization, and punctuation fixes [ci skip] 
Second try on this commit.
 2013-12-04 07:34:22 -07:00
Yves Senn
bad0386bc0 remove variants paragraph indent in release notes. [ci skip] 2013-12-04 12:03:53 +01:00
Yves Senn
828a8f2145 add Spring as major feature in the 4.1 release notes. [ci skip] 
Follow up to #12958.
 2013-12-04 11:54:34 +01:00
Yves Senn
a25cb53939 minor 4_1_release_notes changes. [ci skip] 2013-12-04 10:00:29 +01:00
Godfrey Chan
3fd0bf4896 Added JSON release notes [ci skip] 2013-12-03 16:21:12 -08:00
Łukasz Strzałkowski
eb0402d512 Add variants to release notes 2013-12-04 00:13:16 +01:00
Victor Costan
ddf27acbc2 Introduce a context for rendering fixtures ERB. 
Fixture files are passed through an ERB renderer before being read as
YAML. The rendering is currently done in the context of the main object,
so method definitons leak into other fixtures, and there is no clean
place to define fixture helpers.

After this commit, the ERB renderer will use a new subclass of
ActiveRecord::FixtureSet.context_class each time a fixture is rendered.
 2013-12-03 02:52:26 -05:00
Carlos Antonio da Silva
b42d4c407d Remove note about removed local_constant_names method from guides [ci skip] 2013-12-02 21:42:48 -02:00
Carlos Antonio da Silva
5fdb594f7b Remove dead comment from AS extensions guide [ci skip] 2013-12-02 21:36:09 -02:00
Carlos Antonio da Silva
f3c2c73336 Fix note about class attribute accessors deprecated file [ci skip] 2013-12-02 21:33:31 -02:00
Juanito Fatas
b0a3d113a3 Add number and range field to form helpers article 
Also wrap surrounding text to 80 chars.

[ci skip] Closes #13132
 2013-12-02 20:29:32 -02:00
Guillermo Iguaran
afbefccf2a Merge pull request #11197 from gsamokovarov/unify-mattr-cattr 
Unify cattr and mattr accessors declarations
 2013-12-02 14:25:16 -08:00
Rafael Mendonça França
0638d329c6 Wrap 80 columns [ci skip] 2013-12-02 20:03:19 -02:00
Rafael Mendonça França
73c1fc531d Add documentation about the Action Dispatch salt configuration 
[ci skip]
 2013-12-02 20:03:12 -02:00
Rafael Mendonça França
a6dfe5f024 Use alphabetic order 
[ci skip]
 2013-12-02 20:02:35 -02:00
Rafael Mendonça França
016eb65d7e ✂️ 
[ci skip]
 2013-12-02 20:02:06 -02:00
Rafael Mendonça França
81abcb7947 Make the release notes consistent [ci skip] 
Conflicts:
	guides/source/4_1_release_notes.md
 2013-12-02 20:01:29 -02:00
Genadi Samokovarov
7dfbd91b07 Unify cattr and mattr accessors declarations 2013-12-02 23:57:20 +02:00
Xavier Noria
d362ee17db Merge pull request #13117 from akshay-vishnoi/typo 
Typo and grammatical fixes [ci skip]
 2013-12-02 06:17:09 -08:00
Yves Senn
f7e527b1f5 Merge pull request #11466 from jetthoughts/updated_tesing_guides 
Fix `rake test` description in the guides [ci skip]
 2013-12-02 06:15:58 -08:00
Akshay Vishnoi
ef0f633c66 Typo and grammatical fixes [ci skip] 2013-12-02 19:35:02 +05:30
Guillermo Iguaran
5b37036b0a Update active_record_querying.md 
he or she => they
 2013-12-02 00:36:29 -05:00
Guillermo Iguaran
8ab24bec2e Merge pull request #13130 from gja/master 
Removing some gender sensitive object pronouns
 2013-12-01 20:43:32 -08:00
Guillermo Iguaran
98af6596a9 Add examples for gender neutral pronouns 2013-12-01 23:40:17 -05:00
Guillermo Iguaran
6f0fb7ba25 Update API docs guidelines with reference about gender neutral pronouns 2013-12-01 23:33:54 -05:00
Tejas Dinkar
223ff7949e [ci skip] Removing some gender sensitive object pronouns 2013-12-02 09:24:47 +05:30
Vipul A M
8700e5f56c Use genderless pronouns in security guide. [ci skip] 
related  #49ff20d9b164693ed7fee880b69cc14b141678b3
 2013-12-02 03:22:31 +05:30
Harshad Sabne
41ba51f485 Update contributing_to_ruby_on_rails.md 
Escape hyphen
 2013-12-01 15:07:21 +05:30
Paul Nikitochkin
28be1a28ea Removed redundant field name in the guide 
Fixes: #13108
[ci skip]
 2013-12-01 08:01:28 +02:00
Sıtkı Bağdat
b13c5013ae Update render with a spacer_template [ci skip] 2013-12-01 04:31:15 +02:00
Paul Nikitochkin
3ab9d01dd4 Add rake test:all, rake test:all:db to guide 
[ci skip]
 2013-11-30 13:38:37 +02:00
Harshad Sabne
f4804fafec Update security.md 
Add escape character for correct rendering
 2013-11-30 15:47:25 +05:30
Yves Senn
d4294fe952 add missing arel dependency to active_record_master bug report script. 
[ci skip].

This solves:

```
Could not find gem 'arel (~> 5.0.0) ruby', which is required by gem 'rails (>= 0) ruby', in any of the sources.
```
 2013-11-29 17:07:24 +01:00
Christophe Maximin
9c7eb40858 Fix URL to robots.txt documentation 2013-11-29 10:56:30 -04:00
Harshad Sabne
abefa2f635 Remove Rdoc formatting from markdown [ci skip] 
Use markdown formatting instead
 2013-11-29 18:56:56 +05:30
Kuldeep Aggarwal
647cff3a13 updating options documentation for associations 
removed unnecessary test case and improved test case for belongs_to having invalid  options
 2013-11-29 18:49:56 +05:30
Bikram
94e688dde5 The section that mentions after_commit and after_rollback will swallow exceptions should me made clear. Made that section to be a instead of a regular paragraph. 2013-11-28 19:10:49 +00:00
Yves Senn
598779b749 no need to explain bundler and rails new in the release notes. [ci skip] 
/cc @fxn
 2013-11-28 18:09:36 +01:00
Yves Senn
f6c1039dd4 delete obsolete KINDLE.md. Closes #13037. [ci skip]. 2013-11-28 17:49:29 +01:00
Yves Senn
7c6d99e81e first pass through CHANGELOGS to extract 4_1_release_notes. [ci skip] 
Extract **notable changes**, **deprecations** and **removals** from
each CHANGELOG.

I tried to reference the commits and pull requests for new features
and deprecations.

In the process I also made some minor changes to the CHANGELOGS.

The 4_1_release_notes guide is declared WIP.
 2013-11-28 17:24:15 +01:00
Yves Senn
8c944dea76 create 4.1 release notes guide scaffold. [ci skip] 2013-11-28 15:49:01 +01:00
Yves Senn
88fec426fc 3.2 to 4.0 section in upgrading guide is no longer wip. [ci skip] 2013-11-28 15:43:28 +01:00
Yves Senn
9bb173cb34 move "HTTP PATCH" paragraph into "Upgrading 3.2 -> 4.0". [ci skip] 2013-11-28 15:43:28 +01:00
Harshad Sabne
427db6b9d2 Fix on-site markdown rendering [ci skip] 2013-11-28 00:03:51 +05:30
Sagar Junnarkar
e7f533e346 Link for "New Post" is added in Getting Started guide [ci skip] 
- Earlier(line number 862) it is said to add <%= link_to 'New post', new_post_path %> on posts index page before table tag. But when posts index page html is shown, "New Post" link is missing.
So aaded "New Post" link in this commit
 2013-11-27 11:23:09 +05:30
Harshad Sabne
b58f3a6417 Underscore in markdown should be escaped with backslash [ci skip] 
In the absence of proper escaping the first link was getting messed up and remaining part of the sentence (2nd link) was not displayed in the rendered markdown on the website though it was displaying correctly in the repository markdown file.
 2013-11-26 23:25:34 +05:30
Yves Senn
36053ce92c sync example and documentation for strong_parameters hash whitelisting. 
[ci skip]

This is a follow up to #12609 and integrates #12158.

Thanks @aspiers.
Closes #12158.
 2013-11-26 14:50:44 +01:00
Vipul A M
66087189c1 Added rewhere usage to AR querying guides 2013-11-25 12:00:46 +05:30
Harshad Sabne
a4bba9ce8d Globalize has moved to a new repository 
From (svenfuchs/globalize3) to (globalize/globalize)
 2013-11-25 11:25:13 +05:30
Xavier Noria
17c29a0df0 Merge remote-tracking branch 'docrails/master' 
Conflicts:
	activesupport/lib/active_support/core_ext/hash/deep_merge.rb
	activesupport/lib/active_support/core_ext/hash/keys.rb
 2013-11-24 20:00:24 +01:00
Xavier Noria
28a6a7ea3b a couple of copy-edits before merging [ci skip] 2013-11-24 19:55:46 +01:00
Martin Harrigan
08c72946c5 Helper should be a module in Rails guides [ci skip] 2013-11-23 11:26:17 +00:00
Harshad Sabne
eb67aa976b API Documentation Guidelines link correction [ci skip] 2013-11-23 10:45:07 +05:30
Jacob Evan Shreve
c796cc2ba7 Added a missing close parenthesis to i18n.md 2013-11-21 22:18:17 -05:00
Jon Leighton
64b9e93bb5 Fix ActiveRecord::Relation#unscope 
I'm pretty confused about the addition of this method. The documentation
says that it was intended to allow the removal of values from the
default scope (in contrast to #except). However it behaves exactly the
same as except: https://gist.github.com/jonleighton/7537008 (other than
having a slightly enhanced syntax).

The removal of the default scope is allowed by
94924dc32baf78f13e289172534c2e71c9c8cade, which was not a change we
could make until 4.1 due to the need to deprecate things. However after
that change #unscope still gives us nothing that #except doesn't already
give us.

However there *is* a desire to be able to unscope stuff in a way that
persists across merges, which would allow associations to be defined
which unscope stuff from the default scope of the associated model. E.g.

  has_many :comments, -> { unscope where: :trashed }

So that's what this change implements. I've also corrected the
documentation. I removed the guide references to #except as I think
unscope really supercedes #except now.

While we're here, there's also a potential desire to be able to write
this:

  has_many :comments, -> { unscoped }

However, it doesn't make sense and would not be straightforward to
implement. While with #unscope we're specifying exactly what we want to
be removed from the relation, with "unscoped" we're just saying that we
want it to not have some things which were added earlier on by the
default scope. However in the case of an association, we surely don't
want *all* conditions to be removed, otherwise the above would just
become "SELECT * FROM comments" with no foreign key constraint.

To make the above work, we'd have to somehow tag the relation values
which get added when evaluating the default scope in order to
differentiate them from other relation values. Which is way too much
complexity and therefore not worth it when most use cases can be
satisfied with unscope.

Closes #10643, #11061.
 2013-11-20 22:23:16 +00:00
Jonathan Baudanza
99eb1eb4df Update caching guide with respect to :namespace 
Cache::Store does not have a default value for :namespace. If it ever did, I can't find it in the git history.
 2013-11-19 17:06:50 -08:00
Carlos Antonio da Silva
20d3484f32 Improve reading / style of hashes in AR guide 2013-11-19 10:54:46 -02:00
Carlos Antonio da Silva
db3ec51832 Revert last two commits mistakenly changing join/include syntax 
---

Revert "syntax error joining/including models"

This reverts commit ac35f72f30c47298a20a90c8c537db888b463bbb.

---

Revert "syntax error joining tables"

This reverts commit c365986b48c3e8bc8c7f3fa6a8521616ed5dc138.

---

Comments:

c365986b48 (commitcomment-4630684)
 2013-11-19 10:46:55 -02:00
Ben Lewis
5019a046c6 Fixed typos in shallow routes and routing concerns 
Grammatical tense correction: "There exists two" => "There exist two".
Plurality correction: "can be reused inside others resources" => "can be reused inside other resources".
 2013-11-18 21:10:21 -07:00
Sergio
ac35f72f30 syntax error joining/including models 
syntax error joining/including models
 2013-11-18 18:39:06 +01:00
Sergio
c365986b48 syntax error joining tables 
syntax error joining tables
 2013-11-18 18:31:37 +01:00
Paul Nikitochkin
251923c7a8 Instrument each load config initializer 
In order to simplify profiling loading of initializers,
added instument for tracking load config initializer event from
`config/initializers`
 2013-11-16 21:47:08 +02:00
Peter Vandenabeele
76d4dd6e05 [ci skip] typo in ArgumentError exception 2013-11-16 15:33:14 +01:00
Rafael Mendonça França
38b312a86f Merge pull request #12907 from JuanitoFatas/upgrading 
[ci skip] Update gem versions for 3.2 and 3.1. Also change some words.
 2013-11-15 18:55:50 -08:00
Juanito Fatas
66e44862bd [ci skip] Update gem versions for 3.2 and 3.1. Also change some words. 2013-11-16 10:24:18 +08:00
Sıtkı Bağdat
324ac5f20b Change Relation#all to Relation#load [ci skip] 2013-11-15 23:31:23 +02:00
Harshad Sabne
4a98938ff4 Update action_controller_overview.md [ci skip] 
Code style adherence
 2013-11-15 22:32:44 +05:30
Rafael Mendonça França
72551c29f2 Merge pull request #10848 from 907th/add_block_to_cattr_reader 
Fix #10847: allow to pass a block to `cattr_reader`.
 2013-11-15 07:13:43 -08:00
Nate Berkopec
7910d7d863 Remove broken Commmand Line guide link 
[ci skip]
 2013-11-15 09:33:49 -05:00
Alexey Chernenkov
0e953c94b1 Unify cattr_* interface: allow to pass a block to cattr_reader. 
Example:

    class A
      cattr_reader(:defr) { 'default_reader_value' }
    end
    A.defr # => 'default_reader_value'
 2013-11-15 19:54:51 +06:00
Godfrey Chan
b090122e8b Make it clear that require 'active_support' is required [ci-skip] 2013-11-13 13:39:34 -08:00
Harshad Sabne
deeeaef6d2 Fix broken Wikipedia link. 2013-11-13 20:48:40 +05:30
Alex Johnson
ea5d3544d2 Remove outdated guide on using rack builder w/o rails middleware 
[ci skip]
 2013-11-13 13:35:10 +05:30
Yves Senn
49245f37f7 Revert "remove_column does not take a type argument. [ci skip]. Closes #12864" 
As of Rails 4.0 `remove_column` is no longer an alias for `remove_columns`.
The type is actually valid and used when issuing a rollback (new `change` method).

This reverts commit 9c9d4948e428a226a19aa92c17fa6ac5833c2fb8.
 2013-11-13 09:02:11 +01:00
Alex Johnson
006f710361 Correct guide relating MiddlewareStackProxy with Enumerable 
[ci skip] Enumerable.instance_methods &
Rails::Configuration::MiddlewareStackProxy.instance_methods # =>
[:as_json]

MiddlewareStackProxy does not share any notable methods with Enumerable.
 2013-11-13 13:30:58 +05:30
Juanito Fatas
825e350faa [ci skip] Fix curl response output and use strong parameters in update action. 2013-11-13 02:33:04 +08:00
Yves Senn
9c9d4948e4 remove_column does not take a type argument. [ci skip]. Closes #12864 2013-11-12 15:56:52 +01:00
Alex Johnson
b9a4560d91 [ci skip] Replace #=> with # => 2013-11-12 19:23:50 +05:30
Alex Johnson
5735a77def Fix RailsServer#start content in initialization guide 
[ci skip]
 2013-11-12 19:14:13 +05:30
Yves Senn
bd004eccfa Merge pull request #12851 from RKushnir/master 
Include URL helpers in TestController in bug report templates [ci skip]
 2013-11-11 12:17:03 -08:00
Roman Kushnir
299fe844dd Include URL helpers in TestController in bug report templates 
[ci skip]

Fixes #12848.
 2013-11-11 21:28:26 +02:00
Xavier Noria
b31b6e6699 Merge pull request #12815 from Adam89/patch-1 
Update security.md [ci skip]
 2013-11-11 07:33:38 -08:00
Jimmy Petersen
f387aa1bdd Fixed typo in migrations guide 
Product model name was pluralized in example in migrations guide.
[ci skip]
 2013-11-11 13:35:57 +01:00
Dmitry Korotkov
bc010e7140 Fix missing line and shadow on static error pages [ci skip] 2013-11-11 11:17:44 +04:00
Jens Dahl Møllerhøj
18010385fd Fixed minor typo 
instead of 'rake test' as shortcut, use 'rake'.

Closes #12780 [ci skip]
 2013-11-09 18:49:50 -02:00
Adam
336caf9114 Update security.md 
Hi Guys 
I was reading through this guide last night and noticed a small mistake, would be great if you could update it. 
I changed the word 'building' to 'build' in line 20. 
"Web application frameworks are made to help developers building web applications"
 2013-11-08 13:43:31 -07:00
Gaurish Sharma
2476f9fcd3 ✂️ fix broken url [ci skip] 2013-11-09 00:01:50 +05:30
Xavier Noria
3d5e83fea4 removes redundant curly brackets in example code [ci skip] 2013-11-08 16:55:15 +01:00
Xavier Noria
f0963a61ad Merge pull request #12609 from corwinkelly/patch-1 
Update workaround for "Outside the Scope of Strong Parameters"
 2013-11-08 07:49:31 -08:00
Alex Johnson
83271a64f9 Add section for command_tasks in initialization guide 
[ci skip]
 2013-11-08 15:14:01 +05:30
Alex Johnson
3d449dee5e Update commands.rb content in initialization guide 
[ci skip]
 2013-11-08 15:07:39 +05:30
Vijay Dev
216ec8d559 Merge branch 'master' of github.com:rails/docrails 2013-11-07 23:32:47 +05:30
claudiob
c61544c781 Add +capitalize+ option to Inflector.humanize 
So strings can be humanized without being capitalized:

    'employee_salary'.humanize                    # => "Employee salary"
    'employee_salary'.humanize(capitalize: false) # => "employee salary"
 2013-11-06 13:03:46 -08:00
Alex Johnson
cb632188b3 Update Rails initialization guide to explain how bin/rails is executed 2013-11-06 18:24:22 +05:30
Derek Prior
0e41b0a87a Clarify HTML Safe Translations [ci-skip] 
I think it's confusing to say "Use them in views without escaping." We
use all keys in views without escaping - the escaping is done for us
automatically _unless_ we call html_safe or the key ends in _html.
 2013-11-05 11:16:04 -05:00
Rashmi Yadav
aa330d0d7a Fixed code syntax for config.ru [ci skip] 2013-11-04 21:55:07 +01:00
Yves Senn
9c4261351c document BACKTRACE env var usage in testing guide. [ci skip] 2013-11-04 17:43:05 +01:00
Carlos Antonio da Silva
e474e47bfa Update guides welcome page to point to version 3.2.15 [ci skip] 2013-11-02 17:31:22 -02:00
laurocaetano
d48222d22e remove warnings on ruby trunk 2013-11-01 18:15:53 -02:00
Rashmi Yadav
49062c12ed exists? is deprecated in ruby trunk [ci skip] 
see here 4d4ff531b8807ee88a3fc46875c7e76f613956fb
 2013-11-01 18:07:27 +01:00
Rafael Mendonça França
bdd518343e Merge pull request #12704 from JuanitoFatas/routing 
[ci skip] Add actions to shallow table, change a tense in sentence, add
 2013-10-31 07:53:01 -07:00
Xavier Noria
cc2a9df970 AS guide: errata 2013-10-31 12:35:08 +01:00
Juanito Fatas
5059769a35 [ci skip] Make all tables have Controller#Action, change a tense in sentence. 2013-10-31 18:45:09 +08:00
Rob Zolkos
2527ce70c5 show javascripts can be disabled in generators 2013-10-31 14:03:57 +11:00
Jeremy Kemper
dae66a0c97 Merge pull request #12203 from chancancode/eager_load_json 
Eagerload active_support/json/encoding in active_support/core_ext/object/to_json
 2013-10-30 10:43:43 -07:00
Alex Johnson
178c4f74f9 Update pull request instructions as per the new Github UI 
[ci skip]
 2013-10-30 13:25:28 +05:30
Xavier Noria
7edaecc475 Revert "add active model basics wip to guides/documents.yaml" 
Reason: WIP guides are not in the index because they are partial
work pushed to the repo. Either there is someone working on them
or else the work was interrupted.

Guides are added to the index page when they are finished, the
author considers the draft to be complete, someone reviews them,
and overall they are considered to be good for users to read.

This reverts commit eefc03a8069bddfe31751c4bd4fb1804e7f33c2c.
 2013-10-29 09:31:53 +01:00
Zachary Scott
97ad84e10d guides/rails_on_rack: Fix formatting of _Internal Middleware Stack_ section 2013-10-28 13:56:36 -04:00
Yves Senn
f85c4c6912 Merge pull request #11564 from zzak/active_model_guide 
[Guides] Active Model Basics [ci skip]
 2013-10-28 09:39:37 -07:00
Rafael Mendonça França
6fb056e3b6 Merge pull request #12578 from jeradphelps/configurable_schema_migrations_table_name 
Configurable name for schema_migrations table

Conflicts:
	activerecord/CHANGELOG.md
 2013-10-27 21:07:03 -02:00
Jerad Phelps
26638f0ac9 added schema_migrations_table_name to ActiveRecord::Base in order that the name of the schema migrations table can be configured. 
consolidated test_schema_migrations_table_name tests

Added changelog entry

edited changelog

removed commented lines

removed reader

ensure the schema migrations table is reset at end of test

added entry to configuration guide

guides typo and changelog order
 2013-10-27 08:50:35 -05:00
Damien Mathieu
a0fe2f1fc8 fix typo introduced when searching in markdown document with vim 2013-10-24 13:33:13 +02:00
Damien Mathieu
b8a538625a rephrase the overriding views part about the view path 
See rails/rails#12608
 2013-10-24 13:30:04 +02:00
Harshad Sabne
a31bb063bc Fixed URL link to rendered_component plugin [ci skip] 2013-10-23 22:32:29 +05:30
Evgeniy
eaed8220c2 [ci skip] second parameter of asset-url is depricated 2013-10-23 20:42:30 +04:00
corwinkelly
872b3c91b3 Fix undefined method error for NilClass 
Add .try to prevent undefined method error for NilClass.
 2013-10-23 07:47:15 -04:00
corwinkelly
1dc9e1ce7f Update workaround for "Outside the Scope of Strong Parameters" 
The previous example of how to permit a hash of unknown keys used .tap, but had the side effect of logging an "Unpermitted parameters" message despite being a successful workaround. The proposed workaround is ever so slightly better, imo, because it won't result in an "Unpermitted parameters" message being logged.
 2013-10-22 16:11:56 -04:00
Harshad Sabne
306651c7b3 Update 4_0_release_notes.md 
Code Highlighted
 2013-10-22 23:09:46 +05:30
David Verhasselt
eb6defbae9 Update docs on Tilt::Template in Asset Pipeline guide 2013-10-21 20:34:11 +03:00
Jay Hayes
614b203e1d Fixes typo 2013-10-20 19:51:19 -05:00
Harshad Sabne
e1e6be920d Update 3_2_release_notes.md 
Code style adherence
 2013-10-20 22:53:08 +05:30
Jay Hayes
da1d2fb483 Update I18n guide to note the additional features of the translate view helper 2013-10-19 10:33:47 -05:00
Rashmi Yadav
d96c5a8782 Updated 3.2.x link [ci skip] 2013-10-18 15:21:38 +02:00
Yves Senn
5824c6d0ed Merge pull request #12218 from dv/add-sass-globbing-to-asset-pipeline-docs 
Add sass globbing to asset pipeline docs [ci skip]
 2013-10-17 06:53:24 -07:00
David Verhasselt
4990a79347 Add Sass gobbling info to asset pipeline docs 
[ci skip]
 2013-10-17 14:32:26 +03:00
Juanito Fatas
01d75f038e [ci skip] Fix number of methods added by association. 
Also clean up some trailing spaces on line 1143-1146.
 2013-10-17 02:45:04 +08:00
Yves Senn
f2ca5aa5c2 Merge pull request #12545 from nateberkopec/rephrase_callback_warning 
Rephrase ActiveRecord transaction rollback warning [ci skip]
 2013-10-16 07:55:47 -07:00
Nate Berkopec
cb609b3975 Rephrase ActiveRecord transaction rollback warning 
[ci skip]
 2013-10-16 10:47:37 -04:00
Vijay Dev
403efc3b3a Merge branch 'master' of github.com:rails/docrails 2013-10-15 23:28:34 +05:30
Sıtkı Bağdat
a94186f836 Remove size alias for length validation 
Removed ```The `size` helper is an alias for `length`.``` line. If you use this "nonexist" helper, you will get an error message like this: 

```
ArgumentError: Unknown validator: 'SizeValidator'
...
```

Maybe wanted to mean ```validates_size_of``` helper as an alias for ```validates_length_of``` helper.
 2013-10-14 22:14:30 +03:00
Rafael Mendonça França
efad3b916f Merge pull request #12493 from drodriguez/patch-1 
Keep code consistent with previous code blocks.
 2013-10-13 10:04:37 -07:00