TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
48,377 Commits 2 Branches 0 Tags 294 MiB
149a98a6f1
Commit Graph

134 Commits

Author SHA1 Message Date
Rafael Mendonça França
aab670b430 redis 3.2.0 doesn't allow tcp protocol anymore 
Use redis protocol
 2014-12-13 00:06:31 -02:00
David Heinemeier Hansson
4419294eaa Include missing require 2014-12-05 15:16:10 +01:00
David Heinemeier Hansson
ad4935f127 Merge pull request #17817 from aripollak/hide-activejob-args 
GlobalID objects are logged by their URI, not #inspect on the object, to prevent logging private data
 2014-12-05 11:05:15 -02:00
Ari Pollak
e2fffbff98 Inline to_global_id conversion 2014-12-04 18:25:05 -05:00
Ari Pollak
e5e44ba8db Use try instead of checking for GlobalID::Identification 2014-12-04 16:51:59 -05:00
Rafael Mendonça França
191ea4b85b Merge pull request #17825 from aripollak/fix-activejob-sidekiq-integration 
Fix Sidekiq ActiveJob integration setup

Conflicts:
	activejob/test/support/integration/adapters/sidekiq.rb
 2014-12-04 18:24:23 -02:00
Ari Pollak
25c8ea264e Only filter GIDable objects; remove cosmetic changes 2014-12-01 11:16:30 -05:00
Erik Michaels-Ober
d1374f99bf Pass symbol as an argument instead of a block 2014-11-29 11:53:24 +01:00
claudiob
96d0f751f9 Bump required Ruby version to 2.1.0 
[This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that:

> Rails 5.0 is in most likelihood going to target Ruby 2.2.

Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383)
that **at least** version 2.1.0 **must** be required by the `gemspec` files.
 2014-11-28 22:59:51 -08:00
Ari Pollak
802630378e Hide potentially sensitive ActiveJob params from logs 
* Show GlobalID instead of full object .inspect output
 2014-11-28 22:20:50 -05:00
Ari Pollak
2fa4cbeebd Fix Sidekiq ActiveJob integration setup 
* .connect on a Redis connection wasn't valid
* Reset logger after we're done testing for redis connection to avoid
  "closed stream" error when starting server for real from a fork
 2014-11-28 17:18:32 -05:00
Rafael Mendonça França
f25ad07f5a Start Rails 5 development 🎉 
We will support only Ruby >= 2.1.

But right now we don't accept pull requests with syntax changes to drop
support to Ruby 1.9.
 2014-11-28 15:00:06 -02:00
Fábio Luiz Nery de Miranda
4f8eb78b1a Add perform_enqueued_jobs 
It will set proper queue_adapter state required by assert_performed_jobs assertions.

Also the block version of assert_performed_jobs will make sure this
state is respected.

Fixes #17684
 2014-11-25 00:24:36 -02:00
yuuji.yaginuma
3e296e7a3a [ci skip] add "Qu" to Backends Features list 2014-11-15 13:48:52 +09:00
Yves Senn
2a843b3538 docs, minor changes in Active Job documentation. [ci skip] 2014-11-10 14:56:07 +01:00
Zachary Scott
77c0256409 Correct fixed-width doc syntax, thanks to @sikachu for pointing it out! 
From dc5854f and c07c0b2 [ci skip]
 2014-11-03 19:31:31 -08:00
Zachary Scott
b049d792bd Document included ability of AJ::QueueName module for class methods [ci skip] 2014-11-03 19:26:04 -08:00
Zachary Scott
7ea0f26801 Add documentation of AJ::QueueAdapter class methods module [ci skip] 2014-11-03 19:25:44 -08:00
Zachary Scott
60fcf60c7b Document AJ::Execution class methods module [ci skip] 2014-11-03 19:23:36 -08:00
Zachary Scott
c07c0b268e Document the module which includes perform_later for AJ::Enqueuing [ci skip] 2014-11-03 19:22:57 -08:00
Zachary Scott
73161c5744 Add documentation for class methods module included for AJ::Core used 
for serialization and deserialization of jobs. [ci skip]
 2014-11-03 19:22:11 -08:00
Zachary Scott
dc5854f382 Document the class methods include module for AJ::Callbacks [ci skip] 2014-11-03 19:21:43 -08:00
rochefort
797a7a7c83 Remove redundant to_s in interpolation 2014-11-04 07:00:24 +09:00
Robin Dupret
1d6d0cc245 Tiny documentation styling fixes [ci skip] 2014-11-02 12:32:50 +01:00
Zachary Scott
26126c8533 Merge pull request #17469 from rishijain/update_docs_2 
added punctuations, and role of queue_adapter module [ci skip]
 2014-11-02 01:21:11 -07:00
Robin Dupret
30c3813cf0 Tiny documentation fixes and styling improvements 
[ci skip]
 2014-11-01 19:36:24 +01:00
Rishi Jain
19f6ac929b placed description at correct place [ci skip] 2014-11-01 10:29:34 +05:30
Rishi Jain
84f313ab5d added punctuations, and role of queue_adapter module [ci skip] 2014-11-01 06:15:13 +05:30
Robin Dupret
aeb431a6ca Tiny documentation improvements [ci skip] 2014-10-31 19:48:42 +01:00
Godfrey Chan
4daebedcc4 Prepare for 4.2.0.beta4 release 2014-10-30 14:12:24 -07:00
Terry Meacham
11ab04b111 Added queue_name_delimiter attribute. 
- Added ActiveJob::Base#queue_name_delimiter to allow for
  developers using ActiveJob to change the delimiter from the default
  ('_') to whatever else they may be using (e.g., '.', '-', ...).

- Updated source guide to include a blurb about the delimiter.
 2014-10-26 21:46:05 -05:00
Yves Senn
5a16b5cd6d Merge pull request #17355 from vipulnsward/aj-string-fixes 
Fix error string raised from AJ enqueue_at for ClassQueueAdapter
 2014-10-23 11:51:01 +02:00
Yves Senn
2e38f83241 Merge pull request #17343 from vipulnsward/inline-aj-callbacks 
Inline AJ around_perform and  around_enqueue in CallbackJob used for tests
 2014-10-23 08:34:15 +02:00
Vipul A M
9494c74a9d - Fix error string raised from enqueue_at 2014-10-22 19:26:46 +05:30
Joe Lewis
8e12371da6 💅 fix typos in activejob queuing test 2014-10-22 06:33:10 -07:00
Vipul A M
588b39e1cd - Inline AJ around_perform and around_enqueue in CallbackJob used for tests. 2014-10-21 11:37:40 +05:30
Rafael Mendonça França
f1e1894101 Merge pull request #17331 from vipulnsward/activejob-cleanups 
Activejob cleanups
 2014-10-20 18:33:47 -02:00
Vipul A M
6ecd33e4e1 - Changed description for AJ enqueuing methods to provide a sane description. 
[ci skip]
 2014-10-21 00:54:03 +05:30
Vipul A M
7b87fb1b64 - Fix mentioned shortcut, to what the shortcut actually is, and that it accepts blocks for assert_no_enqueued_jobs and assert_no_performed_jobs test helpers. 
- args => arguments when used in actual docs.

[ci skip]
 2014-10-21 00:40:59 +05:30
Vipul A M
2965e1671d - Remove duplication in AJ logging test for setting logger. 
- Remove un-needed require in AJ rescue test.
 2014-10-20 12:38:11 +05:30
Vipul A M
c417311c4a No need to specify log level, run at log level as all other Rails components. 2014-10-20 12:36:44 +05:30
Yves Senn
74a527cc63 Merge pull request #17329 from vipulnsward/mention-perform-later-docs 
Mention `perform_now` in AJ base docs to specify how to immediately invoke a job [ci skip]
 2014-10-20 09:04:39 +02:00
Yves Senn
e62554607c docs, It's "Active Job" not "Active job". [ci skip] 2014-10-20 09:00:16 +02:00
Vipul A M
e16592e744 Mention perform_now in AJ base docs to specify how to immediately invoke a job. [ci skip] 2014-10-20 00:26:38 +05:30
Vipul A M
8660853770 - Removed unused variable warnings from ActiveJob Adapters 2014-10-19 23:17:22 +05:30
Vipul A M
16c04040f4 Enable emitting of warnings from ActiveJob tests. 2014-10-19 23:05:03 +05:30
Yves Senn
64e64c6f04 tests, move original_ var assignments outside of begin. 2014-10-10 08:55:17 +02:00
Blake Gentry
4a1dbba108 ActiveJob: allow blank queue names 
As discussed in #17195, Que uses blank queue names by default for
performance reasons. At the very least, ActiveJob should allow users to
choose "" as their queue name. This commit allows blank queue names, as
well as tests to make sure that nil queue names still use the default.
 2014-10-09 19:42:43 -07:00
Ari Pollak
1472e0cf2c Don't pass retry option to Sidekiq 
* This would override whatever default is configured in Sidekiq
  system-wide, and retry is true by default anyway.
 2014-10-08 13:41:38 -04:00
Rafael Mendonça França
ee9f86e2e3 Point to a specific version of guide to make the redirect work 2014-10-08 11:24:16 -03:00