Commit Graph

4451 Commits

Author SHA1 Message Date
James Wen
b8a742673d Clarify description of include_all_helpers config setting's default behavior [ci skip] 2016-04-08 13:39:29 -04:00
Javier Vidal
4da7d6ea2f Fix broken link in 'Ruby on Rails 3.1 Release Notes' [ci skip] 2016-04-08 16:09:12 +02:00
Vipul A M
303456be66 Merge pull request #24465 from y-yagi/remove_needless_entry
remove needless entry [ci skip]
2016-04-08 18:02:24 +05:30
yuuji.yaginuma
d03c90e8aa remove needless entry [ci skip]
The option backed to `start` in da26934313a31ae530b7537aba8a7662152f4dfe.
2016-04-08 21:22:09 +09:00
Roque Pinel
e08232cda2 Fixes for the strong & weak ETags guide [ci skip] 2016-04-07 23:18:50 -04:00
Rafael França
659b104a00 Merge pull request #24444 from prathamesh-sonpatki/update-message-proc-documentation
Update example of passing a proc to `:message` option for validating records [ci skip]
2016-04-06 01:01:50 -03:00
Prathamesh Sonpatki
7f1fc1ee09
Update example of passing a proc to :message option for validating records [ci skip]
- This change is made as the behavior for `:message` proc was changed in
  https://github.com/rails/rails/pull/24119.
- Also check
  https://github.com/rails/rails/pull/24431#issuecomment-206106790 for
  reference.
2016-04-06 09:29:01 +05:30
Rafael França
54ce28017c Fix Active Model basics introduction to indicate it only introduces us to integration and not complete i18n framework.
Fix Active Model basics introduction [ci skip]
2016-04-06 00:55:49 -03:00
Prathamesh Sonpatki
343e2647b3 [ci skip] Fix formatting of code snippet in Action Cable guide 2016-04-05 20:55:58 +05:30
Eileen M. Uchitelle
106851c445 Merge pull request #24419 from rgm/master
Extend `ActionController::TestCase` deprecation warning
2016-04-05 08:07:53 -04:00
प्रथमेश Sonpatki
3108e0809f Merge pull request #24410 from mechanicles/strong-weak-etags-info
Update documentation based on the new changes for strong & weak ETags.
2016-04-05 15:30:03 +05:30
Santosh Wadghule
0287e1fccb Update documentation based on the new changes for strong & weak ETags [ci skip]
- Update info for weak ETag
- Add info for strong ETag
- Add examples for strong and weak ETags
- Display difference between generated strong and weak ETags strings.
2016-04-05 15:28:28 +05:30
Vipul A M
1ed86d2738 Fix Active Model basics introduction to indicate it only introduces us to integration and not complete i18n framework.
[ci skip]
2016-04-05 13:25:24 +05:30
Prathamesh Sonpatki
c89e6926a0 [ci skip] Update code used for filtering passwords in the configuring guide 2016-04-05 12:05:48 +05:30
Vipul A M
c1c6c3878e Guides changes, follow up of #24401
[ci skip]
2016-04-05 11:42:07 +05:30
Ryan McCuaig
58c12900b7 it's => its typo 2016-04-04 19:13:57 -07:00
Arthur Vieira
723a7c8ef4 [ci skip] Fix variable name 2016-04-04 18:17:04 -03:00
Kasper Timm Hansen
7199301a7b Merge pull request #24406 from prathamesh-sonpatki/update-release-notes
Update Rails 5.0 release notes
2016-04-03 22:06:54 +02:00
Vijay Dev
bdcacc8566 Merge branch 'master' of github.com:rails/docrails 2016-04-03 16:51:27 +00:00
Prathamesh Sonpatki
7d88ca6ee5 Update Rails 5 release notes [ci skip]
- Removed entry for # Template Collection from release notes.
- Remove duplicate entry for caching Action mailer views.
- Remove duplicate entry for left_outer_joins.
2016-04-03 22:18:14 +05:30
yuuji.yaginuma
ef6699b6ca remove deprecated datetime_field from guide [ci skip]
`datetime_field` was deprecated in 316811b4d3f4e5a1a7bcd03de97c67218770e333
2016-04-03 07:57:50 +09:00
Javier Vidal
14ba215375 Fixes broken link in 'Ruby on Rails 2.2 Release Notes' [ci skip] 2016-04-01 09:29:26 +02:00
Andrew Babichev
02ead6437e [ci skip] Parameter filter performs regular expression partial matching 2016-03-31 18:15:44 +03:00
Vipul A M
fc959d6efd s/documention/documentation/
[ci skip]
2016-03-29 18:58:10 +05:30
Sammy Larbi
53db086e60 Update how to clear the association cache
Passing `true` to the association has been deprecated.
2016-03-28 09:03:02 -05:00
Arkadiusz Fal
ee640a1f75 [skip ci] Update numericality validation docs
Add `:other_than` option documentation.
2016-03-28 12:22:46 +02:00
Mohamad Abras
8eca8d5808 remove old-dead link 2016-03-27 09:19:56 +00:00
Laura Murphy-Clarkin
2657ec8973 Correct typos in "Active Record Query Interface" guide 2016-03-25 12:27:06 +00:00
Vijay Kumar Agrawal
e6aaa8570a [ci skip] Added missing custom context validation 2016-03-24 19:56:04 +05:30
Olivier Lacan
a2df57c991 Remove reference to unmaintained plugin/gem
[restful-authentication](https://rubygems.org/gems/restful-authentication/versions/1.2.1) hasn't been updated since 
September 6th, 2012 so it might not be a great idea to recommend that Rails users try it out.

Devise seems like a much more popular and secure solution that automatically resets sessions on sign in and out 
so it's a great example in this case. 

/cc @tenderlove @josevalim
2016-03-23 11:21:32 +01:00
Vipul A M
6025714146 s/responsibilty/responsibility/
s/symantically/semantically/

[ci skip]
2016-03-22 20:03:27 +05:30
Vipul A M
5007963e18 - Fixed abrupt start of sentence in changelog
[ci skip]
2016-03-22 19:47:42 +05:30
Yves Senn
2346c7f281 guides, sync 5.0 release notes with changelogs
[ci skip]

Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft.
This is a follow up to c94045d and contains changes made since the
release of beta1.
2016-03-22 14:45:17 +01:00
Yves Senn
c94045dc1c guides, sync railties and AP changelogs with 5.0 release notes.
[ci skip]

This updates the 5.0 release notes guide to reflect changes that
happened after beta1 has been released.

I'll sync the other changelogs later today but I'll push this batch to
prevent against cumbersome merge conflicts.
2016-03-22 12:12:39 +01:00
yuuji.yaginuma
fb1163949a update Active Job default adapter [ci skip]
Follow up to 625baa69d14881ac49ba2e5c7d9cac4b222d7022
2016-03-22 07:45:10 +09:00
Scott Bronson
bcad7cebd4 remove Rails 4 text from asset pipeline guide 2016-03-18 16:19:25 -07:00
Mohamad Abras
ba3a1edca7 use rails 5 favicon.ico for rails guides 2016-03-17 17:20:33 +00:00
schneems
61174c9cea Document and Match the Rails logger interface
The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features.

We are also matching the stdout logging interface to the default logger in bootstrap f5a5988352/railties/lib/rails/application/bootstrap.rb (L42-L45).
2016-03-16 10:34:28 -05:00
Sandeep Navghane
3c688c737b Update action_controller_overview.md 2016-03-15 13:49:40 +05:30
Aaron Ang
798dc5a925 Remove log-related stuff from ActiveSupport::Dependencies
In this patch, all log-related stuff in `ActiveSupport::Dependencies`
is removed because the logging is no longer useful.
2016-03-15 00:54:48 +01:00
Wiehann
36ea7bcc70 Correct command for generating secret_key_base [ci skip] 2016-03-14 17:00:00 +02:00
yuuji.yaginuma
272058b4dc add queue_classic to list of provide provider_job_id [ci skip] 2016-03-14 19:10:09 +09:00
yuuji.yaginuma
0c85ff33b1 add headers to payload list [ci skip]
Follow up to #24115.
2016-03-13 09:40:38 +09:00
Chris Arcand
5147ab121d Clarify has_many :dependent option docs [ci skip]
Clarifies the documentation here to mean all options are for when the
relation is destroyed; also now reflects the documentation on this same
option found in the has_one section.
2016-03-11 16:07:09 -05:00
Greg Molnar
71a3e6634c remove obsolete i18n links from guides [ci skip] 2016-03-10 17:01:03 +01:00
Ryuta Kamizono
7fc10468b6 Remove needless break; [ci skip] 2016-03-10 18:09:01 +09:00
Santosh Wadghule
4300213c01 Remove extra 'the' and unwanted comma [ci skip] 2016-03-08 15:40:29 +05:30
Jon Moss
7c94db1370 Remove incorrect Rack documentation example
`Sprockets` does not respond to the call method, so I changed the
example to use a fake `MyRackApp`.

Closes #22579.

[ci skip]
2016-03-07 12:47:08 -05:00
Vijay Dev
598816f630 Merge branch 'master' of github.com:rails/docrails
Conflicts:
	guides/source/association_basics.md
2016-03-06 06:58:36 +00:00
yuuji.yaginuma
b6618c6cee remove entry for reverted commit [ci skip]
Follow up to ddf4c953ae8d10489e0bfd6008bd76395f6e1267
2016-03-06 11:17:12 +09:00
Rafael Mendonça França
403c57aec0 Update the rendering guide to match the current behavior
In the latest security releases render with a trailing slash no more call
render :file.

Also add a note about the security implications of using it with user
parameters.
2016-03-05 20:07:27 -03:00
Mehmet Emin İNAÇ
325ccb150c Added some useful configuration options into configuring.md [ci skip]
Added information about inserting middlewares with indexes. I think this information useful. We can use indexes also for `insert_after` but the behavior is not same and this is not the right place to give full information about all configuration options.
The configuration for I18n fallbacks is important for production environment. Especially using different fallbacks for different locales.
2016-03-05 22:42:14 +02:00
yuuji.yaginuma
722227a6f6 remove config that are no longer needed in sprockets-rails 3
`config.assets.raise_runtime_errors` and `config.assets.digest` are enabled
by default in sprockets-rails 3.
2016-03-05 12:14:48 +09:00
Sam Ruby
56ed162bf3 Match Puma 3 startup messages [ci skip] 2016-03-04 16:38:34 -05:00
Michael Ryan
3de932281a Fix author callback in engines guide [ci skip]
The `before_save` callback used with `set_author` results in the
validation error "Author must exist," due to the change in `belongs_to`
behavior introduced by #18937.

Use `before_validation` instead.
2016-03-04 12:37:05 -05:00
Jon Moss
8e9a1a62d3 Merge pull request #24021 from y-yagi/add_scaffold_stylesheet_to_guide
add `scaffold_stylesheet` method to guide [ci skip]
2016-03-03 19:29:07 -05:00
yuuji.yaginuma
40dcb477cc add scaffold_stylesheet method to guide [ci skip]
`scaffold_stylesheet` was added in #20479.
2016-03-04 09:14:00 +09:00
Kasper Timm Hansen
2ef8a0e2b8 [ci skip] Make collection caching explicit in guides.
Since f6e4814 was written we've made collection caching explicit.

Thus the documentation is outdated and needs a rewrite.
2016-03-03 20:53:49 +01:00
Santosh Wadghule
ea36c579c6 Change 'a HTTP' to 'an HTTP' [ci skip] 2016-03-03 20:28:01 +05:30
Prathamesh Sonpatki
b5bdcaa838 [ci skip] Update all guides with null: false change in migrations
- We no longer add `null: false` for timestamps columns as per
  rails/rails@a939506.
- Followup of
  14867b1a9a.
2016-03-03 13:54:04 +05:30
Prathamesh Sonpatki
14867b1a9a [ci skip] Update getting started guide for chanages in migrations API
- We no longer add `null: false` for timestamps columns as per
  a939506f29.
- Similarly `references` and `belongs_to` columns no longer mention
  `index: true` in migration files. It's added by default as per
  909818b93b.
2016-03-03 10:32:42 +05:30
Mehmet Emin İNAÇ
57dbf45675 Changed behaviour of timestamps helper by create_table migration generator [ci skip] 2016-03-03 02:31:29 +02:00
Rafael Mendonça França
56f3bbc5b0 Merge pull request #23936 from yui-knk/local_constants_to_be_public
Deprecate `Module.local_constants`
2016-03-01 14:40:17 -03:00
Rafael Mendonça França
bc57930e09 Merge pull request #23417 from sgringwe/master
Add option to error on ignored order or limit
2016-03-01 14:36:32 -03:00
yui-knk
86d4e18958 Deprecate Module.local_constants
After Ruby 1.9, we can easily get the constants that have been
defined locally by `Module.constants(false)`.
2016-03-01 20:34:37 +09:00
Arthur Nogueira Neves
5d84ff53cd Merge pull request #23957 from delftswa2016/fix-documentation-stylesheet
Fix value of CSS background-color property in Ruby on Rails guide
2016-02-29 09:56:23 -05:00
Bas van IJzendoorn
8116770c7b Fix typos in Action View Overview guide
This patch fixes some typos in the Action View Overview section of the Rails guide.

[ci skip]
2016-02-29 11:11:23 +01:00
Bas van IJzendoorn
bb7c8df5b0 Fix value of CSS background-color property in Rails guide
Change background-color value to transparent, which is the default value of background-color.

[ci skip]
2016-02-29 11:10:26 +01:00
Prathamesh Sonpatki
e700f8ebfb Fix formatting in Action Cable guide [ci skip] 2016-02-28 20:49:16 +05:30
Prathamesh Sonpatki
4213825a9a Fix merge conflict in Action Cable guide [ci skip] 2016-02-28 20:16:56 +05:30
David Heinemeier Hansson
2b5d784583 Further cleanup of the cable guide 2016-02-28 15:40:27 +01:00
प्रथमेश Sonpatki
4c43a10acc Merge pull request #23943 from y-yagi/remove_rake_word
remove "rake" word [ci skip]
2016-02-28 19:45:35 +05:30
Prathamesh Sonpatki
2ff63580fe Fix typos in Action Cable guide [ci skip] 2016-02-28 19:42:39 +05:30
David Heinemeier Hansson
4eaaced784 Merge pull request #23176 from davidkuhta/patch-1
Guide for Action Cable
2016-02-28 15:05:36 +01:00
yuuji.yaginuma
21da4cba13 remove "rake" word [ci skip] 2016-02-28 21:04:42 +09:00
yuuji.yaginuma
aaf13f8231 use app:update instead of deprecated rails:update [ci skip]
`rails:update` was deprecated in 6fb31638c8b61731103d4963272755b217a2df87
2016-02-28 15:52:56 +09:00
Jon Moss
65b2cfaddd Merge pull request #23933 from HayleyCAnderson/ha-action-cable-docs-fixes
[ci skip] Add small Action Cable documentation fixes
2016-02-27 15:17:11 -05:00
Hayley Anderson
b425a86591 Add small Action Cable documentation fixes
* Fix typos/grammar errors
* Make capitalization/naming consistent
2016-02-27 13:53:31 -05:00
Arthur Neves
3174b5f92a Update docs to point to new update task.
This guides were pointing to this command `rails app:update`, which I
tried to run, but it didnt worked. I think the right command is `rails
rails:update` instead. Also thats the name of the rake task.

Also I removed the `Rake` word from the title, as we run it using
`rails` bin now.

cc @kaspth
[skip ci]
2016-02-27 12:32:03 -05:00
Kasper Timm Hansen
6fb31638c8 Merge pull request #23439 from ryohashimoto/160203_rake_rails
Use app namespace for framework tasks
2016-02-27 15:14:56 +01:00
Kuldeep Aggarwal
3edab2a56b [ci skip]Add info for specifying logger in different envrionments.
refer 2dc3e81aea8dbc, 56ca2061df83a3
2016-02-27 14:52:36 +05:30
Mikhail Dieterle
d3b1eccff9 [ci skip] fix json output 2016-02-27 09:25:35 +03:00
Ryo Hashimoto
eaec958630 The tasks in the rails task namespace is deprecated in favor of app namespace.
(e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
2016-02-26 19:35:23 +09:00
Prathamesh Sonpatki
a9f50f87c3 [ci skip] Remove reference to Rails 4 in the initialization guide. 2016-02-26 15:52:21 +05:30
प्रथमेश Sonpatki
56ca2061df Merge pull request #23902 from prajakta-tambe/update-debuggings-rails-app-doc
Changed debugging rails app doc.
2016-02-26 15:36:49 +05:30
prajakta
2dc3e81aea - Changed Debugging Rails Applications doc's logger introduction section. Changed location for specifying logger.
[Prajakta, thiagoaugusto]
2016-02-26 15:22:39 +05:30
claudiob
569dc54a15 Doc: update AC::Parameters guides for Rails 5
[ci skip]
2016-02-25 08:22:30 -08:00
claudiob
d57fa1fbf3 Doc: update routes guides for Rails 5
[ci skip]
2016-02-25 08:20:15 -08:00
Andrew White
2fda4e0874 Merge pull request #23874 from st0012/update-documents
[ci skip] Update configuration guide
2016-02-25 13:54:01 +00:00
Kasper Timm Hansen
46cb45df48 Additional review of 6b31761.
* Fixes typos in error message and release notes.
* Removes unused template test file.
2016-02-25 11:13:42 +01:00
Godfrey Chan
73b1efc58f Lock down new ImplicitRender behavior for 5.0 RC
1. Conceptually revert #20276

   The feature was implemented for the `responders` gem. In the end,
   they did not need that feature, and have found a better fix (see
   plataformatec/responders#131).

   `ImplicitRender` is the place where Rails specifies our default
   policies for the case where the user did not explicitly tell us
   what to render, essentially describing a set of heuristics. If
   the gem (or the user) knows exactly what they want, they could
   just perform the correct `render` to avoid falling through to
   here, as `responders` did (the user called `respond_with`).

   Reverting the patch allows us to avoid exploding the complexity
   and defining “the fallback for a fallback” policies.

2. `respond_to` and templates are considered exhaustive enumerations

   If the user specified a list of formats/variants in a `respond_to`
   block, anything that is not explicitly included should result
   in an `UnknownFormat` error (which is then caught upstream to
   mean “406 Not Acceptable” by default). This is already how it
   works before this commit.

   Same goes for templates – if the user defined a set of templates
   (usually in the file system), that set is now considered exhaustive,
   which means that “missing” templates are considered `UnknownFormat`
   errors (406).

3. To keep API endpoints simple, the implicit render behavior for
   actions with no templates defined at all (regardless of formats,
   locales, variants, etc) are defaulted to “204 No Content”. This
   is a strictly narrower version of the feature landed in #19036 and
   #19377.

4. To avoid confusion when interacting in the browser, these actions
   will raise an `UnknownFormat` error for “interactive” requests
   instead. (The precise definition of “interactive” requests might
   change – the spirit here is to give helpful messages and avoid
   confusions.)

Closes #20666, #23062, #23077, #23564

[Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]
2016-02-25 01:19:49 -08:00
Stan Lo
d0c8117ced Add config.debug_exception_response_format into configuration guide 2016-02-25 13:45:09 +08:00
Stan Lo
4e82346756 Update config.force_ssl's documentation 2016-02-25 13:41:09 +08:00
Jon Moss
8b69f1eeba Enable Action Cable routes by default
This also marks Action Cable routes as internal to Rails.
2016-02-24 19:05:03 -05:00
Akshay
afea912a75 [ci skip] Need to mention debug_exception_response_format in the api_app documentation.
- #23771 removed the reference to debug_exception_response_format from the api_app documentation.
- We need to let users know, they have ability to configure debug_exception_response_format in their development environment.
- Added documentation for the same in api_app.md file
- Grammar corrections
2016-02-25 05:03:21 +05:30
Chashmeet Singh
861b98def8 Updated file documentation [ci skip] 2016-02-24 23:13:43 +05:30
Rafael França
edbab4e4f5 Merge pull request #23860 from zerothabhishek/weak-etag-guide
Changes caching guide to add note on weak etags
2016-02-24 14:23:41 -03:00
Abhishek Yadav
a6f8526ee6 changes caching guide to add note on weak etags 2016-02-24 22:48:28 +05:30
Rafael França
38b2f527d0 Merge pull request #23857 from st0012/update-documents
[ci skip] Update guide sources for mailer view caching feature
2016-02-24 14:00:20 -03:00
Stan Lo
5a2d7a1967 Fix wording and wrong reference 2016-02-25 00:53:38 +08:00
Stan Lo
569cb157e7 Fix ActionView's cache section reference 2016-02-25 00:39:04 +08:00
Stan Lo
f7ce370e60 Add caching guide in ActionMailer basics 2016-02-25 00:36:41 +08:00
Stan Lo
bebd9086c8 Add ActionMailer configuration options 2016-02-25 00:17:05 +08:00
eileencodes
dbfa8fdfc2 Preparing for 5.0.0.beta3 release
Adds changelog headers for beta3 release
2016-02-24 11:14:40 -05:00
Stan Lo
ec50f9239b Update 5.0 release notes 2016-02-25 00:07:20 +08:00
David Heinemeier Hansson
ef06afe29a Merge pull request #23795 from claudiob/replace-rack-with-rails-command
AppGenerator: Replace 'rake' with 'rails_command'
2016-02-24 12:09:17 +01:00
David Kuhta
6b515171a8 Header Typo 2016-02-23 21:36:37 -06:00
David Kuhta
f04874f31c stream_for example 2016-02-23 21:05:46 -06:00
Rafael França
8b794c9f1f Merge pull request #23836 from sstephenson/turbolinks-5
Turbolinks 5 compatibility changes
2016-02-23 23:55:56 -03:00
David Kuhta
a946f3930b Explicitly denote that channel.rb is a default file. 2016-02-23 20:35:53 -06:00
David Kuhta
e39d8dd506 Change ActionCable.server.broadcast to XChannel.broadcast_to
Using broadcast directly off server is not recommended
2016-02-23 20:21:05 -06:00
Michael Groeneman
43edcc6c8f [ci skip] No hyphen in 'side effects' 2016-02-23 16:29:42 -08:00
Michael Groeneman
3ea7d02ee6 [ci skip] Fix typo in Form Helpers Guide 2016-02-23 16:05:27 -08:00
Sam Stephenson
2f792616ab Update JavaScript guide for Turbolinks 5 2016-02-23 17:56:42 -06:00
Sam Stephenson
7225f0bb9f Switch to data-turbolinks-track="reload" 2016-02-23 17:55:32 -06:00
Tara Scherner de la Fuente
640ef22b67 update assert_nothing_raised in testing.md 2016-02-22 22:56:23 -08:00
Scott Ringwelski
5d87bb4da8 Add a note about downcasing submit tag
This is a notable change since this will cause confusing test failures for tests relying on the old naming scheme.
2016-02-21 16:05:39 -08:00
claudiob
1a5941e3cf AppGenerator: Replace 'rake' with 'rails_command'
Since Rails 5.0 is switching the Rails command line from 'rake …'
to 'rails …', it makes sense to also replace the `rake` method in
the Rails templates API.

Based on feedback from @matthewd and @kaspth, I chose to replace
`rake` with `rails_command`, which is less confusing than
the alternatives `rails` or `command` or `rails_run` and is not
Thor-reserved word like `task`.
2016-02-20 10:01:55 -08:00
yuuji.yaginuma
9ceb0ea8d9 remove needless debug_exception_response_format config [ci skip]
Since a0343d11f1bf80a79e273c1d0cf9934ef2601e98, `debug_exception_response_format` config depends on `api_only`.
Therefore, if set the `api_only`, need to specify `debug_exception_response_format` is not.
2016-02-19 12:37:09 +09:00
Xavier Noria
042bfb8715 partial pass over the API guide [ci skip] 2016-02-18 23:29:29 +01:00
Rafael Mendonça França
454bc1deab Remove github gems from the master bug report templates
All gems are released now so we don't need to ask the github repository
for these gems anymore.
2016-02-18 15:35:45 -02:00
kamal namdeo
6890043f4c [ci skip] fix suggested change-replace 'an' with 'the in Rails engine guide' 2016-02-18 20:48:19 +05:30
kamal namdeo
dd898fe6a0 Fix the language in engines guide 2016-02-18 13:23:07 +05:30
Prathamesh Sonpatki
e0b401feeb Add Action Cable CHANGELOG in release notes [ci skip] 2016-02-17 12:03:10 +05:30
Chirag Aggarwal
613bda5ad7 [ci skip] Updating edge rails guides to include on_weekday? on Date, Time and DateTime
[ci skip] Adding `on_weekend?` method in edge rails guides
2016-02-17 04:32:20 +05:30
Yves Senn
9d37874732 reset ActionMailer::Base.deliveries in ActionDispatch::IntegrationTest.
Whenever you are sending emails in integration tests using the `:test`
delivery method you need to make sure that
`ActionMailer::Base.deliveries` is reset after every test. This piece of
boilerplate code is present in all my applications that send
emails. Let's have `ActionDispatch::IntegrationTest` reset the
deliveries automatically.
2016-02-16 11:20:59 +01:00
Eileen M. Uchitelle
7c3dc9632b Merge pull request #23688 from meinac/guide_typo_fix
Fix small typo in i18n guide [ci skip]
2016-02-15 09:15:50 -05:00
Mehmet Emin İNAÇ
804b4092e8 Fix small typo in Rails guides [ci skip] 2016-02-15 16:09:11 +02:00
David Heinemeier Hansson
587d70a79b Merge pull request #23687 from vipulnsward/add-on-weekday
Add `#on_weekday?` method to `Date`, `Time`, and `DateTime`.
2016-02-15 14:43:47 +01:00
Vipul A M
02a9e03c35 Add #on_weekday? method to Date, Time, and DateTime. 2016-02-15 18:16:51 +05:30
David Kuhta
55d9a70634 Create action_cable_overview.md resolves #23176 [ci skip]
Rails Guide for Action Cable

Added content from README

Pull additional information from Action Cable README and restructured Client/Server elements

Update to list numbering

Switched from list numbers to headings in the examples
Change AppearancesChannel to AppearanceChannel

Word missing

fixed missing word.

Removed Mistaken nesting of Channel class

Removed nesting of ChatChannel and AppearanceChannel from within ApplicationChannel Module. (Copy&Paste error)

Incorporated first round of comments

1. Capitalize "action cable"
2. Separated "Consumers require... via JavaScript" into two sentences
3. Minor typographical correction (remember...)
4. Extra backtick
5. Revised text which implied Redis was the exclusive storage adapter to reflect it's position as default.
6. Revised reference to denote correct config file location: config/cable.yml
7. Added adapter: redis to environment configuration blocks
8. Capitalized "R" for "Rack"
9. Revised syntax for routing to reflect the hash syntax. (to: NOT :to =>)
10. Removed reference to Action Cable being separate from Rails.
11. Began revision for adapter API [I believe this requires a reformatting of the 'Redis' portion of the configuration section to simply "Storage Adapters"]
12. Celluloid -> Concurrent-ruby

Moved errant grave mark [ci skip]

Reordered "In App" above "Standalone" [ci skip]

Reordered to reflect "In App" as preferable to "Standalone"

Action Cable Deployment [ci skip]

Removed paragraph that alludes to Action Cable not being able to run in the same process as Rails.

Removed EM reference and updated deployment [ci skip]

Removed explicit multi-threaded server dependency reference [ci skip]

Revised Configuration and fixed typos [ci skip]

Switched Lifecycle Graphic for Detailed Description [ci skip]

Switched from Lifecycle graphic to detailed description to facilitate revision and maintainability in the future.

Capitalized Heading (typo) [ci skip]

Implemented merged commits from README [ci skip]

Pulled over all (or at least I believe all) merged commits from README. (Dec 14, 2015 - Feb 11, 2016)

Editorial - Capitalize WebSockets [ci skip]

Reformated lines to ~75 characters [ci skip]
2016-02-14 14:04:41 -06:00
Mikhail Dieterle
c0bbfdb48e [ci skip] fix typos 2016-02-14 19:17:03 +03:00
yui-knk
f847f342f4 [ci skip] Update 'Testing Active Record'
Follow up 8c629bf463b47643712570d4511a68b9a3da1476.
`bundle exec rake test` in 'activerecord' runs tests for

* sqlite3
* mysql2
* postgresql
2016-02-14 13:11:31 +09:00
Xavier Noria
73fb2977ca restores the guides layout header [ci skip] 2016-02-13 17:56:56 +01:00
Jon Moss
f800e00f9a Merge pull request #23660 from meinac/change_x_gzip_to_gzip
Change x-gzip to gzip in docs [ci skip]
2016-02-13 10:28:21 -05:00
Mehmet Emin İNAÇ
2b63f2ee75 Change x-gzip to gzip in docs [ci skip]
For more information about GNU zip mime type please check IETF's web site [RFC6713](http://tools.ietf.org/html/rfc6713) or [IANA](http://www.iana.org/assignments/media-types/media-types.xhtml#application)
2016-02-13 17:11:05 +02:00
Jon Moss
4e80c12de3 Merge pull request #23654 from kamipo/fix_grammar_a_to_an
Fix grammar `a` to `an` [ci skip]
2016-02-13 09:39:34 -05:00
yuuji.yaginuma
f653b3b3a1 add missing name option to flash test example [ci skip] 2016-02-13 21:54:33 +09:00
Ryuta Kamizono
1335959135 Fix grammar a to an [ci skip] 2016-02-13 20:44:44 +09:00
Tom von Schwerdtner
1a61496ae5 Use correct path in documentation.
s/config\/production/config\/environments\/production/

[ci skip]
2016-02-12 13:53:18 -05:00
Kasper Timm Hansen
f709682697 Merge pull request #23612 from vipulnsward/23561-fix-routes-args
Fix argument passing to rake routes
2016-02-12 10:40:04 +01:00
Vipul A M
ef2a8c2391 - Fixed and removed long arguments to rake routes
- Fixed related documentation and usage all around

Fixes #23561
2016-02-12 14:35:57 +05:30
Prathamesh Sonpatki
2c89123b1a Fix numbers of steps to upgrade Rails [ci skip] 2016-02-12 13:38:02 +05:30
Leslie Viljoen
de51b0e707 Improve wording in documentation change
[ci skip]
2016-02-12 11:56:26 +13:00
Leslie Viljoen
4097ed5586 Document the upgrade process
The iterative process one has to follow is not currently documented, and
people could be unfamiliar with the Rails versioning scheme, causing
them to skip versions or upgrade to patch releases.

[ci skip]
2016-02-12 09:52:20 +13:00
Mark J. Lehman
0e6963254a Update active_record_querying.md
Added important distinction between scopes and class methods.
2016-02-10 16:00:22 -08:00
David Heinemeier Hansson
074ff5ce14 Merge pull request #23583 from brchristian/penultimate
Array.second_to_last and Array.third_to_last access methods
2016-02-10 20:45:12 +01:00
Brian Christian
e8aeda2ab3 rename to 'second_to_last' and 'third_to_last' 2016-02-10 10:10:38 -08:00
John Cole
344ddcbc3e Fix typo 2016-02-09 23:07:38 -05:00
Matt Michnal
767f168772 Fixed grammatical errors in rails docs [ci skip]
Fixed errors in rails migrations docs [ci skip]

Fixed errors in rails security docs [ci skip]
2016-02-09 17:57:16 -07:00
Brian Christian
c74045cf07 allow Array.penultimate and Array.antepenultiate access methods 2016-02-09 16:02:08 -08:00
Dave Gynn
836f6f1747 Update documentation regarding initializers [ci skip]
- Remove ActionController `logger` and `initialize_framework_caches`
  which were merged into `set_configs` in fbc9d0f4
- Rename ActiveRecord `set_reloader_hooks` changed in 283a0876
- Add missing initializers for ActionController and ActiveRecord
2016-02-09 14:51:23 -05:00
yuuji.yaginuma
9e70daa941 remove description of render :nothing from guide [ci skip]
`:nothing` option was deprecated in 44781b6e9790d90b4f8b9a41d2b2c114b1a582ee
2016-02-09 14:38:50 +09:00
Abhishek Jain
c2b9a5dbef [ci skip] Fix grammar 2016-02-09 04:16:28 +05:30
Prayag Verma
581c2a6547 Fix a typo
Replace `a` with `an`
2016-02-08 22:40:48 +05:30
Prathamesh Sonpatki
abef3c2b0d Remove references to Rails 4 from assets guide [ci skip] 2016-02-08 08:57:02 +05:30
mabras
f83d57d3e1 update turbolinks url [ci skip] 2016-02-08 03:17:31 +02:00
Larry Kyrala
5015215f9d doc changes
for rails/rails#23431

       modified:   guides/source/asset_pipeline.md
* description of asset combination from apps and gems, e.g. jquery-rails
* after @vipulnsward's related change rails/rails#23479
  correction: --skip-sprockets will prevent all of these gems, not just sass-rails and uglifier

       modified:   guides/source/working_with_javascript_in_rails.md
* noted that rails.js requires the asset pipeline

[ci skip]
2016-02-07 15:42:21 -05:00
Vipul A M
38f6d4e818 Publish guide on "Using Rails for API-only Applications"
Fixes #23322
[ci skip]
2016-02-07 15:28:16 +05:30
Vijay Dev
9a9587ff30 Separate for new and existing applications clearly
[ci skip]
2016-02-07 07:25:03 +00:00
Vijay Dev
bef16522db Merge branch 'master' of github.com:rails/docrails 2016-02-07 07:14:50 +00:00
David Heinemeier Hansson
625baa69d1 Change the default adapter from inline to async 2016-02-05 15:35:37 +01:00
Zachary Scott
be45d2f477 Check off some todos for the Testing guide with @senny [ci skip] 2016-02-05 19:56:23 +09:00
Yves Senn
f5032667f4 docs, remove trailing whitespace from testing guide. [ci skip] 2016-02-05 10:43:38 +01:00
Yves Senn
507a952686 docs, link Rails specific assertions to the API. [ci skip] 2016-02-05 10:42:22 +01:00
yuuji.yaginuma
924f33ad96 add missing include to engine test example [ci skip]
Using url helper method of engine in example code,
include `Engine.routes.url_helpers` is required to use helper method of engine.
2016-02-05 13:09:23 +09:00
Ryuta Kamizono
c9feea6c9a SQLite 2 support has been dropped [ci skip] 2016-02-04 09:23:11 +09:00
Rafael França
6ece7df8d8 Merge pull request #23442 from prathamesh-sonpatki/improve-pg-version-old-error-message
Improve pg version old error message and mention this change in release notes.
2016-02-03 17:05:20 -02:00
Yves Senn
2144c75cf2 Merge pull request #23447 from y-yagi/update_pg_supported_version_in_docs
update supported version of PostgreSQL in docs [ci skip]
2016-02-03 14:26:32 +01:00
yuuji.yaginuma
33681d0001 update supported version of PostgreSQL in docs [ci skip]
Follow up to  #23434
2016-02-03 22:24:29 +09:00
Kasper Timm Hansen
3fed7dd224 Merge pull request #23436 from y-yagi/use_bin_command_in_routes_task
use rails command in routes task
2016-02-03 07:51:27 +01:00
Prathamesh Sonpatki
52b3226a7a Mention PostgreSQL version support in release notes [ci skip] 2016-02-03 10:41:29 +05:30
Ryo Hashimoto
c8ac079413 use rails secret in rails guides 2016-02-03 10:13:38 +09:00
yuuji.yaginuma
fae1724398 use rails command in routes task
For other task has become to use the rails command at doc and test,
I think that routes task also it is better to use the rails command.
2016-02-03 08:17:25 +09:00
Scott Ringwelski
08a7481183 Add initial support for allowing an error on order or limit of queries being ignored in batches
add some documentation and add 4 tests regarding error vs. warning behavior

fix a typo when referring to the message

go back to default in tests so that ordering is not important. use a constant instead of method. fix assert_nothing_raised call. use self.klass to allow per class configuration

remove logger warn assets as that is tested elsewhere. pass error_on_ignore through find_each and find_in_batches also.

add blocks to the finds so that the code is actually executed

put the setting back to default in an ensure

Add a changelog entry
2016-02-02 15:05:16 -08:00
Zachary Smith
789fabf01f Fix typo. 2016-02-02 13:45:12 -07:00
Ryan Nielson
ac1427d6ca Change command_task.rb to commands_task.rb in docs
The initialization documentation references `rails/commands/command_task.rb`. This appears to be a typo as the file is actually `rails/commands/commands_task.rb`.
2016-02-02 09:20:10 -04:00
Sean Griffin
49f6ce63f3 Preparing for Rails 5.0.0.beta2 2016-02-01 14:37:52 -07:00
Kasper Timm Hansen
baae952588 Merge pull request #23225 from vipulnsward/20420-rake-routes-options
Add options for rake routes task
2016-02-01 22:09:22 +01:00
Vipul A M
f3e6e80e13 Merge pull request #23406 from hackerkid/master
.git added to https repo urls
2016-02-02 00:38:34 +05:30
Vishnu Ks
b818fd3b45 .git added to https repo urls 2016-02-02 00:33:46 +05:30
Rafael França
04dea729e3 Merge pull request #23151 from maclover7/fix-23148
Add documentation for #17573
2016-02-01 17:03:17 -02:00
Vipul A M
8a436fdd98 Add options for rake routes task
Add two options: `-c` and `-g`.
`-g` option returns the urls name, verb and path fields that match the pattern.
`-c` option returns the urls for specific controller.

Fixes #18902, and Fixes #20420

[Anton Davydov & Vipul A M]
2016-02-02 00:27:30 +05:30
Vishnu Ks
25cf3f0d7c git protocol replaced with https 2016-02-02 00:12:44 +05:30
Jon Moss
b3427c662e Add documentation for #17573
Fixes some parts of #23148.

[ci skip]
2016-02-01 13:28:30 -05:00
Rafael França
8b2c618cef Merge pull request #23375 from prathamesh-sonpatki/fix-19835
Fix documentation related to `config.assets.cache_store` [ci skip]
2016-02-01 11:00:56 -02:00
Prathamesh Sonpatki
437fa98e63 Fix documentation related to config.assets.cache_store [ci skip]
- sprockets-rails no longer supports customizing cache store after
  rails/sprockets-rails@ecaeb27 using `config.assets.cache_store`.
- Instead we need to configure it using block syntax.
- Fixes #19835.
2016-02-01 15:16:37 +05:30
Rafael Mendonça França
c2079f86f8 Revert "Merge pull request #23366 from maclover7/add-configuation-ar-docs"
This reverts commit 96355e87cba247246234386b0af9273cc5d59db9, reversing
changes made to a00c36feea6c0271b5ad48a949ef294514fdef52.

See https://github.com/rails/rails/pull/23366#issuecomment-177714429
2016-02-01 00:23:43 -02:00
Vipul A M
acddd032d0 Merge pull request #22857 from bdewater/interlock-doc
Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip]
2016-02-01 01:56:43 +05:30
Bart de Water
6cdc36a026 Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip] 2016-01-31 21:18:37 +01:00
Santiago Pastorino
b7a6dc91bc Merge pull request #23368 from y-yagi/remove_backward_compatibility_code_for_minitest_4
remove backward compatibility code for Minitest 4
2016-01-31 15:23:02 -03:00
Ryuta Kamizono
7d67c318f6 Remove odd ` [ci skip] 2016-01-31 16:43:52 +09:00
Jon Moss
3ded07e7c8 Add configuration section to "Active Record Basics" guide
This is to fill in some missing information as apart of #22931.

It's on purpose that the sample `Message` model inherits from
`ActiveRecord::Base` -- Active Record is not meant to be coupled to
Rails, and we can't guarantee that users outside of the Rails world will
have an `ApplicationRecord` class that inherits from
`ActiveRecord::Base`.

[ci skip]
2016-01-30 19:46:00 -05:00
Jon Moss
d2bd7bba8e Small cleanup to Testing Guide
- inbuilt --> built-in
- Remove random spaces from code examples

[ci skip]
2016-01-30 15:10:25 -05:00
Vipul A M
153438f749 Merge pull request #23358 from vipulnsward/testing-guide-pass-3
Pass 3 over testing guide
2016-01-31 01:30:09 +05:30
Vipul A M
c01948cc57 Pass 3 over testing guide
- Various grammar fixes
- Added assertions for update controller action tests
- Added user helper tests
- Fix typos

[ci skip]
2016-01-31 01:28:50 +05:30
Prayag Verma
4663cab624 typo fix [ci skip]
Spelling mistake - direcotry > directory
2016-01-31 00:59:14 +05:30
Mikhail Dieterle
14037b8d8e [ci skip] fix typo 2016-01-30 19:32:23 +03:00
yuuji.yaginuma
92cca41bbe remove backward compatibility code for Minitest 4
The master branch is required Ruby 2.2.2+, for the Ruby 2.2 is bundled Minitest 5.4.3,
I think backward compatibility code for Minitest 4 is unnecessary.
2016-01-30 16:52:09 +09:00
Francis Go
a48f97e0e6 Getting Started Guide: Update Ruby version to 2.3.0p0 2016-01-29 14:18:11 +11:00