Commit Graph

246 Commits

Author SHA1 Message Date
Robin Dupret
2bc88d4f74 Add a changelog entry for #13363 [ci skip] 2013-12-21 14:03:14 +01:00
Rafael Mendonça França
a220b1518d Merge pull request #13059 from imkmf/cycle-accepts-array
Cycle object should accept an array

Conflicts:
	actionview/CHANGELOG.md
2013-12-06 17:05:59 -02:00
Kristian Freeman
1eaa521273 A Cycle object should accept an array and cycle through it as it would
with a set of comma-separated objects.
2013-12-06 10:57:37 -08:00
Andriel Nuernberg
ec19c77ca5 Label only accepts :index and :namespace attributes from the input 2013-12-05 20:27:38 -02:00
Godfrey Chan
2c564cdbdb Added \u2028 \u2029 to json_escape 2013-12-04 09:43:42 -08:00
Godfrey Chan
2f1c5789c1 Fixed a long-standing bug in json_escape that strips quotation marks 2013-12-04 09:27:54 -08:00
Yves Senn
543ccf740d ActionView::MissingTemplate for partials includes underscore.
Missing partial folder/_partial instead of folder/partial.

Closes #13002.
2013-12-02 08:35:34 +01:00
Shimpei Makimoto
1e848906c5 Use set_backtrace instead of @backtrace in ActionView error 2013-11-16 04:41:28 +09:00
Carlos Antonio da Silva
5deec016fe Improve changelogs formatting [ci skip] 2013-11-09 16:44:58 -02:00
pseidemann
881a2cc907 fix simple_format escapes own output when sanitize is set to true 2013-11-08 17:13:59 +01:00
Jérémy Lecour
cdf74eb5a0 Fix typo in the CHANGELOG 2013-10-31 15:29:16 +01:00
Vasiliy Ermolovich
106c988c10 add include_hidden option to collection_check_boxes helper 2013-10-27 18:31:19 +03:00
Brad Murray
6c04cb2261 update changelog 2013-10-15 11:23:37 +13:00
Rafael Mendonça França
0cc4ff77cc Add CHANGELOG entry for #12344
[ci skip]
2013-09-24 21:07:24 -03:00
Bogdan Gusiev
e8e08d69c2 Fix some edge cases for AV select helper with :selected option 2013-09-23 17:48:23 +03:00
Rafael Mendonça França
0e9f0bd6f7 Use ERB in the CHANGELOG [ci skip] 2013-09-23 11:11:26 -03:00
Bogdan Gusiev
57bf92c6de Ability to pass block to AV#select helper
Example:

    = select(report, "campaign_ids") do
      - available_campaigns.each do |c|
        %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name
2013-09-23 14:25:42 +03:00
Vasiliy Ermolovich
0b0ac5d917 handle :namespace form option in collection labels 2013-09-22 21:49:01 +03:00
Daniel Schierbeck
77e79ecd92 Bust the template digest cache key when details are changed
Since the lookup details will influence which template is resolved, they
need to be included in the cache key -- otherwise two different
templates may erroneously share the same digest value.
2013-09-19 10:25:14 +02:00
Rafael Mendonça França
495daef061 Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-as
form_for - fix :namespace and :as options clash

Conflicts:
	actionview/CHANGELOG.md
2013-09-12 18:20:14 -03:00
Rafael Mendonça França
4bdf929579 Write the right CHANGELOG entry for #11603
[ci skip]
2013-09-12 13:25:21 -03:00
Adam Niedzielski
e18f045b65 form_for - fix :namespace and :as options clash
:as option should not overwrite :namespace option when
generating html id attribute of the form element. id should be prefixed
by specified namespace even if :as option is present

Add test case showing the issue and code fixing it
2013-09-09 07:59:07 +02:00
Paul Nikitochkin
061e48df26 Cleanup of excerpt helper
* replaced String concatenation by joining
* separator has default value to '', even it is nil
2013-09-06 18:00:55 +03:00
Rafael Mendonça França
974335d4d0 Improve CHANGELOG entry [ci skip] 2013-08-27 14:10:45 -03:00
Josh Lauer
7e74a01f84 Only cache template digests if config.cache_template_loading
since ActionView::Resolver.caching is set to the same value as config.cache_template_loading
only cache template digests if config.cache_template_loading is not falsy
fixes issues #10752 and #10791
2013-08-06 14:06:42 -04:00
Nathan Stitt
0855f041df Add "extname" option to javascript_include_tag
ActionView::Helpers.asset_path is where the logic for
javascript_include_tag resides.  It takes an extname option for
specifying the extension or false to not append it.  This exposes that
option to javascript_include_tag.

Without the option files that didn't end with ".js" would get the
extension appended to them.  This broke JST templates and other file
types that should be interpreted as JavaScript but who's file extension
isn't ".js"
2013-08-03 09:30:06 -05:00
Rajarshi Das
36aaf46372 fix the changelog typo[ci skip] 2013-08-02 12:33:35 +05:30
Rafael Mendonça França
69339e54d3 Fix current_page? when the URL contains escaped characters
In some cases webservers like nginx send the escaped characters
lowercased to the Rails application. The current_page? helper was
comparing the escaped strings that are different since Ruby escapes the
URL using uppercased characters.
2013-08-01 10:46:35 -03:00
Joel Cogen
1424873948 text_area should handle nil value option like text_field 2013-07-24 08:39:17 +02:00
Carlos Antonio da Silva
c23c193a84 Fix changelog syntax and use Ruby 1.9 hash style [ci skip] 2013-07-22 14:36:09 -03:00
Vasiliy Ermolovich
cadfe4bf45 add support for html attributes to grouped_options_for_select 2013-07-20 17:14:28 +03:00
Rafael Mendonça França
ebc5bdb8e7 Use the canonical router on the CHANGELOG entry
Thanks @egilburg

[ci skip]
2013-07-18 10:35:15 -03:00
kennyj
ca85caca0d Fix default rendered format problem when calling render method without :content_type option. Closes #11393. 2013-07-15 02:11:43 +09:00
Rafael Mendonça França
b18a27375a Add CHANGELOG entry for #11348 2013-07-07 14:26:20 -03:00
Rafael Mendonça França
09f6fe1cd4 Fix "Stack Level Too Deep" error when rendering recursive partials
When rendering recursive partial Action View is trying to generate the
view digest infinitly causing a stack level error.

Fixes #11340
2013-07-07 13:44:16 -03:00
Takayuki Matsubara
06388b0779 Added an enforce_utf8 hash option for form_tag method
Control to output a hidden input tag with name `utf8` without monkey
patching

Before:

    form_tag
    # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>'

After:

    form_tag
    # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>'

    form_tag({}, { :enforce_utf8 => false })
    # => '<form>....</form>'
2013-07-07 23:49:38 +09:00
Carlos Antonio da Silva
6b9356a4b7 Remove the deprecated include_seconds argument from distance_of_time_in_words
Pass in an :include_seconds hash option to use this feature.
2013-07-02 22:46:23 -03:00
Vipul A M
38aafc0377 Remove FormBuilder deprecation warning about block argument and associated tests 2013-07-02 02:06:39 +05:30
Jon Rowe
53eb9fdd9c fetch value(s) from stringified options 2013-06-29 19:32:13 +10:00
Carlos Antonio da Silva
e16ad2db8c Review AV changelog [ci skip] 2013-06-27 15:39:17 -03:00
kennyj
94c72c45bb Remove passing the prompt to grouped_options_for_select as an argument, because it was deprecated. 2013-06-28 03:11:00 +09:00
Rafael Mendonça França
035e2976d0 Add CHANGELOG entry for #10971
[ci skip]

Conflicts:
	actionpack/CHANGELOG.md
2013-06-24 16:21:54 -03:00
Łukasz Strzałkowski
d1fb5d5949 Adjust changelog for AV & AP 2013-06-20 19:06:52 +02:00
Łukasz Strzałkowski
1d59e94cea Remove heading from AV's CHANGELOG 2013-06-20 19:01:26 +02:00
Piotr Sarnacki
5bcdf4faa6 ActionView version should be 4.1.0 2013-06-20 17:23:15 +02:00
Piotr Sarnacki
78b0934dd1 Add bare actionview gem to the root directory
This commit creates structure for Action View gem and is first of a
series of commits extracting Action View from Action Pack.
2013-06-20 17:23:15 +02:00