TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
49,731 Commits 2 Branches 0 Tags 294 MiB
1747c4e2ce
Commit Graph

66 Commits

Author SHA1 Message Date
Vipul A M
5cfaf5a46e - Changed IN to ON in markdown renderer condition 
- Changed `IN` to `ON` in all note sentences in guides.
 2015-01-14 11:52:13 +05:30
Josh Cheek
2d1f4033ab Un-inline if statement 
The single line was long enough that it rendered on two lines,
causing the example to look like syntactically invalid code.
 2014-12-29 12:59:05 -07:00
Dan Bernier
65158a6701 Fix bug in ActionMailer guide. 
When setting a mailer's default from address, you have to pass a hash
with a `:from` key; you can't pass just an email address.
 2014-12-24 16:12:47 +00:00
Xavier Noria
7702974281 warn about reading guides in GitHub 
References #18148.
 2014-12-23 23:32:50 +01:00
yuuji.yaginuma
c15d3fb0da [ci skip] fix description of url_for 2014-11-30 10:18:07 +09:00
Guo Xiang Tan
ec49324bd7 Update docs to reflect changes to MailerGenerator. 2014-11-25 09:56:49 +08:00
Juanito Fatas
49f8356f33 [ci skip] Fix code snippet display in Action Mailer Basics guide. 2014-09-16 15:32:38 +08:00
Logan Hasson
3941b8da9f [ci skip] Clarify Action Mailer/Active Job usage note 2014-08-21 10:55:50 -04:00
Cristian Bica
9e7f4a94ca Updated rdoc / guides / release notes related to ActiveJob / ActionMailer 2014-08-20 17:48:34 +03:00
@schneems and @sgrif
2bbcca004c Deprecate *_path methods in mailers 
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.

Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.

Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.

The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.

Paired @sgrif & @schneems
 2014-07-30 12:01:45 -05:00
Sam DeCesare
fd984e8500 fix bug in email with name example code 
The display name in the email "to" field needs to be quoted otherwise
your email-sending service will fail when trying to deliver mail to
user's with commas in their name (i.e. John Smith, M.D.).
 2014-06-11 17:41:06 -07:00
Juanito Fatas
2e1903822a [ci skip] Refine Action Mailer guide. 
* Wrap 80 words if possible.
* Make attachment hash options more readable. (L239-L243)

  Before:

  ![screenshot 2014-06-11 02 59 54](https://cloud.githubusercontent.com/assets/1000669/3235432/a91d0464-f0d2-11e3-9e4a-6af2b2a83f1a.png)

   After:

  ![screenshot 2014-06-11 02 59 36](https://cloud.githubusercontent.com/assets/1000669/3235428/a47b28dc-f0d2-11e3-806c-cfaedd3f15df.png)

* L619 Wrap "location" in code: `"location"`.
* L628 Use actual section name.
* L697 Remove unnecessary `./` when refer to other guide.
 2014-06-11 03:13:10 +08:00
Josef Šimánek
981dda53db Use generated binstubs in guides examples. 
[ci skip]
 2014-05-20 13:29:18 +02:00
Yves Senn
75cd7bc3c2 Merge pull request #13728 from semenyukdmitriy/master 
Added missing `file` delivery method to the Configuration Guide
 2014-01-22 01:53:30 -08:00
Semenyuk Dmitriy
9e63ead4ae [ci skip] Added missing file delivery method 2014-01-22 15:50:01 +06:00
Yves Senn
080fc9cad3 docs should say email not Email. [ci skip] 2014-01-20 15:04:36 +01:00
Yves Senn
dfac4ced1d docs, hyperlink the Mail gem in Action Mailer guide. [ci skip] 2014-01-20 14:47:40 +01:00
AvnerCohen
f381759430 Minor align BR tags with HTML void - with reference to the generators code change - f038d4cc5f 2013-10-09 14:42:33 +02:00
Paul Nikitochkin
2c8bc2cdcd Use Ruby on Rails Coding Conventions for code examples in the guides 
* Indent after private/protected
* Ruby >= 1.9 syntax for hashes
* Prefer method { do_stuff } instead of method{do_stuff} for single-line blocks.

[ci skip]
 2013-09-06 21:42:29 +03:00
Peter Jaros
2e0a9941a8 AM Guide: Should be "different formats". 2013-07-24 15:23:48 -04:00
Cristian Planas
93fd780a88 Using preferred find_by syntax in guides 2013-07-01 01:38:46 +02:00
Robin Dupret
59efb76306 Remove a duplicated section [ci skip] 
Attachments were previously covered so remove the useless part. Just
move a note about multipart headers set when the mail method is
triggered to the kept section.
 2013-06-29 19:14:09 +02:00
Kyle Fritz
6f30110cb4 correct no-replay@example.com to no-reply@example.com 2013-05-29 14:46:07 -03:00
Sunny Ripert
53607be559 Remove double spaces in guides 2013-05-28 14:38:02 +02:00
Sunny Ripert
606c09b8db Consistent use of one space only after punctuation 2013-05-28 14:38:02 +02:00
Fiona Tay
1c204fcdad Make guide description more concise 2013-04-21 01:05:29 -07:00
Vijay Dev
b15ce4a006 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	guides/source/action_mailer_basics.md
 2013-04-11 22:58:14 +05:30
Yves Senn
d4ae49b058 get the Action Mailer guide ready. [ci skip] 2013-04-09 20:06:46 +02:00
Jonathan Roes
bff281e759 Proofreading tweaks to the Mailer guide 2013-04-01 13:53:21 -03:00
Yves Senn
b662cb89ce move mailer testing examples into the testing guide. 
Closes #9325.

I adjusted the example and the description in the testing guide and
simply linked from the mailer to the testing guide. This way we don't
have to maintain two separate places.
 2013-03-25 19:46:44 +01:00
Vijay Dev
be3e402c79 copy edits [ci skip] 2013-03-10 00:06:51 +05:30
Fabrizio Regini
1fe5d36e11 Adding a note for :body option in mail method. 2013-03-08 23:29:58 +01:00
Carlos Antonio da Silva
a87687e5fd Merge pull request #9359 from justinwb/master 
Removed template_root as a configuration option
 2013-02-27 04:31:06 -08:00
Qihuan Piao
5d631475a1 Update guide doc to use migration shortcuts 2013-02-25 00:38:46 +09:00
Qihuan Piao
a1dd468b1c Wrap around_action word with <code> tag 2013-02-25 00:29:03 +09:00
Justin Bingham
063ba216c0 Removed template_root as a configuration option 
Removed template root from actionmailer configuration options as it seems to have been pulled out completely in favor of explicit definition via template_path / template_name.
 2013-02-21 10:40:34 -05:00
José Valim
474e7dd82a Merge pull request #9084 from senny/document_am_delivieries_reset 
document the behavior of `ActionMailer::Base.delivieries` in tests
 2013-01-26 08:14:26 -08:00
Yves Senn
18dceeb425 document the behavior of ActionMailer::Base.delivieries in tests 
thanks @danielpuglisi
 2013-01-26 17:05:58 +01:00
Yves Senn
7e6e4f2547 document how to create custom rails environments 2013-01-21 20:38:04 +01:00
Akira Matsuda
9da9763e0a s/it's/its/ 
[ci skip]
 2013-01-18 17:17:59 +09:00
Yves Senn
29a69cde0c spelling correction for AM interceptors 2013-01-17 14:25:56 +01:00
Yves Senn
a7772405dc document Intercepters in ActionMailer guide 2013-01-16 20:51:04 +01:00
Jeremy Kemper
009873aec8 Introduce ./bin for your app's executables: bin/bundle, bin/rails, bin/rake. Executable scripts are versioned code like the rest of your app. To generate a stub for a bundled gem: 'bundle binstubs unicorn' and 'git add bin/unicorn' 2013-01-06 21:41:36 -07:00
Jeremy Kemper
f9da785d0b Move background jobs to the 'jobs' branch until fully baked. Not shipping with Rails 4.0. 2012-12-21 16:29:47 -08:00
Andy Lindeman
5c2eb889c2 config.action_mailer.async is no longer used 2012-12-10 13:43:29 -05:00
Vijay Dev
0a33fcd68b Merge branch 'master' of github.com:lifo/docrails 2012-12-08 23:11:37 +05:30
Steve Klabnik
350b122ecc Remove reference to background queue in mailer guide. 
Mailers are always async now, and we already discuss
queueing lower down in the guide.
 2012-12-07 23:22:51 -08:00
Steve Klabnik
ed78770b1a Remove references to Rails versions. 
There's no reason for guides to reference old behaviors. They should
be current as of the versions of Rails that they ship with, and including
older information just clutters thing.

I discussed this change with @fxn and he agrees.
 2012-12-07 23:20:35 -08:00
Francesco Rodriguez
f19e41fb16 update guides to use _action callbacks [ci skip] 2012-12-07 23:43:46 -05:00
Katie Oldaker
fc6336d1be Punctuation, capitalization, grammar fixes in rails guides 2012-12-07 16:32:06 -05:00