Commit Graph

1782 Commits

Author SHA1 Message Date
Joshua Peek
181cd109d9 Lookup ruby bin name too 2009-09-14 00:51:31 -05:00
Joshua Peek
c5a6de50bb Use rbconfig instead of rubygem detection 2009-09-14 00:47:09 -05:00
Joshua Peek
ec01cc4510 For testing, only load rubygems if mocha is missing 2009-09-14 00:41:04 -05:00
Joshua Peek
27458464d6 Forgot to update load path dir for vendored memcache 2009-09-14 00:09:34 -05:00
Jeremy Kemper
fa1e6dc577 Skip parent isolation tests too 2009-09-13 21:37:31 -07:00
Joshua Peek
a42c8958f9 Bump vendored memcache to 1.7.5 2009-09-13 23:30:32 -05:00
Joshua Peek
b2f0b8cbda Rollback AS bundler work and improve activation of vendored dependencies 2009-09-13 22:55:46 -05:00
Joshua Peek
6f9e449830 Callbacks need to require reporting 2009-09-13 21:56:10 -05:00
Joshua Peek
8c8e09c305 Restore AS vendor file until we get things sorted out in railties 2009-09-13 21:07:35 -05:00
Joshua Peek
199a423f42 Don't eager require mocha, AS unit needs to set stuff up first 2009-09-13 16:12:33 -05:00
Joshua Peek
fff3f0ae0c Detect missing dependencies and automatically run bundler 2009-09-13 15:10:29 -05:00
Joshua Peek
5b8373da29 Shush interpolation warnings 2009-09-13 14:34:59 -05:00
Joshua Peek
3b6bb4664f Forget about old memoize immutable behavior 2009-09-13 13:08:12 -05:00
Joshua Peek
870bf8950f Load vendored i18n if its not found since its a real requirement 2009-09-13 12:49:22 -05:00
Joshua Peek
ec0d4efd79 Avoid referencing rubygems 2009-09-13 12:47:37 -05:00
Joshua Peek
f3f2e0b00d Move AS vendor support into bundler.
Run `rake bundle` before running tests.
2009-09-13 12:24:50 -05:00
Joshua Peek
3b325d624c require reporting before attempting to "shush" 2009-09-13 10:53:12 -05:00
Jeremy Kemper
941e990410 Shush, new_callbacks 2009-09-13 06:06:20 -07:00
Jeremy Kemper
c2018b4b7b Shush, rexml 2009-09-13 05:57:44 -07:00
Jeremy Kemper
7e6652edbf Prefer not to shadow a local 2009-09-13 05:56:21 -07:00
Jeremy Kemper
98f96a0809 Ignore isolation test tests for test-unit 2 also 2009-09-13 05:52:18 -07:00
Jeremy Kemper
053a0f6ac4 Clean up spurious JSON decoding test failure 2009-09-13 05:43:02 -07:00
Jeremy Kemper
7d2add8c96 Ruby 1.9 compat: fix regexp slice test 2009-09-13 05:31:43 -07:00
Jeremy Kemper
cce2112f12 Silence warning for Encoding.default_external= 2009-09-13 04:48:40 -07:00
Jeremy Kemper
91ffddca57 Use Encoding.default_external, not _internal 2009-09-13 04:43:41 -07:00
Jeremy Kemper
091486fb98 activesupport -> active_support 2009-09-13 02:45:37 -07:00
Aaron Patterson
f959758687 making secure_compare faster
[#3195 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-09-13 02:44:52 -07:00
Michael Koziarski
e590508a9b Dup the arguments to string compare so we can use force_encoding. 2009-09-13 10:36:04 +12:00
Yehuda Katz
a8a336cbfc Revert "ruby 1.9 friendly secure_compare" because it breaks CI and Sam Ruby's suite
This reverts commit 5de75398c495f109772b622291362a98bc6c21d1.
2009-09-12 14:35:03 -05:00
Jeremy Kemper
8682d76cc9 Revert "Allow frameworks to be required by their gem name"
This has just been confusing. Better to educate than band-aid.

This reverts commit 18a24274ec823ded4ffa29bf33fd3d76816aab7e.
Originally from http://dev.rubyonrails.org/ticket/8845 [drnic]
2009-09-12 02:41:01 -07:00
Jakub Kuźma
b22c951e7a ruby 1.9 friendly secure_compare
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-09-12 12:48:34 +12:00
Beau Harrington
38d65b03d6 Remove redundant checks for valid character regexp in ActiveSupport::Multibyte#clean and #verify.
[#3181 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-09-10 17:36:54 -07:00
José Valim
2ea1d684d9 Refactor new callbacks and AR implementation.
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-09-08 10:26:39 -05:00
José Valim
4f37b97033 Changed ActiveRecord to use new callbacks and speed up observers by only notifying events that are actually being consumed.
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-09-08 10:26:39 -05:00
Jeremy Kemper
aeab739bd5 Ruby 1.9: fix MessageVerifier#secure_compare 2009-09-08 14:05:33 +09:00
Joshua Peek
47aebacd51 Please 1.8.6 CI 2009-09-07 21:56:53 -05:00
Joshua Peek
fe68cf2784 Fix failing AS isolated tests 2009-09-05 18:31:10 -05:00
Joshua Peek
ca2f2d1800 Turn warnings on for AS isolated tests 2009-09-05 18:24:58 -05:00
Michael Koziarski
87c93da440 Fix a messed up merge commit 2009-09-04 14:28:32 +12:00
Michael Koziarski
9a73630d93 Add verify and clean methods to ActiveSupport::Multibyte.
When accepting character input from outside of your application you can't
blindly trust that all strings are properly encoded. With these methods
you can check incoming strings and clean them up if necessary.

Signed-off-by: Michael Koziarski <michael@koziarski.com>

Conflicts:

	activesupport/lib/active_support/multibyte.rb
2009-09-04 09:25:38 +12:00
Coda Hale
5e6dab8b34 Fix timing attack vulnerability in ActiveSupport::MessageVerifier.
Use a constant-time comparison algorithm to compare the candidate HMAC with the calculated HMAC to prevent leaking information about the calculated HMAC.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-09-04 09:25:38 +12:00
Carl Lerche
bd53ebde72 Add required dependencies on activemodel 2009-09-01 12:26:00 -07:00
Yehuda Katz
67f5d611f5 Add rake gemspec and gemspecs to the repo 2009-08-31 17:20:44 -07:00
Jay Pignata
7316d029e6 Duplicating the options hash in Date#advance to prevent modification of the original [#1133 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-08-31 13:02:19 -05:00
Jeffrey Hardy
0821941598 Eliminate warnings from Regexp multiline extension tests
[#3103 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-08-26 14:47:29 -07:00
Jeffrey Hardy
66d8063c91 Correct Regexp#un/optionalize assertions and fix uncovered failures
[#3102 state:incomplete]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-08-26 14:46:38 -07:00
Jeremy Kemper
e93d0a50c0 Ruby 1.9: fix Time#beginning_of_day inaccuracy due to subtracting a Float 2009-08-22 15:53:19 -07:00
Jeremy Kemper
26e4d688ac Skip isolation test tests when using MiniTest 2009-08-15 12:28:09 -07:00
Yehuda Katz
ccd1c5e521 Allow superclass_delegating_accessor to take a block for initial set. 2009-08-11 15:03:53 -07:00
Yehuda Katz
4bf516e072 More perf work:
* Move #set_cookie and #delete_cookie inline to optimize. These optimizations should
    almost certainly be sent back upstream to Rack. The optimization involves using
    an ivar for cookies instead of indexing into the headers each time.
  * Was able to use a bare Hash for headers now that cookies have their own joining
    semantics (some code assumed that the raw cookies were an Array).
  * Cache blankness of body on body=
  * Improve expand_cache_key for Arrays of a single element (common in our case)
  * Use a simple layout condition check unless conditions are used
  * Cache visible actions
  * Lazily load the UrlRewriter
  * Make etag an ivar that is set on prepare!
2009-08-11 15:03:53 -07:00