Joshua Peek
eeba755a11
Accessing nonexistant cookies through the signed jar should not raise an
...
exception
2010-01-17 21:31:06 -06:00
Joshua Peek
d2d4acf027
Cookies middleware
2010-01-16 17:22:27 -06:00
Jeremy Kemper
db49b7dc94
Fix new year heisenbug
2009-12-31 18:32:16 -08:00
David Heinemeier Hansson
c06aff0a7e
Added cookies.permanent, cookies.signed, and cookies.permanent.signed accessor for common cookie actions [DHH]
2009-12-20 14:33:13 -08:00
Yehuda Katz
000d593621
Clean up and update cookies
2009-10-26 18:01:09 -07:00
Jeffrey Hardy
a8dc9fd27b
CookieJar#delete should return the key's value, consistent with a Hash
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-10-14 11:50:51 -07:00
Olly Legg
0349278f3d
Memoize cookies so that updates to cookies are available in the current request. [ #2733 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-28 09:18:27 -05:00
Jeremy Kemper
f9dde8fe4e
Port cookies to new base
2009-05-22 17:05:44 -07:00
Joshua Peek
a8b75c480f
Functional test runner finalizes response just like the integration test runner. In both runners, the @response object will now behave the same.
...
Some functional tests will need to be updated if they are relying on preprocessed data on the response.
2009-05-02 14:57:40 -05:00
Carl Lerche & Yehuda Katz
906aebceed
Bring abstract_controller up to date with rails/master
...
Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list
of commits that could not be applied cleanly or are obviated with the
abstract_controller refactor. They all need to be revisited to ensure
that fixes made in 2.3 do not reappear in 3.0:
2259ecf368e6a6715966f69216e3ee86bf1a82a7
AR not available
* This will be reimplemented with ActionORM or equivalent
06182ea02e92afad579998aa80144588e8865ac3
implicitly rendering a js response should not use the default layout
[#1844 state:resolved]
* This will be handled generically
893e9eb99504705419ad6edac14d00e71cef5f12
Improve view rendering performance in development mode and reinstate
template recompiling in production [#1909 state:resolved]
* We will need to reimplement rails-dev-boost on top of the refactor;
the changes here are very implementation specific and cannot be
cleanly applied. The following commits are implicated:
199e750d46c04970b5e7684998d09405648ecbd4
3942cb406e1d5db0ac00e03153809cc8dc4cc4db
f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690
e3b166aab37ddc2fbab030b146eb61713b91bf55
ae9f258e03c9fd5088da12c1c6cd216cc89a01f7
44423126c6f6133a1d9cf1d0832b527e8711d40f
0cb020b4d6d838025859bd60fb8151c8e21b8e84
workaround for picking layouts based on wrong view_paths
[#1974 state:resolved]
* The specifics of this commit no longer apply. Since it is a two-line
commit, we will reimplement this change.
8c5cc66a831aadb159f3daaffa4208064c30af0e
make action_controller/layouts pick templates from the current instance's
view_paths instead of the class view_paths [#1974 state:resolved]
* This does not apply at all. It should be trivial to apply the feature
to the reimplemented ActionController::Base.
87e8b162463f13bd50d27398f020769460a770e3
fix HTML fallback for explicit templates [#2052 state:resolved]
* There were a number of patches related to this that simply compounded
each other. Basically none of them apply cleanly, and the underlying
issue needs to be revisited. After discussing the underlying problem
with Koz, we will defer these fixes for further discussion.
2009-04-13 15:18:45 -07:00
Yehuda Katz and Carl Lerche
6c05b5e938
Temporarily modifies setup to call super directly. This can support more T::U runners.
2009-04-08 17:33:41 -07:00
Doug McInnes
c877857d59
Fix for TestResponse.cookies returning cookies unescaped [ #1867 state:resolved]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
2009-04-07 13:21:41 -05:00
Joshua Peek
0edb0a4fac
Deprecate ActionController::Response#set_cookie :http_only option infavor of :httponly
2009-02-07 15:37:54 -06:00
Jeremy Kemper
cf09fa74f7
Include process methods in ActionController::TestCase only. No need to alias_method_chain :process either.
2009-01-09 00:14:27 -08:00
Jeremy Kemper
35fa007313
Include process methods in ActionController::TestCase only. No need to alias_method_chain :process either.
2009-01-07 14:49:05 -08:00
Frederick Cheung
cf9c36834a
Fix failing cookie store test
2008-12-21 15:57:09 +00:00
Joshua Peek
3b317b7100
Switch to Rack::Response#set_cookie instead of using CGI::Cookie to build cookie headers
2008-12-20 21:25:47 -06:00
Joshua Peek
fda62ecf70
Rename AbstractResponse to Response and inheirt from Rack::Response
2008-12-19 17:15:22 -06:00
Joshua Peek
a14bbd7a85
Process CGI 'cookie' header into 'Set-Cookie' for all responses.
...
This mostly affects response.headers['cookie'] for test requests. Use response.cookies instead.
2008-12-19 16:49:06 -06:00
Joshua Peek
cbee72d216
Improve cookie test coverage
2008-12-19 16:35:23 -06:00
Pratik Naik
99930d499e
Fix symbol cookie test
2008-07-17 18:19:09 +01:00
Rich Cavanaugh
d8bcec6ce6
make CGI::Cookie handle deleting a cookie properly
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2008-05-13 10:51:55 -07:00
Rich Cavanaugh
a425cd1473
Don't double-escape cookie store data. Don't split cookie values with newlines into an array. [ #130 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2008-05-12 15:26:19 -07:00
Pratik Naik
ef4c65088f
Move missing template logic to ActionView
2008-04-19 18:59:13 +01:00
Jamis Buck
11787b802a
remove support for ampersand-delimited cookie values
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-12 21:45:39 +00:00
Jeremy Kemper
9d755f1983
require abstract_unit directly since test is in load path
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-05 13:32:06 +00:00
Jeremy Kemper
a3143eaa98
Ruby 1.9 compat: account for new, non-flattening Array#to_s
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-15 02:29:15 +00:00
Rick Olson
c9fecf20ff
Ensure that cookies handle array values correctly. Closes #9937 [queso]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-20 17:30:01 +00:00
David Heinemeier Hansson
e3b49c052b
Fixed spelling errors ( closes #9706 ) [tarmo/rmm5t]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 14:18:47 +00:00
Jeremy Kemper
28f7de07cb
Test CGI::Cookie#to_s. Closes #9624 [tarmo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7535 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 09:01:33 +00:00
David Heinemeier Hansson
eede82ccb9
Added support for HTTP Only cookies (works in IE6+ and FF 2.0.5+) as an improvement for XSS attacks ( closes #8895 ) [lifo/Spakman]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-21 15:05:49 +00:00
David Heinemeier Hansson
f7b0bc9ea3
Removed deprecated ActionController::Base.cookie (use ActionController#Base.cookies[]= instead)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 22:56:15 +00:00
David Heinemeier Hansson
4cfc60a6c8
Removed deprecated ActionController::Base.cookie (use ActionController#Base.cookies[]= instead)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 22:55:16 +00:00
Michael Koziarski
f81dae3fca
Remove deprecated functionality from actionpack. Closes #8958 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-03 00:18:30 +00:00
Michael Koziarski
fd65d89e07
Allow you to delete cookies with options. Closes #3685 [josh, Chris Wanstrath]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-01 23:27:59 +00:00
Rick Olson
fcd73821c2
Modernize cookie testing code, and increase coverage (Heckle++) #7101 [Kevin Clark]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-17 06:51:59 +00:00
Jeremy Kemper
4f3bf6cb23
Deprecate @cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-29 08:04:39 +00:00
David Heinemeier Hansson
ce96c5b30b
Added assert_no_cookie and fixed assert_cookie_equal to deal with non-existing cookies #979 [bitsweat]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:54:25 +00:00
David Heinemeier Hansson
b1999be5a7
A hopefully more successful attempt at the Routing branch merge
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:45:35 +00:00
David Heinemeier Hansson
88a3343ed5
Backed out of routing merge.. investigating missing patches
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:24:55 +00:00
David Heinemeier Hansson
c844755e5a
Merged back the Routing branch
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 00:51:02 +00:00
David Heinemeier Hansson
177cae5483
Allow symbols to be used as names for setting cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@22 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:11:42 +00:00
David Heinemeier Hansson
defda16b83
Allow symbols to be used as keys for setting cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@21 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:09:38 +00:00
David Heinemeier Hansson
d0c90331f1
Added a new container for cookies that makes them more intuative to use. The old methods of cookie and @cookies have been deprecated.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@20 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-26 02:04:35 +00:00
David Heinemeier Hansson
db045dbbf6
Initial
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-24 01:04:44 +00:00