Commit Graph

4451 Commits

Author SHA1 Message Date
utilum
7d62e27dd5 Mention JS Runtime dependency in dev dependencies guide [ci skip]. 2016-12-14 16:08:44 +01:00
yuuji.yaginuma
7fab05008c remove deprecated assert_send from assertion list [ci skip]
`assert_send` was deprecated in minitest 5.10.0.
Ref: f95ef007ec
2016-12-09 16:12:56 +09:00
yuuji.yaginuma
d71f289fb2 stop using removed render :text
Follow up to 79a5ea9eadb4d43b62afacedc0706cbe88c54496
2016-12-03 15:28:59 +09:00
utilum
2dc74387b7 Fixes #27202, [ci skip] 2016-11-30 21:22:30 +01:00
Rory O’Kane
4c0c7cba2b Fix typo in Rails 5.0 release notes – “when when”
[ci skip]
2016-11-29 16:46:10 -05:00
JessRudder
a92e115e19 Add note about step needed to get tests to pass if you implemented basic auth [ci skip] 2016-11-28 19:28:40 -05:00
jnoortheen
fa497ebb0d fix: solves issue#27189 2016-11-27 22:59:59 +05:30
Prathamesh Sonpatki
312b345b45
Followup of UUID default extension in the docs [ci skip]
- Mentioned clearly that for PostgreSQL < 9.4, you need to pass the
  default option with "uuid_generate_v4()"
- Also updated PostgreSQL Active Record guide with this change.
- https://github.com/rails/rails/pull/25395#r66877078
2016-11-24 17:33:16 +05:30
Jon Moss
4c3afea7df Change html-scanner to rails-html-sanitizer
[ci skip]
2016-11-19 20:31:25 -05:00
Tom Prats
dd66493d70 Updated Sprockets Documentation 2016-11-17 18:18:14 -05:00
Vipul A M
8d015dff82 Remove mention of deprecated SafeERB gem from security docs for now, prior section already speaks about sanitization as a safety measure. [ci skip] (#27086)
Fixes #27085
2016-11-18 00:11:48 +05:30
yuuji.yaginuma
eda23fa62f remove alias_method_chain from guide [ci skip]
Follow up to 7c848e6dd493ff236d33a0410a92f4c3e5cc3c7f
2016-11-15 08:42:02 +09:00
Conrad Beach
b8341b3a2a Fix small typo in Layouts and Rendering guide. [ci skip]
Changed "same way they do" to "same way they are".
2016-11-14 14:07:21 -07:00
Andrew White
0ef5b6c163 Merge pull request #26905 from bogdanvlviv/docs
Add missing `+` around a some literals.
2016-11-13 14:09:30 +00:00
Xavier Noria
e86524c0c5 adds support for arbitrary hashes in strong parameters 2016-11-11 23:31:50 +01:00
bogdanvlviv
25eed41c49 Update guides/source/active_record_querying.md
Add info about updating locking column value

Follow #26050 and #26871

[ci skip]
2016-11-10 20:42:23 +02:00
Kasper Timm Hansen
bab665f893 [ci skip] Expand context on :cache_hits.
Need to explain the key is only there in certain cases.
2016-11-08 18:52:31 +01:00
yui-knk
4582d5766a [ci skip] Add render_collection.action_view entry to AS instrumentation 2016-11-08 20:03:22 +09:00
Kasper Timm Hansen
e91dd52d56 Merge pull request #26982 from bogdanvlviv/started_guide
Fix 'Getting Started with Rails' [ci skip]
2016-11-07 07:36:03 +01:00
bogdanvlviv
2339466542 Add missing spaces [ci skip] 2016-11-07 01:43:59 +02:00
bogdanvlviv
88aeadb5b3 Fix 'Getting Started with Rails' [ci skip]
`bin/rails generate controller Comments` creates files
  app/assets/javascripts/comments.coffee
  app/assets/stylesheets/comments.scss
  not
  app/assets/javascripts/comment.coffee
  app/assets/stylesheets/comment.scss
2016-11-06 23:02:23 +02:00
Daniel Amireh
b49e601e3a Use local variable instead of instance variable [ci skip]
Update render yield docs to use `search` local variable instead of `@q` instance variable
2016-11-05 14:19:28 +01:00
colleenmcguckin
700623936e
fix typo in Rails Test Runner section 2016-10-31 12:18:20 -07:00
Shia
e7bb3cd4ae Remove `Rack::Runtime from console log [ci skip] 2016-10-31 17:53:52 +09:00
Benny
32d0d971eb Add missing space in Migrations guide [ci skip] 2016-10-31 11:32:29 +08:00
yuuji.yaginuma
8ee7d5e1fc update doc about assets digest class [ci skip]
The default digest class changed to SHA256 in sprockets 3.0.
Ref: https://github.com/sstephenson/sprockets/pull/647
2016-10-30 09:34:27 +09:00
Erol Fornoles
f7d54c4247
Add documentation for config.assets.version [skip ci] 2016-10-28 18:13:30 +08:00
yuuji.yaginuma
3db6ca9d04 fix initializer name [ci skip]
This changed in c046660
2016-10-27 08:04:24 +09:00
bogdanvlviv
5faa9a235c Add missing + around a some literals.
Mainly around `nil`

[ci skip]
2016-10-27 00:27:47 +03:00
James Doyley
ae83b01b19 Update HABTM documentation in guides 2016-10-26 09:22:23 +01:00
Rafael Mendonça França
8b3ed2b68a
Fix HTML escaping in the guides
render :html escapes the argument if not provided as html safe.
2016-10-25 11:19:28 -02:00
Erol Fornoles
094638e544
Fix typo in Upgrading Ruby on Rails Guide [ci skip] 2016-10-24 22:28:40 +08:00
yuuji.yaginuma
0f87413f41 update description of Etag [ci skip]
The document is written with "only generate weak", but it can also be used to
strong etag.
Also, add missing entory for #24387
2016-10-24 20:17:31 +09:00
Carlos Antonio da Silva
a0d0648efb Merge release note entry for Date/Time/DateTime extensions
The first release note entry mentioned #on_weekday?, but that was only
added by the second PR mentioned there. To simplify reading the notes
just merge the two, since they are related methods. [ci skip]
2016-10-23 16:51:51 -02:00
Yves Senn
dba9ce8ec8 guides, include note about modifiers when using the CLI.
[ci skip]

This was pointed out on
https://github.com/rails/rails/issues/15583#issuecomment-239212831

The comment was lost in the changes made by
fcd0ac066e0959a9f4fa4459a27e041abe8eb52a and
3e1373a773085d5f19cb6a466ab2736cc1ca2713
2016-10-20 20:34:46 +02:00
Yves Senn
fb2f8d2b75 remove trailing whitespace [ci skip] 2016-10-20 20:32:24 +02:00
Bruno Facca
85dd85fe01 [ci skip] Fix return values of Hash Extensions examples
The hashes returned in some examples of the following sections had items in a different order than their receivers. That may mislead readers into believing those methods will not preserve element order.

Extensions to Hash/Working with Keys/transform_keys and transform_keys!
Extensions to Hash/Working with Keys/stringify_keys and stringify_keys!
Extensions to Hash/Working with Keys/symbolize_keys and symbolize_keys!
Extensions to Hash/Slicing
2016-10-20 15:38:49 -02:00
Alex Kitchens
f6cc4f5648 [ci skip] Fix typo in Guides: Contributing 2016-10-17 16:31:01 -05:00
rmarone
be6990bf01 Pull request for ticket 26769 (#26770)
* Clarify the default behavior of log_formatter

Updates language to remove reference to production.rb and fix quoting
2016-10-15 09:20:41 -04:00
Godfrey Chan
f2f9b88685 Introduce a benchmark template [ci skip]
This replaces boilerplate in the “benchmark your code” section of the
contributors’ guide with an executable template. I also amended the text
to encourage best practices and codified it in the template.

For now this is only good for relatively self-contained changes that can
be inlined into a simple script. In the future, this can be expanded to
cover how to measure the difference between two commits.

The output looks like this:

```
==================================== Empty =====================================

Warming up --------------------------------------
              blank?   225.963k i/100ms
         fast_blank?   238.147k i/100ms
Calculating -------------------------------------
              blank?      8.825M (± 6.4%) i/s -     44.063M in   5.014824s
         fast_blank?      9.311M (± 6.3%) i/s -     46.439M in   5.009153s

Comparison:
         fast_blank?:  9310694.8 i/s
              blank?:  8824801.7 i/s - same-ish: difference falls within error


================================= Single Space =================================

Warming up --------------------------------------
              blank?    56.581k i/100ms
         fast_blank?   232.774k i/100ms
Calculating -------------------------------------
              blank?    813.985k (±16.7%) i/s -      4.017M in   5.076576s
         fast_blank?      9.547M (± 5.2%) i/s -     47.719M in   5.013204s

Comparison:
         fast_blank?:  9547414.0 i/s
              blank?:   813985.0 i/s - 11.73x  slower


================================== Two Spaces ==================================

Warming up --------------------------------------
              blank?    58.265k i/100ms
         fast_blank?   244.056k i/100ms
Calculating -------------------------------------
              blank?    823.343k (±16.2%) i/s -      4.020M in   5.014213s
         fast_blank?      9.484M (± 4.9%) i/s -     47.347M in   5.005339s

Comparison:
         fast_blank?:  9484021.6 i/s
              blank?:   823343.1 i/s - 11.52x  slower


=============================== Mixed Whitspaces ===============================

Warming up --------------------------------------
              blank?    53.919k i/100ms
         fast_blank?   237.103k i/100ms
Calculating -------------------------------------
              blank?    763.435k (±16.8%) i/s -      3.720M in   5.018029s
         fast_blank?      9.672M (± 5.8%) i/s -     48.369M in   5.019356s

Comparison:
         fast_blank?:  9672467.2 i/s
              blank?:   763435.4 i/s - 12.67x  slower


=============================== Very Long String ===============================

Warming up --------------------------------------
              blank?    34.037k i/100ms
         fast_blank?   240.366k i/100ms
Calculating -------------------------------------
              blank?    409.731k (± 8.9%) i/s -      2.042M in   5.028235s
         fast_blank?      9.794M (± 4.3%) i/s -     49.035M in   5.016328s

Comparison:
         fast_blank?:  9794225.2 i/s
              blank?:   409731.4 i/s - 23.90x  slower
```
2016-10-15 12:34:46 +02:00
Javier Cuevas
854a1be5fa Suggested edits 2016-10-13 18:02:52 +02:00
Javier Cuevas
3de12286e6 Improve Action Cable Overview guide
The default adapter in development & test environments is not `redis` but `async`.
2016-10-13 17:49:26 +02:00
Rafael Mendonça França
b3d41eae4b
Deprecated ActionDispatch::ParamsParser::ParamsParser
ActionDispatch::ParamsParser class was removed in favor of
ActionDispatch::Http::Parameters so it is better to move the error
constant to the new class.
2016-10-10 01:35:58 -03:00
kenta-s
a0f871f95a Change page:change to turbolinks:load in README.md [ci skip] 2016-10-05 19:41:27 +09:00
Esteban Santana Santana
ddddedc487 Allow the use of listen's 3.1.x branch.
When the initial evented monitor feature was written, the latest version of listen
was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series.
This patch allows the use of the new versions.
2016-10-03 16:58:17 +05:30
yuuji.yaginuma
f597822f4a add cached key to sql.active_record event [ci skip]
Follow up to #26584
2016-10-02 13:29:17 +09:00
Jeremy Wilmot
7d0e73bc01 Remove dup distinct from AR query list [ci skip] 2016-09-30 15:12:16 -07:00
Yusuke Nakamura
86c0dccac1 Fix typo in 5_0_release_notes.md doc [ci skip] 2016-09-29 21:56:56 +09:00
Jon Moss
29f883640c Merge pull request #26648 from y-yagi/update_description_of_queue_adapter
update description of queue adapter in test [ci skip]
2016-09-28 17:04:21 -04:00
Michael Lennox
ba415c4f8a Removes broken performance testing link from the 2.2 release notes 2016-09-28 14:11:26 +01:00