Commit Graph

29 Commits

Author SHA1 Message Date
Ryuta Kamizono
1dc17e7b2e Fix CustomCops/AssertNot to allow it to have failure message
Follow up of #32605.
2018-05-13 11:32:47 +09:00
Daniel Colson
a1ac18671a Replace assert ! with assert_not
This autocorrects the violations after adding a custom cop in
3305c78dcd.
2018-04-19 08:11:33 -04:00
Daniel Colson
94333a4c31 Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
Yuriy Ustushenko
226116a440 Clear the transaction state when AR object is duped 2018-01-25 10:09:16 +07:00
Ryuta Kamizono
245c1dafa8 Enable Layout/LeadingCommentSpace to not allow cosmetic changes in the future
Follow up of #31432.
2017-12-14 17:30:54 +09:00
Kir Shatrov
831be98f9a Use frozen-string-literal in ActiveRecord 2017-07-19 22:27:07 +03:00
Matthew Draper
87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
Koichi ITO
d62a79fae4 Raise NotImplementedError when using empty_insert_statement_value with Oracle
Refer: https://github.com/rsim/oracle-enhanced/pull/1180
2017-02-17 19:43:48 +09:00
Xavier Noria
d22e522179 modernizes hash syntax in activerecord 2016-08-06 19:37:57 +02:00
Xavier Noria
9617db2078 applies new string literal convention in activerecord/test
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:26:53 +02:00
Sean Griffin
b6e15f9a11 Don't error when duping a record with no PK 2014-07-02 07:00:26 -06:00
Carlos Antonio da Silva
2b6e3051bd Add missing require to fix test 💣 2014-05-02 21:14:17 -03:00
Carlos Antonio da Silva
dbacebafac Move dup destroyed test to specific file that tests dup logic
Also change other related test to use existing record rather than
creating new one.
2014-05-02 20:59:22 -03:00
Rafael Mendonça França + Kassio Borges
bf2c428056 Don't need to check if the scope respond to call
We are checking this when defining the default scope and raising an
ArgumentError
2013-08-31 14:53:28 -03:00
Alexander Balashov
cec0343965 Fix typo: overriden => overriDDen 2013-03-28 18:52:14 +04:00
Vipul A M
55686dd1be fix typos in AR. lots of them. 2013-03-19 00:04:39 +05:30
Hiroshige Umino
ec9aa3ca89 Do not override attributes on dup by default scopes 2013-02-26 00:30:49 +09:00
Akira Matsuda
59e2630ca7 Missing repair_validations 2013-01-22 05:24:23 +09:00
Christian Seiler
fb66521772 Call super to nullify the reference to the original errors object in the dup'ed object (call ActiveModel::Validations#initialize_dup). Closes #7291 2012-10-16 15:09:23 +02:00
Guillermo Iguaran
2d7ae1b08e Remove mass_assignment_options from ActiveRecord 2012-09-16 23:59:05 -05:00
Bogdan Gusiev
30468f58a7 Fixed after_initialize callbacks call on AR model #dup 2012-01-07 11:11:04 +02:00
Aaron Patterson
61774e0d49 please use ruby -I lib:test path/to/test.rb, or export RUBY_OPT 2011-06-06 15:47:13 -07:00
Jon Leighton
253bb6b926 Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases. 2011-06-04 23:47:03 +01:00
Franck Verrot
47f39d26a7 Testing that dup is resetting the timestamps 2010-11-25 01:18:43 +08:00
Aaron Patterson
a551d2ec62 fixing variable names. oops! 2010-11-23 17:42:49 -08:00
Aaron Patterson
d717cb2913 clone and dup are working on 1.8 2010-11-23 14:29:05 -08:00
Aaron Patterson
064c28d6c2 fixing dup regressions 2010-11-23 14:29:05 -08:00
Aaron Patterson
6a8f1b8b40 renaming duplication test to dup test 2010-11-23 14:29:04 -08:00