Commit Graph

65955 Commits

Author SHA1 Message Date
Kasper Timm Hansen
1d047235b0
Merge pull request #31497 from aried3r/patch-2
Update new_framework_defaults_5_2.rb.tt
2017-12-18 19:54:22 +01:00
George Claghorn
a6eb2a27c3 Ensure MiniMagick tempfiles are properly unlinked after image transformation 2017-12-18 13:14:26 -05:00
Anton Rieder
391ec4e392
Update new_framework_defaults_5_2.rb.tt
Be consistent in comments when mentioning AES.
2017-12-18 18:28:16 +01:00
Eileen M. Uchitelle
0dfe220425
Merge pull request #31449 from PHedkvist/headless_api_doc
Add headless browser support in api docs [ci skip]
2017-12-18 12:24:43 -05:00
Pierre Hedkvist
72aca5231f Add headless browser support in api docs [ci skip] 2017-12-18 16:51:22 +00:00
Eileen M. Uchitelle
ce2fc70c7b
Merge pull request #31485 from y-yagi/skip_bootsnap_option
Add `skip_bootsnap` option
2017-12-18 10:09:12 -05:00
Eileen M. Uchitelle
6553c7fef7
Merge pull request #31479 from iamvery/reword-delegate-allow-nil-paragraph
Clarify docs for delegate :allow_nil option
2017-12-18 10:01:32 -05:00
Eileen M. Uchitelle
b2be83fc2c
Merge pull request #31490 from eugeneius/hash_digest_class_truncate
Don't include ellipsis in truncated digest output
2017-12-18 09:59:13 -05:00
George Claghorn
95117a2ce2 Convert non-web image (e.g. PSD) variants to PNG 2017-12-18 07:49:24 -05:00
yuuji.yaginuma
35373219c9 Raise an error only when require_master_key is specified
To prevent errors from being raise in environments where credentials
is unnecessary.

Context: https://github.com/rails/rails/issues/31283#issuecomment-348801489

Fixes #31283
2017-12-18 08:04:15 +09:00
Ryuta Kamizono
daf15f58b9 Fix test_counter_cache_with_touch_and_lock_version failure
Looks like it is failed due to datetime rounding. Related #23521.

https://travis-ci.org/rails/rails/jobs/317734560#L1980-L1984
2017-12-18 04:36:55 +09:00
Ryuta Kamizono
de354cc357 Using table name qualified column names unless having SELECT list explicitly
Previously table name qualified `*` is used in that case. If it is not
qualified with a table name, an ambiguous column name error will occur
when using JOINs.
2017-12-18 01:52:54 +09:00
Xavier Noria
475a0f887c emphasize working on existing issues/patches for newcomers [ci skip]
Thanks to @Datasnuten for the suggestion.
2017-12-17 14:14:40 +01:00
Prathamesh Sonpatki
fd1304d2aa
Minor cleanup of CHANGELOG of PR #30850 [ci skip] 2017-12-17 13:00:37 +05:30
Prathamesh Sonpatki
f4d2a8a8ce
Added reference to default value of allow_other_host [ci skip] 2017-12-17 12:53:39 +05:30
Chris Salzberg
876865aba7
Add changelog entry for e1ceb10 2017-12-17 14:47:02 +09:00
Chris Salzberg
e1ceb10fa8
Undefine attribute methods on all descendants when resetting column info
If we don't do this, then we end up with an inconsistent situation where
a parent class may e.g. reset column information, but child classes will
contine to see attribute methods as already generated, and thus not pick
up this new column (falling through to method_missing).
2017-12-17 11:58:29 +09:00
Chris Salzberg
4aee5fcbfb
Add failing test 2017-12-17 11:58:26 +09:00
Eugene Kenny
b9e7c676ca Don't include ellipsis in truncated digest output
Using `truncate` to limit the length of the digest has the unwanted side
effect of adding an ellipsis when the input is longer than the limit.

Also:
 - Don't instantiate a new object for every digest
 - Rename the configuration option to `hash_digest_class`
 - Update the CHANGELOG entry to describe how to use the feature
2017-12-17 00:49:02 +00:00
George Claghorn
7b1dfac291 Update ActiveStorage::Blob#transformation docs [ci skip] 2017-12-16 19:41:43 -05:00
yuuji.yaginuma
c5b900da73 Add test case that active_storage:install task works within engine
Follow up of #31391
2017-12-17 09:10:36 +09:00
yuuji.yaginuma
838b40da84 Add skip_bootsnap option
`bootsnap` is a useful gem normally. However, `bootsnap` is unnecessary
when generating a Rails application to be used only for testing.
So I want to control whether use this or not by option.
2017-12-16 20:07:50 +09:00
Kasper Timm Hansen
28d2968533
Merge pull request #31316 from bogdanvlviv/update-association_basics-guide
Update "Active Record Associations" guide [ci skip]
2017-12-16 10:18:52 +01:00
Ryuta Kamizono
a2a2377b1c
Merge pull request #31484 from yhirano55/fix_active_storage_guide
Fix Active Storage Overview guide [ci skip]
2017-12-16 14:29:07 +09:00
Yoshiyuki Hirano
94baf7291a Fix Active Storage Overview guide [ci skip] 2017-12-16 14:25:45 +09:00
yuuji.yaginuma
ce98cd0d0d Explicitly require sidekiq/cli
Currently, sidekiq integration test + Ruby 2.5.0-rc1 show exception as follows.

```
#<Thread:0x000000000670bec0@/home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/sidekiq-5.0.5/lib/sidekiq/util.rb:23 run> terminated with exception (report_on_exception is true):
/home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:53:in `block in load_missing_constant': uninitialized constant Sidekiq::CLI (NameError)
	from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:8:in `without_bootsnap_cache'
	from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:53:in `rescue in load_missing_constant'
	from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/bootsnap-1.1.7/lib/bootsnap/load_path_cache/core_ext/active_support.rb:42:in `load_missing_constant'
	from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/sidekiq-5.0.5/lib/sidekiq/launcher.rb:65:in `heartbeat'
	from /home/travis/build/rails/rails/vendor/bundle/ruby/2.5.0/gems/sidekiq-5.0.5/lib/sidekiq/launcher.rb:123:in `start_heartbeat'
```

https://travis-ci.org/rails/rails/jobs/317187279#L2152

The reason for this is that `Sidekiq::CLI` has not been loaded.
Sidekiq integration test launches a Sidekiq instance within
another Ruby process. In such a case, need to require 'sidekiq/cli'
in that launch code.

Ref: https://github.com/mperham/sidekiq/pull/3692#issuecomment-352032251
2017-12-16 11:02:26 +09:00
George Claghorn
af0caadb8d Handle invalid signed blob IDs gracefully 2017-12-15 19:26:53 -05:00
Claudio B
ca2c4cb7c4
Merge pull request #31481 from claudiob/fix-ast-guides
[ci skip] Use :amazon, not :s3, so that guides reflect the current code
2017-12-15 15:51:25 -08:00
Claudio B
6211445d55 [ci skip] Use :amazon, not :s3, to reflect code
The [template](https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/config/storage.yml.tt#L10)
that generates the `config/storage.yml` file has the Amazon S3 key specified as `:amazon`, not `:s3`.

The guides should reflect the nomenclature, given that every other service also
has the name of the company as the key (:google, :microsoft).
2017-12-15 15:49:18 -08:00
Jay Hayes
c46c303c86 Clarify docs for delegate :allow_nil option 2017-12-15 14:32:52 -06:00
Ryuta Kamizono
6bd28902e2
Merge pull request #31473 from shioyama/fix_instantiate_test_attributes
Modify test to correctly pass attributes hash
2017-12-16 00:49:51 +09:00
George Claghorn
311af752cf Restrict variants to variable image blobs 2017-12-15 10:45:00 -05:00
Chris Salzberg
c91a44d540
Modify test to correctly pass attributes hash 2017-12-15 23:53:49 +09:00
Ryuta Kamizono
3ddb811acc Remove needless change_table
These are using `remove_column` directly, not used `t` in
`change_table`.
2017-12-15 17:52:11 +09:00
Ryuta Kamizono
cda7e63abc Sync header title with file name [ci skip]
Like other Basics and Overview guides.
2017-12-15 16:52:27 +09:00
Ryuta Kamizono
1865ef7318
Merge pull request #31470 from ydakuka/fix-typos-a-st-guide
Fix in ASt guide [ci skip]
2017-12-15 16:41:38 +09:00
Ryuta Kamizono
640242654c
Merge pull request #31471 from yhirano55/inherit_active_record_base
[ci skip] Inherit ActiveRecord::Base in example codes
2017-12-15 16:39:27 +09:00
Yauheni Dakuka
83e10bd068 Fix in ASt guide [ci skip] 2017-12-15 10:33:38 +03:00
Yoshiyuki Hirano
6d65c0f077 [ci skip] Inherit ActiveRecord::Base in example codes 2017-12-15 16:32:58 +09:00
yuuji.yaginuma
6a902d43c7 Fix guide generation error [ci skip]
Currently, generation of guide is an error in `5_2_release_notes.html`.

```
$ bunele exec rake guides:generate:html
Generating 5_2_release_notes.md as 5_2_release_notes.html
rails/guides/rails_guides/markdown.rb:44:in `dom_id': undefined method `[]' for nil:NilClass (NoMethodError)
	from rails/guides/rails_guides/markdown.rb:106:in `block (2 levels) in generate_structure'
```

It seems that it is an error because there are multiple
`active-storage` anchors.

Since Active Storage is a Major feature, it is unnecessary to show
CHANGELOGs, so remove from `Incompatibilities` section.
2017-12-15 15:52:02 +09:00
Ryuta Kamizono
597b941930 [ci skip] Add missing **DO NOT READ THIS FILE ON GITHUB, GUIDES ARE PUBLISHED ON http://guides.rubyonrails.org.** 2017-12-15 14:02:25 +09:00
Ryuta Kamizono
f4b775ae48
Merge pull request #31466 from dixitp012/action_pack_doc_link_update
[ci skip] update link
2017-12-15 13:54:25 +09:00
Dixit Patel
a680e2f727 [ci skip] update link 2017-12-15 10:15:04 +05:30
George Claghorn
06dbc028da
Merge pull request #31464 from yhirano55/update_guide_index
[ci skip] Update guide index for active storage
2017-12-14 23:32:29 -05:00
Yoshiyuki Hirano
63554cb322 [ci skip] Update guide index for active storage 2017-12-15 13:19:55 +09:00
Ryuta Kamizono
377948850f Clear dirty schema_cache after dump_schema_cache
`dump_schema_cache` fills `schema_cache` even if the test that modifies
the schema has properly cleared the schema cache.

Fixes #31463.
2017-12-15 13:04:51 +09:00
George Claghorn
48fbc4aec8
Merge pull request #31037 from jeffreyguenther/activestorage-guide
ActiveStorage Guide
2017-12-14 22:23:09 -05:00
Jeffrey Guenther
53757939b7 Tweak whitespace 2017-12-14 19:09:48 -08:00
Jeffrey Guenther
1dba0a279d Formatting updates 2017-12-14 19:08:33 -08:00
Jeffrey Guenther
1c5358e472 Merge branch 'master' into activestorage-guide 2017-12-14 19:03:28 -08:00