TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
51,301 Commits 2 Branches 0 Tags 294 MiB
21474f143a
Commit Graph

3567 Commits

Author SHA1 Message Date
Carlos Antonio da Silva
f54e89bf59 Improve note about unique index and foreign key on has_one association 
Related to f1af967e0055a33c45071848a049ff342e9c291e. [ci skip]
 2015-04-13 08:13:16 -03:00
Mehmet Emin İNAÇ
45747a5572 Fix the wrong documentation about config.autoload_paths [ci skip] 
config.autoload_paths is not changeable from environment specific configuration files.
 2015-04-13 11:56:50 +03:00
Zachary Scott
f1af967e00 Add note wrt foreign key constraint to ensure data integrity 
Thanks for patch @sgrif :trollface:

Closes #18216
 2015-04-12 20:20:48 -07:00
Zachary Scott
da5fe3be1f Apply comments from @rafaelfranca: we shouldn't recommend you use scaffold css 
Closes #19492 and fixes #19453
 2015-04-12 18:11:14 -07:00
Zachary Scott
558597c0f8 Merge pull request #19564 from jonatack/counter_cache_docs 
[skip ci] Fix counter_cache in the Rails Guides
 2015-04-12 16:29:09 -07:00
Zachary Scott
8b0aa0c1b1 Some copy edits for modifying View Paths [ci skip] 2015-04-12 14:43:25 -07:00
Zachary Scott
66f3ec6746 Merge branch 'view_paths' of https://github.com/nishantmodak/rails into nishantmodak-view_paths 2015-04-12 14:25:14 -07:00
Nishant Modak
69283303f3 view paths docs [ci skip] 2015-04-13 01:41:48 +05:30
Kasper Timm Hansen
efaec3dd63 Merge pull request #19732 from wazery/patch-2 
[ci skip] Update contributing guide
 2015-04-12 16:32:00 +02:00
Islam Wazery
2e1d69ea97 [ci skip] Update contributing guide 2015-04-12 16:23:42 +02:00
Robin Dupret
5493e9c7f8 Fix a few typos and wrap some lines [ci skip] 2015-04-12 15:34:28 +02:00
yuuji.yaginuma
3b88493bbb remove reference to register_javascript_expansion and register_stylesheet_expansion from guide [ci skip] 
These methods no longer exists.
 2015-04-12 14:52:28 +09:00
Yuki Nishijima
f7ba69436a Speed up Levenshtein by 50% and reduce 97% of memory usage 
Calculating -------------------------------------
             each_char   924.000  i/100ms
        each_codepoint     1.381k i/100ms
  -------------------------------------------------
             each_char      9.320k (¡Þ 5.1%) i/s -     47.124k
        each_codepoint     13.857k (¡Þ 3.6%) i/s -     70.431k

  Comparison:
        each_codepoint:    13857.4 i/s
             each_char:     9319.5 i/s - 1.49x slower

The full report can be found here:
  https://gist.github.com/yuki24/a80988f35aceac76f1d5
 2015-04-11 15:28:23 -07:00
Carlos Antonio da Silva
193297abc8 Remove mention of super old defined_javascript_functions method [ci skip] 
It was removed long ago: e358b1fce8fdcbac896dde08286be020420e843e.
 2015-04-11 17:57:54 -03:00
Islam Wazery
4521aadae0 Rename railties/bin to railties/exe 
That will match the new Bundler executables convention.
Bundler Blog Post: http://bundler.io/blog/2015/03/20/moving-bins-to-exe.html
Also updated the necessary tests.
 2015-04-11 19:26:34 +02:00
eileencodes
6ad9e2c4a5 [ci skip] Remove link_to_function and button_from_function from guides 
These methods were removed in cb9f7f4 and are no longer methods in the
Rails codebase.
 2015-04-11 08:47:44 -04:00
Jon Atack
478a755387 [skip ci] primay_key -> primary_key 2015-04-11 15:38:07 +05:30
Zachary Scott
d2998764c5 Copy edits for primary_key documentation in association guide. [ci skip] 2015-04-10 17:27:40 -07:00
Zachary Scott
47dc07313b Merge branch 'belongs_to_primary_key_doc' of https://github.com/girishso/rails into girishso-belongs_to_primary_key_doc 2015-04-10 17:20:40 -07:00
Mikhail Dieterle
8ec88a1b9e [ci skip] add missing file extension 2015-04-10 23:07:04 +03:00
Mikhail Dieterle
81b291915c [ci skip] format rake output 2015-04-10 22:55:19 +03:00
Mikhail Dieterle
746695d6c8 [ci skip] fix helper name 2015-04-10 22:35:46 +03:00
yui-knk
fdcc71d014 [ci skip] Wrap with double quotation 2015-04-10 13:54:25 +09:00
yui-knk
e9df18436b [ci skip] Downcases filter names 2015-04-10 13:33:02 +09:00
Eliot Sykes
fc11ea4a0d Add Active Job to Configuring Guide [ci skip] 2015-04-09 18:41:46 +01:00
Nishant Modak
7f178c83de Fix URL rails-framework-hooks 2015-04-07 01:19:30 +05:30
yuuji.yaginuma
cb04fa41e7 correct the directory which rake notes look by default [ci skip] 2015-04-06 23:48:49 +09:00
yui-knk
1917719f00 [ci skip] Remove Extensions to Proc chapter section 
`Proc#bind` is removed with 4.1 release
 2015-04-06 08:37:27 +09:00
Szymon Madeja
1fda385cdf Update command_tasks source code 2015-04-05 17:10:40 +02:00
Robin Dupret
9cc41c36f7 Fix a few typos [ci skip] 2015-04-05 15:58:43 +02:00
Yves Senn
0eab204c0e Merge pull request #19644 from y-yagi/auto_discovery_link_tag_doc 
correct output of auto_discovery_link_tag [ci skip]
 2015-04-05 10:55:13 +02:00
Mehmet Emin İNAÇ
75c32edd9d change REQUEST_URI to PATH_INFO 
request.env['REQUEST_URI'] returns full URI of the resource
request.env['PATH_INFO'] returns only path of the resource
 2015-04-04 21:16:58 +03:00
yuuji.yaginuma
e2d9e85368 correct output of auto_discovery_link_tag [ci skip] 2015-04-04 07:37:23 +09:00
yui-knk
a21a8192aa [ci skip] Replace reraised with not captured 2015-04-02 00:26:18 +09:00
Konstantinos Rousis
8f092302aa [ci skip] fix guides example on arbitrary SQL execution 2015-04-01 16:03:41 +02:00
yui-knk
0f26977d09 [ci skip] Remove unnecessary lines 2015-04-01 20:02:56 +09:00
yui-knk
66bf962a7a [ci skip] Add : 2015-04-01 19:59:54 +09:00
yui-knk
8f73c3ff61 [ci skip] Fix :having option with having method 2015-04-01 13:45:56 +09:00
Jonan Scheffler
21a2d9a987 Update routing.md 
This adds instructions for routing to rack applications with mount instead of match.

I just spent an unreasonable amount of time staring at this, hopefully the next person will save some time. It's possible that the docs should simply advise people to use mount and leave out the match method but I don't know enough about the differences in the two approaches to assert that definitively.
 2015-04-01 00:37:23 -03:00
Eliot Sykes
d402268d78 Remove unused subdir deployment considerations section [ci skip] 2015-03-31 18:47:45 +01:00
Kir Shatrov
afbd6559f9 No need to mention unit tests in testing guide anymore 2015-03-31 14:38:28 +03:00
Kir Shatrov
851621bf19 New test runner syntax in testing guide 2015-03-31 14:38:28 +03:00
Kir Shatrov
487aa51b14 Suggest new hash syntax in testing guide 2015-03-31 14:38:28 +03:00
Kir Shatrov
3cee8ce2e8 Don't suggest bin/rails test controllers 2015-03-31 13:45:17 +03:00
Hendy Tanata
b016533d5b Add missing "of" to testing guide. 2015-03-30 09:15:54 -07:00
Matthew Draper
cb01246721 Merge pull request #19034 from jvanbaarsen/explicit-job-base-class 
Add explicit base class for ActiveJob jobs
 2015-03-30 23:04:25 +10:30
Matthew Draper
ffd2f085a5 Merge branch 'kirs' 2015-03-30 17:06:09 +10:30
Kir Shatrov
09d2623783 Switch to bin/rails test in testing guide 
rails/rails#18305
 2015-03-30 00:11:02 +03:00
Zachary Scott
e8a334a9ee Merge pull request #19483 from yui-knk/fix/getting_started 
[ci skip] Fix an object of `reference`
 2015-03-29 12:52:19 -07:00
Jon Atack
676514c082 [skip ci] Fix counter_cache in the Rails Guides 
In the AR Associations Guide, this PR fixes:

- The counter_cache declaration is now shown only in the `belongs_to`
association.

- The docs stated that the counter_cache declaration needs to be on the
`has_many` side; now corrected to the `belongs_to` side.

- Split the custom column explanation out to a separate paragraph.

- Simplify the NOTE because it is true both with and without a custom
column name.
 2015-03-28 11:23:11 +05:30
Santosh Wadghule
2e1fefffab Remove old and not working link. [ci skip] 2015-03-28 01:09:52 +05:30
Santosh Wadghule
2816494f5a Correct doc sentence [ci skip] 2015-03-27 12:25:58 +05:30
Jon Atack
a1671afcd4 [skip ci] Update configuring.md with #18846 
Add `config.active_record.warn_on_records_fetched_greater_than` to the
Configuring Rails Guide.
 2015-03-27 09:46:14 +05:30
Vijay Dev
c26ee64b92 Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	guides/source/4_0_release_notes.md
 2015-03-26 16:22:41 +00:00
Kyle Oba
138180252d [skip ci] Minor edits for clarity, to make smooth, & separate clauses. 
* Add conjunction for clarity.
* Add comma between independent clauses: create command, and generation
  of fixtures.
 2015-03-25 16:04:57 -10:00
Andrey Nering
4b87780abc Documenting remove_column as a reversible migration method [ci skip] 2015-03-25 09:16:08 -03:00
Jon Atack
616f9a8fdb [ci skip] Active Record Validations guide fixes 
- Remove deprecated `[]=`

- Fix duplicate `errors#add` example. The second code example was
originally `[]=`, replace it with `[] <<`.

- Improve explanations for `errors#add` and `errors#full_messages`

Follow-up to PR #19457 (closed after borking my git history). Apologies
for the duplicate PR.

cc @kaspth
 2015-03-25 13:30:41 +05:30
yuuji.yaginuma
df280c4316 update config.assets.digest default value in guides [ci skip] 2015-03-25 09:17:12 +09:00
Kasper Timm Hansen
c8ca20f7a0 [ci skip] Update 4.2 Release notes with more assert_select information. 
Adds documentation for substitutions and why Regexp substitions look different
when assertion fails.
 2015-03-24 21:25:38 +01:00
Juanito Fatas
55f135f131 Rails 5 requires 2.2.1. [ci skip] 
Follow up of https://github.com/rails/rails/pull/19263.
 2015-03-24 20:19:14 +08:00
yui-knk
c79b9c8601 [ci skip] Fix an object of reference 2015-03-24 09:01:15 +09:00
yui-knk
c4a3a6da09 [ci skip] Change to a singular form (the comment model) 2015-03-24 08:48:11 +09:00
Jeroen van Baarsen
929a794a31 Add explicit base class for ActiveJob jobs 
* Jobs generated now inherent from ApplicationJob
* ApplicationJob inherents from ActiveJob::Base
* Added entry to changelog

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
 2015-03-23 22:37:11 +01:00
Carlos Antonio da Silva
b7b70c8deb Merge pull request #19455 from jonatack/patch-1 
[ci skip] Consistent spacing inside hash brackets in Action View guide.
 2015-03-22 19:14:09 -03:00
Rafael Mendonça França
4ba9c55fcd Merge pull request #19434 from kirs/deprecate-alias-method-chain 
Deprecate alias_method_chain in favour of Module#prepend
 2015-03-22 18:29:11 -03:00
Kir Shatrov
a982a42d76 Deprecate alias_method_chain in favour of Module#prepend 
…as discussed #19413
 2015-03-22 23:11:19 +02:00
Santosh Wadghule
47a07560a1 Change 'a' to 'an' for 'HABTM' word [ci skip] 2015-03-23 00:46:09 +05:30
yui-knk
133317593e [ci skip] Add link for "parameter_names section" 2015-03-23 00:43:04 +09:00
yui-knk
39dfbf0b9c [ci skip] Capitalize title 2015-03-22 22:54:14 +09:00
Jon Atack
46ea75e105 [ci skip] Consistent spacing inside hash brackets 2015-03-22 16:45:36 +05:30
Anderson Dadario
f612433710 [ci skip] Fix for Security Guide - Captcha Section 2015-03-22 07:55:45 -03:00
Kir Shatrov
0d16c9d1a5 Better title in Testing Guide 
suggested by @senny
https://github.com/rails/rails/pull/18305#issuecomment-73847595
 2015-03-22 12:52:17 +02:00
yui-knk
4f578ec36a [ci skip] Change the null to a not null constraint 2015-03-22 19:18:00 +09:00
Sean Collins
43fc9892ac Change 'girlfriend' to 'partner' 2015-03-20 15:24:54 -04:00
Jeremy Kemper
5154089c18 Revert "Merge pull request #19404 from dmathieu/remove_rack_env" 
Preserving RACK_ENV behavior.

This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing
changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
 2015-03-20 08:14:11 -07:00
amitkumarsuroliya
44e94a38f4 Updated MySQL documentation link to MySQL latest version 5.6 everywhere [ci skip] 2015-03-19 22:11:18 +05:30
Sean Griffin
505ad9af3e Merge pull request #19410 from y-yagi/add_reference_example 
add foreign_key option to result of references column type [ci skip]
 2015-03-19 09:16:11 -06:00
yuuji.yaginuma
478c73f670 add foreign_key option to result of references column type [ci skip] 2015-03-19 23:19:44 +09:00
Damien Mathieu
d578cbfb5c don't fallback to RACK_ENV when RAILS_ENV is not present 2015-03-19 10:06:28 +01:00
Abdelkader Boudih
7f338b9082 Merge pull request #19403 from akshay-vishnoi/docs 
[ci skip] use true as value rather than symbol
 2015-03-19 06:25:38 +00:00
Akshay Vishnoi
e3c70df197 [ci skip] use true as value rather than symbol 2015-03-19 10:50:50 +05:30
James
63d7fd6e94 [skip ci] Fixed typo 2015-03-19 17:12:09 +13:00
Akshay Vishnoi
64e27f9230 [ci skip] use false as value rather than symbol 2015-03-19 07:25:59 +05:30
Dimiter Petrov
a3e4c15048 Change commands in the Getting Started guide to use scripts in bin/ 
[ci skip]
 2015-03-18 21:14:18 +01:00
Yves Senn
8adfba360b Merge pull request #19240 from yui-knk/refactor/guide_rb 
Remove gem check in guides/rails_guides.rb

Conflicts:
	guides/rails_guides.rb
 2015-03-18 12:32:10 +01:00
Santosh Wadghule
4fd571abe2 - Make example code consistent for better understanding. [ci skip] 2015-03-18 14:30:05 +05:30
Santosh Wadghule
84cd102b45 Fix wrong model name for 'Articles', It should be 'Article' [ci skip] 
- Also changed 'a' to 'an' for 'Article' word.
 2015-03-18 12:33:05 +05:30
Ryan Wallace
7ab36f4532 Add config.active_record.dump_schemas. 
Fixes db:structure:dump when using schema_search_path and PostgreSQL
extensions.

Closes #17157.
 2015-03-17 10:43:26 -07:00
Mohnish G J
0b2f8b1cb9 Adds an example of how to access the arguments passed to a custom rake task [ci skip] 2015-03-16 21:56:03 +05:30
Anton Davydov
a290294175 [skip ci] Fix typos in guides 2015-03-15 23:55:06 +03:00
yui-knk
45f307fbbf [ci skip] Fix dead link 
getting_started.html#the-mvc-architecture is lost by this commit
2f06c94e38a116fdfa43d7b7117e6bf911a0bff5 (Mar 14 2012 !).

So replace it with wikipedia link.
 2015-03-16 00:10:48 +09:00
yui-knk
e3efe2bc33 [ci skip] Fix link format 2015-03-15 23:05:17 +09:00
Joel Brewer
2730a22d31 [ci skip] Subject-verb agreement 2015-03-14 12:32:01 -05:00
yui-knk
b4a37f0fcc [ci skip] Remove spaces 2015-03-14 10:05:10 +09:00
Rafael Mendonça França
675f299c8e Merge pull request #19322 from AndrewHendrie/AndrewHendrie-guides-testing-partials-patch 
Asserting partials modification
 2015-03-13 14:57:30 -03:00
Christian Ress
cd67d7eaa8 Added missing closing brace in sample code for safe HTML translations 
Closes #19321. [ci skip]
 2015-03-13 12:43:24 -03:00
Andrew Hendrie
3830854510 Asserting partials modification 
Changed "create Articles view" to "new article view". The create action doesn't typically have a view assigned to it. The view that's being referred to is the 'new' Article view.
 2015-03-13 11:28:18 -04:00
Joshua Peek
9655cb1ce7 Update sprockets links to point to rails org 2015-03-13 10:55:50 -03:00
Marius Butuc
c921606d26 Fix typo in the “Testing Your Mailers” docs 
* [ci skip]
 2015-03-12 15:36:53 -04:00
yui-knk
91c6972bcf [ci skip] Take NOTE: as paragraph to make NOTE block 2015-03-12 23:33:32 +09:00
Rafael Mendonça França
fd3e63e2d9 Merge pull request #18459 from cantino/action_controller_guide_edits 
Action Controller guide edits for grammar and clarity
 2015-03-11 22:53:00 -03:00
Andrew Cantino
54bc2de76d Edits for grammar and clarity, with help from georgeclaghorn and robin850. 2015-03-11 15:49:56 -10:00
Yves Senn
1b7ae86f26 Merge pull request #19289 from ahmad-alkheat/master 
Unnecessary usage of self in the guides [ci skip]
 2015-03-11 15:26:14 +01:00
Ahmad Al-kheat
eb9f0a0d14 Unnecessary usage of self in the guides 
I deleted self from the callbacks guides code example because it's unnecessary and this way it's more like the other examples where self was not used.
 2015-03-11 10:21:17 -04:00
yui-knk
7560c3c8ca [ci skip] Change to code element 2015-03-11 22:57:10 +09:00
yui-knk
5df7866ba0 Add backquote to :as option. 2015-03-11 13:55:40 +09:00
Andrew Hendrie
3f0b7b41e1 Changed 'blank space' to 'blank line' 
Line 85 stated that fixtures are typically separated by a blank space. I changed the wording to blank line because blank space could be misinterpreted as a non-breaking space character when in reality, each fixture record (in YAML) is separated by a blank line.
 2015-03-09 20:20:06 -04:00
Rafael Mendonça França
094ad22349 Merge pull request #19243 from yui-knk/fix/require 
Fix place of require 'rails_guides/markdown'
 2015-03-09 11:42:46 -03:00
yuuji.yaginuma
71dcc40a2c use public Module#include instead of send :include [ci skip] 2015-03-09 23:01:51 +09:00
Jeroen van Baarsen
2d7805c627 Rails 5.0 needs ruby 2.2.1 or higher 
Since there was a bug in 2.2.0, the minimum ruby requirement is 2.2.1. See https://github.com/rails/rails/commit/8ed0b89b
[skip ci]
 2015-03-08 14:03:47 +01:00
yui-knk
ec895167c2 Fix place of require 'rails_guides/markdown' 2015-03-07 16:50:27 +09:00
yui-knk
2a307623a2 Remove gem check in guides/rails_guides.rb 
Now rails/Gemfile includes nokogiri and redcarpet,
so remove gem check from guides/rails_guides.rb
 2015-03-07 13:38:59 +09:00
sshaw
f9369c0f51 More docs on tagged logging [ci skip] 
Mention that tags can also come from a Proc that accepts the request
object or something's to_s method
 2015-03-06 22:20:22 -05:00
Robin Dupret
d969405acd Some documentation edits [ci skip] 
* Fix a few typos
* Wrap some lines around 80 chars
* Rephrase some statements
 2015-03-05 14:18:09 +01:00
yuuji.yaginuma
2449258dc4 fix spelling, ERb -> ERB [ci skip] 2015-03-04 13:37:53 +09:00
yui-knk
59b07df504 [ci skip] Remove unnecessary space 2015-03-04 08:52:21 +09:00
T.J. Schuck
c1ef21e042 Update cache_timestamp_format default value in guides 
[ci skip]
 2015-03-03 18:24:20 -05:00
Robin Dupret
8a74190121 Tiny documentation edits [ci skip] 2015-03-03 21:30:20 +01:00
Piotr Szotkowski
d69c7e66b3 Remove line wrapping from the benchmark/ips output 
[ci skip]
 2015-03-03 21:29:26 +01:00
Jeremy Kemper
35db2bcd82 Remove mention of long-gone initializer and config 
Serving public files from multiple paths was removed in
afc828828ffffe7edeb4648a9d2aa4731191ae21
 2015-03-03 11:46:56 -07:00
yui-knk
9ebe99ca1d [ci skip] Fix fenced code block lang 2015-03-03 09:04:13 +09:00
yui-knk
6fb368fdef [ci skip] Add . 2015-03-03 08:51:16 +09:00
Eileen M. Uchitelle
f08c3f737b Merge pull request #19106 from teeceepee/patch-1 
Improve guides [ci skip]
 2015-03-02 09:50:55 -05:00
Yu Haidong
b7aa845c01 Modify guides for a better sounding sentence 2015-03-02 22:30:59 +08:00
Robin Dupret
565bf8926e Merge pull request #19168 from gsamokovarov/byebug-defaults-guide 
Nit pick the byebug settings guide for default values [ci skip]
 2015-03-02 13:06:55 +01:00
Robin Dupret
76e37e6fa8 Merge pull request #19097 from gsamokovarov/web-console-guide 
Web Console documentation for the upcoming 2.1 release [ci skip]
 2015-03-02 13:06:04 +01:00
Genadi Samokovarov
62dfb16842 Nit pick the byebug settings guide for default values [ci skip] 
In #19097 we had a discussion where we decided to change `byebug`
settings sections default part to actually say `defaults`.
 2015-03-02 14:05:08 +02:00
Genadi Samokovarov
f46b198142 Web Console documentation for the upcoming 2.1 release [ci skip] 
With the upcoming 2.1 [web-console release], I have tweaked the existing
documentation a bit. I tried to focus on the spawning console use case,
because I think a lot of people overlook that.

Tried to explain it as best as I can, however, my English and prose
aren't my best skills :) If you guys can chime in and help me improve
the wording, I would be extremely grateful.

There has been some configuration default changes. For example, the
whitelisted IPs always include IPv4 and IPv6 localhosts now and this
wasn't the case in 2.0. I think a lot of people got bitten by it, that's
why I changed it. I'm a bit confused on how to document this. Should I
just document the latest version, I don't think I can expect all the
people reading the guide to be on it.

[web-console release]: https://github.com/rails/web-console/pull/110
 2015-03-02 13:53:51 +02:00
Kevin Jayanthan
c7172f5040 Fixing incorrect class name used in an example. 
On "Controller Namespaces and Routing" section of the "Rails Routing from the Outside In" , the examples are using "AritclesController" as an example of a controller, to show different organizers. But on the line 232, it incorrectly uses "PostsController" instead of "AritclesController".
 2015-03-02 14:56:31 +05:30
Arthur Nogueira Neves
485e125668 Merge pull request #19159 from stephenminded/docs_fix_polymorphic_index 
[docs fix] Composite index is actually [:imageable_type, :imageable_id]
 2015-03-01 23:01:15 -05:00
Todd Bealmear
c7a37c10ad Add Enumerable#without 2015-03-01 18:45:45 -08:00
Steve Lounsbury
ec85f9da29 Composite index is [:imageable_type, :imageable_id] [ci skip] 2015-03-01 21:38:41 -05:00
Steve Lounsbury
683ad0b471 Indexing a polymorphic assoc adds index on type and id [ci skip] 2015-03-01 14:06:38 -05:00
yui-knk
a1035ad238 [ci skip] Fix fenced code block lang 2015-03-02 00:37:58 +09:00
yui-knk
d1a503be9b [ci skip] Add . 2015-03-01 21:23:09 +09:00
yui-knk
a113c95874 [ci skip] Fix fenced code block lang 2015-03-01 10:44:57 +09:00
Darío Hereñú
f8dabedf13 Update link (minor fix) 2015-02-28 22:39:52 -03:00
Yves Senn
9b4d8b8fbe Merge pull request #19130 from yui-knk/fix/active_support_core_extensions2 
[ci skip] Fix to comment
 2015-02-28 18:30:35 +01:00
yui-knk
c9f0f84d7c [ci skip] Fix to comment 2015-03-01 02:04:27 +09:00
yui-knk
0a3afe236b [ci skip] Fix to String 2015-03-01 01:40:02 +09:00
Yves Senn
c93f808ea5 Merge pull request #19125 from y-yagi/testing_guide 
add `ActiveJob::TestCase` to list of classes providing for test [ci skip]
 2015-02-28 16:38:14 +01:00
yuuji.yaginuma
4b0f0bc37e add ActiveJob::TestCase to list of classes providing for test [ci skip] 2015-02-28 23:31:11 +09:00
Guillermo Iguaran
433d439b79 Merge pull request #19123 from yui-knk/fix/active_support_instrumentation2 
[ci skip] Remove `,`
 2015-02-28 09:28:17 -05:00
yui-knk
52cae7d558 [ci skip] Remove , 2015-02-28 22:08:55 +09:00
yui-knk
b008bfddbd [ci skip] Replace ActiveResource with Active Resource 2015-02-28 22:02:13 +09:00
yui-knk
d495592541 [ci skip] Fix table of 4_1_release_notes.md 2015-02-28 18:24:15 +09:00
Richard Venneman
29165739d9 Remove reference to workingwithrails.com since it is being retired 2015-02-27 22:18:53 +01:00
Rafael Mendonça França
75aa573c8b Don't recommend to precompile all assets 
It is very slow since it will precompile even plugins.

Also it is very unlikely that any application will use this patterns
since it is not a good practice to include all assets manually in the
page.

[ci skip]
 2015-02-27 14:56:08 -03:00
Yury Otcheski
8526921d29 Guides mistake about page caching. 
DHH's key-based cache expiration isn't alternative to page caching. It's true about action caching but not page caching. I propose to remove this line as confusing, page caching is still best if applicable.
[ci skip]
 2015-02-27 18:36:28 +03:00
Aditya Kapoor
98d1ea7411 [ci-skip] correct doc about custom validators 2015-02-27 19:25:25 +05:30