TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
12,353 Commits 2 Branches 0 Tags 294 MiB
214b548485
Commit Graph

2405 Commits

Author SHA1 Message Date
Joshua Peek
f82e1046f8 reset_session needs to be a real method so flash can override it 2009-12-21 17:29:59 -06:00
David Heinemeier Hansson
fa8849a573 Merge branch 'master' of github.com:rails/rails 2009-12-21 11:28:16 -08:00
David Heinemeier Hansson
3ff9e9ee14 Its now possible to use match 'stuff' => 'what#stuff' instead of using the :to for simple routes 2009-12-20 20:37:36 -08:00
David Heinemeier Hansson
83f4d86a93 Rename the RenderingController module to just plain Rendering 2009-12-20 17:15:31 -08:00
David Heinemeier Hansson
c06aff0a7e Added cookies.permanent, cookies.signed, and cookies.permanent.signed accessor for common cookie actions [DHH] 2009-12-20 14:33:13 -08:00
Yehuda Katz
e48b4c2dd0 :to => redirect() can take a String using 1.9-style interpolation or proc that takes the path parameters as a Hash 2009-12-20 14:07:32 -08:00
Joshua Peek
2419fae092 Pending tests for AD Response 2009-12-17 22:10:37 -06:00
Joshua Peek
3b44f35e24 Don't need response prepare! 2009-12-17 22:10:37 -06:00
David Heinemeier Hansson
fa575973b1 Added alert/notice from 2-3-stable and refactored redirect_to into just living in Redirector [DHH] 2009-12-17 16:37:11 -08:00
Joshua Peek
7ee5843c3c Fully expand relative rails framework paths and make sure we aren't 
adding any to the load path more than once.
 2009-12-16 11:56:51 -06:00
Joshua Peek
5f8e48cbd2 Move route reloading into railties 2009-12-14 17:54:41 -06:00
Joshua Peek
ce970a8bb9 Remove route loading tests since it should be tested by railties 2009-12-14 16:52:22 -06:00
Joshua Peek
bcb686054a Hush loading AR unless it fails 2009-12-14 16:01:23 -06:00
Joshua Peek
ee395fe626 TestProcess belongs in AD 2009-12-12 18:09:44 -06:00
Joshua Peek
2297eaed5b "new" and "edit" name routes always need to be prepend to the 
named_route [#3561 state:resolved]
 2009-12-11 12:46:50 -06:00
Joshua Peek
588225f885 Remove fancy method not allowed resource exceptions since they are 
too much of a hack
 2009-12-11 00:01:22 -06:00
Joshua Peek
2f90d70049 Kill RouteSet#recognize 2009-12-10 23:45:04 -06:00
Yehuda Katz
8b9275340f Merge branch 'master' of github.com:rails/rails 2009-12-10 13:11:15 -08:00
Joshua Peek
ec5434c3c2 Check block arity passed to routes draw so you don't need to use 
|map|
 2009-12-09 20:46:32 -06:00
Carlhuda
f9d570bdd8 Simpler RenderOption API -- removes the need for registering the types and extending a module 2009-12-09 13:40:49 -08:00
Joshua Peek
9fbde11b8b More test porting 2009-12-08 17:41:00 -06:00
Joshua Peek
511cef296b Tack format onto resource routes 2009-12-08 17:19:49 -06:00
Joshua Peek
2be5e088d2 Use new routing dsl in tests 2009-12-08 16:52:26 -06:00
Joshua Peek
ac711043ec Fix ambiguous access_token scoping example 2009-12-08 16:15:25 -06:00
Joshua Peek
3d91d7f0a2 Routes added under resource collection should be prefixed with 
resource collection name
 2009-12-08 15:31:56 -06:00
Joshua Peek
1fc58a889d Fixed named prefix scope in resource member and collection actions 2009-12-07 20:57:01 -06:00
Joshua Peek
5835447b6f named_prefix doesn't join with "_" 2009-12-07 19:31:29 -06:00
Joshua Peek
e8489b43e2 Allow name_prefix to be pass into scope 2009-12-07 19:24:33 -06:00
Joshua Peek
40ad54e381 Allow scope to take :path and :controller options 2009-12-07 18:28:02 -06:00
José Valim
2ecfa817c9 Responder redirects to resource if destroy fails. 
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local>
 2009-12-07 15:05:27 -08:00
Joshua Peek
48127c637c Deprecate recalling generation params when the defaults are nil 2009-12-06 20:40:07 -06:00
Joshua Peek
4663f75f6b Update rackmount to fix some pending tests 2009-12-05 13:10:00 -06:00
Carlhuda
c1304098cc Reorganize autoloads: 
* A new module (ActiveSupport::Autoload) is provide that extends
    autoloading with new behavior.
  * All autoloads in modules that have extended ActiveSupport::Autoload
    will be eagerly required in threadsafe environments
  * Autoloads can optionally leave off the path if the path is the same
    as full_constant_name.underscore
  * It is possible to specify that a group of autoloads live under an
    additional path. For instance, all of ActionDispatch's middlewares
    are ActionDispatch::MiddlewareName, but they live under 
    "action_dispatch/middlewares/middleware_name"
  * It is possible to specify that a group of autoloads are all found
    at the same path. For instance, a number of exceptions might all
    be declared there.
  * One consequence of this is that testing-related constants are not
    autoloaded. To get the testing helpers for a given component,
    require "component_name/test_case". For instance, "action_controller/test_case".
  * test_help.rb, which is automatically required by a Rails application's
    test helper, requires the test_case.rb for all active components, so
    this change will not be disruptive in existing or new applications.
 2009-12-02 20:01:08 -08:00
Joshua Peek
4dee277a9b Stop escaping "[]" in query string 2009-12-02 12:46:14 -06:00
Jeremy Kemper
de40bc033a Ensure Cache-Control max-age is an integer 2009-12-02 03:23:00 -08:00
Joshua Peek
70d0b7c87a Fix parens warning in ajax test 2009-12-01 23:19:41 -06:00
Joshua Peek
7fe19d415a Make recognize try to constantize controller to see if it exists 2009-12-01 22:22:48 -06:00
Joshua Peek
44587b7fae Merge branch 'master' of github.com:rails/rails 2009-12-01 14:53:39 -06:00
Joshua Peek
61a31f3d3d Fix generating params with optional defaults [#3404 state:resolved] 2009-12-01 14:52:19 -06:00
Jeremy Kemper
0c4990b5f4 Fix caching test to ensure notifications are all delivered 2009-12-01 12:19:42 -08:00
José Valim
6e30361260 Allow ActionController::Responder to have a common entry point for all formats. 
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local>
 2009-12-01 08:23:43 -08:00
Joshua Peek
075f50d62c Fix some nested resource generation tests 2009-11-29 18:17:14 -06:00
Jeremy Kemper
4f2a04cc08 Notifications: extract central Notifier, cordon off the internal Fanout implementation, and segregate instrumentation concerns 2009-11-28 12:50:09 -08:00
Joshua Peek
59dbae145b Privatize Routing.possible_controllers and fix brittle url helper 
controller test loading.
 2009-11-23 21:50:21 -06:00
Joshua Peek
15ab3a98a1 Find all controllers in memory to use for routing 2009-11-23 20:20:50 -06:00
Joshua Peek
350d3daa88 Remove inflection reloads routes test 2009-11-23 19:25:39 -06:00
Jeremy Kemper
f8d06e62a9 Pending test now passing 2009-11-23 14:07:54 -08:00
Joshua Peek
6e67f88a11 Extended and case insensitive regexp routes aren't that important. 
Mark them as pending till I figure it out.
 2009-11-19 17:58:57 -08:00
Joshua Peek
5df26dd7a9 Add basic nested named route support to new routing dsl. Also add a 
bunch of pending tests.
 2009-11-19 09:04:53 -08:00
Jeremy Kemper
0dfd993e77 Fix test bleed 2009-11-18 17:54:27 -08:00
Jeremy Kemper
e1385be025 Extract form_authenticity_param instance method so it's overridable in subclasses 2009-11-17 23:40:06 -08:00
Will Read
7fadb3f261 Allow explicit placement of hidden id element for nested models. 
[#3259 state:resolved]

Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-11-15 21:47:57 +01:00
José Valim
2cb47c742f Split mime responder into smaller chunks and allow action to be configured. 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-11-13 09:52:52 -08:00
Jeremy Kemper
1ac8e0662f Rack: HTTPS is either 'on' or 'off' as of 9b7a0569e4067d0c23a00fc24273436e85c56d7f 2009-11-10 16:57:55 -08:00
Jeremy Kemper
8cd486da80 test-unit 2 compat: assert_raise doesn't support regexp second arg to match exception message 2009-11-10 16:14:10 -08:00
Joshua Peek
11e798ae0f Avoid adding component lib/ to load path multiple times 2009-11-09 23:28:36 -06:00
Joshua Peek
23229d5ad4 Remove preflight lib check during AP tests. Bundler resolves this issue 2009-11-09 22:59:30 -06:00
Joshua Peek
a31ecff554 Don't warn me if I'm not using bundler to run tests 2009-11-09 22:51:48 -06:00
Joshua Peek
e9d21ca903 Add pending test for generating routes with optional params that recall last 
request
 2009-11-09 22:18:51 -06:00
Joshua Peek
763489ce06 Add pending test for route generation with default param 2009-11-09 21:54:50 -06:00
Jeremy Kemper
0ac88af998 Remark when bundled env require fails 2009-11-09 16:10:37 -08:00
Xavier Noria
1979e9c855 Symbol#to_proc is not needed for Ruby >= 1.8.7 2009-11-09 22:16:51 +01:00
Joshua Peek
c10f4ae01d Merge remote branch 'Fingertips/master' 2009-11-08 16:03:15 -06:00
Jeremy Kemper
a595abff21 Unknown :format param should result in empty request.formats 2009-11-08 12:12:58 -08:00
Chris Hapgood
c2cfb20198 Share ActionView::TestCase's output_buffer with view for concat support. 
[#3467 state:resolved]

Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-11-07 00:42:07 +01:00
Chris Hapgood
b43964d606 Make some assertions in the ActionView::TestCase tests actually do something. 
[#3468 state:resolved]

Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-11-07 00:39:39 +01:00
Nathan Weizenbaum
cbded53671 When rendering layouts with blocks, use #capture to avoid assuming that the return value is the block's content. 
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local>
 2009-11-05 20:08:04 -08:00
Jeremy Kemper
a8ed10546d Ruby 1.9: don't assume params are US-ASCII. Hands off the encoding. 2009-11-04 16:27:54 -08:00
Jeremy Kemper
dc1816da30 Ruby 1.9: fix number precision test 2009-11-04 16:10:24 -08:00
Jeremy Kemper
425a02cece Ruby 1.9: resolve constant lookup issues 2009-11-04 15:41:50 -08:00
Jeremy Kemper
0ff8f81adc Ruby 1.9: more constant lookup badness :( 2009-11-04 15:00:19 -08:00
Jeremy Kemper
52e2bbd5c0 Ruby 1.9: work around constant resolution behavior change :( 2009-11-04 14:51:54 -08:00
Jeremy Kemper
726a2fc8d2 Give useful test:isolated failures 2009-11-04 12:44:06 -08:00
Joshua Peek
f950d0b4af Fix simple resource named routes for new routing dsl 2009-11-03 11:23:22 -06:00
José Valim
976c264724 Extracted localized_cache.rb from ActionController, added it to AbstractController and made ActionMailer use it. 2009-11-01 02:23:49 +01:00
José Valim
0396004861 Add some basic render_test to AbstractController. 2009-11-01 02:23:48 +01:00
José Valim
0cf16ddb88 Improve AbstractController layouts coverage. 2009-11-01 02:23:48 +01:00
José Valim
2d514e5352 Move some of helper tests to AbstractController. 2009-11-01 02:23:48 +01:00
José Valim
43d5504f0a Move all render and layout pieces required in ActionMailer from ActionController to AbstractController. 2009-11-01 02:23:48 +01:00
Yehuda Katz
51c24ae3e3 Caching refactoring 2009-10-29 00:44:12 -04:00
José Valim
427a7385eb Make polymorphic_url work with symbols again and refactor it [#1384 status:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-10-28 14:13:48 -05:00
Joshua Peek
07da304ff8 Some more generation tests 2009-10-27 21:02:21 -05:00
Joshua Peek
43e0bc1c9f Extract routing controller stub helper into abstract unit 2009-10-27 21:02:20 -05:00
Joshua Peek
e296ea056e Enable named route tests 2009-10-27 21:02:20 -05:00
Joshua Peek
759f2ccc4c Start migrating AC routing tests into dispatch folder 2009-10-27 21:02:20 -05:00
Yehuda Katz
2bdd8fa863 Clean up parameter logging some 2009-10-26 21:31:37 -07:00
Yehuda Katz
000d593621 Clean up and update cookies 2009-10-26 18:01:09 -07:00
Yehuda Katz
e1786ee6eb Fixes expires_now and cleans things up a bit 2009-10-26 17:32:42 -07:00
Joshua Peek
3e35d30c0c Always add actionpack/lib to load path for isolated tests 2009-10-21 11:32:31 -05:00
Yehuda Katz + Carl Lerche
4f6d6f7031 Have all the tests running off a single Gemfile 2009-10-20 16:34:44 -07:00
Joshua Peek
a5c82a9dfb Start rewriting some internal tests to use the new routing dsl 2009-10-20 16:03:55 -05:00
Joshua Peek
a1ce52effc New routing dsl 2009-10-20 12:31:23 -05:00
Joshua Peek
df68cae0c0 Group together all the old routing dsl logic 2009-10-20 10:46:27 -05:00
Joshua Peek
a74022ecd3 Move Routing into AD 2009-10-20 10:14:46 -05:00
Joshua Peek
3895e2ccb3 Donate tests I wrote for rackmount rails integration 2009-10-20 09:52:59 -05:00
Joshua Peek
a1df259074 Replace decaying routing internals w/ rack-mount 2009-10-19 23:32:17 -05:00
Joshua Peek
6c581f5fd5 Kill routing tests expecting path to be unescaped. Most rack servers already escape PATH_INFO. 2009-10-19 22:42:11 -05:00
Joshua Peek
33258d713a Fix brittle query string comparisons 2009-10-19 22:42:11 -05:00
Jeremy Kemper
acb1624f27 Merge commit 'josevalim/fixes' 
Conflicts:
	railties/test/generators/app_generator_test.rb
 2009-10-19 18:37:19 -07:00
Joshua Peek
91726c201b Relax generation requirements and only enforce the requirements used in the path segment 2009-10-18 11:05:24 -05:00