TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
16,314 Commits 2 Branches 0 Tags 294 MiB
231d7676f7
Commit Graph

3742 Commits

Author SHA1 Message Date
Mislav Marohnić
c2ca73c9ee ActiveModel::Observing: stop using Observable Ruby module, re-implement notify_observers 
`Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
callback chains) and has extra features (like `changed`) that were never used.

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:09:07 -07:00
Mislav Marohnić
cf616e4876 merge callbacks_observers_test.rb into lifecycle_test.rb where other observers test reside 
Benefits: test able to run independently, subclassing instead of changing the original Comment model

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:09:07 -07:00
Aaron Patterson
779723a0b4 fix a failure and some warnings on 1.9.2 [#4417 state:resolved] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-04-16 09:03:42 -07:00
Michael Koziarski
5aa58cc03f Split the observer railtie into two phases. 
Observers observing models with scopes defined will require the connection to be established.
 2010-04-16 09:49:06 +12:00
Xavier Noria
6be04c4631 i18n -> AS/i18n 2010-04-14 02:30:02 -07:00
Xavier Noria
dd635ec701 adds missing requires for arel and i18n, prevents Arel constant from being autoloaded (which was still seen), though it probably hides an issue related to dependencies 2010-04-14 02:01:55 -07:00
Xavier Noria
9a4fdff0af Merge commit 'docrails/master' 2010-04-14 01:00:03 -07:00
Diego Carrion
e090898c5e fixed typo in RUNNING_UNIT_TESTS 2010-04-14 13:15:51 +10:00
Pratik Naik
2ff5f38abb Ensure not to load the entire association when bulk updating existing records using nested attributes 2010-04-14 01:52:29 +01:00
Xavier Noria
0e274639b4 removes unnecessary assignment and local variable in AR::Base#subclasses, and revises its rdoc 2010-04-13 16:11:36 -07:00
David Heinemeier Hansson
4c8af9bf51 Update changelogs for release 2010-04-13 12:14:54 -07:00
Andrew White
9cea9bc7f0 Refactor compute_type to handle situations where the correct class is already loaded 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-12 21:31:20 -07:00
Emmanuel Oga
f8eddcc735 make ActiveRecord::Base.subclasses a public method 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-12 21:20:45 -07:00
Phil Smith
bab1f910c7 table_name_prefix and table_name_suffix are class_attributes instead of cattr_accessors. [#4230] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-12 10:59:38 +02:00
Andrew White
788d923893 Generate module file for namespaced models [#4230 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-12 10:57:27 +02:00
Aaron Patterson
ecf039fc05 mode postgresql adapters table_exists? method take the schema in to account. [#4341 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-11 14:53:24 -07:00
Jeremy Kemper
6d29f9789e Fix evals missing context 2010-04-10 22:39:10 -07:00
Jeremy Kemper
86dda361e2 Avoid deprecated String#to_a by using Array.wrap(...) instead of Array(...) 2010-04-10 22:37:36 -07:00
Aaron Patterson
61355c0e24 clearing up many warnings, removing unnecessary regular expresion comparisons [#4365 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-10 22:13:42 -07:00
mfoster
5850edf104 Made arrays of ActiveRecords, and any classes, with namespaces convert to valid xml. [#3824 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-10 18:12:43 +02:00
Aaron Patterson
f46dc9b6b7 clear the rest of the warnings, run with warnings turned on [#4332 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-10 13:50:38 +02:00
Aaron Patterson
922e4c57a4 kill warnings on 1.8.7 [#4331 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-10 13:50:35 +02:00
José Valim
ee309d506c Update versions (otherwise you install a gem from source as beta3 but internally it's beta2) and update CHANGELOG. 2010-04-10 12:17:34 +02:00
Santiago Pastorino
13e00ce606 fix stack trace lines on class_eval 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-09 21:28:49 +02:00
Santiago Pastorino
808847792c db:test:prepare for tasks only if AR is loaded 2010-04-09 16:03:27 +12:00
Michael Koziarski
1e3dce08e1 Revert "When creating database with rake, create schemas in schema_search_path if it doesn't exist." 
This reverts commit 6c2a0675f11a9b5b8e88ed7dbccd65cb51be8029.

Reverting because it breaks the ability to run tests using a non-superuser.

Conflicts:

	activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
	activerecord/lib/active_record/railties/databases.rake
 2010-04-09 11:30:40 +12:00
Kristopher Murata
36129f21b8 Dirty datetime attributes should be aware of time zone info [#3658 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-08 10:26:16 -07:00
Pratik Naik
2c27e3d336 Some doc updates reflecting the new query API 2010-04-08 16:49:52 +01:00
Pratik Naik
48634bf59a Reset named scope cache whenever the @target is reset 2010-04-07 01:16:45 +01:00
Simon Effenberg
4f1d0f6b7e remove_index now uses quote_table_name() [#4300 state:resolved] 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2010-04-06 14:15:57 +12:00
Pratik Naik
1f7b4447a9 Memoize association.named_scope calls 2010-04-05 21:55:24 +01:00
Xavier Noria
89978f10af moves Object#singleton_class to Kernel#singleton_class to match Ruby also there, same for #class_eval to simplify, and adds coverage for class_eval 2010-04-05 12:15:08 -07:00
Xavier Noria
723e91e9fd Merge commit 'docrails/master' 2010-04-04 13:36:15 -07:00
Andrew White
00884a5901 Merge branch 'master' of github.com:lifo/docrails 2010-04-04 17:34:23 +01:00
Andrew White
48b2451142 Update various documentation examples to use new routing DSL 2010-04-04 17:34:13 +01:00
Andrew White
98b4424141 Add tests to prevent regression of lazy evaluation of has_many ..., :dependent => :___ 
[#2627 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-04 07:00:24 -07:00
Xavier Noria
11161e6c96 Merge commit 'rails/master' 2010-04-03 10:56:15 -07:00
Carl Lerche
467d251c3d Bring back +extra_conditions+. This effectively reverts 386b7bfd9d78a6d8c8bc7cc4a310df806ad0ba57 2010-04-03 09:54:15 -07:00
Carl Lerche
6e18fa0375 Raise a StatementInvalid error when trying to build a condition with hash keys that do not correspond to columns. 2010-04-03 09:22:00 -07:00
Carl Lerche
52ffaa182e Sanitize association conditions using the correct class 2010-04-03 09:22:00 -07:00
Carl Lerche
13004d4f84 Make the query built by has_many ...., :dependent => :____ lazy since all the information is not really available yet. 2010-04-02 22:33:57 -07:00
Carl Lerche
386b7bfd9d Remove an unused argument 2010-04-02 20:13:09 -07:00
Pratik Naik
c6372d6049 Improve scope docs 2010-04-03 01:49:01 +01:00
Pratik Naik
41a2ba652a Improve named scope lambda 2010-04-03 01:35:43 +01:00
Pratik Naik
684e4d39d6 Remove unnecessary argument for creating scopes 2010-04-03 01:35:43 +01:00
Pratik Naik
13eb2c87e6 Make Relation#inspect less noisy 2010-04-02 18:57:46 +01:00
Pratik Naik
cfa283201e Goodbye ActiveRecord::NamedScope::Scope 2010-04-02 18:57:46 +01:00
Pratik Naik
62fe16932c Make Relation#first and Relation#last behave like named scope's 2010-04-02 18:57:46 +01:00
Pratik Naik
ee07950c03 Scope#method_missing can safely rely on Relation#method_missing 2010-04-02 18:57:45 +01:00
Pratik Naik
0be31f8563 Scope#current_scoped_methods_when_defined is no longer needed 2010-04-02 18:57:45 +01:00
Pratik Naik
83ebe6224f Oops :extends is not a MULTI_VALUE_METHOD 2010-04-02 17:39:47 +01:00
Pratik Naik
b77dd218ce Add Relation extensions 2010-04-02 17:38:02 +01:00
Pratik Naik
bc7da9b77d Consistency when using Relation constants 2010-04-02 17:38:02 +01:00
Rizwan Reza
0dd3eac967 Merge branch 'master' of git://github.com/rails/rails 2010-04-02 14:57:30 +04:30
David Heinemeier Hansson
d956003fa4 Neat and tidy, I say 2010-04-01 13:46:04 -07:00
David Heinemeier Hansson
d868cb4f8a Prep for beta2, depend on latest Bundler 2010-04-01 13:36:45 -07:00
Doug Richardson
e8292abbcd Read postgresql encoding using string key instead of symbol [#4304 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-01 08:36:57 -07:00
Ernie Miller
98bf00d50d Add tests for postgresql column type mapping updates [#4270 state:resolved] 
Signed-off-by: Emilio Tagua <miloops@gmail.com>
 2010-03-31 19:22:54 -03:00
Ernie Miller
ccf8311123 Fix mapping of bigint/smallint/uuid columns in postgresql adapter. 
Signed-off-by: Emilio Tagua <miloops@gmail.com>
 2010-03-31 19:22:44 -03:00
Xavier Noria
824fa10f4d Merge commit 'rails/master' 2010-03-31 07:47:58 -07:00
Pratik Naik
5562abb4e9 Dont try to load the record from the db if preloading didn't find anything 2010-03-31 12:56:09 +01:00
Emilio Tagua
37102a5237 Fix failing test in MySQL. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-30 16:01:53 +02:00
Emilio Tagua
8d99ec9a4d Named scopes shouldn't test equality using to_a if it's not an Array, this was causing records to be loaded before they were needed. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-30 15:36:18 +02:00
wycats
4aded43b73 Replace the placeholder base_hook API with on_load. To specify some code that 
should run during framework load do:

ActiveSupport.on_load(:action_controller) do
  # Code run in the context of AC::Base
end
 2010-03-29 17:08:50 -07:00
José Valim
56bed512f9 Fix dom_id for ActiveRecord [#4296 state:resolved] 2010-03-30 01:32:26 +02:00
Ernie Miller
63026541b2 Fix honoring :primary_key option when joining or eager loading a belongs_to association 
[#765 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-29 15:24:27 -07:00
Jeremy Kemper
36a5e78c14 Add missed changelog for table_name_prefix 2010-03-29 08:56:40 -07:00
Emilio Tagua
7006aa1a85 Arel now handles ranges with excluded end. 2010-03-29 12:30:13 -03:00
Emilio Tagua
53ddbfc460 Warn scoped order and limit are ignored. [#4123 state:resolved] 2010-03-29 11:30:06 -03:00
wycats
5f7bc47303 Rename modularized_table_name_prefix to full_table_name_prefix [#4032 state:resolved] 2010-03-28 23:45:38 -07:00
Andrew White
67d1cec4c8 Add the ability to specify table_name_prefix on individual modules 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 23:43:28 -07:00
Aaron Patterson
98d2d8ce2c use the database to lower case strings rather than ruby. [#4293 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 22:16:34 -07:00
David Heinemeier Hansson
a4eab8f1f3 Update example of default_scope to use the new arel finder syntax 2010-03-28 19:11:06 -07:00
Eugene Pimenov
fc6746fc3f PostgreSQL adapter: escape_bytea, quote_string and unescape_bytea aren't thread-safe in Ruby 1.8 [#3237 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 18:04:46 -07:00
Matthew Rudy Jacobs
b0967cc5cf defining a named_scope which overwrites an existing method is now allowed we just log a warning. 
This was motivated by the fact that :open is defined on all classes
as such the named_scope "open" can never be used, without hacking
ActiveRecord with an "undef_method" [#4083 state:resolved]

Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 13:53:20 -07:00
Rizwan Reza
f1e5a9ff98 Add :dependent = to has_one and has_many [#3075 state:resolved] 2010-03-28 18:47:46 +04:30
Xavier Noria
76f024ac8d adds missing requires for Object#blank? and Object#present? 2010-03-28 14:15:02 +02:00
Xavier Noria
105f9b8154 adds missing requires for Object#duplicable? 2010-03-28 13:26:13 +02:00
Rizwan Reza
155f0be16b Changes migration number to version due to ambiguity. [#3065 state:committed] 2010-03-28 12:16:46 +04:30
Rizwan Reza
66d57d7ba8 Oops, a docfix. 2010-03-28 11:10:35 +04:30
Rizwan Reza
6c2a0675f1 When creating database with rake, create schemas in schema_search_path if it doesn't exist. 2010-03-28 11:01:15 +04:30
José Valim
ff522cf4bc Revert "primary_key now supports :limit for MySQL". Break Sam Ruby app. 
To reproduce, start a new application, create a scaffold and run test suite. [#876 state:open]

This reverts commit faeca694b3d4afebf6b623b493e86731e773c462.
 2010-03-27 14:39:43 +01:00
Rizwan Reza
faeca694b3 primary_key now supports :limit for MySQL 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 03:49:53 -07:00
José Valim
0cb3311d06 Revert "primary_key now supports :limit. [#876 state:resolved]" since it broke AR test suite. 
This reverts commit 41e5c7ed44fedb95636ef9b7a792c46ea03309bd.
 2010-03-27 11:05:37 +01:00
Aaron Patterson
3172db12e4 avoiding a few closure references by evaling. [#4223 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 01:41:44 -07:00
Rizwan Reza
41e5c7ed44 primary_key now supports :limit. [#876 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 01:33:42 -07:00
Pratik Naik
68ade93cde Revert "Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved]" 
This reverts commit 3a875e618487a06a56f6cf912cf5440f294921cc.
 2010-03-27 08:22:32 +00:00
Nathaniel Bibler
3a875e6184 Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 00:35:39 -07:00
Kris Selden
afb786ad8a In PostgreSQLAdapter, switch tables query to use current_schemas function [#918 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-26 17:18:33 -07:00
wycats
197904341f Merge branch 'master' into docrails 2010-03-26 15:10:24 -07:00
José Valim
395d6648ce Move application configuration to the application configuration object, remove railtie_name and engine_name and allow to set the configuration object. 2010-03-26 18:47:55 +01:00
Rizwan Reza
5176b28852 Better MySQL Error message. [#3775 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-26 13:25:53 +01:00
chrisfinne
76d2c455c0 Add debugging documentation for _callback_chain to ActiveRecord::Callback 
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
 2010-03-26 14:01:21 +04:30
Jeremy Roman
ffb22bd2be fix habtm documentation to correct typo 
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
 2010-03-26 13:35:56 +04:30
Jeremy Kemper
a8b93d7a05 Bump to arel 0.3.3 to resolve Active Support dep 2010-03-25 11:52:53 -07:00
Emilio Tagua
d06a754fdd Remove unused attributes_with_quotes method. 2010-03-25 15:47:16 -03:00
Emilio Tagua
fc2e25734a Move methods from association to relation finder methods. 2010-03-25 15:47:06 -03:00
Emilio Tagua
90a4709601 Refactor relation merging to create just one relation and then assign values, instead of creating multiple relation objects. 2010-03-25 13:03:30 -03:00
Emilio Tagua
e260d5fbcf Require Arel 0.3.2 2010-03-25 12:37:38 -03:00
Emilio Tagua
e3a2fae05d Add add_limit_offset! to adapters. 2010-03-25 12:37:38 -03:00