Commit Graph

79 Commits

Author SHA1 Message Date
David Heinemeier Hansson
25b656fefa Fixed that single quote was not escaped in a UrlHelper#link_to javascript confirm #549 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 12:07:13 +00:00
David Heinemeier Hansson
eb5ca2ea5f Removed the default border on link_image_to (it broke xhtml strict) -- can be specified with :border => 0 #517 [?/caleb]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@836 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 12:02:17 +00:00
David Heinemeier Hansson
dfac1cea3d Fixed that form helpers would treat string and symbol keys differently in html_options (and possibly create duplicate entries) #112 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-06 11:50:41 +00:00
David Heinemeier Hansson
28a11969ce Fix request.path_info and clear up LoadingModule behavior #754 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-01 02:04:54 +00:00
David Heinemeier Hansson
630638b00e Fixed that Routes would raise NameErrors if a controller component contains characters that are not valid constant names #733 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:12:35 +00:00
David Heinemeier Hansson
8cddbf0d37 Added PATH_INFO access from the request that allows urls like the following to be interpreted by rails: http://www.example.com/dispatcher.cgi/controller/action -- that makes it possible to use rails as a CGI under lighttpd and would also allow (for example) Rublog to be ported to rails without breaking existing links to Rublog-powered blogs. #728 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-27 17:11:05 +00:00
David Heinemeier Hansson
02df588cf7 Fixed tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 11:50:59 +00:00
David Heinemeier Hansson
b7889524bf Fix empty url_for with nested modules #707
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-24 01:38:10 +00:00
David Heinemeier Hansson
11a2bb91f5 Added some unit tests #706
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 23:53:55 +00:00
David Heinemeier Hansson
fd6abf0a59 Fixed tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 15:05:04 +00:00
David Heinemeier Hansson
41ea6963a3 Added Base#render_to_string to parse a template and get the result back as a string #479
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 14:57:08 +00:00
David Heinemeier Hansson
2bf29b3485 Added FormOptionsHelper#time_zone_select and FormOptionsHelper#time_zone_options_for_select to work with the new value object TimeZone in Active Record #688 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:54:58 +00:00
David Heinemeier Hansson
cd689cf22b Fixed some tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-23 12:52:38 +00:00
David Heinemeier Hansson
f153f42469 Never end generated paths with a '/' #683
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 20:54:40 +00:00
David Heinemeier Hansson
acb3d2cf75 Fixed internal calling
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-20 00:02:02 +00:00
David Heinemeier Hansson
cf6d77600a Tests and tweaks for components
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:51:59 +00:00
David Heinemeier Hansson
0011116592 Unit tests for rendering components
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:49:12 +00:00
David Heinemeier Hansson
cae0f46eda Fixed a few tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@703 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 23:21:08 +00:00
David Heinemeier Hansson
9a5d6d6388 Added ActionView::Base.register_template_handler for easy integration of an alternative template language to ERb and Builder. See test/controller/custom_handler_test.rb for a usage example #656 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 17:22:37 +00:00
David Heinemeier Hansson
2a5fc27cea Added AssetTagHelper that provides methods for linking a HTML page together with other assets, such as javascripts, stylesheets, and feeds.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 16:04:50 +00:00
David Heinemeier Hansson
ad1fe7dd27 Completed FormTagHelper by adding radio_button_tag and select_tag
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 13:09:09 +00:00
David Heinemeier Hansson
967339e4d3 Added FormTagHelper that provides a number of methods for creating form tags that doesn't rely on conventions with an object assigned to the template like FormHelper does. With the FormTagHelper, you provide the names and values yourself.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 12:49:14 +00:00
David Heinemeier Hansson
5eac7ad1d9 Updated tests for TextHelper#auto_link
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-19 12:19:20 +00:00
David Heinemeier Hansson
5760a6cb3e Clear route defaults using :name => nil #663
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:53:18 +00:00
David Heinemeier Hansson
519fe7ccbc Added URL escaping for routing #664
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 23:52:28 +00:00
David Heinemeier Hansson
37249f6a86 Fixed that assert_template_xpath_matches did not indicate when a path was not found #658 [Eric Hodel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 17:13:57 +00:00
David Heinemeier Hansson
b305756d9f Added TextHelper#auto_link, TextHelper#auto_link_urls, and TextHelper#auto_link_email_addresses to turn those elements into ahrefs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-18 14:06:36 +00:00
David Heinemeier Hansson
bc574a86ac Skip Active Record tests in Action Pack if the SQLite database cant be brought up
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:28:13 +00:00
David Heinemeier Hansson
02e382a765 More tests for Routing related stuff
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@647 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 19:00:21 +00:00
David Heinemeier Hansson
6a48e89ae7 Fix that routes werent being loaded in production environment
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 02:04:37 +00:00
David Heinemeier Hansson
29066036f2 Make Routes drop the default for action when the controller changes #651
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-17 01:46:29 +00:00
David Heinemeier Hansson
b1999be5a7 A hopefully more successful attempt at the Routing branch merge
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:45:35 +00:00
David Heinemeier Hansson
88a3343ed5 Backed out of routing merge.. investigating missing patches
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 01:24:55 +00:00
David Heinemeier Hansson
c844755e5a Merged back the Routing branch
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-15 00:51:02 +00:00
David Heinemeier Hansson
65f834ad45 Stringify the parameters on follow_redirect
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 21:54:34 +00:00
David Heinemeier Hansson
61a6a440cb Added follow_redirect method for functional tests that'll get-request the redirect that was made.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-12 19:35:30 +00:00
David Heinemeier Hansson
098fa94356 Fixed documentation snafus #575, #576, #577, #585
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-07 14:15:53 +00:00
David Heinemeier Hansson
b69d337527 Applied the dblack patch
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 15:35:30 +00:00
David Heinemeier Hansson
80b656637a Added :application_prefix to url_for and friends that makes it easier to setup Rails in non-vhost environments #516 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 13:50:58 +00:00
David Heinemeier Hansson
45db66de56 Added :encode option to mail_to that'll allow you to masquarede the email address behind javascript or hex encoding #494 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-24 13:48:24 +00:00
David Heinemeier Hansson
dfed3d309e A few missing files
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:55:13 +00:00
David Heinemeier Hansson
2ee84cc6f9 Fixed that all redirect and render calls now return true, so you can use the pattern of "do and return". Added that renders and redirects called in before_filters will have the same effect as returning false: stopping the chain. Added that only one render or redirect can happen per action. The first call wins and subsequent calls are ignored.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:13:34 +00:00
David Heinemeier Hansson
9c09f81bc6 Added arrays as a value option for params in url_for and friends #467 [Eric Anderson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 14:06:33 +00:00
David Heinemeier Hansson
96e54780b3 Fixed that send_file would "remember" all the files sent by adding to the headers again and again #458 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-13 13:29:49 +00:00
David Heinemeier Hansson
d3a8d5f93c Fixed url rewriter confusion when the controller or action name was a substring of the controller_prefix or action_prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 16:23:18 +00:00
David Heinemeier Hansson
cb8a020ec9 Fixed url rewriter confusion when the controller name was a substring of the controller_prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-12 15:21:09 +00:00
David Heinemeier Hansson
11f766d3eb Removed authentication framework as xal made me realize that with noradios conditional filters, it was actually more code to use the framework than doing it by hand. Killing a darling! Props to noradio for the patch and xal for the nerve to stand up and question the captain before the plane crashed. Oh, and a pad on my own back for walking away from a couple of hours of work without getting pissy
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:21:29 +00:00
David Heinemeier Hansson
677d92299b Added conditional filters #431 [Marcel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 17:14:47 +00:00
David Heinemeier Hansson
cbd367b7fa Added :before option to authentication
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 16:43:21 +00:00
David Heinemeier Hansson
75fca04590 Added authentication framework to protect actions behind a condition and redirect on failure. See ActionController::Authentication for more.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-09 15:20:00 +00:00